Warp-Walk 1.0.1

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

10:30, 31st May 2010
The_Reborn_Devil:

You got some leaks here.

• Set EW_Points[1] = ((Position of (Load EW_int of 3 in EW_Hash)) offset by (Random real number between 225.00 and 255.00) towards ((Facing of (Load EW_int of 3 in EW_Hash)) + 45.00) degrees)

The location Position of (Load EW_int of 3 in EW_Hash) should be stored in a variable and then destroyed. You got several of these. You also got a leak here:

• (Terrain cliff level at EW_Points[1]) Equal to (Terrain cliff level at (Position of (Load EW_int of 3 in EW_Hash)))

And why do you use a region here:

• (Terrain cliff level at (Center of (Region centered at (Load EW_int of 0 in EW_Hash) with size (1.00 1.00)))) Not equal to (Terrain cliff level at (Position of (Load EW_int of 3 in EW_Hash)))

When you could just use the location directly.


Status: Rejected until updated
Rating: N/A

PM me or another mod once you've updated this to get it reviewed again. Have a nice day!

 

[cHeRoL]

Interesting

 

[Demongrip]

Lol very interesting,even fun when you warp over cliffs.About the coding-I can`t tell you anything because I don`t understand hashtables,so you should wait for review from others.
Yet again quite fun and useful spell.

 

[Godslayer]

this is not MUI it works only for one unit per player, per instance(0.8-1 seconds)
also i think the hashtables are not needet, arrais would have done the same job.

i gues noone would recognize its not mui ingame because u dont see if a unit doesnt warp
but rules say it has to be MUI.

also the hashtable clearing stuff and and the attacked unit stuff is not correct, because it checks the unittype.
they should check if the unit has that warp-walk ability

 

[chief_newgin]

Ok I fixed it hope now it's better!

 

[Godslayer]

ok well done.
i think there are some leaks i didnt see...
but if not, i think there are no reasons why it shouldnt get approved.

 

[TriggerHappy]

Fairly simple;

• All of these Center of's leak. You need to store them inside a variable then destroy them. Anything that looks like the two actions below need to be fixed.
  • Unit - Move (Load EW_int of 3 in EW_Hash) instantly to (Center of (Region centered at EW_Points[1] with size (1.00, 1.00)))
  • Unit - Order (Load EW_int of 3 in EW_Hash) to Move To (Center of (Region centered at (Load EW_int of 0 in EW_Hash) with size (1.00, 1.00)))
• Thats all I really have, the code is fairly short and only has a few leaks which I mentioned above.

 

[Noobsmoke]

Fairly simple;

• All of these Center of's leak. You need to store them inside a variable then destroy them. Anything that looks like the two actions below need to be fixed.
  • Unit - Move (Load EW_int of 3 in EW_Hash) instantly to (Center of (Region centered at EW_Points[1] with size (1.00, 1.00)))
  • Unit - Order (Load EW_int of 3 in EW_Hash) to Move To (Center of (Region centered at (Load EW_int of 0 in EW_Hash) with size (1.00, 1.00)))
• Thats all I really have, the code is fairly short and only has a few leaks which I mentioned above.

pointed