Warp Jump 1.3

[Moderator]

12:20, 29th Dec 2009
TriggerHappy:

• Please use coordinates instead of locations.
• Initialize your locals directly instead of setting them after.
• Remove all of the BJ's.
• There's no need to inline the event.

 

[Kingz]

First of all learn Jass don't make GUI=>Jass conversions.
Look at this horrible example you are giving:

Improvements and mistakes

function warp_jump_conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A001' ) ) then
        return false
    endif
    return true
endfunction

Real jass looks like:

function Condition takes nothing returns boolean
 return GetSpellAbilityId() == SpellID
endfunction

So you should first understand jass and read some tutorials before uploading low quality spells.
Also don't use bjs.

    set Ability = 'A001' // Ability code

But that should be above the triggers condition so you actualy use that variable for something.
It should be a global also.

globals
 constant integer Ability = 'A001'
endglobals
function Condition takes nothing returns boolean
 return GetSpellAbilityId() == Ability
endfunction

Never use bj's they all have calculations to replace them.
Also why not instantly set some variables?

local trigger Warp = CreateTrigger()

Saves up space.

GetWidgetLife(widget) > 0.405

Checks if the unit is alive don't use GUI=>Jass version.
Awfull coding style, comments are usualy next to the functions not under them.

call SetUnitPositionLoc( LastUnit, TargetPos) // Move casting unit to the target location

All in all one poor Jass spell. You need to learn much more.

 

[Dubey]

Yes, the initial check_condition is converted from gui to jass as I started making this spell in gui and switched halfway through to jass

I have removed all wrapper BJ's and only left the ones that actually do something
(With the exception of Life and Mana, must have missed those on the run through)

I dislike instantly setting variables (old coding habit) so that's simply personal preference

all my comments are above the functions that relate to them??? how are you getting under??

Also I tried the global variable thing (was looking for a way to make globals) but I keep getting endofline errors (Expected End of Line) If you know how to combat that error I would be very appreciative
-EDIT-
Someone finally told me that I'll need the hacked WE for "vJASS"
This is a JASS spell, not vJASS, that's why it's tagged as JASS

I'm moving the code onto hive so it's easier to access

 

[gunggang777]

vJass is better...(not eat many memory)
if you change to vJass this will be a great spell
vJass Like this (declare global,optimize the script,removeBj's...and leaks)
and how to hide like that? i'am newbie WTF?
and one thing...
This spell don't work with me...

 

[D4RK_G4ND4LF]

Just downloaded and I was like: "OMG WTF ANOTHER UBER NOOB SPELL WHICH DOES NOTHING!!!!111"

then checked the trigger and it was deactivated on default oO

well at least it works

 

[Dubey]

oops, I'll go reactivate it thanks

ANd the only thing vJASS will do for this ability is make it easier to change the ability code

 

[xDeathKnightx]

This skill is awsome, and im gunna use it, only problem is, when u teleport it comes up saying you have 2 heros for a bout 0.25 seconds and then goes back to 1 hero
but beside's from that i like it , good job 4/5 +rep

 

[Dubey]

Yeah, that's the "Known Bug" That I'm trying to get rid of =P

At least i got it to display the same skill points =P

But the propername is wrong, a tad unsure as how to change that.

However it is fully usable for a normal unit.

 

[xDeathKnightx]

yeah, i don't think its a major issue, the skill is still awesome, in all points.
If you don't get rid of it, i don't think too many people will be upset by it as the skill is awesome as it is at the moment , Gj

 

[Ranger21]

GetWidgetLife(widget) > 0.405

Fail's for heroes

So don't recommend this shit in everywhere

GetWidgetLife(widget) > 0.405 can produce more heavily bugs then BJ

But there alternative...
Works fine always
IsUnitType(Unit,UNIT_TYPE_DEAD) == false and GetUnitTypeId(Unit)>0

 

[Ranger21]

If you don't want see icon of second hero - fix that in Object Editor

There is option for hiding this icon

 

[Kingz]

I don't use GetWidgetLife(), i prefer GetUnitState()
Still you need to work a lot on it if you want it to get aproved.

 

[Dubey]

@ Ranger21
I am creating a copy of the unit who cast the ability... you should be able to see that
And thus you can't get rid of the portrait like that.

I've fixed the food error and scoured my code for anything that could be replaced as natives to the highest degree

 

[Deuterium]

call TriggerSleepAction( Distance/GetUnitAbilityLevel(LastUnit,Ability))

This leads to a delay when unpausing the unit by the time the ability is level 3...

Uses some stupid BJ's and you don't null location locals, you only RemoveLocation. You use locations thus...

Umm, spell idea is nothing nice - no offense...

off-topic @ gunggang777:
vJass doesn't take less memory than Jass, vJass is Jass, just a mask for thing too look easier to you. But deep to the core of the script, everything you can make in vJass can be made in Jass but with many many many much more lines.
What I'm saying, efficiency wise, both are the same (depends on how good the scripter is ); work-wise, vJass takes the lead...

 

[Dubey]

Again, could you tell me exactly what BJ's i am using.. I was pretty certain i had gotten rid of most of them.

Hmm, you don't really *have* to null locations, but i'll fix it as soon as i figure out how to get rid of the hero portrait and fix the hero name.

Might I ask how

call TriggerSleepAction( Distance/GetUnitAbilityLevel(LastUnit,Ability))

Is causing a delay??

 

[Deuterium]

The Wait can only drop to 0.27s and not less, even if you insert a lesser number...

 

[Dubey]

Thanks for that, very simple to solve ^_^

 

[Anachron]

Add locust ('Aloc' - is the ID) to the double, so it will not look like the unit is placed twice, also change the player to neutral...

 

[Deuterium]

Ok let me tell you what you can do to make this spell at least look good.

It's all about the SFX, what you do is pick a nice little effect (something white-ish/light blue-ish) and when the ability is triggered, you start playing around with unit transparency. You make once fade while you unfade the other and keep on increasing the fading until the original disappears and the new stays.
The SFX, well once one unit fades is gonna start to unfade, you just create, add the 0.01 expiration timer, and the death effect of the SFX would appear on both units, giving an original touch.

Umm, also change the name and make the spell look magical rather then fiery...

 

[Dubey]

However.. I realy didn't want to do it like that. I chose those effects for my ability, I'm not going to change them becuse you don't like them. I made them easy enough to change in the code.

I am currently working on the transparency, doing something like that yeah, but the sfx is staying the same...

@Anachron
Wait... why would you add the locust ID to it?

But that neutral idea is brilliant!!!! Thnx
-EDIT-
Right, well that does solve the portrait problem, however he is not targeted by Neutral Hostile but thats a small error.
However the propername problem is still there... I'm going to post this question in the spell foums
Just to let you know I finished the transparency thing a while ago, but I won't update it until I have this propername thing solved (Unless it can't be solved)

 

[Anachron]

Didn't checked spell yet, but if its a double and shouldn't be selectable, you should add Locust ability to it.

 

[Deuterium]

Just "Warp"?

 

[Dubey]

@ Anachron
that completely defeats the purpose of this ability... this ability is not an escape ability, it's an initiating ability...

@ Deuterium
Nah, I like the name Warp Jump, and it lets you use J as a hotkey XD
Besides I have another ability called Warp that I made ages ago