[JASS] vjASS [Structs] - no initial value

[Anachron]

Hey all.
I have a little question.

I am having a struct A.
Before this struct, I declare a private global constant (PGC).
Inside the struct I set a member to the PGC,
but its 0. How does that come, if the PGC is not 0?

globals
    private constant real EXAMPLECONSTANT = 128.
endglobals

struct ExampleStruct
    real MEMBER = EXAMPLECONSTANT
endstruct

This (changed) doesn't work in my struct... Its always after creation 0. But not if I set during creation.

 

[Pharaoh_]

struct ExampleStruct

-> Shouldn't this be

private struct ExampleStruct?

 

[Anachron]

Why? I mean its all in a scope..

scope ExampleScope
    globals
        private constant real EXAMPLECONSTANT = 128.
    endglobals

    struct ExampleStruct
        real MEMBER = EXAMPLECONSTANT
    endstruct
endscope

I think it isn't that.

 

[GhostWolf]

Do you want us to magically find the answer without the rest of the code?
Because if the answer is yes, then you probably forgot to .create() your struct.

 

[Anachron]

Nope...
Well, I declared other variables, but those have values.
I just want to know how its possible to get a 0 if its actually
not null, and that for some constant global variables.

The whole code is up to 1000 lines and not finished, so its
a monster of code, but I did comment it alot. But finally, I want
to release it when its ready. I just want to know when it can
happen that constants are not initializing a member of a struct, by
creating a new instance.

 

[Mooglefrooglian]

I beleive the answer is to use the onInit method in the struct.

 

[maskedpoptart]

Anachron, can you post the code that is telling you MEMBER is 0? I did a little test using your code and found that MEMBER is set to 128. Here:

scope ExampleScope initializer Init
globals
    private constant real EXAMPLECONSTANT = 128.
endglobals

struct ExampleStruct
    real MEMBER = EXAMPLECONSTANT
endstruct
function Init takes nothing returns nothing
    local ExampleStruct ex = ExampleStruct.create()
    call BJDebugMsg("MEMBER is "+R2S(ex.MEMBER)) //output: "MEMBER is 128.000"
endfunction
endscope

 

[Anachron]

I beleive the answer is to use the onInit method in the struct.

There is such a method?
But it does also work in the variable declaration for most guys.

 

[Ciebron]

struct X_Struct
    real X = 2. //this will be set after a create, NOT ON INIT!
endstruct

 

[Anachron]

What do you mean, not on INIT?

I tested the struct creation at map initialisation, is that wrong?
(But also delay did not work proberly).

And, the value is not 2, its a CONSTANT GLOBAL PRIVATE...

 

[Element of Water]

onInit = at map initialisation. You don't want that. A plain number is exactly the same as a constant global. It's kinda like a textmacro...

 

[Ciebron]

Constants get inlined

globals
constant real Y = 128.
endglobals

struct A
    real X = Y
endstruct

struct B
    real X = 128. //this is the same thing as above
endstruct


function Action takes nothing returns nothing
    local A a = A.create() //when i call this the X will be set to what ever value that is after the =
    
    //But u could also
    set a.X = Y  
    //this is the same thing as doing like u want
    //since when u create it it allocate a struct index and get the X get set to Y(128.), so same shit
endfunction

 

[Anachron]

globals
constant real Y = 128.
endglobals

struct A
    real X = Y
endstruct

struct B
    real X = 128. //this is the same thing as above
endstruct


function Action takes nothing returns nothing
    local A a = A.create()
    // doesn't work

    set a.X = Y  
    //Works
endfunction

 

[maskedpoptart]

Anachron, would you mind showing us how you know what works and what doesn't? Are you using BJDebugMsg? If you look at the code I posted above, I proved that struct members are assigned when the struct instance is created. Show us the code you use to test this stuff and its exact output.

 

[Anachron]

I will, tomorrow.. Until then, its holded.

 

[Deuterium]

Well you can't give a struct's member an initial value (so I know, I might be wrong about this), I mean the best way to give it a value would be setting it after creating the struct:

Code

library DT initializer blah
globals

    private constant real NUMB = 28.
    
endglobals

struct DEU

    real r
    
endstruct

private function test takes nothing returns nothing
    local DEU d = DEU.create()
    set d.r = NUMB
    call DisplayTextToForce(GetPlayersAll(), R2S(d.r))
endfunction


//===========================================================================
private function blah takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterTimerEventPeriodic(t, 2.)
    call TriggerAddAction(t, function test)
endfunction
endlibrary

Test this and you'll see that it works just as supposed to.

 

[Anachron]

It does, but alot of guys already did it with start values...
(Like this, for example:
Mapper Maltes Dialog System
)

 

[Deuterium]

He didn't use initial values, he simply used methods...

 

[Anachron]

So its not my mistake? I have to set them in the construction method?

Edit:

boolean UsesHotkeys = false
boolean Rebuild = false
integer OptionCount = 0

He did..

 

[maskedpoptart]

As I proved earlier, you can assign struct members initial values like real powerLevel = 9001. I am absolutely sure this works. You must be having a problem in how you test the values of your struct members... Just post your testing script when you get a chance, so we can find the problem.

 

[Mooglefrooglian]

Or as someone mentioned (I think?) just set them inside the create method. The method masked is talking about movies it into the create function anyways, so it doesn't matter, just looks prettier .

 

[Deuterium]

As I proved earlier, you can assign struct members initial values like real powerLevel = 9001. I am absolutely sure this works. You must be having a problem in how you test the values of your struct members... Just post your testing script when you get a chance, so we can find the problem.

When I do that, the map doesn't run... but when I set a value later in a function, it works...

 

[Anachron]

I am posting it later. Thanks for the help until yet.

 

[Dr Super Good]

Static struct variables are initialized on map init and are equivently constants.
Struct variables are initilized on the creation of a struct insance and can take preset values.

What may be happening is the actual compiler is messing up and not representing it properly. As I heard all constant non handles replace the references with the actual number on save for speed.

 

[Anachron]

Please use struct members, looks far better and is easier to understand. So, you think my compiler might be broken?

 

[Dr Super Good]

library TestStruct initializer init
    globals
        private constant real TESTREAL = 128
    endglobals

    private struct TSTR
        public real a = TESTREAL
        public real b = 128
    endstruct
    
    private function init takes nothing returns nothing
        local TSTR tester = TSTR.create()
        call BJDebugMsg(R2S(tester.a))
        call BJDebugMsg(R2S(tester.b))
        call tester.destroy()
    endfunction
endlibrary

library TestStruct initializer init
    globals
        private constant real TESTREAL = 128
    endglobals

    private struct TSTR
        public real a = TESTREAL
        public real b = 128
    endstruct
    
    private function init takes nothing returns nothing
        local TSTR tester = TSTR.create()
        call BJDebugMsg(R2S(tester.a))
        call BJDebugMsg(R2S(tester.b))
        call tester.destroy()
    endfunction
endlibrary

This displays 128.000 for both a and b. Thus I have no clue what you are complaining about as it works perfectly for me.

 

[PurplePoot]

Some scenarios:

1

globals
real const=128.
endglobals
struct s
real val=const
endstruct

globals
real const=128.


//JASSHelper struct globals:
constant integer si__s=1
integer si__s_F=0
integer si__s_I=0
integer array si__s_V
real array s__s_val

endglobals


//Generated allocator of s
function s__s__allocate takes nothing returns integer
 local integer this=si__s_F
    if (this!=0) then
        set si__s_F=si__s_V[this]
    else
        set si__s_I=si__s_I+1
        set this=si__s_I
    endif
    if (this>8190) then
        return 0
    endif

   set s__s_val[this]=const
    set si__s_V[this]=-1
 return this
endfunction

//Generated destructor of s
function s__s_destroy takes integer this returns nothing
    if this==null then
        return
    elseif (si__s_V[this]!=-1) then
        return
    endif
    set si__s_V[this]=si__s_F
    set si__s_F=this
endfunction

2

globals
constant real const=128.
endglobals
struct s
real val=const
endstruct

globals
constant real const=128.


//JASSHelper struct globals:
constant integer si__s=1
integer si__s_F=0
integer si__s_I=0
integer array si__s_V
real array s__s_val

endglobals


//Generated allocator of s
function s__s__allocate takes nothing returns integer
 local integer this=si__s_F
    if (this!=0) then
        set si__s_F=si__s_V[this]
    else
        set si__s_I=si__s_I+1
        set this=si__s_I
    endif
    if (this>8190) then
        return 0
    endif

   set s__s_val[this]=const
    set si__s_V[this]=-1
 return this
endfunction

//Generated destructor of s
function s__s_destroy takes integer this returns nothing
    if this==null then
        return
    elseif (si__s_V[this]!=-1) then
        return
    endif
    set si__s_V[this]=si__s_F
    set si__s_F=this
endfunction

3

struct s
real val=128.
endstruct

globals
//JASSHelper struct globals:
constant integer si__s=1
integer si__s_F=0
integer si__s_I=0
integer array si__s_V
real array s__s_val

endglobals


//Generated allocator of s
function s__s__allocate takes nothing returns integer
 local integer this=si__s_F
    if (this!=0) then
        set si__s_F=si__s_V[this]
    else
        set si__s_I=si__s_I+1
        set this=si__s_I
    endif
    if (this>8190) then
        return 0
    endif

   set s__s_val[this]=128.
    set si__s_V[this]=-1
 return this
endfunction

//Generated destructor of s
function s__s_destroy takes integer this returns nothing
    if this==null then
        return
    elseif (si__s_V[this]!=-1) then
        return
    endif
    set si__s_V[this]=si__s_F
    set si__s_F=this
endfunction

The moral: You're doing it wrong.

 

[Deuterium]

Well PP, when I was doing it, simply the map wouldn't initialize. When later I simply have set the value of the struct inside a function rather then directly giving an initial value, it worked...
So I guess it's something about compiling... I'll test that later tonight...

 

[Anachron]

Edit: Yes, it works. But not for my struct... Very VERY strange...
Edit2: Oh btw, I am having everything inside a scope..

Edit: Some code:

scope WhispWheels
    globals
        //#==============================#
        //>         System Settings      <
        //#==============================#
        private constant real BASE_RANGE = 250.
        // ^ Sets the default range for whisp roots
    endglobals

struct WhispWheel
        //#=======================================#
        //>  The normal members of the struct     <
        //#=======================================#
        real range = BASE_RANGE

        public static method create takes real x, real y, player p returns WhispWheel
            // ################################
            // #            Locals            #
            // ################################
            local WhispWheel ww = WhispWheel.allocate()
            // ^ the instance object
            
            // ################################
            
            call BJDebugMsg(R2S(ww.range))
            return ww
        endmethod
endstruct
endscope

 

[Element of Water]

Post your whole struct code and we'll see what the problem might be.

 

[Anachron]

Edited the post above.

Edit... (lol): It does work there... What the hell..
Edit2:

//Generated allocator of WhispWheel
function s__WhispWheel__allocate takes nothing returns integer
 local integer this=si__WhispWheel_F
    if (this!=0) then
        set si__WhispWheel_F=si__WhispWheel_V[this]
    else
        set si__WhispWheel_I=si__WhispWheel_I+1
        set this=si__WhispWheel_I
    endif
    if (this>-1) then
        return 0
    endif
   set s__WhispWheel_range[this]= WhispWheels__BASE_RANGE
 return this
endfunction

Seems like everything is working on WE..

 

[Element of Water]

That's obviously not the proper code. It has a syntax error. As it is, that code should work. Post the whole create method.

 

[Anachron]

// The Constructor-Method. Does return the new instance
        public static method create takes real x, real y, player p returns WhispWheel
            // ################################
            // #            Locals            #
            // ################################
            local WhispWheel ww = WhispWheel.allocate()
            // ^ the instance object
            local integer i = 0
            // ^ a local counter for the loop
            local real f = 0.
            // ^ a local degrees for roots
            local Loc l = 0
            // ^ a local struct of the location.
            // This is only to be able to get X and
            // Y back at the same time
            local Root r = 0
            // ^ a local struct of the root which we
            //     will add to the whispwheels
            local real rootX = 0.
            local real rootY = 0.
            // ^ ^ The two coordinates for the new Root
            
            set ww.wheel = CreateUnit(p, ID_WHEEL, x, y, 270.)
            // ^ create the Whisp Wheel Unit
            
            // ################################
            
            call BJDebugMsg(R2S(ww.range))
            
            // Add basedata to the instance
            set ww.x = x
            set ww.y = y
            
            // Now lets add the Base-Roots to the Wheel
            loop
                exitwhen i >= BASE_ROOTS
                set f = f + 360 / BASE_ROOTS
                //call BJDebugMsg("F: " + R2S(f))
                // ^ This sets the degrees symetric,
                //   whatever the amount of baseroots are
                
                set l = Loc.new(x, y)
                set l = Loc.polarOffset(l, f, BASE_RANGE)
                set rootX = l.getX()
                set rootY = l.getY()
                // ^ gets the new coordinates for the root
                call l.destroy()
                // ^ destroy the helper-array
                set r = Root.create(rootX, rootY, f, p)
                call ww.addRoot(r)
                // ^ Creates the new Root-Instance
                // and adds it to the whispwheel
                set i = i + 1
            endloop
            
            // Check for attaching this instance to the struct
            if AUTO_ADD then
                call WhispWheel.addIns(ww)
            endif
            
            //set defaults
            //set ww = WhispWheel.setDefaults(ww)
            
            return ww
        endmethod

Thats 100% of the method...

 

[Element of Water]

Very strange. Oh well, if you can't find a solution, simply do it yourself in the create method.

 

[Anachron]

Yeah, works 100% if I enable the line:

 //set ww = WhispWheel.setDefaults(ww)

Hopeing it would be able to not need to.