[vJass] Gigant Critical 1.4

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.


16 Nov 2011
Bribe: WEAPON_TYPE_WHOKNOWS -> null.

You only need one hashtable, not 2.

TriggerCount still should not be search-based.

You are still creating groups locally which you only use once.

You are still not using FirstOfGroup loop.

The EVENT_PLAYER_UNIT_ATTACKED event is abusable. You need to have this run from a Damage Detection System.

What is with all the "QueueUnitAnimation" spam?

You still have TriggerRegisterAnyUnitEventBJ inlined which adds unnecessary bloat to the code size. There is no reason for you to have inlined it, and if you care about efficiency, like I said, use SpellEffectEvent.

 

[baassee]

Post triggers please.

 

[Pharaoh_]

• Use "keyword", instead of StringHash, or integers to save/load values.
• Translate the comments in English.
• Use a damage detection system instead of on attack event (which can be abused with the "Stop" command).
• Use coordinates instead of locations, e.g. the function SetUnitPositionLoc() can be replaced with SetUnitPosition().
• You don't need to reset local reals/integers, only handles.
• Functions that take arguments do not need locals to declare the arguments all over again, e.g.:

        local integer Abil = abil

just use the "abil" argument directly in the function.
• The "Persent" function is needed (it should be "Percent", by the way), just make the calculations needed within the main function.
• Index variable in the TriggerCount function could be Integer, there's no reason to make it real, when you increase it by 1 and then convert it to integer with R2I.
• Become familiar with timers, instead of creating timed triggers. T32 or TimerUtils would be the way to go.

 

[Magtheridon96]

CTL would be good too.

        set Trg         = null
        set Attacked    = null
        set Dum         = null
        set Drg         = 0
        set Bol         = false
        set Tns         = 0
        set Trg_Loc     = null
        set Pla         = null
        set Trig        = null
        set Hnd         = null
        set Scl         = 0
        set Index       = 0
        set Lvl         = 0
        set IfUnitHaveGC=false

>_>

Here:

        set Trg         = null
        set Attacked    = null
        set Dum         = null
        set Trg_Loc     = null
        set Pla         = null
        set Trig        = null
        set Hnd         = null

 

[Losam]

Bad Job Guy.

 

[xorkatoss]

well at least you tried...3/5

 

[Zendo.ExE]

sorry 4 my bad work... this is my first spell in vJass