System - Recipe Combine 1.4 (GUI & vJass)

[Moderator]

12.12
IcemanBo: For long time as NeedsFix. Rejected.

09:35, 3ndth Sep 2015

This resource has been set to Need Fix by BPower.

Reason:
Recipe Combine is basically identical to Recipe System without the functionality to disassemble item recipes.
The mirror image sound overlaps with the sf sound, hence is not so important difference to the system of dk-diablo.
However the main reason for my decision is a unit handle leak in your Actions function. The player unit item pickup event occurs frequently and so does the leak.

From moderator to user:
If you are already using Recipe Cobine 1.4 successfully in your map, please make sure to fix the leak in the TriggerAction function ( function Actions ).
For this add set u = null to the end of the function. The remove the return after the following line:
call DestroyEffect(AddSpecialEffectTarget(ITEM_COMBINE_EFFECT, u, ATTACH_POINT)).

Previous review

Diablo-dk: We do already have a recipe system, but since many people here prefer GUI over jass, this will be approved.
The dis-advantage of this system is the huge loop.

 

[Insaniac69]

I tested it, it works nicely and in a simple GUI system, good job! Though not sure why many people would use the disassemble part of the ability but that was nice too. (Liked how in 2 part combos it only split up the 2nd stage and not every single one in the 2-part combo)
This should be approved no problem, if theres a reason why it isn't then someone needs to be smacked. >.>

 

[Dark_Dragon]

Well sorry about that but doing that it disassembles to 1 stage will make some problems to some people if they only want to disassemble the max stage item. If they want one stage less then its simple to cast disassemble again right? However ty for comment.

 

[Dark_Dragon]

Yes I cleard the sound location now. Ok I maded this in GUI because some people say that in GUI cant be done this system so I maded it to show people that it can be done. By the way what do you mean that disassemble part of ability is maded in big loop. It cant be done whitout loop ok, or I cant cut it in less loop. If you think loop can be reduced then tell me how plz.

 

[Xarwin]

Actually it is pretty easy to create this system. But I guess people can always use it...

 

[Insaniac69]

Told you! Knew it would be approved fast.

 

[Diablo-dk]

when i say dis-advantage i don't mean the disassemble trigger. I meant the combine trigger had a giant loop.

 

[Dark_Dragon]

Oh ok sry, I knowe that its a big loop but still do you think it will cause a little lag coz I tested it and no lag ok ^^.

 

[Ziken]

Very useful to most people.

But, you really need to fix that loop, it doesn't matter if you tested it. Testing it on LAN, on your campian custom games, are a lot different that testing it oin battle.net.

That loop will become 3x/5x worst than it is when played on battle.net, and as well, with more people, it will increase even more.

Just fix the loop, and it will be perfect.

 

[ap0calypse]

Hmm... why doesn't it work for me?:
I used 2 of the same items to create 1 better item, and that item can also upgrade when you have 2 of those.
But when I buy 1 weapon, it instantly upgrades 'till the last level...

I used it like this:
Set Item_need[17] = End
Set Item_need[18] = Diamond Sword
Set Item_need[19] = Diamond Sword
Set Item_need[20] = End
Set Item_create[6] = Diamond Sword

If I use different items it doesn't do anything.

 

[Dark_Dragon]

ok guys i will try to think of something to try reduce the loop. ap0calypse your problem is very easy to fix i test in my map that stuff you say and it works great. The problem in your map must be something like all this (your) items have same name and i think you miss clicked somewhere and then all system goes down. You must only check did you missclicked some item and/or maybe something other is wrong, maybe whit trigger you imported, if you create your own variable in map whit same name make shure that is has enough big array or maybe some variable in code is set wrong when you whos copying code, try this and it will work for you for sure ^^ because i test this and it works ok gess you will find out where it the bug good luck.

 

[ap0calypse]

No, srry, it just doesn't work :s
I copy-pasted the triggers again (except load items) and checked all variables, etc...

can you take a look at it? (I'll e-mail the map)

 

[Dark_Dragon]

Ok I send you the map and it works have fun ^^

 

[ap0calypse]

Dark Dragon, you're great, really.
The system is working perfectly and those triggers you made are very usefull.

Thank You for everything, I hope you can check my map in a few weeks on hive

 

[Ninja_Duels]

wow that is nice but i need some help
Sound - Play gg_snd_Recipe_Snd at 100.00% volume, located at Sound_Point with Z offset 0.00

plz help me

 

[ap0calypse]

Ninja Duels, I think you can just delete that, it plays a sound when an item is fused at the point of the unit who holds the fused item.
If you like to hear a sound, just add the sound you like in the sound editor and change the 'gg_snd_Recipe_Snd' to your sound.

 

[Dark_Dragon]

Yes that sound is played when item is fused. You need to go to sound editor, then go to spells\abilities\orc\mirror image\mirror image.wav and right click on her and click use as sound. The sound will appire in your sound list. Double clicl on her change name to Recipe_Snd and set pitch to 1.20, then click ok, goto trigger editor click this gg_snd_Recipe_Snd and click ok do that at every place where it gives you that function is off(where is red trigger icon). Good luck!

 

[Tan]

USE THIS EASY RECIPE SYSTEM INSTEAD: http://www.hiveworkshop.com/forums/showthread.php?t=35788S

 

[Diablo-dk]

Tan, can you explain why we should use that system instead? It is not even a system, it is just a trigger which doesn't seem to have any advantage over this system. This system is clearly easier..

 

[ZXander_Stealth]

Thank You...For a nice skill to make recipes...But I cant use your trigger cause i copy to my map but your trigger didnt works... Dont know why...

 

[Dark_Dragon]

Hmm are you using we-unlimited, if so than yes weu bugs a lot, if not then try to check have all variables been copied and did you put array in all of them, which you need to set array, if you can find what is wrong send me your map at <[email protected]> and i will check it.

 

[lomi12]

ZXander_Stealth:
Thank You...For a nice skill to make recipes...But I cant use your trigger cause i copy to my map but your trigger didnt works... Dont know
I got the same problem even i use normal WE

 

[Dark_Dragon]

Its hard to say what is wrong when I don't know what you did I can only check if you send me your map

 

[WherewolfTherewolf]

Ok, now you have about 500 spells and systems that have been neglected to be even looked at by the moderators...........
I would suggest taking a look at hanky's vast plain spell

 

[Dark_Dragon]

Ok! I really don't understand what you want to say, this comment should not be here, as you did not say anything about this system other that its approved. It has been approved a long time ago, now its applied mass update on system. That's all! This comment you posted should be in hanky's vast plain spell, or you can contact moderator about that, not here!

 

[G_Rator]

HERE IS WHAT I DID:

function Trig_Load_Items_Actions takes nothing returns nothing
    // | |
    // Staff of Wizandry
    set udg_CItemType[1] = 'ratf'
    set udg_CItemType[2] = 'ckng'
    set udg_CItemType[0] = 'desc'
    call NewItemGroup()
    // END
    call DestroyTrigger( GetTriggeringTrigger() )
endfunction

//===========================================================================
function InitTrig_Load_Items takes nothing returns nothing
    set gg_trg_Load_Items = CreateTrigger(  )
    call TriggerRegisterTimerEventSingle( gg_trg_Load_Items, 0.10 )
    call TriggerAddAction( gg_trg_Load_Items, function Trig_Load_Items_Actions )
endfunction

BUT THE PROBLEM IS IT SHOWS AN ERROR IN LINE 37, THAT IS WHEN I CALL COSTUM SCRIPT:call NewItemGroup() !!! CAN U TELL ME HOW TO FIX IT?

I DID MAKE THIS IN JASS I JUST CONVERTED GUI TRIGGER TO TEXT SO U CAN SEE.

 

[Dark_Dragon]

np you must forgot to add variable type or something, just send me your map and ill fix it in no time.

 

[kelogsloops]

Hey does htis thingo work anymore? :< I used this a while ago and it worked perfectly on my map, then i used it again for another map and nothing worked :<

 

[Dark_Dragon]

Must work even faster now, just tell me whats the problem and i will help!

 

[kelogsloops]

Okay, i've got a problem

i just downloaded it, copied the mapheader and the triggers and put it in my mapheader and added the triggers. as soon as i save i get 1747 error lines :<.

Can you help me? I copied the map header into mine, and then copied the triggers.

-EDIT-

Is it because i copied the map header into mine? I think it screwed up all of my other triggers :<. But i tried to NOT copy the map header and there were about 3 error lines :< PLEASE HELP URGNETTTTT!!

 

[Dark_Dragon]

Well i send you the map problem was you created only 1 of 4 variables

Have fun!

 

[Soul-_-Hunter]

junk... guy and jass
i want just guy

 

[Dark_Dragon]

junk... guy and jass
i want just guy

what exactly do you mean? there is no jass since i said you just need to copy that and edit GUI so you don't need to know jass, so please read Installation and its not "guy" you know what guy means its called "GUI" not guy and as i said you have only GUI you don't have jass since i said that that code must be in your map so that engine works like blizzard.j script for example.

 

[biblioty]

// Item Group 1
set udg_CItemType[1] = 'rat6'
set udg_CItemType[2] = 'rat9'
set udg_CItemType[0] = 'ratf'
call NewItemGroup()

the call NewItemGroup() is giving me the error even when i copy it strait from ur map
nvm i fixed it

 

[Vixen]

Thank you for your script, Dark_Dragon
Works fine and great

 

[Dark_Dragon]

glade both problems where fixed and have fun using then in ur modes!

Greets!
~Dark Dragon

 

[Gummifrog]

I test alot of Recipe systems today and this is the best

 

[Gummifrog]

Why are it alltimes Crash when i save the map?

 

[Dark_Dragon]

Why are it alltimes Crash when i save the map?

coz you must copy and past the code from the map header (blue map icon where ur map name is displayed in trigger editor) copy that code from my map header to yours and enjoy

 

[Sporling]

awww

i get all the time that error

Scritp Error
Load Items
compile error
set udg_CType[udg_ItemN-1] = udg_CItemType[0]

my english isnt really good so i cant find the problem in that trigger or script, and iam not good in scripting so thats 2 problems why i need help :/


EDIT: My fail, i forget 1 variable

 

[Darkness568]

This package works great, but for some reason my map no longer loads in Warcraft 3 and when i hit test the map doesnt load either. I got no errors from saving. When i click on the map within the game the description and picture pops up but no player slots. The only thing i added to the map was the item system you created and was done that way to go and test it.

If you want i can pm you the map, but it may releate to the issues i pmed u about earlier about possible missing files.

 

[Dark_Dragon]

This package works great, but for some reason my map no longer loads in Warcraft 3 and when i hit test the map doesnt load either. I got no errors from saving. When i click on the map within the game the description and picture pops up but no player slots. The only thing i added to the map was the item system you created and was done that way to go and test it.

If you want i can pm you the map, but it may releate to the issues i pmed u about earlier about possible missing files.

hmm yeah i would like if u can send me the map it would save me from thinking what can it be again!

maybe patch...

 

[Darkness568]

Its the jass i believe because i have had no issues until this was put in and jasscraft gives statement of function syntax errors along with finding several undeclared variables which may be the fact that i dont have them as i searched in the variable listings and couldnt find the variable ItemN which was a part of the errors.

I am seeing now if the missings variables will fix it.

 

[Dark_Dragon]

Its the jass i believe because i have had no issues until this was put in and jasscraft gives statement of function syntax errors along with finding several undeclared variables which may be the fact that i dont have them as i searched in the variable listings and couldnt find the variable ItemN which was a part of the errors.

I am seeing now if the missings variables will fix it.

in older version this was a problem coz you had to declare variables yourself... in this new version you only need to declare your main variable and thats all.

overall i suggest you to dl JNGPS and enable EGUI! EGUI has Item Config type which allows you to make recipes by few clicks, its more readable and by one click you can have fast Item Stacking...

try out EGUI and you will see what i mean, i dont suggest you to use this... overall this systems are as well fast and well coded but ones from my ultimate library are ofc better, as well its more easy no need for jass scripts and such...

Greets!
~Dark Dragon

 

[Sporling]

I dont know why this wont work please help

http://www.hiveworkshop.com/forums/pastebin.php?id=yjkxli

its everytime that Custom Script: call NewItemGroup() error

i have copy/paste the map header:
//TESH.scrollpos=0
//TESH.alwaysfold=0

in my map header

 

[Anachron]

Can it handle conditional combining?
Like:
Ring of Health
or
2x Ring of Regeneration.


I guess someone could make something like this.

 

[Hemske]

Cant seem to get it to work after copied it over to my map. The error i get is: "The trigger "item combine core" must have an initialization function called "inittrig_item_combine_core". Also gets error on each of the "Call NewItemGroup()" trigger, Says "Expected a function name". Anyon e know what i've done wrong or how to fix this? Thanks!

 

[meteOrain-]

Cant seem to get it to work after copied it over to my map. The error i get is: "The trigger "item combine core" must have an initialization function called "inittrig_item_combine_core". Also gets error on each of the "Call NewItemGroup()" trigger, Says "Expected a function name". Anyon e know what i've done wrong or how to fix this? Thanks!

I happen to have same problem cant find a way to fix it can you tell

here is the whole trigger

• Load Items
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- --- --------
    • -------- Item Group 1 --------
    • Set CItemType[1] = Gauntlets of Ogre Strength +3
    • Set CItemType[2] = Raw Material
    • Set CItemType[0] = War Gauntlets
    • Custom script: call NewItemGroup()
    • -------- ======= --------
    • Custom script: call DestroyTrigger( GetTriggeringTrigger() )

EDIT+

Well i made my own recipe trigger.

But you can still fix this problem for that other guy

 

[Ayrayen]

Cant seem to get it to work after copied it over to my map. The error i get is: "The trigger "item combine core" must have an initialization function called "inittrig_item_combine_core". Also gets error on each of the "Call NewItemGroup()" trigger, Says "Expected a function name". Anyon e know what i've done wrong or how to fix this? Thanks!

yep it worked fine just a while ago untill now.

You should really fix this...