Unit Groups vs Linked Lists

[Spellbound]

So what are the pros and cons of Unit Groups and Linked Lists? My main concern is performance because I use 2 unit groups with First of Group inside loops and add/remove units from one to the other when I have to do things like channeled spells.

 

[BPower]

A unit group probably runs via an internal stack or linked list.

Both FirstOfGroup loops and coded linked list iterations are very fast.
Add/Remove are probably faster for group handles.
Create/Destroy are probably equal, maybe faster for your own coded linked list.
Important could be that groups automatically remove invalid ( removed ) units.

Use what fits you best.

ForGroup is definitly slower on bigger groups.

I would use linked lists.

 

[Anitarf]

Linked lists are better.

 

[Chaosy]

I think linked list suck.
Or well, the syntax does.

Bannar made a rather acceptable one though. http://www.hiveworkshop.com/forums/jass-resources-412/containers-vector-t-248942/ but even then I dislike the names, though that can be changed to my taste so no biggie.

 

[Anitarf]

That's not a linked list, that's an array. This is a linked list.

 

[Chaosy]

Same thing different name as far as I can see.
Allows dynamic indexing.

Then again, I am not sure since there isn't a demo.

 

[Wietlol]

There is some serious difference between a vector and a linked list...
However, I do think unit groups are vectors as well.

Myself, I dont really care much and use unit groups.
But having a feature to loop over a group without removing the units on it without using a swap group would be nice.

But apart from that, you are still bound to unit groups because you cant do "LinkedListEnumUnitsInRange()" or something like that.
You still have to read from the group and while you are doing so, then you can better just do what you wanted to do.

But as long as you are not bound to such methods and you only need the "group" to store units, then a linked list is in my eyes a better option.

 

[IcemanBo]

If list is good for your, then use list.
VectorT is similar, but has more logic included.

VectorT does allow functions: assign/insert/erase. But their complexity is O(n), and sadly there
is no optimized way provided to remove for example the first element without using erase.
In a list you have less functionality, but can simply connect the next to prev and alike - so is more light weight if you need this example.

Lists are good.
VectorT is also good, provides some more, but not always needed.

 

[BPower]

Same thing different name as far as I can see.
Allows dynamic indexing.

Absolutely not the same thing.
Different types of collections have a different complexity and eventually different API.

 

[Almia]

Lists are faster, but not for lookups
That's one of the cons of a list.

Same thing different name as far as I can see.
Allows dynamic indexing.

Vector is a self-resizing array so no.

 

[Spellbound]

I am completely confused lol. I guess if FoG and add/remove are fast enough, I don't need to bother with linked lists?

 

[IcemanBo]

If group fits your needs, then you don't need to write your own list for it, no.

 

[Wietlol]

Lists are faster, but not for lookups
That's one of the cons of a list.


Vector is a self-resizing array so no.

You forget that lists do not change the indices of their content.
If you have a uniquely filled list (one that do not fill multiple indices with the same data), you can then make a variable on that data that stores in which indice they are stored.

Then you have 100% fastest lookups.
The only problem is when your hardware device is going mental and starts loading data you are going to use in the next iterations of the loop.
In that case, linear lists are way faster... that said arrays. I dont know how vectors work behind the screen, but I assume this is the difference between arrays and (linked lists + vectors).

The only real drawback you will be facing in JASS is that you cannot for example do a binary search... cause you cant get to the middle or something like that.

@SpellBound
Unit groups arent bad.
You should start using advanced lists as soon as you want to store something else than a unit...

 

[Troll-Brain]

Be carefull with ghost units (units removed of the game but not from the group).
Indeed, units are not automatically removed from a group when they are removed off the game, and then FirstOfGroup can an will return null when you will try to enum this ghost unit, and then the FirstOfGroup loop will be stopped before the end.

Note that ForGroup doesn't enum ghost units, but's it's way slower and it splits the code.

 

[BPower]

Be carefull with ghost units (units removed of the game but not from the group).
Indeed, units are not automatically removed from a group when they are removed off the game, and then FirstOfGroup can an will return null when you will try to enum this ghost unit, and then the FirstOfGroup loop will be stopped before the end.

Is that a confirmed issue? I will test it asap, very intersting.

 

[PurgeandFire]

Is that a confirmed issue? I will test it asap, very intersting.

Yep.

 

[Anitarf]

It's 2016, there are still people who don't know about this issue?

The whole method of using an indexing system to attach data to units and then using groups to loop through those units is really suboptimal. The only reason it is used is because it's the most expedient method available in plain JASS. It's been almost 10 years though, people really need to stop being afraid of vJass and start using it.

 

[IcemanBo]

You can't expect everyone to know everything, you know.

 

[Skyflash]

Depends the Dynamic Indexing is a very fast method but hard to create it`s to better using Dynamic Indexing while you need to run a spell too many times like Systems and templates but for a Normal Spell Using UnitGroups is better because its faster to create them and also Use UnitGroups while you using Hashtables They are Prefect matches

It's 2016, there are still people who don't know people really need to stop being afraid of vJass and start using it.

It`s not a Official Language and most of the times people encounter Compatibility issues while using vjass stuff because the original Worldedit doesn`t support it and you have to use JNGP and JNGP is one of the most horrible thing i`v ever used very buggy and incompatible with Warcraft i rather use GUI and Jass

 

[BPower]

JNGP is one of the most horrible thing i`v ever used very buggy and incompatible with Warcraft i rather use GUI and Jass

When, where, how? Can you list an example?

Very radical view on something working well for a huge group of people.

 

[KILLCIDE]

JNGP is one of the most horrible thing i`v ever used very buggy and incompatible with Warcraft i rather use GUI and Jass

I've been using JNGP for over a year and never encountered an issue. You must be doing something wrong.

 

[Skyflash]

When, where, how? Can you list an example?

Very radical view on something working well for a huge group of people.

1-my anti-virus constantly removes the JNGP
2-the still uses old version of worldedit this means if you create a map with regular WE and save it with JNGP your map will be gone one of my spell Packs get destroyed because I didn't know this fact

3-the JNGP skips the syntax errors and runs the map and warcraft couldn't load that map the debug window never shows up the JNGP`sntax checker is always malfunctioned getting weird errors when you fix them manually like copying the missed dlls will still have an inaccurate syntax checker constantly shows
Weird syntax errors in an approved vjass spell!


4-most important one when you copy an vjass spell in your map you can`t add a simple trigger to map andthe god blessed syntax checker finds errors in spell`s code
Besides the maps containing vjass codes won't be run in warcraft

 

[Spellbound]

1. Change antivirus? I use Nod32 and it never had any problems with JNGP.
2. Whenever I open a map that's been created with Vanilla WE in JNGP it tell me the version is off. That's it, no data loss whatsoever.
3. Have you updated JassHelper? If you don't the syntax checker will find all sorts of weird bugs that aren't there.
4. ???

PS: Not saying you don't have these problems, it's just very strange.

 

[Almia]

It's just that you don't use it properly.
Antiviruses sometimes deletes PipeDream(or PitzerMike, i forgot which of the two)'s DLLs

 

[HappyTauren]

If you're too stupid to install JNGP and use its features, you're probably going to be a very lousy coder either way.