Ultimate Hero Pick System 2.0.0.4 (vJass)

[Moderator]

23:43 Dec 7, 2012
Magtheridon96: Approved.
Wonderful. =)

If you would like an extended review, feel free to PM me.

 

[-Kobas-]

Video and better documentation in few days ^_^

 

[Luorax]

Well, I did not go through the whole system, just a few things, much likely "first impressions":

1, First of all, this is vJASS, not JASS, cuz you're using a globals/endglobals block -> this requires a JASSHelper to compile. So you should get rid of those multiple triggers and merge them all and place everything inside a library. It'd look way better.

2, Sweet tutorial directly from Bribe.

3, Don't use locations. NEVER. Use pure X/Y/Z coords. Each native that uses locations have a non-location version that uses X/Y coords (just like CreateUnitAtLoc and CreateUnit)

4, Use TriggerAddCondition instead of TriggerAddAction

function Act takes nothing returns boolean
    ...
    return false
endfunction

function InitTrig_UHPS_Start takes nothing returns nothing
    local trigger t=CreateTrigger()
    call TriggerAddCondition(t,Filter(Act))
endfunction

5, If you merge everything as I said in point #1, use proper data encapsulation. Use private functions with proper names, use library initializers, etc.

I think that's all for now.

 

[marko9]

Good job man...^_^

 

[88WaRCraFT3]

Finnaly jass GJ!
Edit: You still use units :O
Btw: you can still see unit selection circle

 

[Magtheridon96]

http://www.hiveworkshop.com/forums/jass-ai-scripts-tutorials-280/structs-dummies-197435/

This may be useful for you.

You should give this system an API so configuration is easier.

I'd post more, but while writing an extremely long post about how you should improve the system, my browser crashed
Too tired now.

 

[-Kobas-]

First of all, this is vJASS, not JASS, cuz you're using a globals/endglobals block -> this requires a JASSHelper to compile. So you should get rid of those multiple triggers and merge them all and place everything inside a library. It'd look way better.

It will look better but it won't be so useful.
I don't care about code beauty here, just like I explained this few times for GUI version.
This here is supposed to show people how system can look like and how easily can be edited. Each new icon, each new system edit will require large number of modifications, easy ones, but still large number of them. For each new hero we need to add like 20 lines of code.

Don't use locations. NEVER. Use pure X/Y/Z coords. Each native that uses locations have a non-location version that uses X/Y coords (just like CreateUnitAtLoc and CreateUnit )

Thanks for info, will improve this.

You still use units :O

I prefer units over trackables, you can always edit unit name into some text just like I did . Nice message can be displayed when you place mouse over it. With tracks you are forced to use floating text, and that will remove nice border and increase number of variables, lines of code etc etc.
Also newbie coders will find units more easier for usage than trackables, you don't need different models imported, you can easily set edit unit dimensions like this as well.

you can still see unit selection circle

Only bad thing, but I can live with it.

Structs for Dummies

Thanks, I already saw that, but honestly I don't like vJass.
Dunno why, maybe because no one showed it to me.

I can use udg variables if globals bother you?

 

[Adiktuz]

I can use udg variables if globals bother you?

and add a trigger which has those globals in GUI for those who don't want to create it themselves...

I'll definitely look at this on the WE... I love the way you used units, especially those texts when you hover over the hero icons...

 

[Bugz]

Great work, also because i know how long you have been knowing jass

 

[-Kobas-]

Program will soon finish with producing and uploading video.
Version 1.2 is out
No more vJass GLOBALS (tested, works in normal WE nicely ^_^)
Added GUI variables block for easy import.
Added a lot of comments, READ ME script with introduction, how to import and tricks, things.
Enjoy

 

[baassee]

I'll try to use this somewhere... Nice work, most stuff have already been pointed out so I have nothing to say

 

[Kanadaj]

sweet GetLocalPlayer() :3

 

[-Kobas-]

Maker pointed some errors in Chat few hours ago.
I fixed 5 problems, just locations left, I will replace them with coordinates when I come home from school

 

[mateuspv]

I love that your system is very creative and beautiful, now even better.
Here UHPS always had this blank.
I do not know why.
http://imageshack.us/photo/my-images/526/kobas.png

 

[-Kobas-]

Because of resolution, or at least I think so, it was main problem to few more users as well.

EDIT:

Updated. Maker I fixed everything you mentioned and added few more things

 

[Magtheridon96]

You still need to combine this system into one trigger :/

 

[Luorax]

^ this. Also:

- Replaced location variables with coordinates (X and Y)

// This code is simple system addon, created to show you how powerful it can be.
function Interface_Human takes nothing returns nothing
    local integer ID = GetDestructableTypeId(GetEnumDestructable())
    local location l = Location(GetDestructableX(GetEnumDestructable()), GetDestructableY(GetEnumDestructable()))
    //   -  Night Elf       - Orc          - Undead
    if ID == 'B01Q' or ID == 'B014' or ID == 'B019'then
        call CreateDestructable('B01I', GetLocationX(l), GetLocationY(l), 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01R' or ID == 'B015' or ID == 'B01A' then
        call CreateDestructable('B01J', GetLocationX(l), GetLocationY(l), 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01S' or ID == 'B016' or ID == 'B01B' then
        call CreateDestructable('B01K', GetLocationX(l), GetLocationY(l), 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01T' or ID == 'B017' or ID == 'B01C' then
        call CreateDestructable('B01L', GetLocationX(l), GetLocationY(l), 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01U' or ID == 'B018' or ID == 'B01D' then
        call CreateDestructable('B01M', GetLocationX(l), GetLocationY(l), 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01V' or ID == 'B013' or ID == 'B01E' then
        call CreateDestructable('B01N', GetLocationX(l), GetLocationY(l), 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01W' or ID == 'B012' or ID == 'B01F' then
        call CreateDestructable('B01O', GetLocationX(l), GetLocationY(l), 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01X' or ID == 'B011' or ID == 'B01G' then
        call CreateDestructable('B01P', GetLocationX(l), GetLocationY(l), 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    endif
    call RemoveLocation (l)
    set l = null
endfunction

 

[-Kobas-]

Zomg I missed that trigger.
Fixed.

You still need to combine this system into one trigger :/

Why?

 

[Magtheridon96]

Because the system would be lighter, more portable, more readable, less cumbersome, and because you'll have less triggers (Every jass resource on the hive is in one trigger ;D)

By the way, this system is HAXX

 

[Geries]

Thats a bullshit. If someone makes his own system in one trigger then thats the problem, if not then that is. You still can copy trigger directories so no problem with portability. Good job man

 

[Bannar]

Optimization continues (this will be a bit long):

Dont inline TriggerRegisterAnyUnitEventBJ - this only increases size of your map.

function CreateTrack takes real X, real Y, integer Id, trigger T, integer UnitID returns nothing
    local integer i = 0
    set udg_UHPS_BUTTON[Id] = CreateUnit(Player(12),UnitID,X,Y,0)
    call SetUnitVertexColor(udg_UHPS_BUTTON[Id],255,255,255,0)
    loop
    exitwhen i>11
        call TriggerRegisterPlayerUnitEvent(T, Player(i), EVENT_PLAYER_UNIT_SELECTED, null)
        set i = i+1
    endloop
endfunction

->>

function CreateTrack takes real X, real Y, integer Id, trigger T, integer UnitID returns nothing
    set udg_UHPS_BUTTON[Id] = CreateUnit(Player(12),UnitID,X,Y,0)
    call SetUnitVertexColor(udg_UHPS_BUTTON[Id],255,255,255,0)
    call TriggerRegisterAnyUnitEventBJ(T,EVENT_PLAYER_UNIT_SELECTED)
endfunction

Trigger 'UHPS Setup' leaks timers:set udg_UHPS_CAMERA_TIMER[i] = CreateTimer()Remove RegisterEvent(int). Global arrays for ints are by default equal to 0, while booleans favourite 'false'.

    loop
        exitwhen i > 11
        call RegisterEvent(i)
        set udg_UHPS_SFX1[i] = "Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl"
        set udg_UHPS_SFX2[i] = "Abilities\\Spells\\Human\\Resurrect\\ResurrectTarget.mdl"
        set udg_UHPS_CAMERA_TIMER[i] = CreateTimer()
        set udg_UHPS_SYSTEM_BOOLEAN[i] = false
        set udg_UHPS_PICKEDHERO[i] = 0
        set udg_UHPS_TXTTAG[i] = CreateTextTag()
        call SetTextTagPos(udg_UHPS_TXTTAG[i],udg_UHPS_STATSX[i],udg_UHPS_STATSY[i],100)
        call SetTextTagText(udg_UHPS_TXTTAG[i],"",0.025)
        call TriggerRegisterTimerExpireEvent(gg_trg_UHPS_Camera_Loop, udg_UHPS_CAMERA_TIMER[i])
        call TriggerRegisterPlayerUnitEvent(gg_trg_UHPS_Click, Player(i), EVENT_PLAYER_UNIT_SELECTED, null)
        set i = i + 1
    endloop
endfunction

->>

    loop
        exitwhen i > 11
        call TriggerRegisterPlayerChatEvent( gg_trg_UHPS_Start, Player(i), "xxx", true )
        call TriggerRegisterPlayerEvent(gg_trg_UHPS_Start, Player(i), EVENT_PLAYER_END_CINEMATIC)
        set udg_UHPS_SFX1[i] = "Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl"
        set udg_UHPS_SFX2[i] = "Abilities\\Spells\\Human\\Resurrect\\ResurrectTarget.mdl"
        if udg_UHPS_CAMERA_TIMER[i] == null then
            set udg_UHPS_CAMERA_TIMER[i] = CreateTimer()
        endif
        set udg_UHPS_TXTTAG[i] = CreateTextTag()
        call SetTextTagPos(udg_UHPS_TXTTAG[i],udg_UHPS_STATSX[i],udg_UHPS_STATSY[i],100)
        call SetTextTagText(udg_UHPS_TXTTAG[i],"",0.025)
        call TriggerRegisterTimerExpireEvent(gg_trg_UHPS_Camera_Loop, udg_UHPS_CAMERA_TIMER[i])
        set i = i + 1
    endloop
    call TriggerRegisterAnyUnitEventBJ(gg_trg_UHPS_Click, EVENT_PLAYER_UNIT_SELECTED)
endfunction

Trigger 'UHPS Start' - Instead of TriggerAddAction use TriggerAddCondition; basically use conditions everywhere. However if you're going call TriggerExecute(the Start trigger here) than leave the AddActions.

Things like: 0.00 ->> 0.; 0.10 ->> 0.1

Global triggers in your system can be mostly replaced by local triggers which deprecate them.

Trigger UHPS Settin Button:

GetDestructableX()    ->>    GetWidgetX()
GetDestructableY()    ->>    GetWidgetY()

Don't you think that spamming GetSoldUnit() and multiple other functions in each line is a bit.. floopy and inefficient? Your functions in that trigger owns soooo many elseifs that... crap, fuck that; rewrite it!

1) UHPS_Settings_Button_Actions:
Use global array int and store those Ids into it at the begining. Those effects too.. This applys to first part of your trigg, but I'm pretty sure that with some formula usage all the Orc/Human/NE/UD and 1st part of function below can be combined into tiny trigg. Meaby I'll try to figure out some usefull formula for you.

Instead of this

    elseif GetUnitTypeId(GetSoldUnit()) == 'h007' then
        set udg_UHPS_SFX1[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl"
        set udg_UHPS_SFX2[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Human\\Resurrect\\ResurrectTarget.mdl"
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h008' then
        set udg_UHPS_SFX1[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Undead\\DarkRitual\\DarkRitualTarget.mdl"
        set udg_UHPS_SFX2[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Undead\\DeathPact\\DeathPactTarget.mdl"
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h009' then
        set udg_UHPS_SFX1[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Orc\\Purge\\PurgeBuffTarget.mdl"
        set udg_UHPS_SFX2[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl"
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h00A' then
        set udg_UHPS_SFX1[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Undead\\DeathCoil\\DeathCoilSpecialArt.mdl"
        set udg_UHPS_SFX2[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Undead\\AnimateDead\\AnimateDeadTarget.mdl"
        call RemoveUnit(GetSoldUnit())
    endif
endfunction

Throw that (I assume you've used globa array idea):

function UHPS_Settings_Button_Actions takes nothing returns nothing
    local integer i=0
    local unit u = GetSoldUnit()    // that one you need anyways
    local integer id = GetUnitTypeId(u)    // omg this one too >.<
    
    // here are the first 4 'ifs/elseifs'

    endif
    loop
        exitwhen i>3
        if id == IDS[i] then
            set id = i
            set i = 3
        endif
        set i = i+1
    endloop
    if id<4 then
        call RemoveUnit(u)
        set i = GetPlayerId(GetOwningPlayer(u))
        set udg_UHPS_SFX1[i] = SFX[2*id]
        set udg_UHPS_SFX2[i] = SFX[2*id+1]
    endif
    set u = null
endfunction

^Asuming that: IDS[0] = 'h007'; IDS[1] = 'hoo8' etc. while:
SFX[0] = "Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl"
SFX[1] = "Abilities\\Spells\\Human\\Resurrect\\ResurrectTarget.mdl"
etc..

Trigger UHPS, function UHPS_Click_Actions - you've forgotten to null handles? D;

Another anti loop racism? (=

function UHPS_Click_Actions takes nothing returns nothing
    local player p = GetTriggerPlayer()
    local integer P = GetPlayerId(p)
    local integer i = GetRandomInt(1,udg_UHPS_MAXHERO)
    local unit hero
    //Hero Icon 1
    if  GetTriggerUnit() == udg_UHPS_BUTTON[1]  then
        call SelectUnit(GetTriggerUnit(),false)
        call UHPS_Hero_Icon(1,p)
    
    //Hero Icon 2
    elseif GetTriggerUnit() == udg_UHPS_BUTTON[2]  then
        call SelectUnit(GetTriggerUnit(),false)
        call UHPS_Hero_Icon(2,p) 
     
    //Hero Icon 3
    elseif GetTriggerUnit() == udg_UHPS_BUTTON[3]  then
        call SelectUnit(GetTriggerUnit(),false)
        call UHPS_Hero_Icon(3,p)
        
    //Hero Icon 4
    elseif GetTriggerUnit() == udg_UHPS_BUTTON[4]  then
        call SelectUnit(GetTriggerUnit(),false)
        call UHPS_Hero_Icon(4,p)
        
    //Hero Icon 5
    elseif GetTriggerUnit() == udg_UHPS_BUTTON[5]  then
        call SelectUnit(GetTriggerUnit(),false)
        call UHPS_Hero_Icon(5,p)
        
    //Hero Icon 6
    elseif GetTriggerUnit() == udg_UHPS_BUTTON[6]  then
        call SelectUnit(GetTriggerUnit(),false)
        call UHPS_Hero_Icon(6,p)

    //------------------------------------------
    //TEMP BUTTON
    //COPY AND PASTE, COPY AND PASTE this function for each new button
    //JUST BE SURE THAT YOU USE SAME BUTTON ID LIKE IN SETUP TRIGGER, HERE FOR EXAMPLE xxx
    //elseif GetTriggerUnit() == udg_UHPS_BUTTON[xxx]  then
    //    call SelectUnit(GetTriggerUnit(),false)
    //    call UHPS_Hero_Icon(xxx,p)
    //------------------------------------------
    
    //Random
    elseif GetTriggerUnit() == udg_UHPS_BUTTON[99] then 
        call SelectUnit(GetTriggerUnit(),false)
        set udg_UHPS_SYSTEM_BOOLEAN[GetPlayerId(p)] = false
        call DisableTrigger(GetTriggeringTrigger())
        call TriggerSleepAction(0)
        set hero = CreateUnit(p,udg_UHPS_HEROTYPE[i],udg_UHPS_SPAWNX,udg_UHPS_SPAWNY,0)
        if GetLocalPlayer() == p then
            call SelectUnit(hero, true)
            call ResetToGameCamera(0)
            call PanCameraToTimed(udg_UHPS_SPAWNX,udg_UHPS_SPAWNY,0)
            call AttachSoundToUnit(udg_UHPS_SOUND2[i], hero)
            call SetSoundVolume(udg_UHPS_SOUND2[i], 270)
            call StartSound(udg_UHPS_SOUND2[i])
            call DestroyEffect(AddSpecialEffect(udg_UHPS_SFX2,udg_UHPS_SPAWNX,udg_UHPS_SPAWNY))
            call EnumDestructablesInRect(gg_rct_SystemRegion, null,function UHPS_Visibilty_D_OFF)
            call ForGroup(udg_UHPS_G, function UHPS_Visibilty_U_OFF)
            call UHPS_Visibility_F_OFF()
        endif
        call TriggerSleepAction(1)
        call EnableTrigger(GetTriggeringTrigger())
        
    //OK
    elseif GetTriggerUnit() == udg_UHPS_BUTTON[100] then 
        call SelectUnit(GetTriggerUnit(),false)
        set udg_UHPS_SYSTEM_BOOLEAN[GetPlayerId(p)] = false
        call DisableTrigger(GetTriggeringTrigger())
        call TriggerSleepAction(0)
        set hero = CreateUnit(p,udg_UHPS_HEROTYPE[udg_UHPS_PICKEDHERO],udg_UHPS_SPAWNX,udg_UHPS_SPAWNY,0)
        if GetLocalPlayer() == p then
            call SelectUnit(hero, true)
            call ResetToGameCamera(0)
            call PanCameraToTimed(udg_UHPS_SPAWNX,udg_UHPS_SPAWNY,0)
            call AttachSoundToUnit(udg_UHPS_SOUND2[udg_UHPS_PICKEDHERO], hero)
            call SetSoundVolume(udg_UHPS_SOUND2[udg_UHPS_PICKEDHERO], 270)
            call StartSound(udg_UHPS_SOUND2[udg_UHPS_PICKEDHERO])
            call DestroyEffect(AddSpecialEffect(udg_UHPS_SFX2,udg_UHPS_SPAWNX,udg_UHPS_SPAWNY))
            call EnumDestructablesInRect(gg_rct_SystemRegion, null,function UHPS_Visibilty_D_OFF)
            call ForGroup(udg_UHPS_G, function UHPS_Visibilty_U_OFF)
            call UHPS_Visibility_F_OFF()
        endif
        call TriggerSleepAction(1)
        call EnableTrigger(GetTriggeringTrigger())
    endif
endfunction

->>

function UHPS_Click_Actions takes nothing returns nothing
    local player p = GetTriggerPlayer()
    local integer P = GetPlayerId(p)
    local integer i = 1
    local boolean b = false
    local unit u = GetTriggerUnit()
    loop
        exitwhen i>6
        if u == udg_UHPS_BUTTON[i] then
            call SelectUnit(u,false)
            call UHPS_Hero_Icon(i,p)
            return
        endif
        set i = i+1
    endloop
    if u == udg_UHPS_BUTTON[99] then
       set b = true
       set i = GetRandomInt(1,udg_UHPS_MAXHERO)
    elseif u == udg_UHPS_BUTTON[100] then
       set b = true
       set i = udg_UHPS_PICKEDHERO
    endif
    if b then
        call SelectUnit(u,false)
        set udg_UHPS_SYSTEM_BOOLEAN = false
        call DisableTrigger(GetTriggeringTrigger())
        call TriggerSleepAction(0)
        set bj_lastCreatedUnit = CreateUnit(p,udg_UHPS_HEROTYPE[i],udg_UHPS_SPAWNX,udg_UHPS_SPAWNY,0)
        if GetLocalPlayer() == p then
            call SelectUnit(bj_lastCreatedUnit, true)
            call ResetToGameCamera(0)
            call PanCameraToTimed(udg_UHPS_SPAWNX,udg_UHPS_SPAWNY,0)
            call AttachSoundToUnit(udg_UHPS_SOUND2[i], bj_lastCreatedUnit)
            call SetSoundVolume(udg_UHPS_SOUND2[i], 270)
            call StartSound(udg_UHPS_SOUND2[i])
            call DestroyEffect(AddSpecialEffect(udg_UHPS_SFX2,udg_UHPS_SPAWNX,udg_UHPS_SPAWNY))
            call EnumDestructablesInRect(gg_rct_SystemRegion, null,function UHPS_Visibilty_D_OFF)
            call ForGroup(udg_UHPS_G, function UHPS_Visibilty_U_OFF)
            call UHPS_Visibility_F_OFF()
        endif
        call TriggerSleepAction(1)
        call EnableTrigger(GetTriggeringTrigger())
    endif
    set u = null
    set p = null
endfunction

^I wasn't checking that in game but hope you get the idea ;p Waits aren't best option too; timers, timers!

There are probably more improvements, but at first lets see, how your code gonna work this shit above (=

Good approach tho ;P
MOVE EVERYTHING INTO ONE TRIGGER SAYS THE COMMUNITY!

 

[Magtheridon96]

Thats a bullshit. If someone makes his own system in one trigger then thats the problem, if not then that is. You still can copy trigger directories so no problem with portability.

>_>
Not when you know how to organize your code right.
Comments and whitespace should be used to increase readability.
In it's current state, it's very messy and unreadable.

edit
Kobas, you should avoid using underscores in function names because that's against Jass convention.
The only case where underscores are used in function names is when you create a public function and JassHelper converts it's name to this: LibraryName_FunctionName()

 

[-Kobas-]

Thanks for support and criticism, I will check this closely.

 

[zv27]

It looks fucking good,but my favorite is still the system of maps Rise Of Winterchill

5/5

 

[baassee]

And don't worry about the amount of suggestions. Not your fault really, it's more like 'judging GUI - i dont care , judging jass/vjass/zinc - omg change this that there here ...'

 

[Bannar]

I would say nothing, but similar stuff happens to me so ofen
Jassing makes ppl more carefull before they upload something, ofcourse only if you don't want see half of coding community throwing suggestions here and there, telling how bad your shit actually looks like D;

 

[Luorax]

That's mostly because GUI is limited to its built-in BJ's (Bad JASS'es) (there are some GUI system out there tho', but not that much), while JASS and vJASS have tons of libraries to choose from, you can use different data structures, libraries and stuffs to write your own system.

 

[88WaRCraFT3]

can you tell me song name ? (i am sorry for offtopic but i really like the song)

 

[-Kobas-]

can you tell me song name ? (i am sorry for offtopic but i really like the song)

Two Steps From Hell - All Drones Go To Hell: Full Length: 09 Dreams of the Seven.mp3

call TriggerRegisterPlayerUnitEvent(T, Player(i), EVENT_PLAYER_UNIT_SELECTED, null)
You are right. But this code line show for what player you want it triggered. You will easily split this or remove few players. Point is to be more easier to work with, even for GUI users, that want to enchant their code with few lines of script.

Global arrays for ints are by default equal to 0, while booleans favourite 'false'.

True. Sorry, I forgot to edit this after switching from globals to user defined globals.
Will fix only this, that register trigger even is explained above.

I won't quote code below. But I get your point.
I will fix some things but keep some other.

And last thing, about timers and wait, it is added there to remove bug when you click few times in a row and spawn few heroes, also 0.5 sec delay (more or less) before clicking on another button isn't really such problem, you won't read info so fast or move cursor over screen (I don't care about 100% accurate value).

Kobas, you should avoid using underscores in function names because that's against Jass convention.
The only case where underscores are used in function names is when you create a public function and JassHelper converts it's name to this: LibraryName_FunctionName()

Because of user defined globals I just wanted to make sure that my variables won't mix with any other.
Is this really problem, spell mod?

It looks fucking good,but my favorite is still the system of maps Rise Of Winterchill

Thanks, maybe I decide to add few more things into multiboard and change your mind

And don't worry about the amount of suggestions. Not your fault really, it's more like 'judging GUI - i dont care , judging jass/vjass/zinc - omg change this that there here ...'

Jassing makes ppl more carefull before they upload something, ofcourse only if you don't want see half of coding community throwing suggestions here and there, telling how bad your shit actually looks like D;

I use jass it will be month or so. And honestly I don't really care, each programmer has it's own style. Ofc there are rules that we all most fallow, but I won't change my system much just because some epic coders find it "less effective", after all this isn't created for them, they can code this easily, ofc if they have idea, this is created for newbies and all people here somewhere that want to create something unique and cool. And 1 last thing I don't care about rating or mark, but I do care about fame. Sorry if I acted arrogant, that wasn't my intention.

I hope that I didn't missed anything.

 

[Magtheridon96]

Because of user defined globals I just wanted to make sure that my variables won't mix with any other.
Is this really problem, spell mod?

for readability, yes.

 

[-Kobas-]

There updated.
Oh I was working on new version as well.

I added dialog buttons.
Now when you pick hero you will be able to design it even more using dialog buttons.
Something like this but related to hero setup: http://www.hiveworkshop.com/forums/...s-279/dialog-buttons-advanced-systems-186390/

 

[Magtheridon96]

// This code is simple system addon, created to show you how powerful it can be.
function Interface_Human takes nothing returns nothing
    local integer ID = GetDestructableTypeId(GetEnumDestructable())
    local real x = GetWidgetX(GetEnumDestructable())
    local real y = GetWidgetY(GetEnumDestructable())
    //   -  Night Elf       - Orc          - Undead
    if ID == 'B01Q' or ID == 'B014' or ID == 'B019'then
        call CreateDestructable('B01I', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01R' or ID == 'B015' or ID == 'B01A' then
        call CreateDestructable('B01J', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01S' or ID == 'B016' or ID == 'B01B' then
        call CreateDestructable('B01K', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01T' or ID == 'B017' or ID == 'B01C' then
        call CreateDestructable('B01L', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01U' or ID == 'B018' or ID == 'B01D' then
        call CreateDestructable('B01M', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01V' or ID == 'B013' or ID == 'B01E' then
        call CreateDestructable('B01N', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01W' or ID == 'B012' or ID == 'B01F' then
        call CreateDestructable('B01O', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01X' or ID == 'B011' or ID == 'B01G' then
        call CreateDestructable('B01P', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    endif
endfunction

function Interface_Night_Elf takes nothing returns nothing
    local integer ID = GetDestructableTypeId(GetEnumDestructable())
    local real x = GetWidgetX(GetEnumDestructable())
    local real y = GetWidgetY(GetEnumDestructable())
    //   -  Human       - Orc          - Undead
    if ID == 'B01I' or ID == 'B014' or ID == 'B019'then
        call CreateDestructable('B01Q', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01J' or ID == 'B015' or ID == 'B01A' then
        call CreateDestructable('B01R', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01K' or ID == 'B016' or ID == 'B01B' then
        call CreateDestructable('B01S', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01L' or ID == 'B017' or ID == 'B01C' then
        call CreateDestructable('B01T', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01M' or ID == 'B018' or ID == 'B01D' then
        call CreateDestructable('B01U', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01N' or ID == 'B013' or ID == 'B01E' then
        call CreateDestructable('B01V', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01O' or ID == 'B012' or ID == 'B01F' then
        call CreateDestructable('B01W', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01P' or ID == 'B011' or ID == 'B01G' then
        call CreateDestructable('B01X', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    endif
endfunction

function Interface_Orc takes nothing returns nothing
    local integer ID = GetDestructableTypeId(GetEnumDestructable())
    local real x = GetWidgetX(GetEnumDestructable())
    local real y = GetWidgetY(GetEnumDestructable())
    //   -  Human       - Night Elf          - Undead
    if ID == 'B01I' or ID == 'B01Q' or ID == 'B019'then
        call CreateDestructable('B014', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01J' or ID == 'B01R' or ID == 'B01A' then
        call CreateDestructable('B015', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01K' or ID == 'B01S' or ID == 'B01B' then
        call CreateDestructable('B016', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01L' or ID == 'B01T' or ID == 'B01C' then
        call CreateDestructable('B017', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01M' or ID == 'B01U' or ID == 'B01D' then
        call CreateDestructable('B018', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01N' or ID == 'B01V' or ID == 'B01E' then
        call CreateDestructable('B013', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01O' or ID == 'B01W' or ID == 'B01F' then
        call CreateDestructable('B012', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01P' or ID == 'B01X' or ID == 'B01G' then
        call CreateDestructable('B011', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    endif
endfunction

function Interface_Undead takes nothing returns nothing
    local integer ID = GetDestructableTypeId(GetEnumDestructable())
    local real x = GetWidgetX(GetEnumDestructable())
    local real y = GetWidgetY(GetEnumDestructable())
    //   -  Human       - Orc          - Night Elf
    if ID == 'B01I' or ID == 'B014' or ID == 'B01Q'then
        call CreateDestructable('B019', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01J' or ID == 'B015' or ID == 'B01R' then
        call CreateDestructable('B01A', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01K' or ID == 'B016' or ID == 'B01S' then
        call CreateDestructable('B01B', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01L' or ID == 'B017' or ID == 'B01T' then
        call CreateDestructable('B01C', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01M' or ID == 'B018' or ID == 'B01U' then
        call CreateDestructable('B01D', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01N' or ID == 'B013' or ID == 'B01V' then
        call CreateDestructable('B01E', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01O' or ID == 'B012' or ID == 'B01W' then
        call CreateDestructable('B01F', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    elseif ID == 'B01P' or ID == 'B011' or ID == 'B01X' then
        call CreateDestructable('B01G', x, y, 0.00, 1, 0)
        call RemoveDestructable(GetEnumDestructable())
    endif
endfunction

function UHPS_Settings_Button_Actions takes nothing returns nothing
    if GetUnitTypeId(GetSoldUnit()) == 'h002' then
        if GetLocalPlayer() == GetOwningPlayer(GetSoldUnit()) then
            call EnumDestructablesInRect(gg_rct_SystemRegion, null, function Interface_Human)
        endif
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h003' then
        if GetLocalPlayer() == GetOwningPlayer(GetSoldUnit()) then
            call EnumDestructablesInRect(gg_rct_SystemRegion, null, function Interface_Night_Elf)
        endif
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h004' then
        if GetLocalPlayer() == GetOwningPlayer(GetSoldUnit()) then
            call EnumDestructablesInRect(gg_rct_SystemRegion, null, function Interface_Orc)
        endif
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h005' then
        if GetLocalPlayer() == GetOwningPlayer(GetSoldUnit()) then
            call EnumDestructablesInRect(gg_rct_SystemRegion, null, function Interface_Undead)
        endif
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h007' then
        set udg_UHPSSFX1[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl"
        set udg_UHPSSFX2[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Human\\Resurrect\\ResurrectTarget.mdl"
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h008' then
        set udg_UHPSSFX1[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Undead\\DarkRitual\\DarkRitualTarget.mdl"
        set udg_UHPSSFX2[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Undead\\DeathPact\\DeathPactTarget.mdl"
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h009' then
        set udg_UHPSSFX1[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Orc\\Purge\\PurgeBuffTarget.mdl"
        set udg_UHPSSFX2[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl"
        call RemoveUnit(GetSoldUnit())
    elseif GetUnitTypeId(GetSoldUnit()) == 'h00A' then
        set udg_UHPSSFX1[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Undead\\DeathCoil\\DeathCoilSpecialArt.mdl"
        set udg_UHPSSFX2[GetPlayerId(GetOwningPlayer(GetSoldUnit()))] = "Abilities\\Spells\\Undead\\AnimateDead\\AnimateDeadTarget.mdl"
        call RemoveUnit(GetSoldUnit())
    endif
endfunction

//===========================================================================
function InitTrig_UHPS_Settings_Button takes nothing returns nothing
    set gg_trg_UHPS_Settings_Button = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_UHPS_Settings_Button, EVENT_PLAYER_UNIT_SELL )
    call TriggerAddAction( gg_trg_UHPS_Settings_Button, function UHPS_Settings_Button_Actions )
endfunction

->

// This code is simple system addon, created to show you how powerful it can be.
function Interface_Human takes nothing returns nothing
    local destructable u = GetEnumDestructable()
    local integer ID = GetDestructableTypeId(u)
    local real x = GetWidgetX(u)
    local real y = GetWidgetY(u)
    
    //   -  Night Elf       - Orc          - Undead
    if ID == 'B01Q' or ID == 'B014' or ID == 'B019'then
        call CreateDestructable('B01I', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01R' or ID == 'B015' or ID == 'B01A' then
        call CreateDestructable('B01J', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01S' or ID == 'B016' or ID == 'B01B' then
        call CreateDestructable('B01K', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01T' or ID == 'B017' or ID == 'B01C' then
        call CreateDestructable('B01L', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01U' or ID == 'B018' or ID == 'B01D' then
        call CreateDestructable('B01M', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01V' or ID == 'B013' or ID == 'B01E' then
        call CreateDestructable('B01N', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01W' or ID == 'B012' or ID == 'B01F' then
        call CreateDestructable('B01O', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01X' or ID == 'B011' or ID == 'B01G' then
        call CreateDestructable('B01P', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    endif
    
    set u = null
endfunction

function Interface_Night_Elf takes nothing returns nothing
    local destructable u = GetEnumDestructable()
    local integer ID = GetDestructableTypeId(u)
    local real x = GetWidgetX(u)
    local real y = GetWidgetY(u)
    
    //   -  Human       - Orc          - Undead
    if ID == 'B01I' or ID == 'B014' or ID == 'B019'then
        call CreateDestructable('B01Q', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01J' or ID == 'B015' or ID == 'B01A' then
        call CreateDestructable('B01R', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01K' or ID == 'B016' or ID == 'B01B' then
        call CreateDestructable('B01S', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01L' or ID == 'B017' or ID == 'B01C' then
        call CreateDestructable('B01T', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01M' or ID == 'B018' or ID == 'B01D' then
        call CreateDestructable('B01U', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01N' or ID == 'B013' or ID == 'B01E' then
        call CreateDestructable('B01V', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01O' or ID == 'B012' or ID == 'B01F' then
        call CreateDestructable('B01W', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01P' or ID == 'B011' or ID == 'B01G' then
        call CreateDestructable('B01X', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    endif
    
    set u = null
endfunction

function Interface_Orc takes nothing returns nothing
    local destructable u = GetEnumDestructable()
    local integer ID = GetDestructableTypeId(u)
    local real x = GetWidgetX(u)
    local real y = GetWidgetY(u)
    
    //   -  Human       - Night Elf          - Undead
    if ID == 'B01I' or ID == 'B01Q' or ID == 'B019'then
        call CreateDestructable('B014', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01J' or ID == 'B01R' or ID == 'B01A' then
        call CreateDestructable('B015', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01K' or ID == 'B01S' or ID == 'B01B' then
        call CreateDestructable('B016', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01L' or ID == 'B01T' or ID == 'B01C' then
        call CreateDestructable('B017', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01M' or ID == 'B01U' or ID == 'B01D' then
        call CreateDestructable('B018', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01N' or ID == 'B01V' or ID == 'B01E' then
        call CreateDestructable('B013', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01O' or ID == 'B01W' or ID == 'B01F' then
        call CreateDestructable('B012', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01P' or ID == 'B01X' or ID == 'B01G' then
        call CreateDestructable('B011', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    endif
    
    set u = null
endfunction

function Interface_Undead takes nothing returns nothing
    local destructable u = GetEnumDestructable()
    local integer ID = GetDestructableTypeId(u)
    local real x = GetWidgetX(u)
    local real y = GetWidgetY(u)
    
    //   -  Human       - Orc          - Night Elf
    if ID == 'B01I' or ID == 'B014' or ID == 'B01Q'then
        call CreateDestructable('B019', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01J' or ID == 'B015' or ID == 'B01R' then
        call CreateDestructable('B01A', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01K' or ID == 'B016' or ID == 'B01S' then
        call CreateDestructable('B01B', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01L' or ID == 'B017' or ID == 'B01T' then
        call CreateDestructable('B01C', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01M' or ID == 'B018' or ID == 'B01U' then
        call CreateDestructable('B01D', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01N' or ID == 'B013' or ID == 'B01V' then
        call CreateDestructable('B01E', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01O' or ID == 'B012' or ID == 'B01W' then
        call CreateDestructable('B01F', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    elseif ID == 'B01P' or ID == 'B011' or ID == 'B01X' then
        call CreateDestructable('B01G', x, y, 0.00, 1, 0)
        call RemoveDestructable(u)
    endif
    
    set u = null
endfunction

function UHPSSettingsButtonActions takes nothing returns nothing
    local unit u = GetSoldUnit()
    local integer i = GetUnitTypeId(u)
    local player p = GetOwningPlayer(u)
    local integer k = GetPlayerId(p)
    
    if i == 'h002' then
        if GetLocalPlayer() == p then
            call EnumDestructablesInRect(gg_rct_SystemRegion, null, function Interface_Human)
        endif
        call RemoveUnit(u)
    elseif i == 'h003' then
        if GetLocalPlayer() == p then
            call EnumDestructablesInRect(gg_rct_SystemRegion, null, function Interface_Night_Elf)
        endif
        call RemoveUnit(u)
    elseif i == 'h004' then
        if GetLocalPlayer() == p then
            call EnumDestructablesInRect(gg_rct_SystemRegion, null, function Interface_Orc)
        endif
        call RemoveUnit(u)
    elseif i == 'h005' then
        if GetLocalPlayer() == p then
            call EnumDestructablesInRect(gg_rct_SystemRegion, null, function Interface_Undead)
        endif
        call RemoveUnit(u)
    elseif i == 'h007' then
        set udg_UHPSSFX1[k] = "Abilities\\Spells\\Human\\HolyBolt\\HolyBoltSpecialArt.mdl"
        set udg_UHPSSFX2[k] = "Abilities\\Spells\\Human\\Resurrect\\ResurrectTarget.mdl"
        call RemoveUnit(u)
    elseif i == 'h008' then
        set udg_UHPSSFX1[k] = "Abilities\\Spells\\Undead\\DarkRitual\\DarkRitualTarget.mdl"
        set udg_UHPSSFX2[k] = "Abilities\\Spells\\Undead\\DeathPact\\DeathPactTarget.mdl"
        call RemoveUnit(u)
    elseif i == 'h009' then
        set udg_UHPSSFX1[k] = "Abilities\\Spells\\Orc\\Purge\\PurgeBuffTarget.mdl"
        set udg_UHPSSFX2[k] = "Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl"
        call RemoveUnit(u)
    elseif i == 'h00A' then
        set udg_UHPSSFX1[k] = "Abilities\\Spells\\Undead\\DeathCoil\\DeathCoilSpecialArt.mdl"
        set udg_UHPSSFX2[k] = "Abilities\\Spells\\Undead\\AnimateDead\\AnimateDeadTarget.mdl"
        call RemoveUnit(u)
    endif
    
    set u = null
    set p = null
endfunction

function InitTrig_UHPS_Settings_Button takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SELL)
    call TriggerAddCondition(t, Condition(function UHPSSettingsButtonActions))
    set t = null
endfunction

 

[Bannar]

Maggy, you know that with some additional array globals this whole elseif spam would be cleaned up ;<

 

[Adiktuz]

yeah an array or a hash would shorten that code tremendously...

 

[marko9]

Ok I mean its clean and briliant but my opinion is that you should add something like when you change the hero interface changes on his own...just my opinion ^_^

 

[Magtheridon96]

yeah an array or a hash would shorten that code tremendously...

Maggy, you know that with some additional array globals this whole elseif spam would be cleaned up ;<

I know, but before I tell him to use a hashtable, I need him to know that spamming functions like that is bad and slow

-Kobas-, you'd save the ID of the destructable you're going to create inside a hashtable with the key of the ID variable you're checking those Interface_ functions.


Your function would become like this:

function Interface_Night_Elf takes nothing returns nothing
    local destructable u = GetEnumDestructable()
    
    call CreateDestructable(LoadInteger(udg_InterHash, GetDestructableTypeId(u), 0), GetWidgetX(u), GetWidgetY(u), 0.00, 1, 0)
    call RemoveDestructable(u)
    
    set u = null
endfunction

That's a HUGE improvement

Kudos to Adiktuz and Spinnaker for forcing me to do this xD

 

[Kazeon]

I have seen many other systems like this.. That all were the videos and photos only. But in fact they're totally weird I think!!! The interface was totally bad. Not like in the photo that you give... I don't know what's wrong with my pc but i think mine is normal. The models are not shown when I click any hero button.
But just keep going on! Good job..

 

[-Kobas-]

My system work perfectly fine without errors, if your PC can't display them, change game resolution screen or visual options. If everything you try fail, just use floating text (text tags) as titles instead images.

 

[Kazeon]

Ah, but that's so creative... There's a dialog box when we hover at the hero button.. That's cool.. Actually the interface or skin is not really important here.. The important is the system.. And you made it!

Rep++
_________________________________________
Oh and the model preview doesn't display too.. I think the resolution isn't the problem here....

 

[Adiktuz]

The goodness of using units instead of trackables... awesome...

 

[Undeadducky]

Awesome I will test This Out Looks Epic 100000/5

 

[Maker]

You could disable entering the selection screen if the player already has a hero. You could consider repick option.

I'm not a fan of using a terrain type for the black. It limits the number of tiles available. Instead, try:

local image i = CreateImage("Textures\\Black32.blp", 2000, 2000, 0, -3300, 1400, 0, 0, 0, 0, 2)
call SetImageRenderAlways(i , true)

And then show/hide it locally.

The 2000, 2000 is the width (x) and height (y). The -3300 and 1400 are the coordinates of the lower left corner of the image. 2 is image type. Don't use 1, since that gets drawn over effects I believe. You can test 3 and 4 also, but I believe 2 should work.

I can select the unit in the screen are, when not in the screen mode. I can get more heroes.

gg_trg_UHPS_Camera_Setup trigger loops even when no units are in the screen. That is a no-no.

Add call CameraSetupApplyForceDuration(udg_UHPSCamera, true, 0) to function Trig_UHPS_Progress_Actions so the camera pans instantly, and not over 0.1 seconds when the player enter the screen.

If I select Pick hero when no hero has been selected, a special effect is still created.

That's all for now, I'll take a look at the coding some more later. Keep on improving this, it is a great system.

 

[Marcos DAB]

Its too hard to implement...

 

[Apheraz Lucent]

Subscribing. I am looking forward to see this in LW. Keep up the good work, -Kobas-!

Anyways, make the interface change icon removable in the code (True, False boolean). Not all of us needs it. Usage of five different fonts is just... Ugh.

 

[-Kobas-]

Well you can remove whole trigger and that button with few trigger actions in setup trigger and that's it

But I will try to optimize this completely, for now you are free to experiment with it.

 

[Apheraz Lucent]

Try to use some polishing in here, too. Rather than a spam of a single effect, wonders can be performed with few different.

 

[-Kobas-]

Hmmmmm I started working on this once again, because lately a lot of people asked from me edited GUI version.

New one will be coded in vJass and so far code looks far more easier and faster than this one.
In just 1 day I re-coded 90% of whole system, simple library replaced all those triggers and shits.
Hmmm only thing left is to setup each hero, store stats and other values into variables and so on, but it should be finished in no time.
I will create GUI trigger as well so you can easily edit this even if you don't know jass.

It has 16 heroes, 1 interface for all players, you can still use multiboard with this, basic setup and so on...

 

[baassee]

Lovely, gimme a call if you need any help

 

[-Kobas-]

Lovely, gimme a call if you need any help

I will share code tomorrow before I actually update resource
Any help is appreciated