Trigger Doesn't Do Damage

[Aeroblyctos]

Hey.

I have a little problem. I have done thousands of this type of triggers but I don't understand what's wrong with this one. The trigger doesn't do any damage to player 1's units.

TRIGGER

• Elite Boss TORNADO DMG
  • Events
    • Time - Every 0.50 seconds of game time
  • Conditions
  • Actions
    • Set TempGroup = (Units in Elite Boss Fightning Area WHOLE <gen> matching (((Unit-type of (Matching unit)) Equal to Tornado (ELITE BOSS)) and (((Matching unit) is alive) Equal to True)))
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • Set TempLoc = (Position of (Picked unit))
        • Set TempGroup2 = (Units owned by Player 1 (Red))
        • Set TempGroup3 = (Units within 350.00 of TempLoc matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is in TempGroup2) Equal to True) and (((Matching unit) has buff Invulnerable) Equal to False))))
        • Set TempGroup4 = (Units within 250.00 of TempLoc matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is in TempGroup2) Equal to True) and (((Matching unit) has buff Invulnerable) Equal to False))))
        • Set TempGroup5 = (Units within 150.00 of TempLoc matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is in TempGroup2) Equal to True) and (((Matching unit) has buff Invulnerable) Equal to False))))
        • Unit Group - Pick every unit in TempGroup3 and do (Actions)
          • Loop - Actions
            • Unit - Cause ELITE_BOSS to damage (Picked unit), dealing Tornado_Damage_1 damage of attack type Spells and damage type Normal
            • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Human\FlakCannons\FlakTarget.mdl
            • Special Effect - Destroy (Last created special effect)
        • Unit Group - Pick every unit in TempGroup4 and do (Actions)
          • Loop - Actions
            • Unit - Cause ELITE_BOSS to damage (Picked unit), dealing Tornado_Damage_2 damage of attack type Spells and damage type Normal
        • Unit Group - Pick every unit in TempGroup5 and do (Actions)
          • Loop - Actions
            • Unit - Cause ELITE_BOSS to damage (Picked unit), dealing Tornado_Damage_3 damage of attack type Spells and damage type Normal
        • Custom script: call RemoveLocation(udg_TempLoc)
        • Custom script: call DestroyGroup(udg_TempGroup2)
        • Custom script: call DestroyGroup(udg_TempGroup3)
        • Custom script: call DestroyGroup(udg_TempGroup4)
        • Custom script: call DestroyGroup(udg_TempGroup5)
    • Custom script: call DestroyGroup(udg_TempGroup)

The one who helps will get some rep.

 

[Nightmare Moon]

I don't see any action where you pick "TempGroup2".
You pick all groups except "TempGroup2"

 

[Garfield1337]

You can make it shorter:

• Elite Boss TORNADO DMG
• Events
  • Time - Every 0.50 seconds of game time
• Conditions
• Actions
  • Custom script: set bj_wantDestroyGroup = true
  • Unit Group - Pick every unit (Units in Elite Boss Fightning Area WHOLE <gen> matching (((Unit-type of (Matching unit)) Equal to Tornado (ELITE BOSS)) and (((Matching unit) is alive) Equal to True))) and do (Actions)
  • Loop - Actions
    • Set TempLoc = (Position of (Picked unit))
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 350.00 of TempLoc matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) has buff Invulnerable) Equal to False))) and (Owner of (Matching)) Equal to Player 1 (Red)) and do (Actions)
    • Loop - Actions
      • Unit - Cause ELITE_BOSS to damage (Picked unit), dealing (Tornado_Damage_1 + Tornado_Damage_2 + Tornado_Damage_3) damage of attack type Spells and damage type Normal
      • Custom script: call DestroyEffect(AddSpecialEffectTarget("Abilities\\Spells\\Human\\FlakCannons\\FlakTarget.mdl", GetTriggerUnit(),"origin"))
    • Custom script: call RemoveLocation(udg_TempLoc)

 

[mckill2009]

coz you destroyed tempgroups outside the cause damage loop...

 

[Maker]

Could you paste the trigger into an empty test map? You don't have to add units, regions etc. Just the trigger. Make sure the variables are copied.

I don't see any action where you pick "TempGroup2".
You pick all groups except "TempGroup2"

Units in group 2 need not to be picked. The group works as a filter for groups 3, 4 and 5.

You can make it shorter

That way the damage won't be applied correctly.

coz you destroyed tempgroups outside the cause damage loop...

The groups are destroyed correctly.

 

[Garfield1337]

That way the damage won't be applied correctly.

Why not?

 

[Maker]

The closer the unit is the more damage it will take. In your trigger all units take the same amount of damage.

Also you have GetTriggerUnit in that special effect custom script

 

[Aeroblyctos]

Yea, there are 3 different damages, Maker is right. The nearer you are a tornado more damage you'll take. I think that's more realistic but I fear of lag...

Okay, I made a test map.

EDIT: I copied the triggers in hurry I forgot to copy the damages from the campaign.

EDIT 2: I added to that second map the damages.

EDIT 3: No more edits!

 

[Maker]

Units with locust won't be picked by the unit group pick

Pick units owned by player matching condition (tornadoes) , it will pick units with locust.

You can take TempGroup2 out of the loop.

 

[Garfield1337]

Oh lol
Didn't notice it deals more damage the closer the unit is.
In that case,this should work:

• Elite Boss TORNADO DMG
• Events
  • Time - Every 0.50 seconds of game time
• Conditions
• Actions
  • Custom script: set bj_wantDestroyGroup = true
  • Unit Group - Pick every unit (Units in Elite Boss Fightning Area WHOLE <gen> matching (((Unit-type of (Matching unit)) Equal to Tornado (ELITE BOSS)) and (((Matching unit) is alive) Equal to True))) and do (Actions)
  • Loop - Actions
    • Set TempLoc1 = (Position of (Picked unit))
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 350.00 of TempLoc matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) has buff Invulnerable) Equal to False))) and (Owner of (Matching)) Equal to Player 1 (Red)) and do (Actions)
    • Loop - Actions
      • Set TempLoc2 = (Position of (Picked unit))
      • Unit - Cause ELITE_BOSS to damage (Picked unit), dealing (Real(Integer(Distance between TempLoc1 and Temploc2) / 100) * Tornado_Damage) damage of attack type Spells and damage type Normal
      • Custom script: call DestroyEffect(AddSpecialEffectTarget("Abilities\\Spells\\Human\\FlakCannons\\FlakTarget.mdl", GetEnumUnit(),"origin"))
    • Custom script: call RemoveLocation(udg_TempLoc)

 

[Aeroblyctos]

Units with locust won't be picked by the unit group pick

Pick units owned by player matching condition (tornadoes) , it will pick units with locust.

You can take TempGroup2 out of the loop.

Is it possible to do with locust?

 

[Maker]

• Set TempGroup = (Units owned by Neutral Passive matching ((((Matching unit) is alive) Equal to True) and ((Unit-type of (Matching unit)) Equal to Tornado)))

 

[CoLd Bon3]

• Unit Group - Pick every unit in TempGroup and do (Actions)
  • Loop - Actions

I don't see any unit added to this group

 

[Aeroblyctos]

Oh yea, everything is working now. Great, thanks guys who helped. Special thanks to Maker.

+rep