[General] Leak Remove

Aeroblyctos · Mar 10, 2012

Hey.

I think this trigger leaks and I've no idea how to fix it. Please fix it for me and can I continue doing this boss spell!

Map attached. Trigger looks like this:

Damage
- Events
  - Time - Every 0.30 seconds of game time
- Conditions
  - Boss_Event Equal to True
- Actions
  - Set Skull_Point[Skull_Counter] = (Position of AAAPhodom)
  - Set Skull_Counter = (Skull_Counter + 1)
  - Wait 1.00 seconds
  - -------- --------
  - Special Effect - Create a special effect at Skull_Point[1] using Objects\Spawnmodels\Undead\UndeadDissipate\UndeadDissipate.mdl
  - Special Effect - Destroy (Last created special effect)
  - Set TempGroup = (Units owned by Player 1 (Red))
  - Set TempGroup2 = (Units within 100.00 of Skull_Point[1] matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is in TempGroup) Equal to True) and ((Level of Invulnerable (Neutral) for (Matching unit)) Equal to 0))))
  - Unit Group - Pick every unit in TempGroup2 and do (Actions)
    - Loop - Actions
      - Unit - Cause AAAPhodom to damage AAAPhodom, dealing 50.00 damage of attack type Spells and damage type Normal
  - Custom script: call DestroyGroup(udg_TempGroup)
  - Custom script: call DestroyGroup(udg_TempGroup2)
  - Custom script: call RemoveLocation(udg_Skull_Point[1])
  - -------- --------
  - For each (Integer A) from 1 to (Skull_Counter - 1), do (Actions)
    - Loop - Actions
      - Set Skull_Point[(Integer A)] = Skull_Point[((Integer A) + 1)]
  - Custom script: call RemoveLocation(udg_Skull_Point[udg_Skull_Counter])
  - Set Skull_Counter = (Skull_Counter - 1)

Rep + credits for the helper.

Chaosy · Mar 10, 2012

i think the call RemoveLocation(udg_Skull_Point[udg_Skull_Counter]) is invaild

shadowvzs · Mar 10, 2012

Aeroblyctos said:
Hey.

I think this trigger leaks and I've no idea how to fix it. Please fix it for me and can I continue doing this boss spell!

Map attached. Trigger looks like this:

Damage

Events

Time - Every 0.30 seconds of game time

Conditions

Boss_Event Equal to True

Actions

Set Skull_Point[Skull_Counter] = (Position of AAAPhodom)

Set Skull_Counter = (Skull_Counter + 1)

Wait 1.00 seconds

-------- --------

Special Effect - Create a special effect at Skull_Point[1] using Objects\Spawnmodels\Undead\UndeadDissipate\UndeadDissipate.mdl

Special Effect - Destroy (Last created special effect)

Set TempGroup = (Units owned by Player 1 (Red))

Set TempGroup2 = (Units within 100.00 of Skull_Point[1] matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is in TempGroup) Equal to True) and ((Level of Invulnerable (Neutral) for (Matching unit)) Equal to 0))))

Unit Group - Pick every unit in TempGroup2 and do (Actions)

Loop - Actions

Unit - Cause AAAPhodom to damage AAAPhodom, dealing 50.00 damage of attack type Spells and damage type Normal

Custom script: call DestroyGroup(udg_TempGroup)

Custom script: call DestroyGroup(udg_TempGroup2)

Custom script: call RemoveLocation(udg_Skull_Point[1])

-------- --------

For each (Integer A) from 1 to (Skull_Counter - 1), do (Actions)

Loop - Actions

Set Skull_Point[(Integer A)] = Skull_Point[((Integer A) + 1)]

Custom script: call RemoveLocation(udg_Skull_Point[udg_Skull_Counter])

Set Skull_Counter = (Skull_Counter - 1)

Rep + credits for the helper.

for me its give fatal error when i try start the map even i turned off all trigger. to u this demo map well?

just a notice, maybe u can removelocation in loop?

For each (Integer A) from 1 to (Skull_Counter - 1), do (Actions)
- Loop - Actions
  - Custom script: call RemoveLocation(udg_Skull_Point[GetForLoopIndexA()])
  - Set Skull_Point[(Integer A)] = Skull_Point[((Integer A) + 1)]
Custom script: call RemoveLocation(udg_Skull_Point[udg_Skull_Counter])

Aeroblyctos · Mar 10, 2012

Really?

You mean you can't start the map?

shadowvzs · Mar 10, 2012

Aeroblyctos said:
Really?

You mean you can't start the map?

y, like on screenshot

Aeroblyctos · Mar 10, 2012

Okay fixed. Here's the fixed map in this post.

Ender · Mar 10, 2012

Damage
- Events
  - Time - Every 0.30 seconds of game time
- Conditions
  - Boss_Event Equal to True
- Actions
  - Custom script: local location udg_Skull_Loc
  - Set Skull_Loc = (Position of AAAPhodom)
  - Wait 1.00 seconds
  - -------- --------
  - Special Effect - Create a special effect at Skull_Loc using Objects\Spawnmodels\Undead\UndeadDissipate\UndeadDissipate.mdl
  - Special Effect - Destroy (Last created special effect)
  - Set TempGroup = (Units owned by Player 1 (Red))
  - Set TempGroup2 = (Units within 100.00 of Skull_Loc matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is in TempGroup) Equal to True) and ((Level of Invulnerable (Neutral) for (Matching unit)) Equal to 0))))
  - Unit Group - Pick every unit in TempGroup2 and do (Actions)
    - Loop - Actions
      - Unit - Cause AAAPhodom to damage AAAPhodom, dealing 50.00 damage of attack type Spells and damage type Normal
  - Custom script: call DestroyGroup(udg_TempGroup)
  - Custom script: call DestroyGroup(udg_TempGroup2)
  - Custom script: call RemoveLocation(udg_Skull_Loc)

made leakless uses a local instead of a global.

shadowvzs · Mar 10, 2012

Aeroblyctos said:
Okay fixed. Here's the fixed map in this post.

acctually if u replace points to coords then i think ok

still i think kinda wrong if u use 1 sec waits in 0.3 sec periodic triggers but u know, also u just pick the units in temp group2 only around 1st point

JASS:

function Trig_Damage_Conditions takes nothing returns boolean
    return udg_Boss_Event
endfunction

function Trig_Damage_Actions takes nothing returns nothing
    local unit pu
    local integer i
    local integer max
    set udg_X[udg_Skull_Counter] = GetUnitX(udg_AAAPhodom)
    set udg_Y[udg_Skull_Counter] = GetUnitY(udg_AAAPhodom)
    set udg_Skull_Counter = udg_Skull_Counter + 1
    call TriggerSleepAction( 1.00 )
    //  
    call DestroyEffect(AddSpecialEffect( "Objects\\Spawnmodels\\Undead\\UndeadDissipate\\UndeadDissipate.mdl" , udg_X[1], udg_Y[1]))
    call GroupEnumUnitsOfPlayer (udg_TempGroup, Player(0), null)
    call GroupEnumUnitsInRange(udg_TempGroup2, udg_X[1], udg_Y[1], 100.00, null)
    loop
        set pu = FirstOfGroup(udg_TempGroup2)
        exitwhen (pu==null)
        if IsUnitInGroup(pu, udg_TempGroup) and GetUnitAbilityLevel(pu, 'Avul') == 0 and not IsUnitType(pu, UNIT_TYPE_DEAD) then
            call UnitDamageTarget(udg_AAAPhodom, udg_AAAPhodom, 50.00, true, false, ATTACK_TYPE_HERO, DAMAGE_TYPE_NORMAL, null)
        endif
        call GroupRemoveUnit(udg_TempGroup2, pu)
    endloop
 
    set i = 1
    set max = udg_Skull_Counter - 1
    loop
        exitwhen i > max
        set udg_X[i] = udg_X[i + 1 ]
        set udg_Y[i] = udg_Y[i + 1 ]
        set i = i + 1
    endloop
    set udg_Skull_Counter = udg_Skull_Counter - 1
    set pu = null
endfunction

//===========================================================================
function InitTrig_Damage takes nothing returns nothing
    set gg_trg_Damage = CreateTrigger( )
    call TriggerRegisterTimerEventPeriodic( gg_trg_Damage, 0.30 )
    call TriggerAddCondition( gg_trg_Damage, Condition( function Trig_Damage_Conditions ) )
    call TriggerAddAction( gg_trg_Damage, function Trig_Damage_Actions )
endfunction

if u want make to others points too then

JASS:

    call DestroyEffect(AddSpecialEffect( "Objects\\Spawnmodels\\Undead\\UndeadDissipate\\UndeadDissipate.mdl" , udg_X[1], udg_Y[1]))
    call GroupEnumUnitsInRange(udg_TempGroup2, udg_X[1], udg_Y[1], 100.00, null)

change to this

JASS:

    call DestroyEffect(AddSpecialEffect( "Objects\\Spawnmodels\\Undead\\UndeadDissipate\\UndeadDissipate.mdl" , udg_X[udg_Skull_Counter], udg_Y[udg_Skull_Counter]))
     call GroupEnumUnitsInRange(udg_TempGroup2, udg_X[udg_Skull_Counter], udg_Y[udg_Skull_Counter], 100.00, null)

Ender · Mar 10, 2012

why bother with globals at all Shadowz? you can just use locals.

Aeroblyctos · Mar 10, 2012

Hey.

I'm a GUI guy and I feel like Ender's code is more for me so I'll pick it. Neverthehless thanks shadowvzs for contributing to this thread.

Thanks again everyone and especially thanks to you Enders.

Maker · Mar 10, 2012

I'm not sure if shadowing a global leaks if you do not null the variable.

I would do it this way:

Damage
- Events
  - Time - Every 0.30 seconds of game time
- Conditions
  - Boss_Event Equal to True
- Actions
  - Custom script: local location l = GetUnitLoc(udg_AAAPhodom)
  - Wait 1.00 seconds
  - Custom script: set udg_Skull_Loc = l
  - -------- --------
  - Special Effect - Create a special effect at Skull_Loc using Objects\Spawnmodels\Undead\UndeadDissipate\UndeadDissipate.mdl
  - Special Effect - Destroy (Last created special effect)
  - Set TempGroup = (Units within 100.00 of Skull_Loc matching ((((Matching unit) is alive) Equal to True) and (((Owner of (Matching unit)) Equal to Player 1 (Red)) and ((Level of Invulnerable (Neutral) for (Matching unit)) Equal to 0))))
  - Unit Group - Pick every unit in TempGroup2 and do (Actions)
    - Loop - Actions
      - Unit - Cause AAAPhodom to damage AAAPhodom, dealing 50.00 damage of attack type Spells and damage type Normal
  - Custom script: call DestroyGroup(udg_TempGroup)
  - Custom script: call RemoveLocation(l)
  - Custom script: set l = null

Pharaoh_ · Mar 10, 2012

If you are going to wait for the actions, why not setting the periodic tick to 1.30 seconds of game-time?

shadowvzs · Mar 11, 2012

Pharaoh_ said:
If you are going to wait for the actions, why not setting the periodic tick to 1.30 seconds of game-time?

coz he want delay, he dont want the special effect be at unit position, he want make special effect on a older unit position like a delayed special effect.

[General] Leak Remove

Attachments

Attachments

Attachments

Attachments

Attachments

Similar threads