Things That Leak

[Newuser]

I have a question, if I use(for example), "Remove Last Created Unit" action, will the "Last Created Unit" only refer to the last created unit in that specific trigger only or does it mean Last Created Unit in any trigger throughout the entire map?

 

[Justify]

The last created unit that is created via "CreateUnitAtLocSaveLast", that function is used by "CreateNUnitsAtLoc" whats the function you use in GUI to create units. If you create 5 footmans, "Last Created Unit" refers to the last of them, it's only usefull when you create single units.

 

[Eleandor]

"Last created unit" refers to the actual last created unit by the GUI action "Unit - create unit". This is a global variable, i.e. there can only be 1 last created unit at the same time, as opposed to 1 last created unit per trigger.

 

[Newuser]

I see thanks.

I was wondering because I have something like this:

• A unit is attacked:
• Create a Unit for owner of attacking unit
• Play last created unit's "spin" animation
• Wait 0.25
• Remove Last Created Unit

Now the thing I was concerned about was if "Remove Last Created Unit" would instead remove another unit created in another trigger.

Now for some reason, the last time I did a trigger with:

• Add an expiration timer to last created, expiring in <x seconds>

If I made the duration shorter than 1 second or something, it would glitch for some reason and cause problems(I forgot what they were though). Not sure if it'll happen again which is why I avoided using an expiration timer in this case.

So I assume the way around this problem would be to set the "Last Created Unit" to a "local unit variable", then wait 0.25 seconds, then removed the unit referring to the local unit variable I made?

 

[Justify]

Expiration timers work perfectly, there has to be another problem in your triggers, I used this function for ages (and maybe every other mapper on hive)

 

[SanKakU]

I see thanks.

I was wondering because I have something like this:

• A unit is attacked:
• Create a Unit for owner of attacking unit
• Play last created unit's "spin" animation
• Wait 0.25
• Remove Last Created Unit

Now the thing I was concerned about was if "Remove Last Created Unit" would instead remove another unit created in another trigger.

Now for some reason, the last time I did a trigger with:

• Add an expiration timer to last created, expiring in <x seconds>

If I made the duration shorter than 1 second or something, it would glitch for some reason and cause problems(I forgot what they were though). Not sure if it'll happen again which is why I avoided using an expiration timer in this case.

So I assume the way around this problem would be to set the "Last Created Unit" to a "local unit variable", then wait 0.25 seconds, then removed the unit referring to the local unit variable I made?

yeah that could work out ok. just make sure to null the variable afterwards so it doesn't leak.
after you remove it, you would do set variablename = null

 

[Tharky]

How to delete arrays??

tried:
call DestroyGroup(udg_GroupVar[])
... not worked...

 

[Eleandor]

Can't delete arrays. You can only delete specific indices on an array. E.g.
call DestroyGroup(udg_GroupVar[0])
call DestroyGroup(udg_GroupVar[1])

bj_forLoopAIndex = "Integer A"
bj_forLoopBIndex = "Integer B"

 

[Tharky]

Can't delete arrays. You can only delete specific indices on an array. E.g.
call DestroyGroup(udg_GroupVar[0])
call DestroyGroup(udg_GroupVar[1])

bj_forLoopAIndex = "Integer A"
bj_forLoopBIndex = "Integer B"

So I need 12 triggers???

or use loop integer? but I don't know how to use them.

• Set AllUnitsGroup[(Player number of (Owner of (Casting unit)))] = (Units in (Playable map area) matching ((((Triggering unit) is A Hero) Equal to False) and ((Owner of (Matching unit)) Equal to (Owner of (Casting unit)))))
• Custom script: call DestroyGro...

 

[Eleandor]

You can always use variables in scripts...

• Set GroupIndex = Player number of (owner of (casting unit))
• Set AllUnitsGroup[GroupIndex] = ...
• Custom script: call DestroyGroup(udg_AllUnitsGroup[udg_GroupIndex])

 

[Tharky]

You can always use variables in scripts...

• Set GroupIndex = Player number of (owner of (casting unit))
• Set AllUnitsGroup[GroupIndex] = ...
• Custom script: call DestroyGroup(udg_AllUnitsGroup[udg_GroupIndex])

Pretty smart...
Thanks for the advice Eleandor. +rep given.
I think this should be added at the first page of the tutorial.

 

[Silvenon]

Do images have to be nulled?

 

[digitalwingx]

Leak?

Hello I could use some help. Does this leak?

• Judgement
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Judgement
  • Actions
    • Set Judgement_Target = (Target unit of ability being cast)
    • Set Judgement_Caster = (Triggering unit)
    • Set Judgement_Ally = (Owner of Judgement_Caster)
    • Set Judgement_Duration_Base = 3.00
    • Set Judgement_Level = (Level of (Ability being cast) for Judgement_Caster)
    • Set Judgement_Modifier = (6.00 + ((Real(Judgement_Level)) x 2.00))
    • Set Judgement_Duration = (Judgement_Duration_Base x (Real(Judgement_Level)))
    • Set Judgement_Caster_Inteligence = (Intelligence of Judgement_Caster (Include bonuses))
    • Set Judgement_Heal = ((Real(Judgement_Caster_Inteligence)) x Judgement_Modifier)
    • Set Judgement_Damage = (Judgement_Heal / 2.00)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Judgement_Target belongs to an ally of Judgement_Ally) Equal to True
      • Then - Actions
        • Unit - Set life of Judgement_Target to ((Life of Judgement_Target) + Judgement_Heal)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Judgement_Level Equal to 1
          • Then - Actions
            • Unit - Add Item Armor Bonus (+2) to Judgement_Target
            • Wait Judgement_Duration seconds
            • Unit - Remove Item Armor Bonus (+2) from Judgement_Target
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Judgement_Level Equal to 2
              • Then - Actions
                • Unit - Add Item Armor Bonus (+4) to Judgement_Target
                • Wait Judgement_Duration seconds
                • Unit - Add Item Armor Bonus (+4) to Judgement_Target
              • Else - Actions
                • Unit - Add Item Armor Bonus (+6) to Judgement_Target
                • Wait Judgement_Duration seconds
                • Unit - Remove Item Armor Bonus (+6) from Judgement_Target
      • Else - Actions
        • Unit - Cause Judgement_Caster to damage Judgement_Target, dealing Judgement_Damage damage of attack type Spells and damage type Normal
        • Unit - Set mana of Judgement_Target to ((Mana of Judgement_Target) - (Judgement_Damage / 2.00))
    • Set Judgement_Target = No unit
    • Set Judgement_Caster = No unit

 

[Element of Water]

You do not need to set Judgement_Caster or Judgement_Target to null at the end, but no, it does not leak.

BTW: You made a mistake - you add item armour bonus +4 twice, instead of removing it the second time.

 

[digitalwingx]

Thanks Element of Water. It's weird this spell is the only custom spell I have with trigger in a game but it crashes every time, only when there are more than 2 players though.

 

[Element of Water]

The reason it crashes is because it's not MUI. Read an indexing tutorial or something.

 

[StYdeSoLaToR]

I have a question about leaks.
If you set a variable for something like

Set Group = (Units within 500 of (Position Of Picked Unit))

The (Position Of Picked Unit) will leak, but will it leak if i store it within a variable, and then destroy it? I was wondering because the variable is set as a GROUP, not a POINT.

Do i have to set (Position Of Picked Unit) into another variable and then do something like this?

Set Group = (Unit within 500 of (Point))

 

[onix_noob]

I have a question about leaks.
If you set a variable for something like

Set Group = (Units within 500 of (Position Of Picked Unit))

The (Position Of Picked Unit) will leak, but will it leak if i store it within a variable, and then destroy it? I was wondering because the variable is set as a GROUP, not a POINT.

Do i have to set (Position Of Picked Unit) into another variable and then do something like this?

Set Group = (Unit within 500 of (Point))

It should be somthing like
Set TempPoint = position of picked unit
Set TempGroup = (Units within 500 of (TempPoint))

and then just destroy them to clear the leaks

 

[jawawaQ]

Can someone please tell me why the Blue Player is bugged?

I don't understand why this occurred.

 

[I34w90_238j]

I can't open your map. Do you use NewGen or some UMSWE or newest version of WEU?
One of the non-existing functions is "eggs". Tell me what do I need to do to open your map.

 

[Loyal2NES]

Does "Rally-Point as Point" leak? Figured it might not since the Rally Point would be predefined.

 

[Element of Water]

Err... yes, it does leak. Locations ALWAYS leak in GUI.

 

[nullmind]

Thank you very much! These are being imported into the WorldEditor Wiki.

 

[naitsirk]

Does Putting a Region In a Variable leak?
If so please tell me how to fix....

 

[Element of Water]

Putting a region made with the region editor in a variable will not leak in any way. Creating a region with Region From Points or whatever will leak, though. Use call RemoveRect(udg_YourRegion)

 

[naitsirk]

Putting a region made with the region editor in a variable will not leak in any way. Creating a region with Region From Points or whatever will leak, though. Use call RemoveRect(udg_YourRegion)

Ok Thanks then My GUI Trigger doesen't Leak becuse i amde teh Regions in the Region Palate So That is good

 

[y Hac KpyTo]

Very Good

 

[ubran]

I know that triggering an ability to use a lightning effect can cause a leak if you fail like I did and leave a timer so it looks like a really powerful shock /facepalm

If someone casts chain lightning right as my single target lightning bolt stun thing goes off, the trigger may remove the chain lightning over the one triggered by the spell. Any suggestions?

 

[Maker]

Post the triggers.

 

[Beast(TrOg)]

Quick question. Will a converted coordinate-to-point leak?

• Set Real[1] = (Angle from (originalPnt) to (Point(TargX, TargY)))

 

[Element of Water]

Yes. Anything to do with locations, except using location global variables directly, WILL leak.

 

[WanderingPeanut]

Object Creation Leak

At the beginning of the thread paskovich said:

Creating any object will of course leak, but it is not that common for example a dummy unit is not killed/removed.

I have a map where I'm creating a lot of units by triggers, will this leak? And if so how can I fix it? (Sorry if someones already answered this, theres too much thread to read). Thanks for any help.

 

[Mooglefrooglian]

At the beginning of the thread paskovich said:
I have a map where I'm creating a lot of units by triggers, will this leak? And if so how can I fix it? (Sorry if someones already answered this, theres too much thread to read). Thanks for any help.

When a unit dies, it stops (edit) using memory (unless it has special effects attached via trigger). You probably shouldn't worry, unless you use custom spells a lot and use dummy units to cast things and dont remove those dummy units.

 

[azlier]

You can remove most units any time, and they remove themselves naturally. The exception is dummy units, which can be created and pretty much forgotten about. That's a leak.

 

[terranempire]

Uh, hello I am kinda confused about the set bj_wantDestroyGroup = true thing.

Here I have an example:

• Actions
  • Player - Add 10 to Player 9 (Gray) Current gold
  • Unit Group - Pick every unit in (Units owned by Player 9 (Gray) of type Builder) and do (Actions)
    • Loop - Actions
• Unit Group - Pick every unit in (Units owned by Player 9 (Gray)) and do (Actions)
  • Loop - Actions
    • Unit - Order (Picked unit) to Attack-Move To (Random point in (Playable map area))
  • Unit Group - Pick every unit in (Units owned by Player 9 (Gray) of type Workshop) and do (Actions)
    • Loop - Actions
  • Unit Group - Pick every unit in (Units owned by Player 9 (Gray) of type Keep) and do (Actions)
    • Loop - Actions
  • Unit Group - Pick every unit in (Units owned by Player 9 (Gray) of type Shipyard) and do (Actions)
    • Loop - Actions
  • Unit Group - Pick every unit in (Units owned by Player 9 (Gray) of type Barracks) and do (Actions)
    • Loop - Actions
  • Unit Group - Pick every unit in (Units owned by Player 9 (Gray) of type Town Hall) and do (Actions)
    • Loop - Actions
  • Unit Group - Pick every unit in (Units owned by Player 9 (Gray) of type Arcane Sanctum) and do (Actions)
    • Loop - Actions
  • Unit Group - Pick every unit in (Units owned by Player 9 (Gray) of type Castle) and do (Actions)
    • Loop - Actions
  • Unit Group - Pick every unit in (Units owned by Player 9 (Gray) of type Scout Tower) and do (Actions)
    • Loop - Actions

The main thing is, Where should bj_wantDestroyGroup = true be located?
Yes, I know that the location leaks but that is irrelevant in this example.

Since the problem is, what happens if I have multiple pick unit actions and want to use the wantDestroyGroup thing, where should I place it in the trigger?

 

[Element of Water]

Just put one before each group loop. Alternatively, just use one group loop with a condition - it'd be much more efficient.

 

[terranempire]

Just put one before each group loop. Alternatively, just use one group loop with a condition - it'd be much more efficient.

How much more efficient? Noticeably or?
Because, I don't really know how to do that kind of trigger in one long loop, heh.

 

[Element of Water]

Just do a "pick every unit in group matching" action.

And yeah, quite a lot more efficient.

 

[terranempire]

Just do a "pick every unit in group matching" action.

And yeah, quite a lot more efficient.

Uh, I'm not quite following you now.
That is basically just the same thing as the one that is used in that example, or do you mean by using an if/then/else thing as well?

 

[Element of Water]

• Group Loop
  • Events
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area) owned by Player 1 (Red)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Unit-type of (Picked unit)) Equal to Town Hall
                • (Unit-type of (Picked unit)) Equal to Keep
                • (Unit-type of (Picked unit)) Equal to Castle
                • (Unit-type of (Picked unit)) Equal to Barracks
          • Then - Actions
            • -------- stuff --------
          • Else - Actions
    • -------- ---------------------------------------------------------- --------
    • -------- ---------------------------OR---------------------------- --------
    • -------- ---------------------------------------------------------- --------
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units owned by Player 1 (Red) matching (((Unit-type of (Picked unit)) Equal to Town Hall) or (((Unit-type of (Picked unit)) Equal to Keep) or (((Unit-type of (Picked unit)) Equal to Castle) or ((Unit-type of (Picked unit)) Equal to Barracks))))) and do (Actions)
      • Loop - Actions
        • -------- stuff --------

God, that took my ages to make... now I remember why I wanted to learn Jass in the first place...

By the way, the second one is more efficient.

 

[terranempire]

Oh, like that, well the only real problem is that they should all spawn a different unit but that is easily fixed.
And the second one is IMO not as efficient because it is simply a pain.
But the only problem is, it'll just be a loop trigger and won't that mean that the whole row is executed for one structure? Instead of the example I had where it just picks the relevant structures and executes them?

And yeah, I guess JASS would be more efficient except for the one fact that has prevented me from learning it, how can you remember all actions and all that without any sort of list?

Anyways, thanks for the help.

 

[Element of Water]

There's a great list in TESH (no idea what that stands for... something-Syntax Highlighter?), which comes with JNGP (Jass NewGen Pack - I'm sure you've heard of it). It has a search function too.

 

[Maker]

Trigger

• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in (Units owned by Player 1 (Red) matching (((Unit-type of (Picked unit)) Equal to Town Hall) or (((Unit-type of (Picked unit)) Equal to Keep) or (((Unit-type of (Picked unit)) Equal to Castle) or ((Unit-type of (Picked unit)) Equal to Barracks))))) and do (Actions)
  • Loop - Actions
    • -------- stuff --------

All those picked units should be matching units Just saying, incase someone tries it and wonders why it doesn't work.

 

[Element of Water]

That just shows how long it is since I used GUI, doesn't it...

 

[johannesr]

Okay i have a question. I set the locations to variables in a trigger, which then turns on a couple more triggers that run every x seconds, creating and sending units to those locations and i use call RemoveLocation(udg_Loc) for every location every time the units get sent there. Does this work or do i have to set the locations to variables again each time the periodic trigger runs?

 

[Maker]

If you save a location into a variable, you can use it an infinite amount of times without call RemoveLocation().

You only need to use RemoveLocation() if you set some other location to the variable.

 

[johannesr]

But won't it create a location leak every time it spawns a unit there?

 

[Maker]

Can you post the triggers?

 

[johannesr]

• Unit Spawn Init
  • Events
    • Destructible - Gate (Diagonal 1) 3003 <gen> dies
  • Conditions
  • Actions
    • Set Loc[1] = (Center of RunLoc <gen>)
    • Set Loc[2] = (Center of Spawn 1 <gen>)
    • Set Loc[3] = (Center of Spawn 2 <gen>)
    • Set Loc[4] = (Center of Spawn 3 <gen>)
    • Trigger - Turn on Unit1 Spawn <gen>
    • Trigger - Turn on Unit2 Spawn <gen>

• Unit1 Spawn
  • Events
    • Time - Every 18.00 seconds of game time
  • Conditions
  • Actions
    • Unit - Create 1 Unit1 for Player 12 (Brown) at Loc[2] facing (Position of Gate (Diagonal 1) 3003 <gen>)
    • Custom script: call RemoveLocation(udg_Loc[2])
    • Unit - Order (Last created unit) to Attack-Move To (Center of RunLoc <gen>)
    • Unit - Create 1 Unit1 for Player 12 (Brown) at Loc[3] facing (Position of Gate (Diagonal 1) 3003 <gen>)
    • Custom script: call RemoveLocation(udg_Loc[3])
    • Unit - Order (Last created unit) to Attack-Move To (Center of RunLoc <gen>)
    • Unit - Create 1 Unit1 for Player 12 (Brown) at Loc[4] facing (Position of Gate (Diagonal 1) 3003 <gen>)
    • Custom script: call RemoveLocation(udg_Loc[4])
    • Unit - Order (Last created unit) to Attack-Move To (Center of RunLoc <gen>)

So my question is, do i have to set Loc[2], Loc[3] etc again every time Unit1 Spawn runs?

 

[Maker]

No, you don't have to.

Make sure you don't use "center of..." with those attack move to actions.