[Trigger] Does this leak, and if so, how do I fix it?

[Lethien]

• Events
  • Unit - A unit Starts the effect of an ability
• Conditions
  • (Ability being cast) Equal to Greater Heal
  • ((Target unit of ability being cast) is alive) Equal to True
• Actions
  • Set Loc[2] = (Position of (Target unit of ability being cast))
  • Set Group = (Units within 800.00 of Loc[2] matching (((Matching unit) Not equal to (Target unit of ability being cast)) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Equal to (Owner of (Target unit of ability being cast))))))
  • Unit Group - Pick every unit in Group and do (Actions)
    • Loop - Actions
      • Special Effect - Create a special effect at (Position of (Picked unit)) using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl
      • Special Effect - Destroy (Last created special effect)
  • Custom script: call DestroyGroup (udg_Group)
  • Custom script: call RemoveLocation (udg_Loc[2])

I think this leaks: 'Create a special effect at (Position of (Picked unit))' but I don't know how to fix it for a unit group with an unset amount of units in it

 

[tjordell]

Yes this below leaks:

• Special Effect - Create a special effect at (Position of (Picked unit)) using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl

A position leak. Create a location variable inside the Unit Group Loop stored with Position of picked unit and then you destroy it IN the Unit Group Loop. Easy as a cake =)

 

[Lethien]

Yes this below leaks:

• Special Effect - Create a special effect at (Position of (Picked unit)) using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl

A position leak. Create a location variable inside the Unit Group Loop stored with Position of picked unit and then you destroy it IN the Unit Group Loop. Easy as a cake =)

Ofcourse, stupid of mine. thanks
can't give u +rep again, sorry.

 

[Pharaoh_]

• ((Target unit of ability being cast) is alive) Equal to True

The target will always be alive. Dead units can't have a spell directly casted on them, because they cannot be targeted :]

 

[Kanadaj]

Pharaoh you forget about spells with long cast time

 

[tjordell]

kanadaj, If the spell has long casting time, it will be interrupted if the target dies. Don't you think that Blizzard has thought that through?

 

[Kanadaj]

Errm not in every case Calculate with the missile speed (But yeah in his case it's not worthy...)