The_Assbastards GUI Missile System

[Moderator]

08:23, 15th Jun 2010
Hanky:
I found some things that should be improved:
- remove those DoNothing functions
- the way how you are indexing is too inefficient, change that
- your missile launcher loop don't need to be active all the time
- there's no need to loop through the whole array
- you should check the map boundarys for the missiles
- there's no real need to set the missile_registry array everytime to null

That's all I found for now. When you have fixed those points message me or some other spell moderator.

 

[MoodestMoo5]

I wrote this for use in my own maps and decided to put it up for others. I go by the_assbastard on bnet and didnt think to use my username on this site

 

[Coolty44]

Breaks rules for in-game screen shot, change that and it wont get insta-rejected

 

[D4RK_G4ND4LF]

cons:
-uses "do nothing" (it actually does nothing so there is no need to use it....)
-missile is attackable by creeps
-uses custom values
-leaks locations(move unit to point with polar offset...)
-leaks groups
-only works for 98 units
-no height support
-no real angle support
-weird coding
-there already are a lot of better missile systems
-nondescriptive/wrong-written variable names
-no ingame screenshot
-unallowed crappy kind of indexing

pros:
+some leaks were removed
+has (bad) documentation

Good things:2
Bad things: 13

Rating: 2/13 -> 1/5 -> Rejected

 

[Anachron]

uses "do nothing" (it actually does nothing so there is no need to use it....)

Actually, do nothing is doing something in an interval of nothing. I heared it should clean leaks and reset game variables.

 

[Rmx]

Actually, do nothing is doing something in an interval of nothing. I heared it should clean leaks and reset game variables.

Well it will be the BEST damn function in GUI lol

 

[Anachron]

No, it does only do a few cleaning stuff, but actually its not nothing.

 

[Rmx]

No, it does only do a few cleaning stuff, but actually its not nothing.

Do you have proof ? plz tell me what 100% it does ?

 

[YourNameHere]

Actually, do nothing is doing something in an interval of nothing. I heared it should clean leaks and reset game variables.

That's only when you use this System.

 

[redscores]

Well, take a look at mine system... and get a idea how you should do it.

 

[PurplePoot]

Actually, do nothing is doing something in an interval of nothing. I heared it should clean leaks and reset game variables.

Then you heard wrong.

function DoNothing takes nothing returns nothing
endfunction

 

[Anachron]

Then you heard wrong.

function DoNothing takes nothing returns nothing
endfunction

I was just confused about this and the DoNothing. Sorry.

 

[MoodestMoo5]

cons:
-uses "do nothing" (it actually does nothing so there is no need to use it....)

then theres also no need to not use it right? whatever i got rid of it

-missile is attackable by creeps

Easily fixed by simply making it invulnerable........

-uses custom values

Actually it doesnt, i gave each missile a custom value because i thought i was going to need it but i didnt, its removed.

-leaks locations(move unit to point with polar offset...)
-leaks groups

It destroys locations/groups after each use... if it is still leaking i have no idea how and its not lagging up my shitty laptop

-only works for 98 units

yes a minor setback, I never needed to use 100+ missiles at once tho and its easy to work around. the number could be increased by simply changing the Missile Creator trigger to start over the missile number from a larger number, i just felt comfortable with 100.

-no height support

I could see how this might limit some intense map makers usage but wc3 itself has barely any height support other then cosmetics

-no real angle support

please explain.. my angles were working fine for me

-weird coding

how is this a con exactly? too sketch?

-there already are a lot of better missile systems

yes but i thought this was a fairly simple one for someone trying to incorporate more basic missiles into their maps, i mean how much more complicated do you need it? I had a lot of fun using this in my maps and no problems.

-nondescriptive/wrong-written variable names

maybe im just lazy but I thought it was explained

-no ingame screenshot

Sorry, but I have no access to taking screenshots, i dont have much of a choice

-unallowed crappy kind of indexing

Please explain this im just too noobish to understand what this means



man you fellers are a hard lot to please

 

[MoodestMoo5]

Finally got access to making a screen shot, flame away