JeffQ's GUI/MUI Basic Missile System v1.01a

[Moderator]

19:01, 17th Jun 2010
Hanky:
As far I can see it seems to be MUI and leakless. So I see no reason why I shouldn't approve it.

 

[baassee]

fucking huge code I have to say ... well let's see what you've learned

EDIT:

oh cmon man, you dont need those ID thingies, just make a variable that stores your attack type and damage type in the start!

why doesnt this support an angle? just make an angle variable that you can attach

else I think it's good but those stuff above is very important to fix, making the system better and more efficient

 

[D4RK_G4ND4LF]

why the fuck is everyone using hashtables??
they are
-more complicated
-slower
-and you can't save attack types

if you are doing something that requires dynamic 2d arrays like triggering a really complicated spell like a pudge wars hook or something hashtables are the easier solution but for that...

 

[baassee]

oh you cant store attack types? switch over to indexing ...

 

[Kingz]

Here is a thought:

• preset the damage types
• when setting a damage type just compare it to a preset

Example in jass:

set DAMAGE_TYPE[0] = DAMAGE_TYPE_ACID
set DAMAGE_TYPE[1] = DAMAGE_TYPE_UNKNOWN
...
set DAMAGE_TYPE[x] = DAMAGE_TYPE_UNIVERSAL

Then when checking if for example damage type integer equal to n:

set DamageType = DAMAGE_TYPE[n]

That is far more efficent that the crappy if/then/else you are using.

Same aplies for the crappy attack type if/then/else branch.

EDIT:

Lol when you said terrain colisions i thought you actualy do something other than destroying the missile upon hiting a terrain(bounce anyone?).

Anyway better systems are present on the hive and the current state of the system is extremely unnefficent due to the if/then/else branches and the use of hashtables.

 

[baassee]

never thought of that idea ... lols say what if you want a missile to bounce on a tree or going below a bridge

 

[real138]

wow ive never seen so many if then else statements used in my life @_@ there is no way you should need that many. if your gonna do that then at least use a loop to loop through it all. but get rid of that. 2/5.
to many of these on hive -.5
to many if then else statements -1.
no extra features to make it stand out -1
code could be much shorter. -.5

 

[JeffreyQ]

Thanks for all the useful feedbacks.

@Kingz
That's a good idea. I almost gave up on the attack type and wrote a system for it to convert instead of so many if, else. I will change it to your idea right away and upload the next version.

What is coming next:
- Supports Angle
- Supports on Hit (Missile will be destroy on 1st encounter of nearest unit)
- Supports Bounce [:

**Although once i add bounce, the system won't be as flexible as now. For example now i can set everything to true, or everything to false or mix anything i like and works perfectly. But if i add bounce, collision can't be true anymore. I will see what i can work on it [:

Once again, thanks for the useful feedback. Gotta love those.

EDIT: Updated to version 1.01a to fix the attack and damage type to make it alilbit more efficient.

 

[Adiktuz]

Thanks for all the useful feedbacks.

@Kingz
That's a good idea. I almost gave up on the attack type and wrote a system for it to convert instead of so many if, else. I will change it to your idea right away and upload the next version.

What is coming next:
- Supports Angle
- Supports on Hit (Missile will be destroy on 1st encounter of nearest unit)
- Supports Bounce [:

**Although once i add bounce, the system won't be as flexible as now. For example now i can set everything to true, or everything to false or mix anything i like and works perfectly. But if i add bounce, collision can't be true anymore. I will see what i can work on it [:

Once again, thanks for the useful feedback. Gotta love those.

EDIT: Updated to version 1.01a to fix the attack and damage type to make it alilbit more efficient.

can't you just put the variable set-up into the map init trigger?...

 

[JeffreyQ]

I can, which i am going to do on the next version [:

 

[Rmx]

Hash table makes everything bigger and more complicated.

I didn't bother to check the trigger, but i really think you should not use hashtable in these kind of situtations or triggering.

 

[JeffreyQ]

I am trying to learn indexing which is confusing ><. And i will be able to overhaul the whole system. But for now, i just want to get the basic idea of how a system can be made.

I found 1 leak in the implementation while i was updating and polishing my code.
If the spell is target point.
User need to set QJ_TargetPoint = Target Point of Ability Being Cast

I can't call RemoveLocation. How do i clear this leak?

 

[baassee]

why cant you call removelocation?

call RemoveLocation(udg_QJ_TargetPoint)

else if it isnt used just make a very short boolean

 

[JeffreyQ]

Because i need to save it during the run of Missile Create. If i destroy it in the implementation example then i won't be able to save it ><

 

[Adiktuz]

Because i need to save it during the run of Missile Create. If i destroy it in the implementation example then i won't be able to save it ><

save it into the hashtable then destroy it after its used...

 

[JeffreyQ]

So its something like this?

In Implementation:

• Set TargetPoint = target point of ability being cast

Then in Creation:

• Hashtable - save TargetPoint of blabla value....
• call RemoveLocation(udg_TargetPoint)

Am i correct?

 

[Kingz]

Omg...

• you have a point
• you get the point's X/Y
• you save the X/Y as reals in hashtable
• remove the location
• when needed load the X/Y from hashtable
• set the location to be Point(X,Y)
• after usage clear the location, if needed save the coordinates first again

Again, really simple solution...

 

[M_Vegeta]

i must say agree making complicated spell in hashtable is only a waste of space ... i rather use Dynamic hashtable & there is a good template made by Hanke that's how i learned mui

i found the spell useful i will learn from

 

[JeffreyQ]

Can u point me to Hanke's template? I can't find it anywhere here.

Also, can someone that know the answer below? Please let me know if i am correct or not.

So its something like this?

In Implementation:

• Set TargetPoint = target point of ability being cast

Then in Creation:

• Hashtable - save TargetPoint of blabla value....
• call RemoveLocation(udg_TargetPoint)

Am i correct?

 

[Kingz]

I dunno about that, like i said just use coordinates.

• you have a point
• you get the point's X/Y
• you save the X/Y as reals in hashtable
• remove the location
• when needed load the X/Y from hashtable
• set the location to be Point(X,Y)
• after usage clear the location, if needed save the coordinates first again

Hanky's template can be found here.

Alternatively you may want to go here since it is a clarification what Hanky/Me is actualy doing and how is a index recycled.

 

[supertoinkz]

What does QJ_Pierece do?

 

[RaidonGod]

can't open the map ... WE 1.24 or WE from JNGP say same error:
"Function does not exist in database: InitHashtableBJ"
"Function does not exist in database: GetLastCreatedHashtableBJ"
"Function does not exist in database: SaveUnitHandleBJ"
I don't no why, other systems and maps with the same function could be opened, but this don't want to be opened.

 

[supertoinkz]

It works for me

 

[Adiktuz]

can't open the map ... WE 1.24 or WE from JNGP say same error:
"Function does not exist in database: InitHashtableBJ"
"Function does not exist in database: GetLastCreatedHashtableBJ"
"Function does not exist in database: SaveUnitHandleBJ"
I don't no why, other systems and maps with the same function could be opened, but this don't want to be opened.

WE should be at least v1.24b and for JNGP, please download the lastest jass helper to be able to use hashtables...

 

[RaidonGod]

WE should be at least v1.24b and for JNGP, please download the lastest jass helper to be able to use hashtables...

all is up-to-date ... also the new blizzard.j and common.j is used by the jasshelper, tesh got also the new funclist.database ...
I don't know why the heck this map won't open. oO