Tech these days are evolving so fast that if you buy a computer now, it will be on sale in a year.
method isValidTargetUnit takes unit u returns boolean
return u == .target
endmethodlibrary RangedAttack requires Projectile
struct rangedattack extends projectile
private real damage
method isValidTargetUnit takes unit u returns boolean
return u == target
endmethod
method onUnitCollision takes unit u returns nothing
if not destroyed then
call UnitDamageTarget(source, u, damage, false, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_NORMAL, null)
call destroy()
endif
endmethod
static method create takes unit source, unit target, real damage, vector startVector, vector endVector, /*
*/ real speed, real arc, string modelpath returns thistype
local real a = Atan2(endVector.y-startVector.y, endVector.x-startVector.x)
local thistype d = .allocate(CreateUnit(GetOwningPlayer(source), 'dumy', startVector.x, startVector.y, a*bj_RADTODEG))
// Ranged data setup:
set d.damage = damage
call d.setModel(modelpath)
// Projectile setup:
set d.source = source
set d.collision = 32
set d.activeUnitCollision = true
set d.toRemove = true
set d.toDestroy = true
set d.activePitch = true
set d.activeRotation = true
set d.activeTargetFollow = true
set d.targetZOffset = 60
set d.target = target
call d.launch(startVector, endVector, speed, arc)
return d
endmethod
endstruct
endlibrary private function filter takes nothing returns boolean
return GetSpellAbilityId() == 'A002'
endfunction
private function onOrder takes nothing returns nothing
local unit caster = GetTriggerUnit()
local unit target = GetSpellTargetUnit()
local real x = GetUnitX(target)
local real y = GetUnitY(target)
local vector a
local vector b
call MoveLocation(loc, GetUnitX(caster), GetUnitY(caster))
set a = vector.create(GetUnitX(caster), GetUnitY(caster), GetLocationZ(loc) + GetUnitFlyHeight(caster) + 60) // 60 represents the height offset from caster.
call MoveLocation(loc, x, y)
set b = vector.create(x, y, GetLocationZ(loc) + GetUnitFlyHeight(target) + 45) // there is no height offset
call rangedattack.create(caster, target, 100, a, b, 1500, 0.2, "Abilities\\Weapons\\FireBallMissile\\FireBallMissile.mdl")
call a.destroy()
call b.destroy()
set target = null
set caster = null
endfunction
method onUnitCollision takes unit u returns nothing
if not (destroyed) then
call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 2, "Unit collision!")
call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 2, " "+GetUnitName(u))
call UnitDamageTarget(source, u, damage, true, true, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_NORMAL, null)
call destroy()
endif
endmethodtoDestroy is off, so that the projectile will not destroy itself when it reaches the end of its trajectory. What happens is the projectile will stall in the air briefly before touching the unit. What's strange is that there is only one way the projectile should stop suddenly, and that is upon being destroyed (which never happens).onFinish method is executing before unit-collision has been detected. This would be due to the really fast projectiles resulting in a low time expectancy. Let's see...onFinish method is being executed before the collision is detected.target member. If you've got a projectile with a target then unit-collision should only be determining collision with non-target units. The target member was made primarily to be used in the onFinish method as a way of referencing a predetermined target. If the target is predetermined, then there is no reason to enumerate units looking for it.local integer i=0
local real n=7.0
local real x=1.0/n
loop
exitwhen not (i<10)
set x = x * (n + 1.0) - 1.0
set i=i+1
endloop
call BJDebugMsg(R2S(x))onUnitCollision to the onFinish method. This method uses an expected time to calculate when it should be executed based on the projectile's velocity and such. The time expectancy is re-adjusted when the target unit moves (if target-following is enabled).onFinish method will still catch them when they should have hit the target.target as a desired "target" then this would be your best bet.isValidUnitTarget and onUnitCollision simply use onFinish.struct rangedattack extends projectile
private real damage
private real collisionHeight
method onFinish takes nothing returns nothing
call UnitDamageTarget(source, target, damage, true, true, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_NORMAL, null)
call destroy( )
endmethod
static method create takes unit source, unit target, real damage, vector startVector, vector endVector, /*
*/ real speed, real arc, string modelpath returns thistype
local real a = Atan2(endVector.y-startVector.y, endVector.x-startVector.x)
local thistype d = .allocate(CreateUnit(GetOwningPlayer(source), 'dumy', startVector.x, startVector.y, a*bj_RADTODEG))
// Ranged data setup:
set d.damage = damage
call d.setModel(modelpath)
// Projectile setup:
set d.source = source
set d.collision = 32
set d.collisionHeight = 128
set d.activeUnitCollision = true
set d.toRemove = true
set d.toDestroy = false
set d.activePitch = true
set d.activeRotation = true
set d.activeTargetFollow = true
set d.targetZOffset = 60
set d.target = target
call d.launch(startVector, endVector, speed, arc)
return d
endmethod
endstructonFinish the way I did. And actually you don't even need unit collision for projectiles that only hit their targets. You could set that field to false as well.
projectileVariable.enableDestCollision = true. Make sure that your projectiles are simply not missing the destructibles either try using a relatively high collision size.
enableDestCollision = true then it won't fire destructable collision events. If the collision size is too small the destructables may not be detected nearby. If... I could go on. Code is not as ambiguous as a description of an error.
library Test
private function Add takes nothing returns boolean
local vector v1 = vector.create(-2000,-2000,64)
local vector v2 = vector.create(2000,2000,64)
local integer i = S2I(GetEventPlayerChatString())
local integer j = 0
local projectile temp
loop
exitwhen j == i
call projectile.create(CreateUnit(Player(0), 'dumy', 0, 0, 0)).launch(v1, v2, 85, 0)
set j = j + 1
endloop
return false
endfunction
private struct Inits
private static method onInit takes nothing returns nothing
local trigger t = CreateTrigger()
call TriggerRegisterPlayerChatEvent(t, Player(0), "", false)
call TriggerAddCondition(t, Condition(function Add))
set t = null
endmethod
endstruct
endlibrarystruct rangedattack extends projectile
static trigger rangedtrigger = CreateTrigger()
private real damage
private real collisionHeight
static location tempLoc = Location(0,0)
private integer element
method isValidTargetUnit takes unit u returns boolean
local boolean inRange = false
call MoveLocation(tempLoc, GetUnitX(u), GetUnitY(u))
if (absoluteReal(GetLocationZ(thistype.tempLoc)+GetUnitFlyHeight(u) - z) < .collisionHeight) then
set inRange = true
endif
return (u != source) and GetWidgetLife(u) >= .405 and inRange
endmethod
method onUnitCollision takes unit u returns nothing
if not (destroyed) then
call Damage.Unit(.source, u, .damage, .element)
call destroy()
endif
endmethod
method isValidTargetDest takes destructable d returns boolean
call DisplayTextToPlayer(Player(0), 0.0, 0.0, "Hit") //for debugging
return true
endmethod
method onDestCollision takes destructable d returns nothing
if (not (destroyed)) then
if not IsDestructableInvulnerable(d) then
call SetDestructableLife(d, GetDestructableLife(d) - .damage)
endif
call destroy()
endif
endmethod
static method create takes unit source, unit target, real damage, vector startVector, vector endVector, /*
*/ real speed, real arc, string modelpath, integer element returns thistype
local real a = Atan2(endVector.y-startVector.y, endVector.x-startVector.x)
local thistype d = .allocate(CreateUnit(GetOwningPlayer(source), 'dumy', startVector.x, startVector.y, a*bj_RADTODEG))
// Ranged data setup:
set d.damage = damage
call d.setModel(modelpath)
// Projectile setup:
set d.source = source
set d.collision = 32
set d.collisionHeight = 128
set d.element = element
set d.activeUnitCollision = true
set d.activeDestCollision = true
set d.toRemove = false
set d.toKill = true
set d.toDestroy = true
set d.activePitch = true
set d.activeRotation = true
set d.activeTargetFollow = false
set d.targetZOffset = 60
set d.target = target
call d.launch(startVector, endVector, speed, arc)
return d
endmethod
endstructif (dat.activeDestCollision) and dat != 0 then // Destructable Collision
set projRef = dat
call SetRect(rct, 0, 0, dat.PROP__collision, dat.PROP__collision)
call MoveRectTo(rct, x, y)
call EnumDestructablesInRect(rct, FUNC__enumDests, null)
endifif (dat.activeDestCollision) and dat != 0 then // Destructable Collision
set projRef = dat
call EnumDestructablesInRect(bj_mapInitialPlayableArea, FUNC__enumDests, null)
endifcollision, because that is the radius in which to check. Try doing this instead and see if that helps:call SetRect(rct, 0, 0, 2*dat.PROP__collision, 2*dat.PROP__collision)2*collision.
4*collision because in the end it will still filter out destructables that are not within the collision radius. The difference is how many destructables the function has to go through to determine the same thing. I think I'll look into it and see what the best option is. I've got some other material added too that I wanted to release so perhaps I will make it in the update.call SetRect(rct, x-2*dat.PROP__collision, y-2*dat.PROP__collision, x+2*dat.PROP__collision, y+2*dat.PROP__collision)
you need the more recent vector system: Vector - Wc3C.net
IIRC Berb (then Berbanog) originally had a 3D hit box but he deleted it as per request due to desync risks.
Because he would take 3d height into consideration (an asynchronous thing) of whether to launch the onImpact event, which would both destroy the projectile as well as cause damage to the target.
I see. I actually just found out that GetLocationZ may cause desync issues due to terrain deformations and fog of war. Just a quick question, does that apply to the new native blzgetunitz function? What if I save the boolean for every local player and and compare them such that a single false would cause the necessary action for all players? Though it might cost a bit slower performance. Also, thanks for the info.
You don't want to wait for synchronization before calling an onImpact function. The sync will take far longer than the missile will require.
Hmm it seems that the only way to avoid desyncs is to avoid terrain deformations and anything related huh. Thanks a lot, this has been very helpful.
