Soul Eaters 1.2

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

12:09, 5th Jan 2015
IcemanBo:
Make the changes noted in this post: http://www.hiveworkshop.com/forums/spells-569/soul-eaters-1-2-a-256660/index2.html#post2604041

 

[mogulkhan1Axe]

Very useful for some big fights nice dude 5/5 keep it coming

 

[GunSlinger]

Thanks bro.

 

[mogulkhan1Axe]

Thanks bro.

Maybe also increase the pass damage a bit it hardly notices

 

[mogulkhan1Axe]

u leak here i belive

• Unit - Create 1 SE_Unit_Type for (Owner of (Triggering unit)) at SE_Caster_Loc facing Default building facing degrees

Owner of triggering unit i think u need to save it into a variable

 

[GywGod133]

In your Trigger Start

Dont use INTEGER A / B
use Integer var instead

Save the Triggering Unit in a variable "TempUnit"
and use it

In owner of caster
Unit - Create 1 SE_Unit_Type for (Owner of (Triggering unit)) at SE_Caster_Loc facing Default building facing degrees
Change it into this
Unit - Create 1 SE_Unit_Type for Triggering Player at SE_Caster_Loc facing Default building facing degrees

====================

In your Trigger Loop

In your Unit Groups
you must save the Picked Unit in a variable

Inside in your Unit Groups
You have Special Effect Leak
Special Effect - Create a special effect attached to the overhead of (Picked unit) using SE_Pass_Effect\

====================

In your SUMMON DIES Trigger

Save the Triggering Unit in a variable "TempUnit"
and use it

You have Unit Group Leak

Inside in your Unit Group
You must save the Picked Unit in a variable then use it

 

[GunSlinger]

@AKA Thanks for that. I'll work on it right away!

EDIT: Do I have to set every picked unit to a variable or just the filtered out ones?

EDIT: Never mind.

 

[Vinz]

Owner of TriggerUnit -> Triggering Player

Store something you use more than twice into a variable.

 

[Zed]

Looks similar to Death Prophet's exorcism spell in Dota
4/5

 

[deathismyfriend]

Store something you use more than twice into a variable.

Should be anything used more than once should be put in a variable. Especially in GUI.

 

[GunSlinger]

Sounds like I need more variables.
I'll start working on it soon.

 

[GywGod133]

Looks similar to Death Prophet's exorcism spell in Dota
4/5

You can do it on Blizzard Spells

 

[GunSlinger]

Should I just remove the whole "not getting damaged again for 0.3 seconds after the last pass" thing? It seems really taxing for the spell.

 

[Kazeon]

OH MY GOSH!!

Dat banshee has a male voice LOL

You made my day bro! Seriously, I was very surprised

On topic: cool spell!

• Unit - Add a SE_Duration[(Level of SE_Ability for SE_Temp_Unit_1)] second Generic expiration timer to (Last created unit)

Don't use it, you should use a timer (in real) which is the lifespan of the spirits. Then substract it by 0.03 (since periodic timer is per 0.03 second) per tick. So you can merge Summon Dies trigger into Move Loop trigger.

Anyway, your trigger should have unique prefix name such as SE_Cast or SEat_Cast.

 

[GunSlinger]

^Ahaha, thanks for that.

I'll make those changes and upload a new version today.

 

[Karassu]

A 'lil bit reminds me of Deidara from Naruto, "Art is a bang!"... Nice, I want this spell to be approved.

 

[GunSlinger]

I've been waiting for 2 weeks now and still no review from a mod.

 

[Karassu]

Yeah, they're busy I guess... Even my map, still pending. Let's just wait 'til the time comes.

 

[Vinz]

Spell mods disappeared.

 

[Kazeon]

• For each (Integer SE_Index_3) from 1 to SE_Summon_Number[(Level of SE_Ability for SE_Temp_Unit_1)], do (Actions)

Store (Level of SE_Ability for SE_Temp_Unit_1) into an array variable.

• Unit Group - Pick every unit in (Units within SE_Pass_AOE[(Level of SE_Ability for SE_Unit[SE_Index])] of (Center of (Playable map area))) and do (Actions)

You leaked one location there

Other than that, it seems acceptable for me.

OFF:
Some of my resources have been burried for more than 5 months lol

 

[GunSlinger]

Huh. I didn't see that leak. With summons set to a 100, I spammed the spell a bunch of times and my game didn't lag so I thought I was good. I'll get right on it.

 

[Kazeon]

This is terrible, you should have made this at least in Jass or even better vJass, time to move on dude.

Dunno why but I have a feeling that this is not going to be reviewed or even approved so soon, not in offensive manner of course.

 

[GunSlinger]

Oh what. They skipped my spell and went to other GUI spells.

 

[Vinz]

I think they're starting with easy ones. But this is easy in my opinion.

 

[IcemanBo]

It was boring in chat room, so edo494 and me decided to review this resource, as you obviously demanded for feedback.

Soul Eaters 1.2 - Review by IcemanBo & edo494​ Concept: The idea is to create random moving 'Soul Eaters', which deal damage to enemies by touching. It reminds of LocustSwarm by CryptLord. The explosive disappearance at the end of the spell deals extra damage to nearby enemies, and is a good addition. You could immediatly end the spell and kill Soul Eaters, if the caster/bearer is dead. At least it could be an optional feature. At the moment the spell itself doesn't have any cooldown and doesn't cost mana. The unit can spam casting, which results in an overpowered ability. I know the user can change it himself in object editor, but your default example should have adequate settings and values. Furthermore if I read "Soul Eaters" I expect it to work with died units in any kind of way, but well that's really minor and subjective. Code: • -------- Attack type used for the pass damage -------- Set SE_Pass_Attck_Type = Spells -------- ---------------------------- -------- -------- Damage type used for the blast damage -------- Set SE_Blast_Dmg_Type = Normal [/stable] -> -------- Attack type used for the pass damage -------- Set SE_Pass_Attck_Type = Spells -------- ---------------------------- -------- -------- Damage type used for the pass damage -------- Set SE_Pass_Dmg_Type = Normal [/stable] ^Pay attention on the damage type. • In cast trigger immediatly store "LastCreatedUnit" into the variable, and use it in further actions to win performance. • Why do you add the base ability to each dummy? There is no sense in doing it. • Unit Group - Pick every unit in (Units within SE_Pass_AOE[(Level of SE_Ability for SE_Unit[SE_Index])] of (Center of (Playable map area))) and do (Actions)[/stable] ^(Center of (Playable map area)) -> SE_Summon_Move. • If you use If/Then/Else avoid having exactly same actions in "Then - Actions" AND "Else - Actions". Or move these actions before or after the If-statement. • Instead of using "Owner of SE_Unit[SE_Index]", store TriggeringPlayer into a variable in cast trigger. SE_Owner[SE_Index]. • You store all affected enemies into a unit variable. You have to null these unit variables, when you don't need them anymore, else you leak. • Instead of "SE_Move_Left" integer variable, and changing it between 0 and 1, you can use a boolean variable "SE_Turn" and set it to true/false. • The offset for Soul Eater's movement is constant 20. It should be configurable, and it would be user friendly if he could give it a offset/second value, and then you would re-calculate the value for your system, depending of the periodic timeout. ( Your 20 offset in periodic event would be 667 speed for the user, for example.) • The "Roll" variable is not needed. Directly compare the correct expression in your condition. • The attack damage timeout for the Soul Eaters is 0.35, which is hardcoded. It could be stored into a variable in the initialization trigger. • Attachment points should be configurable. • Set SE_Add[SE_Max_Index] = (Random real number between 3.00 and 6.00) Set SE_Chance[SE_Max_Index] = 200[/stable] ^Example of which I can't imagine the sense of the varibales, because of the non-informative names. (Or you can add a short comment) Btw for your naming..., using multiple underscopes in the variable name can make it more unreadable and just lengthen the code. I think "prefix_variableName" is a good convention for GUI code. "SE_Index_3" variable has actually not much to do with an index. It's used within a loop, as normal tmpInteger. • Short and informative comments in main loop would be helpful in terms of a guide. Visuals: The banshee as model looks good. It's movement behaviour is fitting and looking smooth. The tooltip does provide all important information. The icon is also matching. The spell is based on battle roar. Once the unit casts the spell, it gets the battle roar buff, and corresponding attachment effect over it's head. Fix this. Conclusion: All in all the spell looks good and might be useful. However, there are some minor mistakes that should be fixed, and some others that could be improved. It is a good try for your first submission, go on like this. Rating: 3/5

 

[edo494]

As mentioned in the review, I rate 3/5, Decent spell

 

[GunSlinger]

Thanks for the review you guys!
I'll be updating this spell with your notes in mind.