[JASS] Simplify multiple "or" conditions

[HungryHusky]

Is there anyway to simplify this JASS line

    return GetUnitTypeId(GetTriggerUnit()) == udg_ZoneEnemies[1] or GetUnitTypeId(GetTriggerUnit()) == udg_ZoneEnemies[2] or GetUnitTypeId(GetTriggerUnit()) == udg_ZoneEnemies[3] or GetUnitTypeId(GetTriggerUnit()) == udg_ZoneEnemies[4] or GetUnitTypeId(GetTriggerUnit()) == udg_ZoneEnemies[5]

To something like this:

    return GetUnitTypeId(GetTriggerUnit()) == udg_ZoneEnemies[1, 5]

 

[Wrda]

Uhh, no.

 

[IcemanBo]

If you save the boolean value true to hashtable for example you can just return a loaded value.

local integer i = 0
loop
    exitwhen i > 5
    call SaveBoolean(hash, udg_ZoneEnemies[i], 0, true)
    set i = i + 1
endloop

return LoadBoolean(GetUnitTypeId(GetTriggerUnit()), 0)

 

[Dr Super Good]

Is there anyway to simplify this JASS line

IcemanBo's approach is probably the highest performance, most scalable and easiest to maintain way. Although hastables are complex calls they are still a lot faster than multiple comparisons as they involve less name resolution (their performance is worse but still comparable to that of an array lookup). The nature of hashtables means that if you are comparing 5 or 5,000 unit types it should still take around the same time to execute.

That said his return statement throws a syntax error as he forgot the hashtable parameter of LoadBoolean.

At some stage returning non-existant values from hashtables was prone to produce a fatal error in WC3. As such I would recommend using "HaveSavedBoolean" to check if it is the appropriate unit type since you only declare values from unit types you want to return true.

return HaveSavedBoolean(hash, GetUnitTypeId(GetTriggerUnit()), 0)

Since only the types which should return true are stored in the hashtable, it will only return true for them. Unlike LoadBoolean which could try to fetch a non-existant boolean, HaveSavedBoolean explicitly defines the return value for such a case and does not attempt any access. You would still want to use LoadBoolean in the case that you explicitly store false or true values at certain indices but only as long as you store something there in the first place.

 

[HungryHusky]

Well, in that case I'll just let it be as it is. Solved.

 

[Fingolfin]

It would be slightly faster to do this:

local integer id = GetUnitTypeId(GetTriggerUnit())
return id == udg_ZoneEnemies[1] or id == udg_ZoneEnemies[2] or id == udg_ZoneEnemies[3] or id == udg_ZoneEnemies[4] or id == udg_ZoneEnemies[5]

 

[BPower]

If you are familiar with vJass, I recommend to use Table inoerder to optimize hashtable usage.