Savior's Aura v1.1

[Moderator]

19:33, 9th Jan 2015
IcemanBo:
Simple concept. Code works fine. Approved.
http://www.hiveworkshop.com/forums/spells-569/saviors-aura-v1-1-a-256071/index2.html#post2638132

 

[Vinz]

This entry is rather simple, but awesome. :3

 

[Blightsower]

thanks you cakemaster

 

[Tal'Rarity]

You already got my vote. =)

 

[Blightsower]

Thank you Dat-C3

 

[mogulkhan1Axe]

Very Nice dude 5/5 very cool spell keep it coming!!

 

[Blightsower]

Thank you mogulkhan1Axe

 

[Tal'Rarity]

I figured while I am at it fixing your other spell, I hope you don't mind if I help you here as well.

Was it your intention so whenever a unit is about to hit a unit under this aura that it triggers? I think its better if they were damaged first then start it because someone can spam stop and force your triggers to run even though no damage was taken at all. A nasty bug with unit is attacked since it catches the unit "as" it is attacking and not when it actually attacked.

Damage Detection systems fix this bug

 

[Blightsower]

if u do that its actually ur disadvantage since the spell is only triggered when attacked by enemy unit. but yeah a DDS will surely fix it.

 

[Tal'Rarity]

if u do that its actually ur disadvantage since the spell is only triggered when attacked by enemy unit. but yeah a DDS will surely fix it.

Accidents happen and sometimes the unit might attack twice just for targeting purposes or stuns.

Like I said about that example, here it is.

[trigger=]
Events
Conditions
Actions
Set SA_UG_UnitGroup = (Units within SA_R_AoE[SA_I_Level] of SA_P_AtkPos)
-------- heals the picked units --------
Unit Group - Pick every unit in SA_UG_UnitGroup and do (Actions)
Loop - Actions
Set SA_U_Picked = (Picked unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(SA_U_Picked is dead) Equal to False
(SA_U_Picked belongs to an ally of SA_PL_Player) Equal to True
(SA_U_Picked is A structure) Equal to False
(SA_U_Picked is Magic Immune) Equal to False
(SA_U_Picked has buff SA_BF_Buff) Equal to True
(Level of SA_A_PassiveAbility for SA_U_Picked) Less than 1
Then - Actions
-------- - --------
-------- sets the picked unit into a variable --------
-------- its ok to recycle this variable isn't it? --------
-------- - --------
-------- - --------
-------- Heals the picked unit --------
-------- - --------
Unit - Set life of SA_U_Picked to ((Life of SA_U_Picked) + SA_R_HealAmt)
-------- - --------
-------- Add some visuals --------
-------- - --------
Special Effect - Create a special effect attached to the SA_S_Attach of SA_U_Picked using SA_S_SFX
-------- - --------
-------- destroy visuals to prevent leaks --------
-------- - --------
Special Effect - Destroy (Last created special effect)
Else - Actions
Set SA_U_Picked = No unit
[/trigger]

I have also uploaded the fixed version of your aura if you'd or anyone else would like it.

 

[Blightsower]

oh... i see that's thats how to create a flexible unit group. thanks for showing me this. i haven't read the DDS and i feel very sleepy. ill upload ur version of the spell. thanks alot

 

[Tal'Rarity]

As always SallyAnna... Glad to be of help. =)

 

[Blightsower]

Thanks alot, this should be approvable? no?

 

[Vinz]

Don't forget DestroyGroup in case.

 

[Blightsower]

this one? ->

• Custom script: call DestroyGroup(udg_SA_UG_UnitGroup)

 

[Tal'Rarity]

Code to copy

[trigger=]
SaviorAuraEffect
Events
Game - damageEventTrigger becomes Equal to 1.00
Conditions
(Level of SA_A_ActiveAbility for target) Greater than 0
(source belongs to an enemy of (Owner of target)) Equal to True
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
damageType Equal to PHYSICAL
Then - Actions
-------- Actions for PHYSICAL damage --------
-------- - --------
-------- Set the attacked unit --------
-------- - --------
Set SA_U_AtkUnit = target
-------- - --------
-------- Determine the owner of the unit --------
-------- - --------
Set SA_PL_Player = (Owner of SA_U_AtkUnit)
-------- - --------
-------- set the level of the ability into a variable --------
-------- - --------
Set SA_I_Level = (Level of SA_A_ActiveAbility for SA_U_AtkUnit)
-------- - --------
-------- Checks on what value should be applied on the aura's healing effect --------
-------- - --------
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
SA_B_UseStat Equal to True
Then - Actions
-------- - --------
-------- if this is applied then the heal value is equal to a certain percentage of the attacked unit's strength --------
-------- - --------
Set SA_R_HealAmt = ((Real((Strength of SA_U_AtkUnit (Include bonuses)))) x (SA_R_Heal[SA_I_Level] x 0.01))
Else - Actions
-------- - --------
-------- if this is applied, then the heal amount is equal to the predefined value in the trigger configuration --------
-------- - --------
Set SA_R_HealAmt = SA_R_Heal[SA_I_Level]
-------- - --------
-------- sets the position of the attacked units into a variable --------
-------- - --------
Set SA_P_AtkPos = (Position of SA_U_AtkUnit)
-------- - --------
-------- selects the valid units that can be healed --------
-------- - --------
Set SA_UG_UnitGroup = (Units within SA_R_AoE[SA_I_Level] of SA_P_AtkPos)
-------- - --------
-------- heals the picked units --------
-------- - --------
Unit Group - Pick every unit in SA_UG_UnitGroup and do (Actions)
Loop - Actions
Set SA_U_Picked = (Picked unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(SA_U_Picked is dead) Equal to False
(SA_U_Picked belongs to an ally of SA_PL_Player) Equal to True
(SA_U_Picked is A structure) Equal to False
(SA_U_Picked is Magic Immune) Equal to False
(SA_U_Picked has buff SA_BF_Buff) Equal to True
(Level of SA_A_PassiveAbility for SA_U_Picked) Less than 1
Then - Actions
-------- - --------
-------- sets the picked unit into a variable --------
-------- its ok to recycle this variable isn't it? --------
-------- - --------
-------- - --------
-------- Heals the picked unit --------
-------- - --------
Unit - Set life of SA_U_Picked to ((Life of SA_U_Picked) + SA_R_HealAmt)
-------- - --------
-------- Add some visuals --------
-------- - --------
Special Effect - Create a special effect attached to the SA_S_Attach of SA_U_Picked using SA_S_SFX
-------- - --------
-------- destroy visuals to prevent leaks --------
-------- - --------
Special Effect - Destroy (Last created special effect)
Else - Actions
Set SA_U_Picked = No unit
-------- - --------
-------- Clean up --------
-------- - --------
-------- SA_UG_UnitGroup.Clear(); --------
-------- Clear the unit group --------
-------- - --------
Unit Group - Remove all units from SA_UG_UnitGroup
-------- - --------
-------- Destroy the instance of the unit group --------
-------- - --------
Custom script: call DestroyGroup(udg_SA_UG_UnitGroup)
-------- - --------
-------- Destroy the point --------
-------- - --------
Custom script: call RemoveLocation(udg_SA_P_AtkPos)
-------- End of Actions for PHYISCAL damage --------
Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
damageType Equal to SPELL
Then - Actions
-------- Actions for SPELL damage --------
-------- End of Actions for SPELL damage --------
Else - Actions
-------- Actions for CODE damage --------
-------- End of Actions for CODE damage --------

[/trigger]

Shouldn't double-run now.

 

[Blightsower]

its ok now Dat-C3

 

[Kazeon]

Review emerges!

Trigger:

• 
  
  • Time - Elapsed game time is 0.00 seconds
  Personally, I would prefer to follow the convention to preload everything at the loading screen:
  
  • Map initialization
• 
  
  • Set SA_U_AtkUnit = target
  I think you can just use variable target.
• 
  
  • Unit Group - Remove all units from SA_UG_UnitGroup
  Unneeded because you are destroying the group afterwards.
• 
  
  • SaviorAuraLearn
    • Events
      • Unit - A unit Learns a skill
    • Conditions
      • (Level of SA_A_ActiveAbility for (Triggering unit)) Greater than (>) 0
      • (Learned Hero Skill) Equal to (==) Savior's Aura (Active)
    • Actions
      • ...
  =>
  
  
  • SaviorAuraLearn
    • Events
      • Unit - A unit Learns a skill
    • Conditions
      • (Level of SA_A_ActiveAbility for (Triggering unit)) Equal to (==) 1
      • (Learned Hero Skill) Equal to (==) SA_A_ActiveAbility
    • Actions
      • ...
  Check the condition.

Object datas & miscs:

• I don't get how this ability can even be categorized as an "aura". This doesn't directly affect units around the Hero, doesn't give any buff/effect to those units. This is more like a just another passive ability. Not being harsh, but I will disqualify this entry if I was a judge there.
  But actually, that's not a matter for now.
• This ability is way too overpowered. You should add something like a chance for the effect to be triggered. As example, Hero has 5% to heal nearby allies when attacked.
  I believe this is one big minus to your score in the contest.
• Using two additional dummy abilities (passive and disabled spellbook) is a neat method how to add buff to all units around easily. Nice one!
• There is nothing wrong with object datas

Rating:

I don't think the concept is that outstanding. But I like your clean coding style, and it's rather flawless. It's MUI, leakless, and well-coded with some neat additional tricks to avoid extra bunch of codes.

3/5 for now and vote for Approved​

 

[Vinz]

But the condition being == 1 will block out the skill on levels 2-4.

 

[Blightsower]

@Dalvengyr... thanks. Dat-C3 helped me on adding the DDS he should be credited as well

 

[Kazeon]

But the condition being == 1 will block out the skill on levels 2-4.

If I remember it correctly, he is just adding spellbook ability on that trigger. You only need to add it once at ability level 1. Except if he is adding different abilities and assigning different values/datas on each level, then the first condition shouldn't be changed.

 

[Vinz]

Damn, I thought it was the heal trigger. It doesn't seem to be included in the first post.

 

[Maker]

Dead units can not have buffs.

 

[IcemanBo]

• Only need to add the passive ability once. Not each level.
• User could be warned in config the AOE to be exactly the same as the AOE of the passive in object editor.
  Else the buff check could fail.
• In your filter for healing, you could check if the unit is in UnitGroup (boolean), instead of checking for ability level. (integer) Result is same, but for me it's simpler and clear.

Approved (please add the warning in a short comment)

@Maker, it's checked if it's dead equals to false:

(SA_U_Picked is dead) == False .... (SA_U_Picked has buff SA_BF_Buff) == True

 

[Maker]

@Maker, it's checked if it's dead equals to false:

(SA_U_Picked is dead) == False .... (SA_U_Picked has buff SA_BF_Buff) == True

Yes, and dead units can not have buffs. So there is no need to check if the unit is alive or not, if you are also checking if it has the buff.

If a unit has the buff, then it is alive.

 

[IcemanBo]

Indeed. You are right.. I misundertsood it.

So the check if unit is alive is not needed.

 

[Blightsower]

I will revisit this spell and upload a better version soon.

 

[KaiZen7th]

This is exactly what I need. Works in v1.32.

 

[Daffa]

I noticed this spell does not play nice with Damage Engine compatibility script since it uses an older version of PDDS that has different variable naming than the current release.

Also, the import guide doesn't specify user need to copy PDDS to their map if it does not exist yet.

 

[KaiZen7th]

It's strange that I can not put floating texts above the hero who learns the aura (not the picked-units) each time the healing occurs. But I can do it to units that receiving the healing (but if I do so, my screen will be a huge mess).