Phoenix Wave v1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

BPower:
http://www.hiveworkshop.com/forums/spells-569/phoenix-wave-v1-193478/?prev=status%3Dp%26of%3Ddateline%26o%3DASC%26imporder%3D1#post2552865

old

Bribe

(Position of (Target unit of ability being cast)) -> (Target point of ability being cast) # One less function call

Array[1] -> Variable1 # If it doesn't need to be an array, don't make it an array.

(Owner of (Triggering unit)) -> (Triggering player) # One less function call

Lots of memory leaks in Phoenix Wave Loop.

 

[Marcos DAB]

Post triggers, and we'll check.

 

[illegalpie]

Bribe

(Position of (Target unit of ability being cast)) -> (Target point of ability being cast) # One less function call

Array[1] -> Variable1 # If it doesn't need to be an array, don't make it an array.

(Owner of (Triggering unit)) -> (Triggering player) # One less function call

Lots of memory leaks in Phoenix Wave Loop.

Please specify those, as I didn't see any in my brief checkup, and furthermore, you have no right to reject it when you A. Don't post where the memory leaks are, and B. The only thing you complained about were a few efficiency things. It functions, and functions well.

Tested: Heres my review.
Spell Idea - 4
Triggering - 5
Special Effects - 5
Therefore, you get a 5/5.

Comments -
I think the knockback might be a little bit instant, but that doesn;t matter.
The only thing I noticed as a bug, was that when a unit dies from the burn damage, the caster doesn't get the gold.

 

[Vatallus]

Finally managed an update after I found my lost account info and password on my old phone. I'm sorry to have forgotten to update this. I can't even remember how long it has been.

 

[Tank-Commander]

The configurables must support multiple levels in order to meet hive requirements

Critique

• Unit - Move PW_Unit_Dummy[PW_Integer_Index] instantly to PW_Point_OffsetLoc, facing (Angle from PW_Point_DummyLoc to PW_Point_TargetLoc) degrees

The move function is an inefficient method and generates lag when many things are using it, using SetUnitX/SetUnitY will prevent lag being generated when other spells which also have "Move" are running.

• Custom script: call DestroyEffect(AddSpecialEffect("Objects\\Spawnmodels\\Other\\NeutralBuildingExplosion\\NeutralBuildingExplosion.mdl", GetUnitX(udg_PW_Unit_Dummy[udg_PW_Integer_Index]), GetUnitY(udg_PW_Unit_Dummy[udg_PW_Integer_Index])))

Special effects should also be configurables instead of hard-coded. Also if you were using co-ordinates for movement throughout the whole spell (as suggested) the end of this line would just be two variable references instead of needing to run extra functions to fetch them

• Set PW_Integer_Max = (PW_Integer_Max - 1)

While this does make the spell able to stop running, there's no garuntee the last entry will be the first to end as such, the index recyling is buggy.

• Unit - Kill PW_Unit_Dummy[PW_Integer_Index]

You kill the dummy, but never remove it (which it should be) I suggest adding an artificial wait between it's death and recycling if you want death animations to still play

• Unit - Create 1 Phoenix Wave Dummy (Phoenix) for (Triggering player) at PW_Point_CasterLoc facing (Angle from PW_Point_CasterLoc to PW_Point_TargetLoc) degrees

The dummy unit type ought to be configurable as well

• Unit - Order (Last created unit) to Neutral Alchemist - Acid Bomb (Picked unit)

Object editor based damage isn't what you'd call good, but I suppose it's alright for minor "extra" damage

That should just about do it, the spell looks fine otherwise

 

[GywGod133]

I suggest you use 0.03125 instead using 0.03

if you dont know
Custom script: set udg_RealVar = 0.03125
Trigger - Add to Loop <gen> the event (Time - Every RealVar seconds of game time)

Edit 1:
Add Spell Configuration (Like Damage, Range, AoE or etc)

 

[BPower]

You should add a configuration trigger, where effects, damage, ability, aoe, damagetype, attacktype, ... can be setup.
"Picked Unit" could be stored into a variable in order to avoid needless function calls.

Please also take care of what the Tank-Commander posted. (Thank you)

Need Fix at the moment.