Pentagram

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

13:12, 11th Feb 2014
BPower:
You have location leaks
You lack user configuration
Using a giant ForGroup loop is past any efficiency.
Using loops within the periodic trigger would shorten the code by a lot.
11:51, 2nd Nov 2013
Maker: Requires many fixes

 

[FUJI]

the pentagram concept is quite creative and cool, add a map boundary.

POST TRIGGERS:

The pentagram creation can merged into 1 line by doing a loop and array point IF YOU USE HASHTABLE
because hashtable can does 2D Arrays to save the pentagram creation point and attached a MUI Data or ID.

EDIT:

Pausing caster is bad.

EDIT2:

Your spell is leaking by misplacing the removing of this:

• Set TargetPoint = (Position of PG_Caster)

You need to remove it in where you'd set it.

 

[Paultaker]

How to post triggers? D: sorry, it's my first spell

EDIT:

Why Pausing caster is bad?

I don't know how to use Hashtables

I'll fix the leak rightaway

 

[FUJI]

^
Copy the trigger via Copy as text.
put a copied trigger to inside this bbcode: [trigger][/trigger]

 

[Paultaker]

Thanks I'll update now
EDIT: Why does the copy as text disabled or something? The text is grey I can't click it >:|
Lol, nvm figured it out

 

[FUJI]

Why Pausing caster is bad?

It can pause the buffs and sometimes buggy.
Use unit's propwindow: it disables the caster's movement.

I don't know how to use Hashtables

It is optional.

 

[BPower]

Things like PG_SpecialEffect, PentaEdgeRadius, TesterSpell_Damage ( this a bad variable name), TesterSpell_Duration should be in an on map init trigger, since they never change (yet).

Do not pause your caster, there are better ways.
Like Jake Zinc said, you should use an hashtable and loop through it.

The iteration of your Pental_edges is explicit and regular, just use a little math or think of a way how one Location points to the next one, this reduces your code to a minimum.
Just the start is little different since its create effect, move, face to Point 4.
Beside thats its 1,2 -> 2,3 ->3,4 -> 4,1.

 

[Paultaker]

Well the problem is, I don't know about hastables, and any help on shortening the loops would be highly appreciated!
EDIT: What can I exactly do to replace the pausing of the unit?

EDIT 2: UPDATE: Optimized trigger

 

[FUJI]

^ Well hashtable can do 2d arrays that's why the pentagram edges can be loop.

"What can I exactly do to replace the pausing of the unit?"

You can use unit's propwindow set to 0 like this:

• -------- FIRST: SAVE THE UNIT'S PROPWINDOW ( DEFAULT ) --------
• Custom Script: set udg_MY_UNIT_PROPWINDOW[ udg_ID ] = GetUnitPropWindow( udg_YOUR_UNIT )
• -------- SECOND: SET THE UNIT'S PROPWINDOW TO 0. --------
• Custom Script: call SetUnitPropWindow( udg_YOUR_UNIT, 0 )
• -------- THIRD: IF THE SPELL IS FINISH THEN SET THE UNIT'S PROPWINDOW TO THE SAVED ORIGINAL UNIT'S PROPWINDOW. --------
• Custom Script: call SetUnitPropWindow( udg_YOUR_UNIT, MY_UNIT_PROPWINDOW[ udg_ID ] )

Do you want me to elaborate the whole function ^^?

 

[FUJI]

How to use hashtable?
Here: http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/hashtables-mui-133407/

Additional Tutorial:
Here: http://www.hiveworkshop.com/forums/...rials-279/things-gui-user-should-know-233242/

 

[Paultaker]

Do you want me to elaborate the whole function ^^?

Sure! I'll be glad to

 

[FUJI]

• -------- FIRST: SAVE THE UNIT'S PROPWINDOW ( DEFAULT ) --------
• Custom Script: set udg_MY_UNIT_PROPWINDOW[ udg_ID ] = GetUnitPropWindow( udg_YOUR_UNIT )
• -------- SECOND: SET THE UNIT'S PROPWINDOW TO 0. --------
• Custom Script: call SetUnitPropWindow( udg_YOUR_UNIT, 0 )
• -------- THIRD: IF THE SPELL IS FINISH THEN SET THE UNIT'S PROPWINDOW TO THE SAVED ORIGINAL UNIT'S PROPWINDOW. --------
• Custom Script: call SetUnitPropWindow( udg_YOUR_UNIT, MY_UNIT_PROPWINDOW[ udg_ID ] )

I'll mark the contents with bold letters.

Custom Script: set udg_MY_UNIT_PROPWINDOW[ udg_ID ] = GetUnitPropWindow( udg_YOUR_UNIT )
Custom Script: call SetUnitPropWindow( udg_YOUR_UNIT, 0 )
Custom Script: call SetUnitPropWindow( udg_YOUR_UNIT, MY_UNIT_PROPWINDOW[ udg_ID ] )

Contents:

1) Custom Script = the custom script can be found in GUI Function, In this function you can write a single JASS Line or Scripts.

2) set = set is the keyword for setting a variable in JASS lines or scripts. Remember: JASS are case sensitives.

3) udg_ = udg_ thingy is for the global variable that created in the Variable Creator in GUI. udg_ is a prefix from global variables in GUI. "udg" stands for User Defines Global. You must use udg_ if you're setting a global variable in JASS.

4) MY_UNIT_PROPWINDOW = This is a real variable, this will be the variable for getting or saving the unit's default propwindow angle.

5) [ udg_ID ] = The MY_UNIT_PROPWINDOW must be a real array variable to pass the data to the another trigger that will make it MUI.

6) GetUnitPropWindow = this is the function for getting and saving the unit's default propwindow angle. The parameters or function takes is a unit variable:
GetUnitPropWindow( THE_UNIT ).

7) call = this is the keyword for JASS in calling actions, functions and etc.
that's why we use this.

8) SetUnitPropWindow = this is the function for setting the unit's propwindow angle. The parameters are: Unit Variable and Real, so we do set the unit's propwindow angle to 0 because it will disable the movement speed.

For making the unit's propwindow to normal then you would set it's propwindow angle to the default saved unit's propwindow.

 

[Paultaker]

So basically, it just disables MS? Seems like i don't have to use it at all since the caster moves instantly every 0.07 seconds; Maybe I can just remove the pausing of unit? And if pausing is bad, why other spells with pause gets approved? D:

 

[FUJI]

^ What?!, it is now not recommended in the spells.

 

[Paultaker]

The spells with a pause function?

 

[FUJI]

^ Yes

 

[T. D. W.]

??? Review

Personal Words

Review

Suggestions

Rating

Judgement

Note

Spell is cool,, not laggy

Configuration Trigger is missing

Don't use

(PGCaster_Group is empty) Equal to True

use a counter instead

If You want me to review an Update of This Spell, Please Notify me this by VM or PM

 

[FUJI]

• Unit - Unpause PG_Caster

Also remove this line ^^.

 

[Bloody Wolf]

well i have to say this is pretty good for a first timer but theres allways more room for a few "upgrades"

 

[Paultaker]

Thanks for the review Jad!

Thanks again JakeZinc you're really helpful

Bloody Wolf, I guess you're right this really needs an "Upgrade". Gonna update this on the weekends.

 

[Bloody Wolf]

Gonna update this on the weekends.

kk i'll keep an eye out for it

 

[pOke]

Maybe you just haven't fixed it yet, but as it stands now, it fails when all 3 cast it at the same time, 2 of the dh don't get their prop reset properly.

 

[Paultaker]

Maybe you just haven't fixed it yet, but as it stands now, it fails when all 3 cast it at the same time, 2 of the dh don't get their prop reset properly.

Yes, also the center position isn't set to an array, will fix everything this weekend

 

[Maker]

• You could use one array for the pentagram points and shorten the code that moved the unit through the points
• There are location leaks
• The tooltip needs fixing
• Unpause caster?
• You could use a configuration trigger and variables for the ability and unit type

 

[Paultaker]

• You could use one array for the pentagram points and shorten the code that moved the unit through the points

It's been really busy these days I don't know when to fix this.

How can I do that?

 

[nhocklanhox6]

Ahaha this spell so funny ^^