Paralyzing Cask v1.0.6

[Moderator]

Paralyzing Cask v1.0.4 | Reviewed by Maker | 17th November 2013 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] The spell is fun to cast and it fits the WC3 world nicely Triggers[/COLOR]] No leaks, the spell is MUI You could use variables for the dummy unit type and for the ability It might be easier to set group = units in range and the do the filtering in a If/then/else rather than doing a long matching unit chain The projectile can stun the target when it lands even if the target is not nearby. You could add a configurable hit radius Objects[/COLOR]] The tooltip is good No unneeded objects The dummy's death type should be Can't raise, does not decay so it does not decay for 90 seconds There is no follow through time Effects[/COLOR]] The effects stay true to the concept of the spell Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS APPROVED Links[/COLOR]] How to get your GUI spell approved [COLOR="gray"

[/TD]

 

[BPower]

Suggestions

Making it homing would make the spell look so much smoother. At least you could kill the flask when it crosses its target.

Your configuration trigger is very short.
Values like damage, bounces, initiale missile height, missile speed, effects should be configurable by the user. You assume people want linear increase of Damage, but maybe they want 10, 40, 210 therefore using an array in the configuration would be nice.

 

[Kazeon]

hey there is a little miscalculation there at the cast trigger for damage variable
it's must be like this

• Set PC_Damage[PC_IndexMax] = (50.00 x (25.00 x (Real((Level of (Ability being cast) for (Triggering unit))))))

I hope it's not a problem for approval

EDIT:
Did you mean
Damage[1] = 100
Damage[2] = 120
Damage[3] = 150
Damage[4] = 175
?
so you are right

EDIT 2:
I dont know how to make a good homing. I have tried to make it but it kinda fail. the missile looks very "weird"

EDIT 3:
kill the flask when it crosses the target but if the current fh is still so high make it kinda bad. :/ I can use this suggestion if there is no arching at the missile

EDIT 4:
Updated. Please download the file dont look at the codes above. I'm too lazy to update it.

Updated to v1.0.2
- Added homing
- Better bounce
- Better sfx usage

 

[T. D. W.]

Make it HOMING >> v1.0.2 doesn't hom yet
Sometimes, the units do not get stunned

just a suggestion: you can use KB3D for this, since you can have a trigger fire on the end of the "KB" and use variables for both the target unit and KBed unit... it can be possible, but you will need to use a hashtable (for the handle Id of the dummy)

 

[Kazeon]

No, i wont..
i think making good homing missile with arc is nearly imposibru
that's why I make two loop trigger. The homing and not homing version.. and as far as I remember, dotas paralyzing cask is not homing too

eh, wait. It's still not homing because defaultly it's still turning on the "non homing" loop trigger. I'm sorry about that

Sometimes, the units do not get stunned

Fixed. I just suggest dont use the homing one because it's just a fail homing

 

[T. D. W.]

it was just a suggestion

i just tested the homing version, so, i noticed that the missile looks like bouncing on the ground when jumping from target to target..

and if i remember right (long time i didn't play dota), dota's version did hom, but i think it homed differently, i mean it calculated the speed of the unit, his facing, the position where he will be in X time, and at this X time, the cask will hit it, but i am not so sure, i'll test this ...

 

[Kazeon]

yeah, they are homing but not arching

 

[T. D. W.]

yeah, they are homing but not arching

yes maybe it's the thing : P

 

[Kazeon]

have you realized that even native warcraft III arcing with homing still looks bad?

 

[T. D. W.]

Yes it does xD

 

[FUJI]

Review

Paralyzing Cask v1.0.3 This spell had been reviewed by jakeZinchttp://www.hiveworkshop.com/forums/members/jakezinc/#visitor_messaging Set PC_Point[1] = (Position of (Triggering unit)) Set PC_Point[2] = (Position of (Target unit of ability being cast)) ^ Use your stored variables ( PC_Caster and Target ). Trigger - Turn on PC Loop <gen> ^ You can check if the index is equal to 1 before turning on the looping trigger. (Level of (Ability being cast) for (Triggering unit)) ^ Again: Use your stored PC_Caster in triggering unit(), Store the Level of the ability being cast in the integer variable because you used it twice ( and it does makes your code faster ). Unit - Create 1 Missile for (Owner of (Triggering unit)) at PC_Point[1] facing PC_Point[2] ^ Use TRIGGERING PLAYER instead of Owner of Triggering Unit(). Unit - Add Crow Form to PC_Missile[PC_IndexMax] Unit - Remove Crow Form from PC_Missile[PC_IndexMax] ^ Instead of this two lines of work, you can use to enable the fly ability of the dummy by setting it's movement type to 'fly' because it is only a dummy unit, also there's another way: Custom script: if UnitAddAbility(udg_PC_Unit,'Amrf') and UnitRemoveAbility(udg_PC_Unit,'Amrf') then Custom script: endif . Unit - Add a 1.00 second Generic expiration timer to PC_Missile[PC_Loop] ^ Just kill the missile. Set PC_Speed[PC_IndexMax] = PC_ConfMissileSpeed ^ This line is not needed, use PC_ConfMissileSpeed instead. Custom script: set udg_PC_X = udg_PC_X + udg_PC_Speed[udg_PC_Loop] * Cos(udg_PC_Angle[udg_PC_Loop]) Custom script: set udg_PC_Y = udg_PC_Y + udg_PC_Speed[udg_PC_Loop] * Sin(udg_PC_Angle[udg_PC_Loop]) ^ Inline these lines and put it inside the call SetUnitX/Y Func because it does only use once. ( Reduced Score Points: -9 ) Other than that none. I'd see your code is not leaking. The documentation is lacking and incomplete. ( Reduced Score Points: -4 ) Configuration Trigger Configurable Events Map initialization Conditions Actions -------- model's path of your missile -------- Set PC_ConfMissileType = Abilities\Spells\Other\AcidBomb\BottleMissile.mdl Set PC_ConfOnImpactSfx = Abilities\Spells\Other\AcidBomb\BottleMissile.mdl -------- range for missile to seek new target -------- Set PC_ConfDetectionRange = 500.00 Set PC_ConfHomingSmoothingFactor = 0.00 -------- max flying height for the missile -------- Set PC_ConfMissileArc = 0.50 -------- missile speed -------- Set PC_ConfMissileSpeed = 15.00 -------- damage per level -------- Set PC_ConfDamageLevel[1] = 75.00 Set PC_ConfDamageLevel[2] = 100.00 Set PC_ConfDamageLevel[3] = 125.00 Set PC_ConfDamageLevel[4] = 150.00 -------- number of bounces per level -------- Set PC_ConfCountLevel[1] = 2 Set PC_ConfCountLevel[2] = 4 Set PC_ConfCountLevel[3] = 6 Set PC_ConfCountLevel[4] = 8 ^ It is lacking at the documentation and some of them does not supporting every level supporting every level of the spell. Set PC_ConfMissileSpeed = 15.00 ^ You must compute the speed in the core trigger like: 500.00 x 0.03 = 15.00 Where 500.00 must be the configuration speed not the 15.00. It depends from you. Set PC_ConfHomingSmoothingFactor = 0.00 Set PC_ConfDetectionRange = 500.00 ^ It must support some of the documentation and levels. Unit - Cause PC_Caster[PC_Loop] to damage PC_Target[PC_Loop], dealing PC_Damage[PC_Loop] damage of attack type Hero and damage type Normal Make the attacktype and damagetype to be configurable. ( Reduced Score Points: -5 ) Also you can remove Conf Prefixes in the configuration variables. Clean spell, simple, leakless and MUI. Does not generates a lag. Inefficient triggering and it has no importing instruction. There's no importing instruction ( Reduced Score Points: -10 ) The special effects are fitting these simple spells and adding an arc in paralyzing cask is nice and beautiful even if it is simple but maybe add some nice combination of effects ^^. Useful from bouncing skills that can stun every units and deals a damage. Make the movement type of the dummy to fly. Add more documentation. Add importing instructions too. Don't add an ability to the dummy because it can consume a small time in importing process, Solution? add only the ability in the core trigger and make that dummy ability to be configurable. Remove the useless trigger like PC HomingLoop(..). Tooltip is good and it does support every levels. Rejected: 1-10 Unacceptable : 11-30 Lacking : 31-49 Useful : 50-69 Recommended : 70-90 Highly Recommended : 91-100 Director Cut : 101-105 1) Triggering - 11/20 2) Documentation - 6/10 3) Importing Instruction - 0/10 4) Special Effects - 11/15 5) Usefulness - 18/20 6) Tooltip - 9/10 7) Configuration - 5/10 Total Score - 60/105 jakeZinc Rating - 3.8/5 Status - Useful and Needs Fix

 

[T. D. W.]

Jake, are you active again?

 

[Kazeon]

FINALLY!! it's a full review o_0
thnks, and I will fix them

 

[Kazeon]

Updated to v1.0.4
- not a big update, I just removed repeated FCs
- added some improvements

I will update the trigger tomorrow, I feel sick, I need to sleep now.

 

[Maker]

Use an in-game screenshot.

 

[Kazeon]

thnks for moderation
btw, what is follow trough time? I will fix them..

 

[Maker]

btw, what is follow trough time?

Read the link in the review.

 

[Kazeon]

there is no explanation about follow trough time there :/

 

[Maker]

And what is this then?

If you are using Channel as the base ability, add about a second of Follow though time. During that time, the caster won't auto-attack, it will keep casting the ability. Adjust the time so that the caster has enough time to end the casting animation, but doesn't start another loop of the animation.

 

[Kazeon]

I don't know

 

[Kazeon]

guys, it's updated!! a big update! all suggestions have been applied. So many improvements. Check it out!!

 

[Rheiko]

you are now a GUI spell maker as well, huh, secondhand?
glad we got a new Spell Maker ^^
and you have a nice spell

Edit: Follow through Time is real value in channel ability in object editor

 

[Kazeon]

i'm not a GUI spell maker. I'm a GUI coder
thnks bro ^^

 

[Rheiko]

but you are making spells? i know you are also GUI coder, because you are making GUI spells with GUI language

 

[Kazeon]

I'm also making systems

hey, why it's so hard just to change the screenshots?

 

[chobibo]

GUI language

GUI interface, jass2 is the language. Troll-Brain and Malhorne prefers to call it jaws though...

 

[Rheiko]

i'll just say it GUI code =P

 

[IcemanBo]

Hey SecondHand, just a little suggestion: You could avoid using "udg_PC_X" and "udg_PC_Y", because I saw you only use them once.

And I'm wondering a bit why use custom script for get angle between two locations? There is a function in GUI which does so, too.

Ok, now I recognized it... you immediatly make * bj_DEGTORAD to prevent using it in loop trigger again, sorry

But if you already use a custom script for getting angle between two unit locatios you could optimize it a bit, without any locs:

• Custom script:Atan2(GetUnitY(UnitB) - GetUnitY(UnitA), GetUnitX(UnitB) - GetUnitX(UnitA))

And you even wouldn't need *bj_DEGTORAD with it

 

[Adiktuz]

GUI is simply GUI... that's it...

Spoiler

GUI Interface is redundant you know? since the I in GUI is already Interface

anyway, it's nice to see someone making a DotA spell that is actually usable... nice job...

 

[Rheiko]

GUI is simply GUI... that's it...

Spoiler

GUI Interface is redundant you know? since the I in GUI is already Interface

well, it's true xD
yeah, just call it GUI :3

 

[Kazeon]

I will fix them, icebro.. thnks