Rheiko
Spell Reviewer
- Joined
- Aug 27, 2013
- Messages
- 4,214
Hello, thank you for the submission! Here's my review so far:
This system is cool and could be really useful — but right now, it lacks proper configuration options. Adding a new bag seems unnecessarily tedious. I have to duplicate triggers and manually change variables? That introduces a high risk of user error, and the system might break if something is set incorrectly.
A system should be easy to configure, especially for beginners. I assume that’s one of the goals of this system: ease of use. In general, users shouldn’t need to understand or touch the internal logic of the system. Instead, they should be able to change configurations via a dedicated configuration trigger.
So instead of having multiple triggers for each bag, consider using a smaller set of core triggers that handle all bags dynamically, and expose configuration settings through a separate trigger.
Duplicate triggers, while sometimes harmless, should generally be avoided — they can cause unnecessary performance overhead and make debugging harder.
Here are a few configuration values that should be exposed via a config trigger:
You mentioned the system could be made multiplayer-compatible by switching from Game Cache to Hashtable. So why not use Hashtable from the start? That way, users don’t have to worry about compatibility depending on the map type — it’ll just work.
In its current form, the system isn’t quite lightweight or beginner-friendly enough. That said, it’s a great idea and a promising start. I really hope you keep improving it — looking forward to the next version!
Cheers!
Awaiting Update
This system is cool and could be really useful — but right now, it lacks proper configuration options. Adding a new bag seems unnecessarily tedious. I have to duplicate triggers and manually change variables? That introduces a high risk of user error, and the system might break if something is set incorrectly.
A system should be easy to configure, especially for beginners. I assume that’s one of the goals of this system: ease of use. In general, users shouldn’t need to understand or touch the internal logic of the system. Instead, they should be able to change configurations via a dedicated configuration trigger.
So instead of having multiple triggers for each bag, consider using a smaller set of core triggers that handle all bags dynamically, and expose configuration settings through a separate trigger.
Duplicate triggers, while sometimes harmless, should generally be avoided — they can cause unnecessary performance overhead and make debugging harder.
Here are a few configuration values that should be exposed via a config trigger:
- Number of bags (no trigger duplication should be needed).
- Model used for the special effect and its attachment point (string variables work great here).
- Sound effect used.
- Unit type used as the bag.
- The ability associated with the bag.
You mentioned the system could be made multiplayer-compatible by switching from Game Cache to Hashtable. So why not use Hashtable from the start? That way, users don’t have to worry about compatibility depending on the map type — it’ll just work.
In its current form, the system isn’t quite lightweight or beginner-friendly enough. That said, it’s a great idea and a promising start. I really hope you keep improving it — looking forward to the next version!
Cheers!
Awaiting Update
Last edited: