Personally I think the whole needs fix thing is completely bullshit in the first place. 90% of the things uploaded here does work fine. Yet it 'needs fix'
If they did not meet the standard requirement of spell approval (MUI, no leaks, no repetitive function calls) then they were indeed needing fix. But if they were just lacking some freaky optimizations, then I'm agreed those are invalid needs fix statuses.
Lately I've realized we have applied a
too high or even too
harsh reviewing standard. Actually, we just need to mention
major flaws in a spell, not every single minor improvements. Efficiency, coding neatness, etc. are not required, they are secondary objective to get higher rating. But those should not influence their approval status. Then eventually, those minor optimizations and clean coding can affect their final ratings.
As far as I see, capt. Bribe did a perfect job on moderating. He did not mention blocks of review but just 3 or less comments including one resource's major approval problematic. Just like "this is not MUI". And that's how a valid review should be.
Yet, our spell submission rules itself is way too constrained. Just like these ones
- JASS code must be written to follow common JASS convention.
- Variable names must be descriptive, but not too descriptive.
- Spells must be easy to import, use variables for object editor data, for example for abilities and unit types. Strive to require as few changes possible when importing.
- The triggers and/or code must be readable and clean. Messy code is very hard to moderate, and even harder for inexperienced users to deal with.
- Users have to be able to configure your spell to their liking. Don't make spells that are hard-coded and only work in one configuration. Allow users to configure things like damage, Area of Effect, special effects, damage type, attack type, etc...
Do you really think they are necessary and required? Personally, I don't think so. Yet they may influence submissions' final ratings. I suggest somebody to rework on our spell rules.
