Need help with a simple trigger

[Lawlfool]

Hi! I've just started to create simple triggers with GUI and I've ran into a problem

What I'm trying to create is a special effect that fires at the location of a dropped item. The dropped item is also removed in the process. I've been trying to figure out why special effect fires at the wrong locations instead of the location where I last dropped the item, before it was removed.

I bet I'm just missing something very obvious to everyone else. Thanks in advance!

• Weapon Drop
  • Events
    • Unit - A unit Loses an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Iron Longsword
  • Actions
    • Set Temp_Point = (Position of (Item being manipulated))
    • Special Effect - Create a special effect at Temp_Point using Abilities\Spells\Human\Polymorph\PolyMorphTarget.mdl
    • Item - Remove (Item being manipulated)
    • Special Effect - Destroy (Last created special effect)
    • Custom script: call RemoveLocation (udg_Temp_Point)

 

[deathismyfriend]

We can't tell anything unless you post your code.... https://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

 

[Lawlfool]

The special effect keeps firing at the location where I picked up the item, instead of where I dropped it.

 

[deathismyfriend]

Do you have a trigger that fires when you pick up the item ?

If not can you post your map. It should not be happening with the trigger you have posted.

 

[Arhowk]

Try putting a 0.00 second wait in the top of your trigger

 

[Lawlfool]

Try putting a 0.00 second wait in the top of your trigger

This fixed it. Thank you! Could you explain the reasoning behind this? I'm new to this stuff and I'd love to know what kind of difference does it make..

 

[Arhowk]

This fixed it. Thank you! Could you explain the reasoning behind this? I'm new to this stuff and I'd love to know what kind of difference does it make..

Well the trigger is probably running before the item is actually dropped, so the sequence goes like this

Unit picks up item >
Unit ordered to drop item >
Trigger lost item function ran >
Item is dropped

When you add the 0.00 second wait, you let everything else run first than come back and finish the trigger. So

Unit picks up item >
Unit ordered to drop item >
Trigger lost item function ran to sleep >
Item is dropped >
Trigger lost item function resumed after the sleep

so "Item is dropped" gets put before the rest of the actions and the position of the item is correct

 

[Lawlfool]

Ok, that makes sense.. Thanks again for the help!

 

[deathismyfriend]

You should do it like this to make it MUI. If it is multiplayer and two or more units drop an item at the same time the way yours is above ( with the wait added at top) it can bug.

This will make it MUI and solve your problem.

• Weapon Drop
  • Events
    • Unit - A unit Loses an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Iron Longsword
  • Actions
    • Custom script: local item itm = GetManipulatedItem()
    • Custom script: local location udg_Temp_Point = Location(GetItemX(itm), GetItemY(itm))
    • Wait - 0.00 seconds
    • Special Effect - Create a special effect at Temp_Point using Abilities\Spells\Human\Polymorph\PolyMorphTarget.mdl
    • Item - Remove (Item being manipulated)
    • Special Effect - Destroy (Last created special effect)
    • Custom script: call RemoveLocation (udg_Temp_Point)
    • Custom script: set itm = null
    • Custom script: set udg_Temp_Point = null

@Arhowk
Thanks for the solution i forgot about that stupid little wait time lol.

 

[Arhowk]

? not only is my solution still mui but urs also wont work because it has no wait...

 

[deathismyfriend]

Lol i forgot to put the wait in there. Also adding a wait without local variables makes it so it is not MUI. I updated my trigger above.

 

[Maker]

You should index the item and then use a 0.00 timer to handle the indexed items.

 

[Lawlfool]

Lol i forgot to put the wait in there. Also adding a wait without local variables makes it so it is not MUI. I updated my trigger above.

Actually your trigger still has the same result as the one I posted first. Special effect still fires at the location where the item was picked.

 

[deathismyfriend]

Actually your trigger still has the same result as the one I posted first. Special effect still fires at the location where the item was picked.

Huh that is odd. Use a timer like maker suggested then. That is your best option.

 

[Arhowk]

Huh that is odd. Use a timer like maker suggested then. That is your best option.

zzzz its fixed. Seriously. Even if GetManipulatedItem() wasn't thread safe than the likelihood of two items being dropped within the same frame is next to null

This fixed it. Thank you! Could you explain the reasoning behind this? I'm new to this stuff and I'd love to know what kind of difference does it make..

 

[Nichilus]

tbh can't the problem in Death's trigger be that he saves the location before wait? I would think that that way it will still save the incorrect location, wait 0.00 seconds and create effect at loc.
In that sense, I think it would be correct to save only the item, after 0.00 wait set temp loc = position of saved item and create effect at temp loc.

 

[deathismyfriend]

tbh can't the problem in Death's trigger be that he saves the location before wait? I would think that that way it will still save the incorrect location, wait 0.00 seconds and create effect at loc.
In that sense, I think it would be correct to save only the item, after 0.00 wait set temp loc = position of saved item and create effect at temp loc.

I believe you are right. I have no way to test it though if you could ?

Here is what i was thinking.

• Weapon Drop
  • Events
    • Unit - A unit Loses an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Iron Longsword
  • Actions
    • Custom script: local item udg_tempItem = GetManipulatedItem()
    • Wait - 0.00 seconds
    • Set Temp_Point = (Center of (tempItem))
    • Special Effect - Create a special effect at Temp_Point using Abilities\Spells\Human\Polymorph\PolyMorphTarget.mdl
    • Item - Remove (Item being manipulated)
    • Special Effect - Destroy (Last created special effect)
    • Custom script: call RemoveLocation (udg_Temp_Point)
    • Custom script: set udg_tempItem = null
    • Custom script: set udg_Temp_Point = null

 

[Nichilus]

tried it and it works

 

[deathismyfriend]

tried it and it works

Thats good and thanks.

@TO
Makers suggestion is still better but this will do i guess. Just remember to make almost everything MUI.

 

[Maker]

0.00 seconds is still 0.1-0.2 seconds even in single player, so one can detect the delay.

 

[deathismyfriend]

0.00 seconds is still 0.1-0.2 seconds even in single player, so one can detect the delay.

I know this that is why i suggested going the way you suggested over the way that was suggested by arhowk.

I was simply providing an MUI example to arhowks suggestion.

 

[Arhowk]

I know this that is why i suggested going the way you suggested over the way that was suggested by arhowk.

I was simply providing an MUI example to arhowks suggestion.

seriously. fact check before you spam a thread. Manipulated Item is threadsafe.

@Maker its still too little for anyone to do something about it. By the time the request for an action gets sent to the host, the 0.1-0.2 seconds will already be elapsed

 

[deathismyfriend]

seriously. fact check before you spam a thread. Manipulated Item is threadsafe.

As i have said above i have no way of testing Warcraft 3 atm. That is why i asked someone to try out the triggers i have posted.
I am not spamming a thread. It is simple optimization.

If Manipulated item does act like a local variable then i do apologize. I still have no way of testing it though.

 

[Maker]

If Manipulated item does act like a local variable then i do apologize.

It does.

 

[Melodia]

just put "position of triggering unit"

 

[deathismyfriend]

It does.

Thanks maker i did not notice this.

@ Melodia
Please do not post things without reading the other posts.