Mana Pulse v1.1 [GUI]

[Moderator]

07:43, 19th Jul 2011
Maker:
Approved.

 

[Jazztastic]

Please provide comments and feedback. I'm using this spell in a map I'm making for my friends, so I want to see what the community thinks of it.

The screenshot isn't good, and neither is the SFX. I would recommend using a green-ish blue-ish explosion model if I were you.

 

[Bribe]

This could be running off of a Unit Indexer instead of a hashtable

Not a review, just a suggestion. It would be faster/more readable at
least in this case.

 

[Maker]

Check the test map, the ability is missing. Set the looping trigger to be initially off.

 

[maddeem]

Why use all those variables when you can just save it all into your one hashtable?
If it is so that it is easier to use, you could put trigger comments under each value you want people to be able to edit.

 

[Jazztastic]

Check the test map, the ability is missing. Set the looping trigger to be initially off.

Whoops, I might have uploaded wrong map. I accidently saved the name wrong halfway thru making it, so it might be the wrong one. I'll check it and edit if this turns out to be true. I do need to set the looping trigger off.

Why use all those variables when you can just save it all into your one hashtable?
If it is so that it is easier to use, you could put trigger comments under each value you want people to be able to edit.

Personal preference. I feel more comfortable if every value saved into a hash is a variable. If you feel that it affects performance I can change it.

This could be running off of a Unit Indexer instead of a hashtable

Not a review, just a suggestion. It would be faster/more readable at
least in this case.

Again, a matter of personal preference. I feel comfortable with hashtables. I understand how useful your unit indexer is, and moreover how much easier this would be to read, but I don't want to make any user downloading it to be constrained to a system. Any resources I upload I want users to be independant of other systems or tools (such as vJass, it's great but 90% of GUI'ers don't have it, one of the reasons I'm staying in GUI among others), same goes for imported materials. I had a very specific art model and a very specific icon for this spell, but I didn't feel it appropriate to upload them with the spell.

I'm really happy that I got three spell pros to look over my spell and no actualy coding errors were found I'll check into the things you guys suggested.

EDIT: Here are suggested models and icons for this spell

http://www.hiveworkshop.com/forums/...sfx-104179/?prev=search=explosion&d=list&r=20

http://www.hiveworkshop.com/forums/...169709/?prev=search=poison%20nova&d=list&r=20

Credits to WILLTHEALMIGHTY and Hellx-Magnus for the resources

 

[x3GlikE]

Looks neat,

 

[Manasurge]

if you consider the knockback bad if the targets have no mana then why not filter it?

 

[Jazztastic]

I said that the ability will deal 0 damage to units without mana, HOWEVER, it will still knock them back, meaning no matter what you get a 0.9 second stun on any effected units, mana or not. And creating an if/then/else block to filter out units with 0 mana from knockback would be ridiculously easy, I'm sure almost all users could do it.

 

[Manasurge]

I understand that, yet you consider it bad in the description of the spell which seems confusing to me if you want it to be like that.

 

[Jazztastic]

As in most people who download the spell will view it as an undesireable effect to have (if the unit is not affected, why does it receive knockback?). However, the reason I made this spell was for my map, and in my map I want the knockback constant no matter what, even if the unit doesn't take mana damage. It would be easily changeable, but it doesn't need to be changed. It's fine how it is, and if people really wanted it changed that bad, they'd add an if/then/else to see whether P_ManaTotal = 0. If it does, just don't do it, simple as that.

 

[Champara Bros]

As in most people who download the spell will view it as an undesireable effect to have (if the unit is not affected, why does it receive knockback?). However, the reason I made this spell was for my map, and in my map I want the knockback constant no matter what, even if the unit doesn't take mana damage. It would be easily changeable, but it doesn't need to be changed. It's fine how it is, and if people really wanted it changed that bad, they'd add an if/then/else to see whether P_ManaTotal = 0. If it does, just don't do it, simple as that.

well you can make a dormant mana for those without it. You know everyone has mana, but not everyone utilizes it. So you can give 50-100 imaginary mana during the damage calculation. But that is just my opinion.

 

[Jazztastic]

So you're suggesting I could just add 50 flat damage, even without mana. Again, it really is up to the user. It would take literally less than 1 minute to edit this spell however you wanted to.

 

[Champara Bros]

So you're suggesting I could just add 50 flat damage, even without mana. Again, it really is up to the user. It would take literally less than 1 minute to edit this spell however you wanted to.

well yeah. but just like you said it is up to the user.

 

[Jazztastic]

@Maker, if you move P_Timer and P_Distance into the init trigger, the spell only functions once properly. It will load the last value of P_Timer and P_Distance if I don't reset them everytime, meaning that the knockback won't even work. If you don't believe me, try it out for yourself.

Filtering structures out is just another boolean in the pick units. So is picking units only in the playable map. Updating.

EDIT: Updated. Forgot to change the Change Log though. Not redoing the whole update for that thing though. In short, the units are properly filtered out, so it cannot target units outside playable map area (if they got there somehow), and if they are going to slide outside the map, it stops the slide temporarily (if they somehow move forward, slide will resume. Timer goes down even while not sliding).

 

[Maker]

@Maker, if you move P_Timer and P_Distance into the init trigger, the spell only functions once properly. It will load the last value of P_Timer and P_Distance if I don't reset them everytime, meaning that the knockback won't even work. If you don't believe me, try it out for yourself.

I know, I meant you could set the initial values in the init tigger and use some other variables when calculating things in the looping trigger. It's not a big deal though.

 

[Jazztastic]

Oh ok. Thanks for the instant feedback

 

[Doom_AngeaL]

well yeah. but just like you said it is up to the user.

Dude, your avatar scared the sh** out of me.

On topic:

I like the general idea of it. But, how it does knockback and all even when the target has no mana makes no sense, if you ask me. I mean, if its a move thats targetting someones mana and because of it, it stuns/moves them, how is it going to happen without mana? again, user preference i suppose.
4/5, because of that ^(i'm a picky guy..)