[GUI] AlternativeStunSystem v1.1

[Moderator]

14:15, 16th Jul 2012
Magtheridon96: Bah, okay.
Pausing units really sucks, but since you acknowledge that and are calling this an "Alternative" stun system, I'll approve it hoping that random users acknowledge that as well.

 

[Vladadamm]

Post reserved.

 

[F1ashB0nd]

English:

Triggers

• Init
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- Add this in your actual initialization trigger. --------
    • Hashtable - Create a hashtable
    • Set StunHash = (Last created hashtable)
    • Set StunEff = Abilities\Spells\Human\Thunderclap\ThunderclapTarget.mdl
    • Set StunEffAtt = overhead

• RunStun
  • Events
  • Conditions
  • Actions
    • -------- Set those 2variables with wanted values (stun duration and stunned unit). --------
    • Set TempReal = 0.00
    • Set TempUnit = No unit
    • -------- Set this one to the desired special stun effect (if you want the normal stun effect, don't add it in your trigger) + its attachement point. --------
    • Set StunEff = Abilities\Spells\Human\Thunderclap\ThunderclapTarget.mdl
    • Set StunEffAtt = overhead
    • -------- You can change this action for the checking/ignoring conditions if you want. --------
    • Trigger - Run StunStart <gen> (checking conditions)

• StunStart
  • Events
  • Conditions
  • Actions
    • Custom script: set udg_TempInt = GetHandleId(udg_TempUnit)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (TempUnit is in StunGroup) Equal to False
      • Then - Actions
        • Unit - Pause TempUnit
        • Unit Group - Add TempUnit to StunGroup
        • Hashtable - Save TempReal as 0 of TempInt in StunHash
        • Special Effect - Create a special effect attached to the StunEffAtt of TempUnit using StunEff
        • Hashtable - Save Handle Of(Last created special effect) as 1 of TempInt in StunHash
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (StunEnd <gen> is on) Equal to False
          • Then - Actions
            • Trigger - Turn on StunEnd <gen>
          • Else - Actions
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • TempReal Greater than (Load 0 of TempInt from StunHash)
          • Then - Actions
            • Hashtable - Save TempReal as 0 of TempInt in StunHash
            • Special Effect - Destroy (Load 1 of TempInt in StunHash)
            • Special Effect - Create a special effect attached to the StunEffAtt of TempUnit using StunEff
            • Hashtable - Save Handle Of(Last created special effect) as 1 of TempInt in StunHash
          • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • StunEff Not equal to Abilities\Spells\Human\Thunderclap\ThunderclapTarget.mdl
      • Then - Actions
        • Set StunEff = Abilities\Spells\Human\Thunderclap\ThunderclapTarget.mdl
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • StunEffAtt Not equal to overhead
      • Then - Actions
        • Set StunEffAtt = overhead
      • Else - Actions

• StunEnd
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in StunGroup and do (Actions)
      • Loop - Actions
        • Set TempUnit = (Picked unit)
        • Custom script: set udg_TempInt = GetHandleId(udg_TempUnit)
        • Hashtable - Save ((Load 0 of TempInt from StunHash) - 0.05) as 0 of TempInt in StunHash
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Load 0 of TempInt from StunHash) Less than or equal to 0.00
                • (TempUnit is dead) Equal to True
          • Then - Actions
            • Unit - Unpause TempUnit
            • Special Effect - Destroy (Load 1 of TempInt in StunHash)
            • Unit Group - Remove TempUnit from StunGroup
            • Hashtable - Clear all child hashtables of child TempInt in StunHash
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (StunGroup is empty) Equal to True
              • Then - Actions
                • Trigger - Turn off StunEnd <gen>
              • Else - Actions
          • Else - Actions

 

[Magtheridon96]

Okay, I'm going to give you a decent review:

• Trigger Snippet

  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • StunEff Not equal to Abilities\Spells\Human\Thunderclap\ThunderclapTarget.mdl
    • Then - Actions
      • Set StunEff = Abilities\Spells\Human\Thunderclap\ThunderclapTarget.mdl
    • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • StunEffAtt Not equal to overhead
    • Then - Actions
      • Set StunEffAtt = overhead
    • Else - Actions
  What's the purpose of this >=o
  It's hardcoded this way and makes no sense D:
  
• You should rename the TempVariables to understandable names to make the system more Beginner-friendly. (After all, beginners are often GUIers)
  
• You're stunning units incorrectly. You should never pause units like that, it's pretty buggy. You should use a stun ability that lasts forever and remove the stun buff after the duration ends.
  
• In StunStart, if a unit is already in the group, you shouldn't destroy the effect, create another effect and save it in the hashtable, just remove all that effect code because if the effect is still there and it's saved in the correct location in the hashtable, then it's redundant to destroy it and recreate it, then save it
  
  
  Trigger Snippet

  • Special Effect - Destroy (Load 1 of TempInt in StunHash)
  • Special Effect - Create a special effect attached to the StunEffAtt of TempUnit using StunEff
  • Hashtable - Save Handle Of(Last created special effect) as 1 of TempInt in StunHash
  That's gotta go my friend ^.^

 

[Vladadamm]

Okay, I'm going to give you a decent review:

• Trigger Snippet

  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • StunEff Not equal to Abilities\Spells\Human\Thunderclap\ThunderclapTarget.mdl
    • Then - Actions
      • Set StunEff = Abilities\Spells\Human\Thunderclap\ThunderclapTarget.mdl
    • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • StunEffAtt Not equal to overhead
    • Then - Actions
      • Set StunEffAtt = overhead
    • Else - Actions
  What's the purpose of this >=o
  It's hardcoded this way and makes no sense D:
  
• You should rename the TempVariables to understandable names to make the system more Beginner-friendly. (After all, beginners are often GUIers)
  
• You're stunning units incorrectly. You should never pause units like that, it's pretty buggy. You should use a stun ability that lasts forever and remove the stun buff after the duration ends.
  
• In StunStart, if a unit is already in the group, you shouldn't destroy the effect, create another effect and save it in the hashtable, just remove all that effect code because if the effect is still there and it's saved in the correct location in the hashtable, then it's redundant to destroy it and recreate it, then save it
  
  
  Trigger Snippet

  • Special Effect - Destroy (Load 1 of TempInt in StunHash)
  • Special Effect - Create a special effect attached to the StunEffAtt of TempUnit using StunEff
  • Hashtable - Save Handle Of(Last created special effect) as 1 of TempInt in StunHash
  That's gotta go my friend ^.^

• That's to reset the stun special effect to default.
• I forgot to say it in the description, but those TempVariables are replacable by the user's TempVariables he used in his map. The others variables aren't temp, it's why they're named Stun.
• It's not really a stun, but a sort of stun recreation. When you need to stun 20 units at same time, creating 1 dummy to stun each unit is not the best. The purpose of this system was to offer something else than dummies to stun units. Aren't some vjass/jass systems using pause too for this ? Only problem, imo, is the lack of buff.
• In StunStart, i did some rule for the effects. For example, if you stun twice an unit, you won't have 2 special effects. It's why only the special effect of the stun that ends the further in time is shown. So, in the case the new stun will end after the first one, i replace the stun special effect by the new one (destroying the old one and creating the new one)

 

[Magtheridon96]

That's to reset the stun special effect to default.

Oh I see, my bad. I was wrong.
In that case, you need to make a constant variable that's configurable called DefaultEffect (same for the attachment point)

It's not really a stun, but a sort of stun recreation. When you need to stun 20 units at same time, creating 1 dummy to stun each unit is not the best. The purpose of this system was to offer something else than dummies to stun units. Aren't some vjass/jass systems using pause too for this ? Only problem, imo, is the lack of buff.

Yes, some systems are using PauseUnit(), and that's why they're not approved
Pausing a unit creates bugs in all of the currently used UnitIndexers in very rare cases and it can create a lot of anomalies. If a unit is ordered while paused, some unwanted consequences will occur. (But, this needs tests, because I only remember unwanted consequences occuring while I was developing my map back in '10)

In StunStart, i did some rule for the effects. For example, if you stun twice an unit, you won't have 2 special effects. It's why only the special effect of the stun that ends the further in time is shown. So, in the case the new stun will end after the first one, i replace the stun special effect by the new one (destroying the old one and creating the new one)

Forget what I said. I just realized you can change the stun effect

 

[mckill2009]

instead of checking a unit group is empty and (StunEnd <gen> is on) Equal to False, which is slow, you could create an integer indexer to it

• If index equals 0 then
• Trigger - Turn on StunEnd <gen>
• endif
• set index = index + 1

• Hashtable - Clear all child hashtables of child TempInt in StunHash
• set index = index - 1
• If index equals 0 then
• Trigger - Turn off StunEnd <gen>
• endif

 

[Jazztastic]

Ordering a dummy unit to use a stunning ability on a 20+ targets will work, if the ability has a cooldown of 0. I use that method all the time for area of effect stuff. Plus a lot of spells use dummies for the visuals so manuevering dummies isn't really a gigantic problem.

Tbh this resource isn't worthwhile if the stuns aren't stackable. That's perhaps the most important thing a resource like this could do.

 

[Noobsmoke]

Isn't this already included in my Buff System ?

 

[Geries]

Don't forget that when you pause the unit you also remove all the command buttons, while at a normal stun you are still able to give commands to units which will be performed after stun ends.

 

[Vladadamm]

Name change (sry for the ASS as short name), the purpose of this is now to give a different stun than the normal one, with different properties.
Also, variables renamed.

 

[Kingz]

Don't we already have a GUI stun system?

Just curious what options does this offer that the other doesn't for it to be used over that one.
Not to dissaprove of you posting this here, you have to start somehow and this is quite nice for a first submission.

 

[Vladadamm]

Your curiosity could be satisfied by reading what i wrote in the description.

Also, that's not my first submission : http://www.hiveworkshop.com/forums/members/vladadamm/#userresources

 

[Kingz]

Here is my first system done for the public.

I was refering to this ^^

And other than you using pause which is wrong (mag explained why) and giving the option to attach custom effect i see nothing more, am i missing something?

You should point out the differences in a better way like:
"This system in addition to stunning the unit offers you also to: Attach a desired stun effect"

Making it easier for users to understand why to use this over the other one, else users will likely pass on to the more popular/downloaded version, as always.
Not that i mind reading that huge description, it could just use some better organisation and the blue color doesn't really do justice to letter on that background color.

 

[baassee]

The dummy Stun ability should be Orc Warlock's Firebolt 'cause that one works through magic immune ^^

 

[Vladadamm]

What dummy stun ability ? It's pause/unpause.

 

[baassee]

What dummy stun ability ? It's pause/unpause.

Well you should use a stun ability ^^ Pause/Unpause sucks as stun (no offense but facts)

 

[Magtheridon96]

He suggested to make this an alternate stun system, meaning the whole point is to use Pause/Unpause.

I still don't know if it's acceptable.
There are a ton of other rejected stun systems that do the exact same thing.

 

[baassee]

Well now I feel pretty old but "back in the days" we never approved due to the clashing possibilities of Pause/Unpause which would make this system either malfunction completly or just screw up its purpose.

 

[Magtheridon96]

function PauseUnitEx takes unit u, boolean b returns nothing
    local integer id = GetUnitUserData(u)
    if (b) then
        set paused[id] = paused[id] + 1
        if paused[id] == 1 then
            call PauseUnit(u, true)
        endif
    else
        set paused[id] = paused[id] - 1
        if paused[id] == 0 then
            call PauseUnit(u, false)
        endif
    endif
endfunction

There we go.

 

[baassee]

function PauseUnitEx takes unit u, boolean b returns nothing
    local integer id = GetUnitUserData(u)
    if (b) then
        set paused[id] = paused[id] + 1
        if paused[id] == 1 then
            call PauseUnit(u, true)
        endif
    else
        set paused[id] = paused[id] - 1
        if paused[id] == 0 then
            call PauseUnit(u, false)
        endif
    endif
endfunction

There we go.

Now it just looks like some sort of StackUtils that J4L made a long time ago ^^ and then it should have a namechange AFAIK or tell some warnings about this

Because pausing sucks - if you try issuing orders to a paused unit, it doesn't register at all. If you try issuing orders to a stunned unit, it actually changes the order the unit will return to after stun. So if you're playing a game where you have one second delay, and you're running into a battle and get stunned and realise you need to get the hell out, you're screwed if the author was lazy and used Pause.

 

[Magtheridon96]

I guess that is a good reason why not to use "PauseUnit" for stuns.

The PauseUnitEx function that I put up may solve the stacking problem, but we're going to need a whole other OrderQueue system to fix the orders problem.

 

[Vladadamm]

It can be a good reason to use "PauseUnit" for stuns. Firstly, with bots, or vck, lc and such you have really less delay than before.
Imo, that's not a problem, that's just a difference.

 

[baassee]

It's about orders man. I dont have 1000 apm ^^