[JASS] Looping over players

[eejin]

Hi, i was wondering why the following snippet doesn't seem to work. I'd expect it to work for all players, but it doesn't seem to do anything.

function Trig_Add_Strength_Actions takes nothing returns nothing
    call DisplayTextToPlayer(Player(0),0,0,"You just pressed ESC")
endfunction

//===========================================================================
function InitTrig_Add_Strength takes nothing returns nothing
    local integer i = 0
    set gg_trg_Untitled_Trigger_001_Copy = CreateTrigger()
    loop
        exitwhen (i > 9)
        set i = i + 1
        call TriggerRegisterPlayerChatEvent( gg_trg_Untitled_Trigger_001_Copy, Player(i), "-str", false )
    endloop
    call TriggerAddAction( gg_trg_Untitled_Trigger_001_Copy, function Trig_Untitled_Trigger_001_Copy_Actions )
endfunction

Also I get this syntax error, but it works fine ingame:

 

[TriggerHappy]

The trigger you create in the trigger editor must be named "Add Strength".

The snippet you posted isn't even the same code that's show in the errors.

Your trigger is named gg_trg_Untitled_Trigger_001_Copy.

Btw, Player starts at zero.

 

[Dr Super Good]

Also I get this syntax error, but it works fine ingame:

Any syntax error means it will not work fine in game as the map script failed to build properly or certain triggers have been forcefully disabled.

The syntax error points towards you having renamed some custom script GUI trigger elements without changing the standard function and variable names to match the new trigger. As such the map initialization function might be failing to call the trigger initialization function, the initialization functions might be defined twice which is not valid JASS, or a variable that does not exist is accessed.

The error you are showing does not translate to the trigger you posted above. It is showing a completely different trigger.

 

[Wietlol]

It could almost have been the same though.
Remember how C++ optimizer unfolds constant loops?
Apart from the names and 1-9 instead of 0-9, it would have been the same.

 

[eejin]

The error you are showing does not translate to the trigger you posted above. It is showing a completely different trigger.

Yes the error is for the same function but then written without the loop. I was a unclear about that.

function Trig_Add_Strength_Actions takes nothing returns nothing
    call DisplayTextToPlayer(Player(0),0,0,SubString(GetEventPlayerChatString(), 5, StringLength(GetEventPlayerChatString())))
endfunction

//===========================================================================
function InitTrig_Add_Strength takes nothing returns nothing
    local integer i = 0
    set gg_trg_Add_Strength = CreateTrigger()
    loop
        exitwhen (i > 9)
        call TriggerRegisterPlayerChatEvent( gg_trg_Add_Strength, Player(i), "-str", false )
        set i = i + 1
    endloop
    call TriggerAddAction( gg_trg_Add_Strength, function Trig_Add_Strength_Actions )
endfunction

It works as that it displays anything behind the "-str", but it stil gives me:

Btw, is there a better way to do chat commands? It seems like there should be some built in functionailty for it, but I can't find it.

 

[Dr Super Good]

It works as that it displays anything behind the "-str", but it stil gives me:

If you are using JNGP you need to turn off the standard World Edit syntax check.

That syntax error is saying the variable you are trying to assign to does not exist.