[JASS] Whats up with this simple loop?

[Anachron]

function FB_Actions takes nothing returns nothing
local unit u = GetTriggerUnit()
local location l = GetSpellTargetLoc()
local real x
local real y
local real X
local real Y
local integer loop1int = 0
local integer loop1end = 1
local location h
local effect e
local location o
local real f
local real r

set X = GetUnitX(u)
set Y = GetUnitY(u)
set h = Location(X,Y)
set loop1end = R2I(DistanceBetweenPoints(h,l) / 64.00)
set f = AngleBetweenPoints(h,l)
call RemoveLocation(h)
call RemoveLocation(l)

call DisplayTextToPlayer(Player(0),0,0,I2S(loop1int))
call DisplayTextToPlayer(Player(0),0,0,I2S(loop1end))

set loop1int = 0
loop
    exitwhen loop1int > loop1end
    set loop1int = loop1int + 1
    set r = r + 64.00
    set o = Location(X,Y)
    set h = PolarProjectionBJ(o,r,f)
    set x = GetLocationX(h)
    set y = GetLocationY(h)
    call RemoveLocation(h)
    call RemoveLocation(o)
    set e = AddSpecialEffect("Abilities\\Weapons\\ZigguratFrostMissile\\ZigguratFrostMissile.mdl",x,y)
    call TriggerSleepAction(0.10)
    call DestroyEffect(e)
    call DisplayTextToPlayer(Player(0),0,0,I2S(loop1int))
endloop

call DisplayTextToPlayer(Player(0),0,0,"Cleared!")
set u = null
endfunction

function FB_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A00J' 
endfunction
//===========================================================================
function InitTrig_FB takes nothing returns nothing
    local trigger gg_trg_FB = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_FB, EVENT_PLAYER_UNIT_SPELL_CAST )
    call TriggerAddCondition( gg_trg_FB, Condition( function FB_Conditions ) )
    call TriggerAddAction( gg_trg_FB, function FB_Actions )
endfunction

why doesn't this work? I've tried many things, the spell is based of shockwave and everything works, exepct that it stops at the loop?!?!?!

 

[Troll-Brain]

r is not initialised
so use it

set r = r + 64.00

stop the function

 

[Anachron]

Great! Thanks! I simply didn't see that

 

[Troll-Brain]

you create also the same location in the loop, instead of simply use the same (o)
and because you use locations why you don't use this function instead :
AddSpecialEffectLoc

 

[PurplePoot]

Or why not just not use locations and BJs (PolarProjectionBJ, DistanceBetwenPoints, AngleBetweenPoints) altogether?

For reference (all in Jass syntax in terms of functions) --

Project a point towards a specified angle, a specific distance -

newX = oldX + distance * Cos(angle)
newY = oldY + distance * Sin(angle)

angle is measured in radians. (Degrees can be converted to radians via 3.14159/180 * angle, with angle in degrees)

Find the angle of the slope of a line, given two points on that line -

angle = Atan2(y2-y1,x2-x1)

Where angle is measured in radians, and the angle found is the angle from x1/y1 to x2/y2

Find the distance between two arbitrary points -

distance = SquareRoot((x2-x1)*(x2-x1) + (y2-y1)*(y2-y1))

Since the values are squared, the order of x1/y1 and x2/y2 does not matter, as long as it is consistent.

 

[Anachron]

Great Purple thanks alot! Now I can do even more anti BJ! <3

 

[Ciebron]

just a little hint

call TriggerSleepAction(0.10)

has a minimum time of 0.3 if im correct so if u want smaller waits then that you have to use a timer which can go as low as 0.035 (lower i think but not recommended)

 

[Anachron]

The minimum is 0.1, not 0.3. Thats why I've used it lal.

 

[PurplePoot]

It's .27 (for .01+) to my knowledge, and shorter if you use 0, although it has a slight random variation.

 

[Anachron]

Yupp but I haven't worked with timers until yet I will learn them later or this weekend I think

 

[Ciebron]

.27 same as .3 for the human eye :>

 

[Flame_Phoenix]

Guys, sleeps minimum value is of 0.27.
However, when inserted into loops it can reach values such as 0.07 or 0.05 (I used it on my linear bombard system which i am remaking).

 

[Ciebron]

dont think so because your bombs fall slooooww, even thou are they fun as hell

 

[Flame_Phoenix]

Lol, the problem is not on the bombs. The fade in and fade out, per example, among many other things, use waits with values lower than 0.20
I just make bombs fall slow because i like them that way =)
But I will soon try to improve it into a full system =)

 

[Anachron]

Lol you are talking about other systems in a single jass question?