[JASS] why my we crash?

[machris13]

i hate to say there are errors

function a takes nothing returns nothing
    local unit u
    local integer i
    local real x
    local real y
    local location l
    local integer i2
    local real w = 0

    loop
        set x = GetLocationX(GetRectCenter(gg_rct_1))
        set y = GetLocationY(GetRectCenter(gg_rct_1))
        set u = CreateUnit( player(1), 'hfoo', x, y, 0.)//syntax!!!
        set x = GetLocationX(GetRectCenter(gg_rct_2))
        set y = GetLocationY(GetRectCenter(gg_rct_2))
        set l = Location(x, y)
        call IssuePointOrderLocBJ( u, "attack", l )
        call RemoveLocation( l )
        set l = null
        set u = null
        if i2 == 3 then
            set x = GetLocationX(GetRectCenter(gg_rct_1))
            set y = GetLocationY(GetRectCenter(gg_rct_1))
            set u = CreateUnit( Player(1), 'hrif', x, y, 0.)
            set x = GetLocationX(GetRectCenter(gg_rct_2))
            set y = GetLocationY(GetRectCenter(gg_rct_2))
            set l = Location(x, y)
            call IssuePointOrderLocBJ( u, "attack", l )
            call RemoveLocation( l )
            set u = null
            set l = null
            set i2 = 0
            set w = 30
        else
        endif
        exitwhen i == 5
        set i = 0
        set i2 = i2 + 1
        call TriggerSleepAction( w )
    endloop

endfunction

function InitTrig_a takes nothing returns nothing
    set gg_trg_a = CreateTrigger(   )
    call TriggerAddAction( gg_trg_a, function a )
endfunction

i make a loop that never ends, is that alright?

 

[M0RT]

There are several errors:
- player(1) should be Player(1)
- The loop is infinite, you propably wanted to test i2 == 5
- You leak 4 locations

set x = GetLocationX(GetRectCenter(gg_rct_1))
set y = GetLocationY(GetRectCenter(gg_rct_1))
set u = CreateUnit( Player(1), 'hrif', x, y, 0.)
set x = GetLocationX(GetRectCenter(gg_rct_2))
set y = GetLocationY(GetRectCenter(gg_rct_2))
set l = Location(x, y)
call IssuePointOrderLocBJ( u, "attack", l )
call RemoveLocation( l )

should look like this:

set u = CreateUnit( Player(1), 'hrif', GetRectCenterX(gg_rct_1), GetRectCenterY(gg_rct_1), 0.)
call IssuePointOrder( u, "attack", GetRectCenterX(gg_rct_2), GetRectCenterY(gg_rct_2) )

 

[machris13]

ok i'll try it,..
can you post the whole jass trigger?
so i wont be confused..please?

 

[M0RT]

Propably this:

function a takes nothing returns nothing
    local unit u
    local integer i2 = 0
    loop
        set u = CreateUnit( Player(1), 'hfoo', GetRectCenterX(gg_rct_1), GetRectCenterY(gg_rct_1), 0.)
        call IssuePointOrder( u, "attack", GetRectCenterX(gg_rct_2), GetRectCenterY(gg_rct_2) )
        if i2 == 3 then
            set u = CreateUnit( Player(1), 'hrif', GetRectCenterX(gg_rct_1), GetRectCenterY(gg_rct_1), 0.)
            call IssuePointOrder( u, "attack", GetRectCenterX(gg_rct_2), GetRectCenterY(gg_rct_2) )
            call TriggerSleepAction( 30 )
        endif
        exitwhen i == 5
        set i2 = i2 + 1
    endloop
    set u = null
endfunction

function InitTrig_a takes nothing returns nothing
    set gg_trg_a = CreateTrigger(   )
    call TriggerAddAction( gg_trg_a, function a )
endfunction

But I not sure what this trigger is supposed to do exactly, so maybe I did some wrong changes. This will spawn 2 'hfoo's and one 'hrif', wait 30 second and spawn two more 'hfoo's

 

[machris13]

can you make it 3 ?
i want 3 hfoo to be created...

thanks by the way!

Edit: NVM dude, i know what to change, thanks by the way!

EDIT: DUDE my wc3 crashes when the second wave comes.!!!

 

[M0RT]

Sorry, it actually makes 4 hfoos. (it makes 6 hfoos total).
If you want to change that, change the parameters of the loop.
Now it loops 6 times, from 0 to 6, making hrif and stopping at 3 (after 4 hfoos are spawned).
If you want to make 3-3 hfoos instead of 4-2, change the condition to i2 == 2