Lightning Storm v1.`

[Moderator]

09:06, 2nd Aug 2012
Magtheridon96: Approved. You didn't really need that extra complexity with the booleans, but it's totally fine in my book.
Good job.
The configuration is decent too.

 

[Jazztastic]

My first submission to the Legendary Fight.

I believe it is customizable enough, and it works. Comment with any suggestions/bugs you find, and I'll be sure to address them.

 

[Magtheridon96]

The target variable thingamajig leaks D:

 

[Kingz]

This could be further optimized by removing the use of locations altogether.

For example, declare locals:

• Custom script: local real x
• Custom script: local real y
• Custom script: local real tx
• Custom script: local real ty

Then in loop:

• Custom script: set x = GetUnitX(udg_caster)
• Custom script set y = GetUnitY(udg_caster)
• Custom script: set tx = GetUnitX(udg_target)
• Custom script set ty = GetUnitY(udg_target)

Then use those coordinates how you see fit.

Edit:

• (Units within areaofeffect[level] of point1 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to

I am pretty sure this leaks a group also.

 

[Jazztastic]

Updated. Fixed the leak from the unit group and optimized it by using GetUnitX/Y rather than the location (although I still had to have them for the Z). I also included Kingz recommendation for special effects.

EDIT: I changed the order of the loop. This way, it'll only check if it is channeling every other cycle (only when it's being created). It will be more efficient and work better. It will also make sure the loop doesnt stop before the last lightning is destroyed, and it wont destroy a lightning before it's created. I also added in the Order ID as a string for the user to change. Finally, I fixed the triggering unit in the cast trigger. This should be ready for approval unless I incorrectly changed the loop.

 

[SpectreD]

Seems nice well done

 

[Erkki2]

Creative use of lightning effects, it looks very realistic. +rep

 

[Marcos DAB]

Should use damage detection to destroy real value of mana based in target's armor.

 

[.OmG.]

Should use damage detection to destroy real value of mana based in target's armor.

I agree, so hero will take less damage then mana burn. Or just Improve description

 

[Kingz]

Or you know...

if GetUnitState(u, UNIT_STATE_MANA) < Damage then
 call UnitDamageTarget(caster, u, GetUnitState(u, UNIT_STATE_MANA), ...)
 call SetUnitState(u, UNIT_STATE_MANA, 0)
else
 call UnitDamageTarget(caster, u, Damage, ...)
 call SetUnitState(u, UNIT_STATE_MANA, GetUnitState(u, UNIT_STATE_MANA) - Damage)
endif

A simple if/then/else statement could do it also.
I know it's in jass but i can't remember the statements in GUI.

 

[Jazztastic]

Or simply make the damage chaos and universal so it deals exact.

 

[Sunreaver]

Sometimes this crash can u tell me the problem