Lightning Storm(new)

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

08:38, 15th Jun 2010
Hanky:
I found some stuff that should be improved:
- null locals otherwise they'll leak
- to hardcode rawcodes isn't a good idea, newbies will have problems importing your spell
- if you write that much stuff in custom script why not writing the whole spell just in jass?
- also you hardcoded the effects, that should be changed

That's all I found for now. When you have fixed those stuff message me or one of the other spell moderators.

 

[The-Rave]

testing... mmm..

 

[deth_lord]

that was a fast post

 

[Chief-Oblivion]

Pretty fun to use but I don't know if it will be accepted because you used paladon's system. also it's not mui.

 

[deth_lord]

as this is my first i don't know what mui is explain T.T

 

[The-Rave]

warning! lightning strom created!
good, but i think it's can be rejected.. hope it's not!

 

[Lambdadelta]

Then you should perhaps revise the rule a bit more.

 

[Demongrip]

Just look at the tutorials section and find what helps you most.I use this one for my spells-http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/dynamic-values-storage-121558/

 

[deth_lord]

if thats the case this is mui... it's also a system not really meant to be a "spell" perchance i'm using it as weather in my map and i noticed no one else has made this. You can take this and turn it into a spell, or keep it as a weather system if you wish. As long as you give me and Paladon credit because it uses some of his stuff.

 

[Chief-Oblivion]

Demon grip either doesn't know what he's talking about or he worded that wrong.

MUI - Multi Unit Instancable means that any amount of units can use the spell at the EXACT same time, and it still functions correctly.

that tutorial he posted is indeed a good tutorial I would reference it.

 

[Demongrip]

Maybe I explained it on way that can`t be understood very well but nevermind
Chief oblivion explained it in the most simple and best way.

 

[Chief-Oblivion]

Yeah, that was just the basic MUI, there are also small aspects that are explained in the tutorial that can compromise whether it's mui or not.

 

[deth_lord]

this spell is mui still by your explanation.

 

[Chief-Oblivion]

=/ I can name a few things that make it not mui just off this trigger.

• Lightning Strike
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Lightning Strike (LS)
  • Actions
    • Set LS_TempPoint[1] = (Position of (Triggering unit))
    • Set LS_TempPoint[2] = (Target point of ability being cast)
    • Set LS_TempPoint[3] = (LS_TempPoint[2] offset by (Random real number between

I am referencing simply the set triggers at the top.

Set LS_TempPoint[1] = (Position of (Triggering unit)) - Setting that point, if another unit uses the ability at the same time it will set it to the point of only one of the units.

Set LS_TempPoint[2] = (Target point of ability being cast) - Yet again, it will set it to only one of the units.

Those are only two, I can name more but I am pretty lazy.

 

[The-Rave]

=/ I can name a few things that make it not mui just off this trigger.

• Lightning Strike
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Lightning Strike (LS)
  • Actions
    • Set LS_TempPoint[1] = (Position of (Triggering unit))
    • Set LS_TempPoint[2] = (Target point of ability being cast)
    • Set LS_TempPoint[3] = (LS_TempPoint[2] offset by (Random real number between

I am referencing simply the set triggers at the top.

Set LS_TempPoint[1] = (Position of (Triggering unit)) - Setting that point, if another unit uses the ability at the same time it will set it to the point of only one of the units.

Set LS_TempPoint[2] = (Target point of ability being cast) - Yet again, it will set it to only one of the units.

Those are only two, I can name more but I am pretty lazy.

it's can be correcting by using local variable, right?

 

[Chief-Oblivion]

Hell if I know, I know how to find them not how to fix them. ;D That's why I don't spell make anymore. Plus it's alot of work.

 

[deth_lord]

true that bro T.T

but i just updated spell. it uses some local vars now (even though there was no problems i'll still do it for you guys *rolls eyes*)

 

[Hanky]

*cough* null locals *cough*

Also having a periodic trigger all time active isn't a good thing...

 

[Darkyvm]

Darkyvm

Lightning Storm(new)

[+] MUI.
[+] Special effects used fit the spell nicely. The random lightning storms around the map are also a nice bonus.
[+] Spell runs smoothly and doesn't lag, even when there are many being cast at once.
[+] Good, simple, and easy to understand readme section.
[+-] The lightning looks a bit weird if you cast it somewhere far away.
[+-] Some BJs used in custom script could've been inlined.
[-] After you remove locations / destroy groups, the leak is still there, you still need to null the variable.
[-] Can't modify damage / radius vaules without having to edit the spell's core.
[-] Not so original, already seen some similar spells somewhere around here.

Inline the BJs to increase efficiency, and if possible, make the spell's damage / radius vaules easier to modify, some people might not be able to identify where are those vaules in the code and not be able to change them (yes, believe me, there are people that can't even understand a simple GUI code, you have to think about everyone that might want to use your spell). Also, null the locals.

3/5 - Good.

 

[deth_lord]

if you can't figure out simple gui you probably shouldn't be mapping :/ but alas, i will probably change it.