1. Are you planning to upload your awesome spell or system to Hive? Please review the rules here.
    Dismiss Notice
  2. Find your way through the deepest dungeon in the 18th Mini Mapping Contest Poll.
    Dismiss Notice
  3. A brave new world lies beyond the seven seas. Join the 34th Modeling Contest today!
    Dismiss Notice
  4. Check out the Staff job openings thread.
    Dismiss Notice
Dismiss Notice
Hive 3 Remoosed BETA - NOW LIVE. Go check it out at BETA Hive Workshop! Post your feedback in this new forum BETA Feedback.
Dismiss Notice
60,000 passwords have been reset on July 8, 2019. If you cannot login, read this.

Lightning Storm(new)

Submitted by deth_lord
This bundle is marked as substandard. It may contain bugs, not perform optimally or otherwise be in violation of the submission rules.
This is a storm system useful for some maps as an added "bonus" if you would say. Every X seconds a storm has a 50% chance of being created. If created the location is pinged and a storm starts in the area. The current area used is small to give a greater feel for it. The area will become a stormy weather system also that is destroyed when the storm ends which is decided by the user with some changes. The bolts themselves deal around 200 damage to buildings and 30% of their max hp in an area of 400 around the bolt. The bolt angle and location is random inside the area. Units in an area of 300 hit by the bolt have a chance to instantly die, and if they don't they take 20% of their max hp in damage and are then knocked back.

This spell was enhanced by me to become a storm but the original "bolt" was made by Paladon.

There are no leaks to this system so far as tested by me.

This is my first attempt at a spell and all of it is in GUI, I'm so sorry for you JASS fans... :p

Updated:
-Changed many of the variable uses to local variables
-put more creeps on the map and spread them out so it's easier to test
-Patched up one leak i found (no one else found it though thank goodness) :D

Keywords:
lightning, storm, storm system, system, lightning storm, lightning storm system, deth_lord, Bob marley
Contents

Lightning Storm (Map)

Reviews
Moderator
12th Dec 2015 IcemanBo: Too long time as NeedsFix. Rejected. 08:38, 15th Jun 2010 Hanky: I found some stuff that should be improved: - null locals otherwise they'll leak - to hardcode rawcodes isn't a good idea, newbies will have problems...
  1. 12th Dec 2015
    IcemanBo: Too long time as NeedsFix. Rejected.

    08:38, 15th Jun 2010
    Hanky:
    I found some stuff that should be improved:
    - null locals otherwise they'll leak
    - to hardcode rawcodes isn't a good idea, newbies will have problems importing your spell
    - if you write that much stuff in custom script why not writing the whole spell just in jass?
    - also you hardcoded the effects, that should be changed

    That's all I found for now. When you have fixed those stuff message me or one of the other spell moderators.
     
  2. The-Rave

    The-Rave

    Joined:
    Aug 26, 2009
    Messages:
    202
    Resources:
    0
    Resources:
    0
    testing... mmm..
     
  3. deth_lord

    deth_lord

    Joined:
    Jun 25, 2009
    Messages:
    47
    Resources:
    2
    Maps:
    1
    Spells:
    1
    Resources:
    2
    that was a fast post :p
     
  4. Chief-Oblivion

    Chief-Oblivion

    Joined:
    Mar 20, 2008
    Messages:
    458
    Resources:
    0
    Resources:
    0
    Pretty fun to use but I don't know if it will be accepted because you used paladon's system. also it's not mui.
     
  5. deth_lord

    deth_lord

    Joined:
    Jun 25, 2009
    Messages:
    47
    Resources:
    2
    Maps:
    1
    Spells:
    1
    Resources:
    2
    as this is my first i don't know what mui is explain T.T
     
  6. The-Rave

    The-Rave

    Joined:
    Aug 26, 2009
    Messages:
    202
    Resources:
    0
    Resources:
    0
    warning! lightning strom created!
    good, but i think it's can be rejected.. hope it's not!
     
  7. Lambdadelta

    Lambdadelta

    Joined:
    Jul 6, 2009
    Messages:
    721
    Resources:
    1
    Maps:
    1
    Resources:
    1
    Then you should perhaps revise the rule a bit more.
     
  8. Demongrip

    Demongrip

    Joined:
    Sep 8, 2009
    Messages:
    80
    Resources:
    6
    Spells:
    6
    Resources:
    6
    Last edited: Sep 17, 2009
  9. deth_lord

    deth_lord

    Joined:
    Jun 25, 2009
    Messages:
    47
    Resources:
    2
    Maps:
    1
    Spells:
    1
    Resources:
    2
    if thats the case this is mui... it's also a system not really meant to be a "spell" perchance i'm using it as weather in my map and i noticed no one else has made this. You can take this and turn it into a spell, or keep it as a weather system if you wish. As long as you give me and Paladon credit because it uses some of his stuff.
     
  10. Chief-Oblivion

    Chief-Oblivion

    Joined:
    Mar 20, 2008
    Messages:
    458
    Resources:
    0
    Resources:
    0
    Demon grip either doesn't know what he's talking about or he worded that wrong.

    MUI - Multi Unit Instancable means that any amount of units can use the spell at the EXACT same time, and it still functions correctly.

    that tutorial he posted is indeed a good tutorial I would reference it.
     
  11. Demongrip

    Demongrip

    Joined:
    Sep 8, 2009
    Messages:
    80
    Resources:
    6
    Spells:
    6
    Resources:
    6
    Maybe I explained it on way that can`t be understood very well but nevermind :)
    Chief oblivion explained it in the most simple and best way.
     
    Last edited: Sep 17, 2009
  12. Chief-Oblivion

    Chief-Oblivion

    Joined:
    Mar 20, 2008
    Messages:
    458
    Resources:
    0
    Resources:
    0
    Yeah, that was just the basic MUI, there are also small aspects that are explained in the tutorial that can compromise whether it's mui or not.
     
  13. deth_lord

    deth_lord

    Joined:
    Jun 25, 2009
    Messages:
    47
    Resources:
    2
    Maps:
    1
    Spells:
    1
    Resources:
    2
    this spell is mui still by your explanation.
     
  14. Chief-Oblivion

    Chief-Oblivion

    Joined:
    Mar 20, 2008
    Messages:
    458
    Resources:
    0
    Resources:
    0
    =/ I can name a few things that make it not mui just off this trigger.

    • Lightning Strike
      • Events
        • Unit - A unit Begins casting an ability
      • Conditions
        • (Ability being cast) Equal to Lightning Strike (LS)
      • Actions
        • Set LS_TempPoint[1] = (Position of (Triggering unit))
        • Set LS_TempPoint[2] = (Target point of ability being cast)
        • Set LS_TempPoint[3] = (LS_TempPoint[2] offset by (Random real number between


    I am referencing simply the set triggers at the top.

    Set LS_TempPoint[1] = (Position of (Triggering unit)) - Setting that point, if another unit uses the ability at the same time it will set it to the point of only one of the units.

    Set LS_TempPoint[2] = (Target point of ability being cast) - Yet again, it will set it to only one of the units.

    Those are only two, I can name more but I am pretty lazy.
     
  15. The-Rave

    The-Rave

    Joined:
    Aug 26, 2009
    Messages:
    202
    Resources:
    0
    Resources:
    0
    it's can be correcting by using local variable, right?
     
  16. Chief-Oblivion

    Chief-Oblivion

    Joined:
    Mar 20, 2008
    Messages:
    458
    Resources:
    0
    Resources:
    0
    Hell if I know, I know how to find them not how to fix them. ;D That's why I don't spell make anymore. Plus it's alot of work.
     
  17. deth_lord

    deth_lord

    Joined:
    Jun 25, 2009
    Messages:
    47
    Resources:
    2
    Maps:
    1
    Spells:
    1
    Resources:
    2
    true that bro T.T

    but i just updated spell. it uses some local vars now (even though there was no problems i'll still do it for you guys *rolls eyes*) :p
     
  18. Hanky

    Hanky

    Joined:
    Jan 15, 2007
    Messages:
    353
    Resources:
    4
    Maps:
    1
    Spells:
    3
    Resources:
    4
    *cough* null locals *cough*

    Also having a periodic trigger all time active isn't a good thing...
     
  19. Darkyvm

    Darkyvm

    Joined:
    May 16, 2007
    Messages:
    202
    Resources:
    1
    Spells:
    1
    Resources:
    1
    Review


    Reviewed by
    Darkyvm


    Reviewed Version
    Lightning Storm(new)


    Reviewing Points
    [+] MUI.
    [+] Special effects used fit the spell nicely. The random lightning storms around the map are also a nice bonus.
    [+] Spell runs smoothly and doesn't lag, even when there are many being cast at once.
    [+] Good, simple, and easy to understand readme section.
    [+-] The lightning looks a bit weird if you cast it somewhere far away.
    [+-] Some BJs used in custom script could've been inlined.
    [-] After you remove locations / destroy groups, the leak is still there, you still need to null the variable.
    [-] Can't modify damage / radius vaules without having to edit the spell's core.
    [-] Not so original, already seen some similar spells somewhere around here.


    Suggestions
    Inline the BJs to increase efficiency, and if possible, make the spell's damage / radius vaules easier to modify, some people might not be able to identify where are those vaules in the code and not be able to change them (yes, believe me, there are people that can't even understand a simple GUI code, you have to think about everyone that might want to use your spell). Also, null the locals.


    Rating
    3/5 - Good.