[JASS] JassNewGenPack glitch.

NiddHogg-kun · Apr 15, 2010

I dont really understand why this happens.

Well who did i recognize it?
When you save a map - after all normal WE save - JASSHepler checks vJASS syntax and etc.

Here's version that worked perfect:

JASS:

library Dash initializer InitDash uses IsTerrainWalkable
globals
private constant real               speed = 12
private constant integer            distance = 400
private constant integer            dpl = 120
private constant integer            ID = 'A001'
private constant integer            BID = 'B000'
private constant string             SFX = "Abilities\\Spells\\Other\\StrongDrink\\BrewmasterMissile.mdl"


timer T = CreateTimer()
real x
real y
real x2
real y2
rect r


endglobals

struct Movement

unit u
real angle
real dis
real sp

static Movement array Index
static integer Total = 0



static method Move takes nothing returns nothing
local Movement dat

local integer i = 0
    loop
        exitwhen i >= dat.Total
        set dat = dat.Index[i]
        
        set x = GetUnitX(dat.u)
        set y = GetUnitY(dat.u)
        
        set x2 = x + (Cos(dat.angle * bj_DEGTORAD)*(dat.sp+40))
        set y2 = y + (Sin(dat.angle * bj_DEGTORAD)*(dat.sp+40))
        
        
        if IsTerrainWalkable(x2,y2) then
            call SetUnitX(dat.u, x + (Cos(dat.angle * bj_DEGTORAD)*dat.sp))
            call SetUnitY(dat.u, y + (Sin(dat.angle * bj_DEGTORAD)*dat.sp))
            call IssueImmediateOrder(dat.u, "stop")
            call DestroyEffect(AddSpecialEffect(SFX,x,y))
            
            
        else
            set dat.dis = -150
        endif
    
        
        set dat.dis = dat.dis - dat.sp
        set dat.sp = dat.sp + 1
        
        if dat.dis <= 0 then
        call SetUnitPathing(dat.u, true)
        call UnitRemoveAbility(dat.u,BID)
        
        call dat.destroy()
        set dat.Total = dat.Total - 1
        set dat.Index[i] = dat.Index[dat.Total]
        set i = i - 1
        
        endif
        
    set i = i  + 1
    if dat.Total == 0 then
      call PauseTimer(T)
    endif
    endloop
    
    
endmethod


static method Start takes nothing returns nothing
    local Movement dat = Movement.allocate()
    
    if dat.Total == 0 then
    call TimerStart(T,0.02,true,function Movement.Move)
    endif
    
    set dat.u = GetTriggerUnit()
    set dat.angle = GetUnitFacing(dat.u)
    set dat.sp = speed
    set dat.dis = distance+(120*GetUnitAbilityLevel(dat.u,ID))
    call SetUnitPathing(dat.u, false)
    set dat.Index[dat.Total] = dat
    set dat.Total = dat.Total + 1
endmethod

endstruct

private function Check takes nothing returns boolean
    return GetSpellAbilityId() == ID
endfunction 



private function InitDash takes nothing returns nothing
    local trigger t = CreateTrigger()
    local integer i = 0
    loop
            exitwhen i == bj_MAX_PLAYER_SLOTS
            call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
            set i =i+1
    endloop
    
    call TriggerAddAction(t, function Movement.Start)
    call TriggerAddCondition(t, Filter( function Check))
    
endfunction



endlibrary

Now after i edited a bit to destroy trees around caster and i got this:

JASS:

library Dash initializer InitDash uses IsTerrainWalkable
globals
private constant real               speed = 12
private constant integer            distance = 400
private constant integer            dpl = 120
private constant integer            ID = 'A001'
private constant integer            BID = 'B000'
private constant string             SFX = "Abilities\\Spells\\Other\\StrongDrink\\BrewmasterMissile.mdl"


timer T = CreateTimer()
real x
real y
real x2
real y2
rect r


endglobals

struct Movement

unit u
real angle
real dis
real sp

static Movement array Index
static integer Total = 0



static method Move takes nothing returns nothing
local Movement dat

local integer i = 0
    loop
        exitwhen i >= dat.Total
        set dat = dat.Index[i]
        
        set x = GetUnitX(dat.u)
        set y = GetUnitY(dat.u)
        
        set x2 = x + (Cos(dat.angle * bj_DEGTORAD)*(dat.sp+40))
        set y2 = y + (Sin(dat.angle * bj_DEGTORAD)*(dat.sp+40))
        
        
        if IsTerrainWalkable(x2,y2) then
            call SetUnitX(dat.u, x + (Cos(dat.angle * bj_DEGTORAD)*dat.sp))
            call SetUnitY(dat.u, y + (Sin(dat.angle * bj_DEGTORAD)*dat.sp))
            call IssueImmediateOrder(dat.u, "stop")
            call DestroyEffect(AddSpecialEffect(SFX,x,y))
            
            
            set r = Rect( x2 - 200*0.5, y2 - 200*0.5, x2 + 200*0.5, y2 + 200*0.5 )
            call EnumDestructablesInRect(r, null, function Movement.KillDestruct)
            
            
        else
            set dat.dis = -150
        endif
    
        
        set dat.dis = dat.dis - dat.sp
        set dat.sp = dat.sp + 1
        
        if dat.dis <= 0 then
        call SetUnitPathing(dat.u, true)
        call UnitRemoveAbility(dat.u,BID)
        
        call dat.destroy()
        set dat.Total = dat.Total - 1
        set dat.Index[i] = dat.Index[dat.Total]
        set i = i - 1
        
        endif
        
    set i = i  + 1
    if dat.Total == 0 then
      call PauseTimer(T)
    endif
    endloop
    
    
endmethod


static method Start takes nothing returns nothing
    local Movement dat = Movement.allocate()
    
    if dat.Total == 0 then
    call TimerStart(T,0.02,true,function Movement.Move)
    endif
    
    set dat.u = GetTriggerUnit()
    set dat.angle = GetUnitFacing(dat.u)
    set dat.sp = speed
    set dat.dis = distance+(120*GetUnitAbilityLevel(dat.u,ID))
    call SetUnitPathing(dat.u, false)
    set dat.Index[dat.Total] = dat
    set dat.Total = dat.Total + 1
endmethod


static method KillDestruct takes nothing returns nothing
    call KillDestructable( GetEnumDestructable() )
endmethod

endstruct

private function Check takes nothing returns boolean
    return GetSpellAbilityId() == ID
endfunction 



private function InitDash takes nothing returns nothing
    local trigger t = CreateTrigger()
    local integer i = 0
    loop
            exitwhen i == bj_MAX_PLAYER_SLOTS
            call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
            set i =i+1
    endloop
    
    call TriggerAddAction(t, function Movement.Start)
    call TriggerAddCondition(t, Filter( function Check))
    
endfunction



endlibrary

or this:

JASS:

scope Dash initializer InitDash
globals
private constant real               speed = 12
private constant integer            distance = 400
private constant integer            dpl = 120
private constant integer            ID = 'A001'
private constant integer            BID = 'B000'
private constant string             SFX = "Abilities\\Spells\\Other\\StrongDrink\\BrewmasterMissile.mdl"


timer T = CreateTimer()
real x
real y
real x2
real y2


endglobals

struct Movement

unit u
real angle
real dis
real sp

static Movement array Index
static integer Total = 0



static method Move takes nothing returns nothing
local Movement dat

local integer i = 0
    loop
        exitwhen i >= dat.Total
        set dat = dat.Index[i]
        
        set x = GetUnitX(dat.u)
        set y = GetUnitY(dat.u)
        
        set x2 = x + (Cos(dat.angle * bj_DEGTORAD)*(dat.sp+40))
        set y2 = y + (Sin(dat.angle * bj_DEGTORAD)*(dat.sp+40))
        
        
        if IsTerrainWalkable(x2,y2) then
            call SetUnitX(dat.u, x + (Cos(dat.angle * bj_DEGTORAD)*dat.sp))
            call SetUnitY(dat.u, y + (Sin(dat.angle * bj_DEGTORAD)*dat.sp))
            call IssueImmediateOrder(dat.u, "stop")
            call DestroyEffect(AddSpecialEffect(SFX,x,y))
        else
            set dat.dis = -150
        endif
    
        
        set dat.dis = dat.dis - dat.sp
        set dat.sp = dat.sp + 1
        
        if dat.dis <= 0 then
        call SetUnitPathing(dat.u, true)
        call UnitRemoveAbility(dat.u,BID)
        
        call dat.destroy()
        set dat.Total = dat.Total - 1
        set dat.Index[i] = dat.Index[dat.Total]
        set i = i - 1
        
        endif
        
    set i = i  + 1
    if dat.Total == 0 then
      call PauseTimer(T)
    endif
    endloop
    
    
endmethod


static method Start takes nothing returns nothing
    local Movement dat = Movement.allocate()
    
    if dat.Total == 0 then
    call TimerStart(T,0.02,true,function Movement.Move)
    endif
    
    set dat.u = GetTriggerUnit()
    set dat.angle = GetUnitFacing(dat.u)
    set dat.sp = speed
    set dat.dis = distance+(120*GetUnitAbilityLevel(dat.u,ID))
    call SetUnitPathing(dat.u, false)
    set dat.Index[dat.Total] = dat
    set dat.Total = dat.Total + 1
endmethod

endstruct




private function Check takes nothing returns boolean
    return GetSpellAbilityId() == ID
endfunction 



private function InitDash takes nothing returns nothing
    local trigger t = CreateTrigger()
    local integer i = 0
    loop
            exitwhen i == bj_MAX_PLAYER_SLOTS
            call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
            set i =i+1
    endloop
    
    call TriggerAddAction(t, function Movement.Start)
    call TriggerAddCondition(t, Filter( function Check))
    
endfunction



endscope

JASSHelper doesnt do it's actions. It is just like normal WE saving.

I really nead your help.

EDIT:
after any changes to the spell - it doesnt work

Bribe · Apr 15, 2010

You just gave us 3 blocks of code that look almost completely identical. I don't want to play "find the difference between these pictures". Be more specific. What should these codes look like that you aren't satisfied with?

NiddHogg-kun · Apr 15, 2010

First example:
I added Tree Destroying while dashing.

JASS:

            set r = Rect( x2 - 200*0.5, y2 - 200*0.5, x2 + 200*0.5, y2 + 200*0.5 )
            call EnumDestructablesInRect(r, null, function Movement.KillDestruct)

also another method

JASS:

static method KillDestruct takes nothing returns nothing
    call KillDestructable( GetEnumDestructable() )
endmethod

Second example:
My friend told me that scopes are better for spells.
So insteed of Library i used Scope.

as i said - After any edit to the code - JASSHelper stops working

Pharaoh_ · Apr 15, 2010

Try killing the destructibles publicly, out of the struct.

NiddHogg-kun · Apr 15, 2010

Here is the spell.
try to save it in JNGP.

Anachron · Apr 15, 2010

I fixed up your code a bit

JASS:

scope Dash initializer InitDash
	globals
		private constant real		SPEED 	= 12
		private constant integer	DISTANCE 	= 400
		private constant integer	DPL 		= 120
		private constant integer	ID 		= 'A001'
		private constant integer	BID 		= 'B000'
		private constant string		SFX 		= "Abilities\\Spells\\Other\\StrongDrink\\BrewmasterMissile.mdl"
		
		
		private			timer		T			= CreateTimer()
		private			real 		x			= 0.
		private			real 		y			= 0.
		private			real 		x2			= 0.
		private			real 		y2			= 0.
	endglobals
	
	private struct Movement
		
		unit u
		real angle
		real dis
		real sp
		
		static thistype array Index
		static integer Total = 0
		
		static method Move takes nothing returns nothing
			local Movement dat
			local integer i = 0
			
			loop
			exitwhen i >= dat.Total
			set dat = dat.Index[i]
			
			set x = GetUnitX(dat.u)
			set y = GetUnitY(dat.u)
			
			set x2 = x + (Cos(dat.angle * bj_DEGTORAD)*(dat.sp+40))
			set y2 = y + (Sin(dat.angle * bj_DEGTORAD)*(dat.sp+40))
			
			
			if IsTerrainWalkable(x2,y2) then
				call SetUnitX(dat.u, x + (Cos(dat.angle * bj_DEGTORAD)*dat.sp))
				call SetUnitY(dat.u, y + (Sin(dat.angle * bj_DEGTORAD)*dat.sp))
				call IssueImmediateOrder(dat.u, "stop")
				call DestroyEffect(AddSpecialEffect(SFX,x,y))
			else
				set dat.dis = -150
			endif
			
			
			set dat.dis = dat.dis - dat.sp
			set dat.sp = dat.sp + 1
			
			if dat.dis <= 0 then
			call SetUnitPathing(dat.u, true)
			call UnitRemoveAbility(dat.u,BID)
			
			call dat.destroy()
			set dat.Total = dat.Total - 1
			set dat.Index[i] = dat.Index[dat.Total]
			set i = i - 1
			
			endif
			
			set i = i  + 1
			if dat.Total == 0 then
			  call PauseTimer(T)
			endif
			endloop
		endmethod
		
		static method Start takes nothing returns nothing
			local Movement dat = Movement.allocate()
			
			if dat.Total == 0 then
			call TimerStart(T,0.02,true,function Movement.Move)
			endif
			
			set dat.u = GetTriggerUnit()
			set dat.angle = GetUnitFacing(dat.u)
			set dat.sp = SPEED
			set dat.dis = distance+(120*GetUnitAbilityLevel(dat.u,ID))
			call SetUnitPathing(dat.u, false)
			set dat.Index[dat.Total] = dat
			set dat.Total = dat.Total + 1
		endmethod
	endstruct
	
	private function Check takes nothing returns boolean
	    return GetSpellAbilityId() == ID
	endfunction 
	
	private function InitDash takes nothing returns nothing
	    local trigger t = CreateTrigger()
	    local integer i = 0
	    loop
		    exitwhen i == bj_MAX_PLAYER_SLOTS
		    call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
		    set i =i+1
	    endloop
	    
	    call TriggerAddAction(t, function Movement.Start)
	    call TriggerAddCondition(t, Filter( function Check))
	endfunction

endscope

Haven't checked the bug yet though. I am not at home.

NiddHogg-kun · Apr 15, 2010

doesnt work for me.
JNGP problem.

if you have time could you just upload a spell with updated code?

Anachron · Apr 15, 2010

Maybe reinstall JNGP, check my tutorial on the signature.

NiddHogg-kun · Apr 15, 2010

did everything. Reinstalled a lot of time.

Anachron · Apr 15, 2010

Did you really do everything?
Did you also deleted the registry entries JNGP creates?

NiddHogg-kun · Apr 15, 2010

registry entries?
well could you give me an example of it?

Anachron · Apr 15, 2010

JassNewGenPack saves the settings in the registry, type RegEdit and search for JassNewGenPack.

NiddHogg-kun · Apr 15, 2010

deleted and got all my spells deleted too >.<
thx >.<

Anachron · Apr 15, 2010

Do you think its my fault that you did not backup your data?
You can still recover them from the Recyclebin.

Bribe · Apr 15, 2010

Whoa, all your maps?

NiddHogg-kun · Apr 15, 2010

ah found in backups

btw i can edit the one from backups

and no glitches

Anachron · Apr 15, 2010

Then use that version.

[JASS] JassNewGenPack glitch.

Attachments

Similar threads