How to make Adding Critical Strike? [Solved]

[Noctiss_Season2]

Basically something like Critical Strike in League of Legends for reference, a critical strike stat for items that will add to itself, capped at 100% where each hit will be a crit.
Also, is there a way to make this with GUI and not Jass?

Thanks everyone in advance <3

 

[Uncle]

Here's a crit system I threw together.

Spoiler: Triggers

• Acquire Sword of Critting
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Sword of Critting
  • Actions
    • Set VariableSet UDex = (Custom value of (Hero manipulating item))
    • -------- --------
    • -------- Increase Crit Chance --------
    • Set VariableSet Stats_CritChance[UDex] = (Stats_CritChance[UDex] + 10.00)
    • -------- --------
    • -------- Add crit ability (could also give all units this ability by default) --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Level of Critical Strike (Stat) for (Hero manipulating item)) Equal to 0
      • Then - Actions
        • Unit - Add Critical Strike (Stat) to (Hero manipulating item)
      • Else - Actions
    • -------- --------
    • -------- Adjust the crit ability based on your Crit Chance / Crit Multiplier --------
    • Ability - Set Ability: (Unit: (Hero manipulating item)'s Ability with Ability Code: Critical Strike (Stat))'s Real Level Field: Chance to Critical Strike ('Ocr1') of Level: 0 to Stats_CritChance[UDex]
    • Ability - Set Ability: (Unit: (Hero manipulating item)'s Ability with Ability Code: Critical Strike (Stat))'s Real Level Field: Damage Multiplier ('Ocr2') of Level: 0 to Stats_CritMultiplier[UDex]
    • Unit - Set level of Critical Strike (Stat) for (Hero manipulating item) to 2
    • Unit - Set level of Critical Strike (Stat) for (Hero manipulating item) to 1

• Lose Sword of Critting
  • Events
    • Unit - A unit Loses an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Sword of Critting
  • Actions
    • Set VariableSet UDex = (Custom value of (Hero manipulating item))
    • -------- --------
    • -------- Decrease Crit Chance --------
    • Set VariableSet Stats_CritChance[UDex] = (Stats_CritChance[UDex] - 10.00)
    • -------- --------
    • -------- Adjust the crit ability based on your Crit Chance / Crit Multiplier --------
    • Ability - Set Ability: (Unit: (Hero manipulating item)'s Ability with Ability Code: Critical Strike (Stat))'s Real Level Field: Chance to Critical Strike ('Ocr1') of Level: 0 to Stats_CritChance[UDex]
    • Ability - Set Ability: (Unit: (Hero manipulating item)'s Ability with Ability Code: Critical Strike (Stat))'s Real Level Field: Damage Multiplier ('Ocr2') of Level: 0 to Stats_CritMultiplier[UDex]
    • Unit - Set level of Critical Strike (Stat) for (Hero manipulating item) to 2
    • Unit - Set level of Critical Strike (Stat) for (Hero manipulating item) to 1

• Acquire Sword of Multiplying
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Sword of Multiplying
  • Actions
    • Set VariableSet UDex = (Custom value of (Hero manipulating item))
    • -------- --------
    • -------- Increase Crit Multiplier (0.01 = 1% and 1.00 = 100%) --------
    • Set VariableSet Stats_CritMultiplier[UDex] = (Stats_CritMultiplier[UDex] + 1.00)
    • -------- --------
    • -------- Adjust the crit ability based on your Crit Chance / Crit Multiplier --------
    • Ability - Set Ability: (Unit: (Hero manipulating item)'s Ability with Ability Code: Critical Strike (Stat))'s Real Level Field: Chance to Critical Strike ('Ocr1') of Level: 0 to Stats_CritChance[UDex]
    • Ability - Set Ability: (Unit: (Hero manipulating item)'s Ability with Ability Code: Critical Strike (Stat))'s Real Level Field: Damage Multiplier ('Ocr2') of Level: 0 to Stats_CritMultiplier[UDex]
    • Unit - Set level of Critical Strike (Stat) for (Hero manipulating item) to 2
    • Unit - Set level of Critical Strike (Stat) for (Hero manipulating item) to 1

• Lose Sword of Multiplying
  • Events
    • Unit - A unit Loses an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Sword of Multiplying
  • Actions
    • Set VariableSet UDex = (Custom value of (Hero manipulating item))
    • -------- --------
    • -------- Decrease Crit Multiplier (0.01 = 1% and 1.00 = 100%) --------
    • Set VariableSet Stats_CritMultiplier[UDex] = (Stats_CritMultiplier[UDex] - 1.00)
    • -------- --------
    • -------- Adjust the crit ability based on your Crit Chance / Crit Multiplier --------
    • Ability - Set Ability: (Unit: (Hero manipulating item)'s Ability with Ability Code: Critical Strike (Stat))'s Real Level Field: Chance to Critical Strike ('Ocr1') of Level: 0 to Stats_CritChance[UDex]
    • Ability - Set Ability: (Unit: (Hero manipulating item)'s Ability with Ability Code: Critical Strike (Stat))'s Real Level Field: Damage Multiplier ('Ocr2') of Level: 0 to Stats_CritMultiplier[UDex]
    • Unit - Set level of Critical Strike (Stat) for (Hero manipulating item) to 2
    • Unit - Set level of Critical Strike (Stat) for (Hero manipulating item) to 1

It uses a Unit Indexer to keep track of each unit's Critical Strike Chance and Critical Strike Multiplier. When you acquire/lose one of the Crit Items it updates the Crit variables and adjusts the Critical Strike ability to match the new values. Note that the Index for these Ability fields starts at 0, so despite it saying Level: 0, it's really referencing ability Level 1.

Also, these Ability fields are a bit buggy so you need to "refresh" the ability in order for the stats to update properly. That's why I set the ability to level 2 and then back to level 1, this "refreshes" it.

The default crit chance is set to 0% and the default crit multiplier is set to 1.5x normal damage. If you want to adjust these values you can change their Initial value in the Variable Editor (Control + B). Keep in mind that units need to have the Critical Strike ability for any of this to work.

 

[Chaosy]

Don't you simply throw on the blademaster crit ability onto items and call it a day?

 

[Uncle]

Don't you simply throw on the blademaster crit ability onto items and call it a day?

But that wouldn't work anything like League's Crit system.

 

[Chaosy]

Why? the only difference is that there is a crit damage multiplier on one item. This is not mentioned as he only asks for crit chance.

 

[Uncle]

How do the mechanics work for having multiple critical strike abilities? Because I'm under the impression that having two separate critical strike abilities won't stack the way you'd want them to.

For instance:
You have 5 items that add 20% critical strike chance each. OP wants this to amount to a 100% chance to crit, but I'm under the impression that the stacking item abilities will either 1) Not stack at all leaving you with a 20% chance to crit. 2) Roll the dice for EACH ability, meaning you have a 20%/20%/20%/20%/20% chance to crit. I can't imagine it would add the chances together to make a single 100% chance.

 

[Chaosy]

Nope, I can confirm that it stacks.

Two items separate items, both using the same 50% crit chance ability. 100% crit chance when picking up both.

Admittedly I did not try with different crit abilities but I do not see why that wouldn't work

 

[Uncle]

Yeah, that doesn't work the way OP wants it to. That gives you two rolls of 50% chance, not one single roll of 100% chance.

 

[Noctiss_Season2]

Exactly as Uncle says, its not hard to find here on Hive or figure out how abilities such as Critical Strike, Bash etc work
each one rolls separately, so if you have 10 bashes each with 10%chance, you don't get 100% bash, you get 10 x roll for 10% success of Bashing on each autoattack, and if you have 3 items each with 30%crit ability, you don't have 90% crit chance on 1 autoattack, you have 3x roll 30%chance to crit

I need a crit stacking system or some way which likely will include a damage engine, I just don't know which one to use or how to set it up (or a custom triggered crit chance if that is possible I have no clue) so that's the kind of help I'm asking for

 

[Chaosy]

My bad, my expectations were too high x)

 

[Uncle]

Exactly as Uncle says, its not hard to find here on Hive or figure out how abilities such as Critical Strike, Bash etc work
each one rolls separately, so if you have 10 bashes each with 10%chance, you don't get 100% bash, you get 10 x roll for 10% success of Bashing on each autoattack, and if you have 3 items each with 30%crit ability, you don't have 90% crit chance on 1 autoattack, you have 3x roll 30%chance to crit

I need a crit stacking system or some way which likely will include a damage engine, I just don't know which one to use or how to set it up (or a custom triggered crit chance if that is possible I have no clue) so that's the kind of help I'm asking for

Scroll up

 

[Noctiss_Season2]

Scroll up

for what?

 

[Uncle]

I hope you're kidding. Look at the 2nd post!

 

[Noctiss_Season2]

I hope you're kidding. Look at the 2nd post!

lmao I'm actually braindead, here is what happened, I clicked on the most recent notification which was JUST chaosys "don't you just throw blademaster crit" in alerts so it went there, I was writing from phone so I didn't notice that u answered.
Bruh moment T_T

 

[Noctiss_Season2]

thanks a lot for the system dud <3 much appreciated

 

[Noctiss_Season2]

Closing tread with this message just wanna say once again, BRUH this is awesome literally exactly what I needed. Dud thank you so much, if you ever need anything, artwork help, icons, Kidneys (do not ask for origin of delivered goods) just say

 

[Uncle]

Closing tread with this message just wanna say once again, BRUH this is awesome literally exactly what I needed. Dud thank you so much, if you ever need anything, artwork help, icons, Kidneys (do not ask for origin of delivered goods) just say

No problem, I've done the same the thing when spammed with notifications