[Trigger] How to fix these leaks

[TKF]

I think I removed all the leaks here that I know of, but how do I remove location leaks? Must I remove the leaks created each time I instantly move a unit?

• Airborne
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • JumpLength Greater than 0.00
      • Then - Actions
        • Set JumpLength = (JumpLength - 12.00)
        • Set Distance = (Distance - 12.00)
        • Set Airheight = (Airheight + (6.00 + (0.07 x JumpLength)))
        • Special Effect - Create a special effect attached to the chest of Jetpack using Abilities\Spells\Human\FlakCannons\FlakTarget.mdl
        • Special Effect - Destroy (Last created special effect)
        • Unit - Move Jetpack instantly to ((Position of Jetpack) offset by 12.00 towards Angle degrees)
        • Animation - Change Jetpack flying height to Airheight at 3000.00
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • And - All (Conditions) are true
          • Conditions
            • JumpLength Less than or equal to 0.00
            • Distance Greater than 0.00
      • Then - Actions
        • Set JumpLength = (JumpLength - 12.00)
        • Set Distance = (Distance - 12.00)
        • Set Airheight = (Airheight + (-6.00 + (0.07 x JumpLength)))
        • Special Effect - Create a special effect attached to the chest of Jetpack using Abilities\Spells\Human\FlakCannons\FlakTarget.mdl
        • Special Effect - Destroy (Last created special effect)
        • Unit - Move Jetpack instantly to ((Position of Jetpack) offset by 12.00 towards Angle degrees)
        • Animation - Change Jetpack flying height to Airheight at 3000.00
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Airheight Less than or equal to 1.00
          • Then - Actions
            • Animation - Change Jetpack flying height to 0.00 at 3000.00
            • Unit - Move Jetpack instantly to LandingSpot
            • Set Airheight = 0.00
            • Set JumpLength = 0.00
            • Set Distance = 0.00
            • Set Angle = 0.00
            • Unit - Turn collision for Jetpack On
            • Trigger - Turn off (This trigger)
            • Unit - Create 1 Dummy for (Owner of Jetpack) at (Position of Jetpack) facing Default building facing degrees
            • Unit - Add Landing Damage to (Last created unit)
            • Unit - Set level of Landing Damage for (Last created unit) to (Level of Jump (Hunter) for Jetpack)
            • Custom script: call IssueImmediateOrder( GetLastCreatedUnit(), "stomp" )
            • Special Effect - Create a special effect at LandingSpot using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
            • Special Effect - Destroy (Last created special effect)
            • Set Jetpack = No unit
            • Custom script: call RemoveLocation( udg_LandingSpot )
            • Unit - Remove (Last created unit) from the game
          • Else - Actions

 

[GhostWolf]

You would like to check the "Things that Leak" sticky thread since you have various location leaks there and it won't help you a lot if we will just tell you which they are.
Better reading and knowing from now and ever

 

[TKF]

ty ghostwolf

• Set PositionTemp = (Position of (Triggering unit))
• Set TargetPointTemp = (PositionTemp offset by 12.00 towards Angle degrees)
• Unit - Move JetPack instantly to TargetPointTemp
• Custom script: Custom script: call RemoveLocation( udg_PositionTemp )
• Custom script: Custom script: call RemoveLocation( udg_TargetPointTemp )

Well to fix this problem with the unit, I remove both the location and target position being moved to. I think this is correct, but I cannot see other location leaks than this in my main trigger....

 

[valkemiere]

need integer n last created unit variable

 

[wd40bomber7]

@TKF Whats the point of creating a special effect if you destroy it in the next line?!

@valkemiere what are you talking about? Try to be more specific in your posts. In (at least several) of your posts I've seen you give short, partially unreadable answers. Its nice that you want to help, but please: Capitalize sentences, use punctuation, and be descriptive. (If English is not your native language I guess you have an excuse)

 

[valkemiere]

oh sorry my english bad, so i just give a short answer. Pardon me.

i think the trigger is good, not leak, but... with 0,01 periodic time, it to fast, the trigger read every time, before it get finished reading first.

 

[TKF]

• Set PositionTemp = (Position of (Triggering unit))
• Set TargetPointTemp = (PositionTemp offset by 12.00 towards Angle degrees)
• Unit - Move JetPack instantly to TargetPointTemp
• Custom script: Custom script: call RemoveLocation( udg_PositionTemp )
• Custom script: Custom script: call RemoveLocation( udg_TargetPointTemp )

This did fuck up the jump, so does anyone knows a different leak cleaning solutiuon which makes it work the same as my first trigger without leaks?


@valkemiere: btw do you suggest that I change my periotic time? is it to fast with 0.01? I can easily change it to 0.02.


@wd40bomber7: I remove the leaks of special effects. They do come every time.

 

[valkemiere]

0.03 lilbit better.

you know, i always cr8 variable for every thing, like number, unit, special effect. Array needed if many of them use it.

i always place constant variable at map initilization, but i dunno this way good or not.

 

[wd40bomber7]

Omg. FOR THE LAST TIME (I've said this in at least a dozen other threads)
You can't have a wait less then (approx) .1 in single player. In multiplayer you can't have a wait less then (approx) .3

So if you set it to .03 or .01 or .0259235873 It will STILL be around .29 (in multi) or .1 (in single)

If you want to wait such little amounts of time, use a timer!

Setting everything to variables is a waste of computer power. Only set objects which must be destroyed to variables!

Also, if you want I'll help you clean your trigger. However I want you to post the map so I can work with the trigger itself. (I don't feel like spending an hour recreating your trigger...)

 

[valkemiere]

maybe you right, i'm noob mapmaker. Post in here too, i wanna learn from you.

 

[operator]

If you want to learn, Then I suggest you don't tell him wrong when he's right about things.

 

[GhostWolf]

First removing a special effect after it was created DOESN'T remove the "shown" effect, so it has no problem in it.

And then again, a event - every x = TIMER and not a WAIT (for a hint, look at the category of it - Time) so it works perfectly with whatever time you put in it.

I suggest you to use ~0.05 for less lag issues.

No there isn't any other way to remove leaks.

 

[TKF]

I rather don't want to use 0.05, it will be to slow here. Maybe I reduce it to 0.02, cuz it must look like a jump flight, not like a lagging jump. This jump causes a sharp increase in height and sharp downfall.


btw I cannot remove the location leaks without screwing the trigger, I don't know how. Without removing them, it still makes noticeable leaks.

 

[GhostWolf]

Of course, 0.01 means 100 leaks every second and thats a lot.

Besides, you probably can't see in your eyes the diffrence beetwin 0.01 and 0.05 but the game feels the diffrence... it makes it work harder by x5

 

[GhostWolf]

• Airborne
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • JumpLength Greater than 0.00
      • Then - Actions
        • Set JumpLength = (JumpLength - 12.00)
        • Set Distance = (Distance - 12.00)
        • Set Airheight = (Airheight + (6.00 + (0.07 x JumpLength)))
        • Special Effect - Create a special effect attached to the chest of Jetpack using Abilities\Spells\Human\FlakCannons\FlakTarget.mdl
        • Special Effect - Destroy (Last created special effect)
        • Set Point[0] = (Position of (Jetpack))
        • Set Point[1] = Point[0] offset by 12.00 towards Angle degrees)
        • Unit - Move Jetpack instantly to Point[1]
        • Animation - Change Jetpack flying height to Airheight at 3000.00
        • Custom script: call RemoveLocation(udg_Point[0]
        • Custom script: call RemoveLocation(udg_Point[1]
      • Else - Actions

Whats the problem with this ?


Whops sorry for double post, didn't notice im not editing x.x

 

[valkemiere]

If you want to learn, Then I suggest you don't tell him wrong when he's right about things.

i just tell what i know....not tell him wrong.
Maybe the ppl who teach me tell me wrong >.>

wd40bomber : ar u mad?

 

[wd40bomber7]

@valkemiere No, I'm not mad at all.
@Ghostwolf I don't see anything wrong with it right off the bat.

 

[TKF]

I did with an mistake put triggering unit instead of Jetpack. ty GhostWolf.

 

[Eleandor]

Custom script: Custom script: call RemoveLocation( udg_PositionTemp )
Custom script: Custom script: call RemoveLocation( udg_TargetPointTemp )

Why do you type custom script twice?

What do you need "Distance" for?

 

[GhostWolf]

Well obviously if you set 2 points you will like to remove both of them...

 

[wd40bomber7]

No not what he meant.
He means why Custom Script: Custom Script:
See theres two of them on one line. In the next line theres another two. Thats what hes trying to say. (I think)