GUI Unit Event (now with a state-of-the-art Lua version)

[Bribe]

If higher values than array limit is needed hashtable is probably the way to go. Dunno if you need it.

That would be insane. No map can survive that many units at once.

 

[IcemanBo]

Higher values isn't necessairly related to higher amount of units.

 

[Bribe]

In this case it is. The count recycles every so often, so the only way to go crazy with numbers is to have the unit count go crazy itself.

The increase in max array size to 2**15 from 2**13 won't make a difference either. Even a couple thousand units will lock up a map.

 

[IcemanBo]

Did you even read what I wrote at first? I mentioned hashtables could be used if values higher than array limit is needed. This has absolutly nothing to do with your recycling system. ;s

 

[Bribe]

I read that, but not sure why you're getting defensive. He hadn't brought up any system but this one, so it is important to not confuse readers who aren't sure of the context of this tangent.

 

[Somebassoon]

Well, its not functioning yet. However, I dont think it would ever even reach 2k, but I sometimes see the Indexer just skip numbers a lot and it worries me that it would eventually go over 8k, so its a safety net. And Im mostly suggesting it for the fun of it, so that the systen has 1 less "limitation"

Well never mind, array max is now around 30k, thanks Blizz!

 

[Spellbound]

So I'm trying to detect animate dead:

Detect when a unit is brought back to life via Reincarnation, Resurrect or Reanimate
Event: Game - DeathEvent Becomes Equal to 2.00

You can differentiate between the three of these as well. If it is summoned, that means it was reanimated. If IsUnitReincarnating[UDex] is true, that means it finished reincarnating. Otherwise, it was simply resurrected.

I did if IsUnitType(DyingUnit, UNIT_TYPE_SUMMONED) then but it didn't work. Am I using the wrong native?

EDIT: WELL THIS IS AWKWARD. It seems to work now, but I'm not sure why it wasn't working before. Might have been a different issue. Plz ignore.

 

[Bribe]

Update to use bj_MAX_PLAYER_SLOTS instead of 16. Previous versions to this were incompatible with 1.29.

 

[Spacebuns]

Again, this is a problem that I described a few pages ago, but I'd like to reiterate it, if a unit dies from 2+ damage instances really close to each other (e.g. through Triggered damage) then the DeathEvent = 1.00 doesn't seem to run properly.

 

[apsyll]

Chocolate flavour is the best but when you like vanilla this system is a must have

 

[Lord_Earthfire]

Hey,

Currently i am running your system in some maps of mine but recently i found a problem that is a bit bugging me. Whenever i kill a unit, the game has a small but noticeable lag spike, which is independent on the map or triggers- I even encounter the same problem in the testmap when i put down some peasants and let them get killed.
If i had some time to spare i would take a look at it, but do you got spontaniously an idea where this is coming from? For reference, I'm using the newest version of the system.

 

[Somebassoon]

Would it be possible to utilize Reincarnation and the unit even system to create a custom corpse/resurrection system? So that we can dynamically shift a unit from alive to dead and toy with its "corpse" with less limitation. Only issue is, auto-cast raise dead wont work.

 

[Reaper51]

Hey,

Currently i am running your system in some maps of mine but recently i found a problem that is a bit bugging me. Whenever i kill a unit, the game has a small but noticeable lag spike, which is independent on the map or triggers- I even encounter the same problem in the testmap when i put down some peasants and let them get killed.
If i had some time to spare i would take a look at it, but do you got spontaniously an idea where this is coming from? For reference, I'm using the newest version of the system.

I can confirm the last patch borked this system it lags every time a unit dies with this trigger enabled

 

[Bribe]

Hey,

Currently i am running your system in some maps of mine but recently i found a problem that is a bit bugging me. Whenever i kill a unit, the game has a small but noticeable lag spike, which is independent on the map or triggers- I even encounter the same problem in the testmap when i put down some peasants and let them get killed.
If i had some time to spare i would take a look at it, but do you got spontaniously an idea where this is coming from? For reference, I'm using the newest version of the system.

I can confirm the last patch borked this system it lags every time a unit dies with this trigger enabled

Hi you two. Thank you for reporting this. I have now updated to 2.5.1.0 which fixes an issue where a unit could be added to the CheckDeathFilter more than once. This was done by tracking whether a unit is in the list via a "-1" value in the list by default.

Also, to the post above asking about manual reincarnation - this is not one of the uses of Unit Indexer. You need a resource like [Snippet] ReviveUnit.

 

[ZiBitheWand3r3r]

Bribe, can you please check: Event: Game - UnitTypeEvent Becomes Equal to 1.00
Its not firing for druid's bear form, or metamorphosis for DH. My game version id 1.29.2

 

[Bribe]

Sounds like your Unit Event is out of date. Go ahead and replace your Unit Event triggers with the ones from this demo map.

I double checked the triggers for regression in case I made a blunder with the 1.29 update, but it should still work.

Edit: another possibility is that it may have broken when i removed the infinite loop thing in the last update. Please let me know how you get on. I won't be able to update the demo map for an indefinite period of time, but I can update the JASS code.

 

[ZiBitheWand3r3r]

I just downloaded demo-map with v2.5.1, it doesn't detect transform, however I found in my older maps v2.4.0, tested it, and 2.4.0 version works fine. I cannot find 2.5.0 on my PC to compare unfortunately.

 

[Bribe]

OK I've found the source of the issue with transform no longer being detected (it is specific to the patches with the combined buff-overlapping stuff, which I guess from what you're saying started in 1.29. I'm testing on 1.30).

With the advancement of the buff overlapping stuff, the second instance of the Defend ability is somehow also set to Permanent when I use the UnitMakeAbilityPermanent native.

So this means I would have to get rid of the UnitMakeAbilityPermanent line in order to recognize the unit when it transforms, which means only one Defend ability could be used and relied upon.

This is an unfortunate bug, as I'll have to figure out how to detect if the unit was removed or if it was transformed, which may not be easy and may not be worth the tradeoff.

 

[ZiBitheWand3r3r]

Bribe, 2.4.0 version detects transform just fine, maybe there is diffrent way to fix this small lag spike upon unit's death reported earlier? In 2.5.0 you updated just bj_MAX_PLAYER_SLOTS ? I suspect that after update 2.4.0-->2.5.x transform detection stops working? I'm still on 1.29.2 game ver.

 

[Bribe]

Update to 2.5.2! This update corrects the issue were transform was no longer being recognized. The only steps needed are to re-copy the JASS script and to either re-copy the config trigger or manually add the one new variable to your variable list:

CheckDeathInList boolean array

There were no changes made to the spell abilities - installation steps are still the same as before. It was difficult to track down why this is failing, so there may be one or two redundant "resets" of the linked list in the code (that don't have a performance impact).

 

[ZiBitheWand3r3r]

Works like a miracle on my 1.29.2 thanks Bribe!
So the second "defend" ability also works on 1.30? Really good to have UnitEvent working with all its features.

 

[Bribe]

Works like a miracle on my 1.29.2 thanks Bribe!
So the second "defend" ability also works on 1.30? Really good to have UnitEvent working with all its features.

Yeah, fixing the linked list was the key. The second defend ability wasn't working because the timer was never deploying.

 

[Devalut]

Does the event to get a summoned unit not grab locusts from locust swarm?
My goal is to add some values to them after they're created, (like the caster & damage) then have them die after hitting something, but for the life of me I can't seem to get them

 

[Bribe]

Maybe they don't launch the summon event? I haven't tested that one. Just use the UnitIndexEvent Equal to 1.00 event and check if UDexUnits[UDex] is a locust.

 

[Devalut]

Yep that did the trick!

Edit:Result

 

[Darkxs]

Hi Bribe, I was wondering how one would go about refering to the local owner of a reincarnating unit? Like
Custom script: If GetLocalPlayer() == GetOwningPlayer(Get???Unit())
Sound - Play Sound
Custom script: endif

I’m currently working on a trigger, where the owner of the reincarnating unit hears a voice when the unit starts reincarnating and once again when it finishes reincarnating.

 

[Bribe]

Keep in mind local stuff can desync so beware, but the reincarnating unit is UDexUnits[UDex] so there's that unit you're after so it's easy to get its owner from their.

 

[Darkxs]

I’m aware, but thanks for pointing it out. I’m rather new to the whole local player thing, so I hope you don’t mind me asking. This would be the right way to refer to the owner of that unit:
Custom script: If GetLocalPlayer() == GetOwningPlayer(GetUDexUnits[UDex]Unit())
right?

 

[Bribe]

Not at all. You can't know what to use there without knowing some basic JASS. It's easier to use Custom Script earlier in the game like with a 0 Seconds Game Time trigger like this (paste into Custom script):

set udg_LocalPlayer = GetLocalPlayer()

That way, you'll never have issues figuring out custom script to use the local player - you can just use it right from there with the GUI variable "LocalPlayer".

I used this trick in my WarChasers Remastered map.

 

[Pinzu]

How would one go about adding this library as optional to another? Any chanse you could wrap it inside library scope? I wish to incorporate it here for handling reincarnation: [vJASS] - Display Remaining Cooldown

 

[Bribe]

How would one go about adding this library as optional to another? Any chanse you could wrap it inside library scope? I wish to incorporate it here for handling reincarnation: [vJASS] - Display Remaining Cooldown

That won't be until the supported vJass GUI hybrid is released.

 

[pusha1999]

can you explain to me Bribe, why this indexing is better than just use a triggers with standart events? i mean i see the point to use this system for reinc detect for example, but, summoning, cargo, death events, spell events...why this is better and what should i do if dont wanna use indexing for all units on map? only for heroes for example and specific units where i need to detect smth.

 

[_Guhun_]

can you explain to me Bribe, why this indexing is better than just use a triggers with standart events? i mean i see the point to use this system for reinc detect for example, but, summoning, cargo, death events, spell events...why this is better

If you use summoning, cargo, death or enter map events, then you cannot assume that they will be executed before the unit is indexed. Therefore, you can easily stumble into a bug where you want to use UDex but it's not set to the right unit custom value.

This system has no support for spell events.

what should i do if dont wanna use indexing for all units on map? only for heroes for example and specific units where i need to detect smth.

You will have to edit the jass code, the system has no default support for that. It's a pretty easy edit, though.

function UnitEventEnter takes nothing returns boolean
    local integer pdex = udg_UDex
    local integer i = udg_UDexLastRecycled
    local unit u = GetFilterUnit()
    //IF UNIT AS DECORATION ABILITY, DO NOT INDEX THIS UNIT
    if GetUnitAbilityLevel(u , 'A0C6') != 0 then
        call SetUnitUserData(u, 0)
        set u = null
        return false
    endif

In my map, I just added that if check right at the top of the UnitEnterEvent function.

 

[Bribe]

Summoning was a bit unnecessary to add, mostly it is there because I think someone asked for it.

Cargo events natively only detect the loading, but not the unloading. So that's why that one is there.

Reincarnation and reanimation, as well as hero revival, are all easily tracked.

The conditions used to have a GUI boolean to scan, but it got lost in the transition of the system to the JASS with GUI overlay. That was an oversight on my part.

I'm not feeling really up to it to maintain these resources until I know what kinds of stuff the new natives will bring. I don't want to spend a dozen hours finishing up the stuff I have mostly-ready (already at least a hundred hours into various incomplete things).

My laptop has issues where half the keys no longer work for some stupid reason, so doing all this would need an external keyboard connected which is a huge inconvenience.

I'll wait for the new patch and then see if any systems of mine are still worth the investment to update or publish.

 

[pusha1999]

Summoning was a bit unnecessary to add, mostly it is there because I think someone asked for it.

Cargo events natively only detect the loading, but not the unloading. So that's why that one is there.

Reincarnation and reanimation, as well as hero revival, are all easily tracked.

The conditions used to have a GUI boolean to scan, but it got lost in the transition of the system to the JASS with GUI overlay. That was an oversight on my part.

I'm not feeling really up to it to maintain these resources until I know what kinds of stuff the new natives will bring. I don't want to spend a dozen hours finishing up the stuff I have mostly-ready (already at least a hundred hours into various incomplete things).

My laptop has issues where half the keys no longer work for some stupid reason, so doing all this would need an external keyboard connected which is a huge inconvenience.

I'll wait for the new patch and then see if any systems of mine are still worth the investment to update or publish.

new patch comming soon? Do you have any info about when?

 

[Bribe]

new patch comming soon? Do you have any info about when?

It'll be before the end of the year. Ralle made a post recently about some of the upcoming features like how it's going to be 64-bit.

 

[A]mun]

A great system once again!

 

[Spacebuns]

Will this system require any update in 1.31?

 

[Bribe]

Will this system require any update in 1.31?

I've not tested it in 1.31, but none of the added features have any significance to this resource. Damage Engine was the only one of mine that benefitted.

 

[Bribe]

Coming soon: Lua Unit Event! I'm really excited for the prospects of this one, because this update is going to plug a huge GUI inconsistency that will enable the standard "Unit is alive/dead" checks to work correctly in all cases.

Also, for those familiar with [Snippet] RegisterEvent pack the Lua Unit Event library will do that sort of thing... but with normal GUI triggers. The future is here!

 

[CaptainHec]

Hello, it would be appreciated if you could tell me:

As a replacement for the "transformed" militia unit, it will be detected, but I want to replace it.

In your instructions it seems to me that you only indicate how to refer to the unit before transforming.

If it's obvious, excuse me, I'm an old rookie in this

 

[Bribe]

Hello, it would be appreciated if you could tell me:

As a replacement for the "transformed" militia unit, it will be detected, but I want to replace it.

In your instructions it seems to me that you only indicate how to refer to the unit before transforming.

If it's obvious, excuse me, I'm an old rookie in this

The event takes place after the transformation finishes. You can replace the unit at that time.

 

[CaptainHec]

Thanks for your answer. (When I try to do what you tell me, the game closes, I'm probably doing it wrong)

For now I am trying to detect how many units there are in a transport when one unit goes up to it.

Event
Game - CargoEvent becomes Equal to 1.00
Condition
(Unit-type of CargoTransportUnit [UDex]) Equal to Ship
Action
Game - Display to (All players) the text: (String ((Number of units in CargoTransportGroup [UDex])))

It always gives me "0"

PD: Should I make a thread for these queries?

 

[Bribe]

You need to set a 0 second timer or use a trigger sleep action.

 

[Bribe]

Event
Game - CargoEvent becomes Equal to 1.00
Condition
(Unit-type of CargoTransportUnit [UDex]) Equal to Ship
Action
Game - Display to (All players) the text: (String ((Number of units in CargoTransportGroup [UDex])))

It always gives me "0"

You need to change the string to:

Number of units in CargoTransportGroup [(Custom value of CargoTransportUnit [UDex])]

 

[Daffa]

Does Reincarnation possible to detect what ability used to reincarnate the unit?

 

[Bribe]

Does Reincarnation possible to detect what ability used to reincarnate the unit?

No this resource wouldn't tell you that. But I think you can get the remaining cooldown of the ability if you know the ability or a list of reincarnation abilities in advance, which could help you too determine which one went off. This requires patch 1.29 or later if I'm not mistaken.

 

[Daffa]

No this resource wouldn't tell you that. But I think you can get the remaining cooldown of the ability if you know the ability or a list of reincarnation abilities in advance, which could help you too determine which one went off. This requires patch 1.29 or later if I'm not mistaken.

Thanks!

 

[Lt_Hawkeye]

Getting a strange bug with detecting a building's death. It is detecting the building's death even its not actually dead.

 

[PiesOfNorth]

I'm trying to use CargoEvent becomes 2.00 (for unloading a unit) but the trigger with the event does not fire at all.
I am using 1.28 though, does it require a later version? if so, is there an older version available that's compatible?