ApprovedCircle Object:
Starting Angle (Of First Point)
Center (X/y)
Radius (X/Y)
Resolution (Number of Points)
Tilt Angle (Elipse)
Rotation/Spin Angular Step (Rotate Points Around Center when Circle is Updated)
Current Angle (Of First Point)
Points
Units (optional)
Key = Circle Instance | Key = -Circle Instance | ||
0
| Starting Angle |
0
| Cur. Angle |
1
| Center X |
i
| X of point i |
2
| Center Y |
-i
| Y of point i |
3
| Radius X | ||
4
| Radius Y | ||
5
| № of Points | ||
6
| Tilt | ||
7
| Rotation | ||
100 + i
| Unit i |
Set Point = (Point((Load i of (-1 x GCOS_Instance) from GCOS_Hashtable), (Load (-1 x i) of (-1 x GCOS_Instance) from GCOS_Hashtable)))
Actions
Set GCOS_Instance = 0
Set GCOS_Tilt = 0.00
Set GCOS_Rotate = 0
Set GCOS_Radius_X = 100.00
Set GCOS_Radius_Y = 100.00
Set GCOS_Center_X = 0
Set GCOS_Center_Y = 0
Trigger - Run Circle System <gen> (ignoring conditions)
For each (Integer A) from 1 to 20, do (Actions)
Loop - Actions
Unit - Create 1 Footman for Player 1 (Red) at (Center of (Playable map area)) facing Default building facing degrees
Hashtable - Save Handle Of(Last created unit) as ((Integer A) + 100) of GCOS_Instance in GCOS_Hashtable
Trigger - Run Circle System <gen> (checking conditions)
function CircleWithUnits takes nothing returns nothing
local integer i = 1
local integer circleID = CreateGCOS(0,2500,2500,500,500,10,0,0)
loop
exitwhen i > 10
//call SaveUnitHandle( udg_GCOS_Hashtable, circleID, 100 + i, CreateUnit(Player(0),'hfoo',0,0,0) )
call SetGCOSUnit(circleID, i, CreateUnit(Player(0),'hfoo',0,0,0))
set i = i + 1
endloop
call UpdateGCOS(circleID)
endfunction
Periodic Trigger
Events
Time - Every 0.03 seconds of game time
Actions
Set GCOS_Instance = 1
Custom script: call SaveReal(udg_GCOS_Hashtable, udg_GCOS_Instance, 1, GetUnitX(udg_TestPaladin))
Custom script: call SaveReal(udg_GCOS_Hashtable, udg_GCOS_Instance, 2, GetUnitY(udg_TestPaladin))
Trigger - Run Circle System <gen> (checking conditions)
Actions
Hashtable - Save GCOS_Center_X as 1 of GCOS_Instance in GCOS_Hashtable
Hashtable - Save GCOS_Center_Y as 2 of GCOS_Instance in GCOS_Hashtable
Hashtable - Save GCOS_Radius_X as 3 of GCOS_Instance in GCOS_Hashtable
Hashtable - Save GCOS_Radius_Y as 4 of GCOS_Instance in GCOS_Hashtable
Hashtable - Save GCOS_N_Points as 5 of GCOS_Instance in GCOS_Hashtable
Hashtable - Save GCOS_Tilt as 6 of GCOS_Instance in GCOS_Hashtable
Hashtable - Save GCOS_Rotate as 7 of GCOS_Instance in GCOS_Hashtable
Trigger - Run Circle System <gen> (checking conditions)
Actions
Set GCOS_Instance = (existing circle number)
Trigger - Run GCOS Main <gen> (IGNORING conditions)
call DestroyGCOS(circleID)local integer circleID = CreateGCOS(angle, centerX, centerY, radiusX, radiusY, numPoints, tilt, spin)call UpdateGCOS(circleID)//This function updates the coordinates of a circle, also spinning it by its specified spin
//You need to call this function after directly changing values in the Hashtable or with the Set functions
function UpdateGCOS takes integer instance returns nothing
//Creates a GCOS and automatically updates its position using the UpdateGCOS fucntion
function CreateGCOS takes real angle, real centerX, real centerY, real radiusX, real radiusY, integer numPoints, real tilt, real spin returns integer
function DestroyGCOS takes integer instance returns nothing
//=================
//Set/Get functions that are hopefully inlined
//=================
function GetGCOSDefAngle takes integer instance returns real
function GetGCOSCurAngle takes integer instance returns real
function GetGCOSCenterX takes integer instance returns real
function GetGCOSCenterY takes integer instance returns real
function GetGCOSRadiusX takes integer instance returns real
function GetGCOSRadiusY takes integer instance returns real
function GetGCOSNoPoints takes integer instance returns integer
function GetGCOSTilt takes integer instance returns real
function GetGCOSSpin takes integer instance returns real
function SetGCOSDefAngle takes integer instance, real angle returns nothing
function SetGCOSCurAngle takes integer instance, real angle returns nothing
function SetGCOSCenterX takes integer instance, real X returns nothing
function SetGCOSCenterY takes integer instance, real Y returns nothing
function SetGCOSRadiusX takes integer instance, real X returns nothing
function SetGCOSRadiusY takes integer instance, real Y returns nothing
function SetGCOSNoPoints takes integer instance, integer number returns nothing
function SetGCOSTilt takes integer instance, real angle returns nothing
function SetGCOSSpin takes integer instance, real angle returns nothing
function GetGCOSPointX takes integer instance, integer pointNumber returns real
function GetGCOSPointY takes integer instance, integer pointNumber returns real
function SetGCOSUnit takes integer instance, integer pointNumber, unit u returns nothing
function GetGCOSUnit takes integer instance, integer pointNumber returns unitCommand | Action |
n or new | Create a new circle on bottom left |
-d (number>27) | Destroy a circle on bottom left with that number |
-rx | Change bottom right circle radius x value |
-ry | Change bottom right circle radius y value |
-np | Change bottom right circle № points |
-s | Change bottom right circle rotation step> 2pi/(input) |
-t | Change bottom right circle (elipse) tilt |
|
We talked about updating the rule, but never actually came across to updating it. Thanks to both of you for bringing this to my attention! The rule has now been properly updated:
Theoretically, any system could use a hashtable in place of all his array variables, but it would not be so great when it comes to readability (big pro especially for a public API) and performance (in places where performance matters). You provided a reason why you don't want to pollute the global namespace but even with thousands of global arrays, hashtables would still be many times slower compared to your variables (
In the case of units, I would propose that you just stay with hashtable since it makes more sense because you are using two keys (circle instance, and the index/position of unit on the storage), but with the circle instance's data, it would make sense to just use arrays imo. One's preference also plays a role here though.
In the GUI api, they are provided the direct hashtable access (not function) so providing the directly the array access would not bring a new problem but I guess you're talking about the jass api here? (Because you said functions) So here, you could also just change the function implementation by making them (the functions) use the array instead of the hashtable, so no need to let the user access the arrays directly and thus they dont have to alter their codes.
function UpdateGCOS, as it considers the case that they exist. This might end up becoming quite costly (and wasteful) in performance. (A hint: You can use indices 32769 (> JASS_MAX_ARRAY_SIZE) and above as a parent table.)
set angle = angle + LoadReal(udg_GCOS_Hashtable,instance,7)? I can certainly see it being useful for a programmer to get a nice value for the current angle, so I'll get it done. I'll also look into putting in some nice documentation in the map itself.SetUnitX call and a SetUnitY call on a null unit handle is a lot cheaper than making a separate loop for valid units only. Unless you are thinking of some other implementation? :S
