[GUI] Custom Life & Mana Drain 0.05

[Moderator]

01:24, 8th Sep 2012
Magtheridon96: Approved.

If only GUI had some form of preprocessor directives.
If it did, most of that crap if/then/else code could be a one-liner without needing any work done by the user. :/

Good job with this.
That Buff-list is not something that people would often include in their resources, but I guess it could be useful in this case.

 

[baassee]

Finally someone who understood how to use GetLocationZ! Too bad mods forgot about this awesome native.

 

[rulerofiron99]

Finally someone who understood how to use GetLocationZ!

Hmm, I suppose I should credit that super helpful tutorial I used...

 

[baassee]

Hmm, I suppose I should credit that super helpful tutorial I used...

Not about that, I edited my post ^^

 

[Maestros]

 

[rulerofiron99]

T_T time to stop making systems

 

[Maestros]

The world crumbles!

 

[MortAr]

It doesn't check if the target is hidden or invisible.

 

[Adiktuz]

this

• Set tempZ1 = (tempZ1 + (Current flying height of tempUnit))
  • Set tempZ1 = (tempZ1 + 60.00)

should be

• Set tempZ1 = (tempZ1 + (Current flying height of tempUnit) + 60.0)

or better yet, merge them into the Custom script where you set the initial tempZ1

• Custom script: set udg_tempZ1 = GetLocationZ(udg_tempLoc1) + GetUnitFlyHeight(udg_tempUnit) + 60.0

To improve efficiency; distance (for range check) only calculated every second, although the lightning effect updates at 0.03. Lightning effect also raises for flying units.

I think it is more efficient if it checks distance for every drain interval [in this case 0.3 seconds]... XD... and you might want to make the drain interval easily customizable by the user (e.g. put it into a variable at set-up)...

Suggestion:
instead of checking if tick is = 10 or 20 or 30, you might want to utilize the modulo function which returns the remainder of a division... so instead of tick = 10 or 20 or 30, you can just use if modulo of tick divided by 10 is equal to zero... that way you can just let the tick value go on and on instead of reseting it to 0 after it reaches 30... that way, you can also use the tick variable to determine if the drain is supposed to end already [effectively eliminating the need for the TicksRemaining variable]...

 

[Maestros]

It doesn't check if the target is hidden or invisible.

this

• Set tempZ1 = (tempZ1 + (Current flying height of tempUnit))
  • Set tempZ1 = (tempZ1 + 60.00)

should be

• Set tempZ1 = (tempZ1 + (Current flying height of tempUnit) + 60.0)

or better yet, merge them into the Custom script where you set the initial tempZ1

• Custom script: set udg_tempZ1 = GetLocationZ(udg_tempLoc1) + GetUnitFlyHeight(udg_tempUnit) + 60.0

I think it is more efficient if it checks distance for every drain interval [in this case 0.3 seconds]... XD... and you might want to make the drain interval easily customizable by the user (e.g. put it into a variable at set-up)...

Suggestion:
instead of checking if tick is = 10 or 20 or 30, you might want to utilize the modulo function which returns the remainder of a division... so instead of tick = 10 or 20 or 30, you can just use if modulo of tick divided by 10 is equal to zero... that way you can just let the tick value go on and on instead of reseting it to 0 after it reaches 30... that way, you can also use the tick variable to determine if the drain is supposed to end already [effectively eliminating the need for the TicksRemaining variable]...

Some people say that reputation means nothing... but then i see people like you guys, spoting out problems right away, and giving constructive answers, this is the way things go one step forward. Just nice

 

[Noobsmoke]

Make the same thing for mana too maybe ?

 

[rulerofiron99]

this

• Set tempZ1 = (tempZ1 + (Current flying height of tempUnit))
  • Set tempZ1 = (tempZ1 + 60.00)

should be

• Set tempZ1 = (tempZ1 + (Current flying height of tempUnit) + 60.0)

or better yet, merge them into the Custom script where you set the initial tempZ1

• Custom script: set udg_tempZ1 = GetLocationZ(udg_tempLoc1) + GetUnitFlyHeight(udg_tempUnit) + 60.0

Will do!

I think it is more efficient if it checks distance for every drain interval [in this case 0.3 seconds]... XD... and you might want to make the drain interval easily customizable by the user (e.g. put it into a variable at set-up)...

I'll add the option to customise, I know how intense distance checks can be, but then again how powerful many pcs these days are.

Suggestion:
instead of checking if tick is = 10 or 20 or 30, you might want to utilize the modulo function which returns the remainder of a division... so instead of tick = 10 or 20 or 30, you can just use if modulo of tick divided by 10 is equal to zero... that way you can just let the tick value go on and on instead of reseting it to 0 after it reaches 30... that way, you can also use the tick variable to determine if the drain is supposed to end already [effectively eliminating the need for the TicksRemaining variable]...

Isn't modulo a calculation (costly division calculation, and then some). I'd like to keep it like this, for efficiency's sake.

Make the same thing for mana too maybe ?

It already works for mana! You can customised it to drain life or mana or both, and change the lightning art and sfx.

EDIT:
Fixed:
- merged addition for tempZ
- checks for hidden
- checks a predetermined buff list for break

 

[baassee]

There is actually more you can do.

-The buff checks are pure crap. Use boolean check if unit is visible. And Invulnerable.
-Use one static location for Z, the X/Y coordinates can be recieved from doing GetUnitX/Y(udg_tempUnit)
-Leaks

• Set tempDistance = (Distance between (Point(tempX1, tempY1)) and (Point(tempX2, tempY2)))

 

[rulerofiron99]

There is actually more you can do.
-The buff checks are pure crap. Use boolean check if unit is visible. And Invulnerable.

I had a look, the only applicable boolean was visibility by triggers.

-Use one static location for Z, the X/Y coordinates can be recieved from doing GetUnitX/Y(udg_tempUnit)

Z has to be changing; units might change height during the course of the spell.

-Leaks

• Set tempDistance = (Distance between (Point(tempX1, tempY1)) and (Point(tempX2, tempY2)))

Oh wow how did I miss that.

 

[baassee]

Oh, in JASS there is IsUnitVisible or something ^^

Anyway you can use one location for Z, just call "MoveLocation(loc, x, y)" and it should be fine.

 

[rulerofiron99]

Oh, in JASS there is IsUnitVisible or something ^^

Anyway you can use one location for Z, just call "MoveLocation(loc, x, y)" and it should be fine.

Hmm, I suppose I can do a Player - Visibility check, although I've never worked with them before.

Don't quite understand what you mean about the Z - I still have to use 2 locations to check the distance anyway, right? Well technically I could just use distance formula, but what advantage does that give? Just a little neater?

 

[baassee]

Alright let's break it down. And btw you forgot to merge a few variables, I'll fix it for ya here!

In the add trigger, instead of doing this:

• Set tempLoc1 = (Position of tempUnit)
• Custom script: set udg_tempX1 = GetLocationX(udg_tempLoc1)
• Custom script: set udg_tempY1 = GetLocationY(udg_tempLoc1)
• Custom script: set udg_tempZ1 = GetLocationZ(udg_tempLoc1)
• Set tempZ1 = (tempZ1 + (Current flying height of tempUnit))
• Set tempZ1 = (tempZ1 + 60.00)
• Custom script: call RemoveLocation(udg_tempLoc1)
• -------- coords of target --------
• Set tempLoc1 = (Position of ncld_Target[Key])
• Custom script: set udg_tempX2 = GetLocationX(udg_tempLoc1)
• Custom script: set udg_tempY2 = GetLocationY(udg_tempLoc1)
• Custom script: set udg_tempZ2 = GetLocationZ(udg_tempLoc1)
• Set tempZ2 = (tempZ2 + (Current flying height of ncld_Target[Key]))
• Set tempZ2 = (tempZ2 + 60.00)
• Custom script: call RemoveLocation(udg_tempLoc1)

You can do like this:

• Custom script: local real x
• Custom script: local real y
• Location StaticZ
• Custom script: set x = GetUnitX(udg_tempUnit)
• Custom script: set y = GetUnitY(udg_tempUnit)
• Custom script: call Movelocation(udg_StaticZ, x, y)
• Custom script: set udg_tempX1 = x
• Custom script: set udg_tempY1 = y
• Custom script: set udg_tempZ1 = GetLocationZ(udg_StaticZ) + GetUnitFlyHeight(udg_tempUnit) + 60.
• Custom script: set x = GetUnitX(udg_ncld_Target[udg_key])
• Custom script: set y = GetUnitY(udg_ncld_Target[udg_key])
• -------- coords of target --------
• Custom script: call Movelocation(udg_StaticZ, x, y)
• Custom script: set udg_tempX2 = x
• Custom script: set udg_tempY2 = y
• Custom script: set udg_tempZ2 = GetLocationZ(udg_StaticZ) + GetUnitFlyHeight(udg_ncld_Target[udg_Key]) + 60.

You see the brilliance here? Now you re-use the location every single time AND it doesn't leak!

 

[Adiktuz]

I still prefer the modulo version since its easier to modify... and it will be more friendly at the time that you make the interval to be easily changeable by the user... because right now, if the user changes the interval, then he needs to change the IF-Conditions too...

 

[rulerofiron99]

Ah, I see! Thanks again.

So this StaticZ point, I just keep moving it around, never using RemoveLocation on it? Or can I remove it at the end of each loop?

I still prefer the modulo version since its easier to modify... and it will be more friendly at the time that you make the interval to be easily changeable by the user... because right now, if the user changes the interval, then he needs to change the IF-Conditions too...

Fair enough, I'll change it.

 

[Adiktuz]

Yes, you just move it around and never destroy it that's why its a static location... You can also use it for other systems or spells if you like and have no problem at all...

 

[MortAr]

You could keep the effect on if the target is magic immune, since most people will not give a unit permanent immunity. Thus, if the immunity wears off, it can start draining it again. Otherwise it is just a waste of casting.

Also, please come up with some other name. This "Non-channeling" thing is just not fitting in here. Other things look good I guess.

 

[rulerofiron99]

You could keep the effect on if the target is magic immune, since most people will not give a unit permanent immunity. Thus, if the immunity wears off, it can start draining it again. Otherwise it is just a waste of casting.

Also, please come up with some other name. This "Non-channeling" thing is just not fitting in here. Other things look good I guess.

Alrighty. What name would you suggest? Custom Life Drain?

 

[MortAr]

Alrighty. What name would you suggest? Custom Life Drain?

Life Tap
Soul Drain
Energy Link
...

 

[Cryophoenix]

Thank You So much
My first request answered
5/5 +Rep

 

[FRENGERS]

This is Spartan....

 

[GaAg0]

Cool