FireExplosion v1.1

[Moderator]

18:18, 16th Sep 2010
The_Reborn_Devil:

The triggering looks ok and there are no leaks.


Status: Approved
Rating: Useful

 

[tazqaz123]

the code seems to be clean... i think... I haven't tried it yet..

and uh, one more thing.. about your "Explotion" -> it should be -> "Explosion"

Making a spell by triggers also needs a good description to make it more realistic..

^_^ have a nice day..

 

[Darkzealot_128]

Hey another Cocobo spell this will prolly be good.

Edit: Spell does no damage.

 

[Anachron]

Rename the trigger names into "FireExplosion_Init" and "FireExplosion_Loop" please.

 

[Cocobo]

@Darkzealot_128
thx

the spell does damage but may be it's deals to small damage... cause only 0,25 inteligent but if 0,25 inteligent damage only damage one unit it will be danger

@tazqaz123
Thx I will fix that

@Anachron
I will change it on next update

 

[Vengeancekael]

Add multiple heroes to the map so that we can see if it's MUI.

 

[Cocobo]

@Kael
Okay but you can test with esc to reset the cooldown

 

[Rmx]

Leaky

• For each (Integer A) from 1 to 2, do (Actions)
• Loop - Actions
• Set FE_SpecialEffectPoint[FE_Integer[3]] = (FE_CasterPoint[FE_Integer[3]] offset by (Random real number between 100.00 and 500.00) towards (Random angle) degrees)
• Special Effect - Create a special effect at FE_SpecialEffectPoint[FE_Integer[3]] using Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Destroy (Last created special effect)

You leak here 2 points each time the triggers runs and it's a timer so it will leak TON OF TIMES.

Remove the Position leak by putting it in the Loop.

Example : for each bla bla
position 1
effect
remove position 1

Put the Script of leak removal in the loop

Also your triggering is somehow not effective :S
Srsly you should try diffrent style becoz it may do some serious damage.

This trigger may work MUI on 1 hero " yes really weird "
But if done with another hero the spell the same time it may not be MUI.

You should put two heroes on the map to test if it's really MUI

Good luck that was a very fast review btw

 

[Klingo]

• Set FE_AOE[FE_Integer[2]] = 500.00

you don,t need to put array on this cause it's a constant

Edit: same thing on this

• Set FE_Timer[FE_Integer[2]] = 10.00

Edit2: you never remove location of this

• Set FE_SpecialEffectPoint[FE_Integer[3]] = (FE_CasterPoint[FE_Integer[3]] offset by (Random real number between 100.00 and 500.00) towards (Random angle) degrees)

Plus you don,t need to put it as an array cause you only use it in one trigger

edit3: caster point variable don't need to be arrayed (still unsure)

 

[MortAr]

FE_Integer should be split into 3 separate integers without array value, using less memory.

 

[Cocobo]

@Rmx

Oh yeah thx i forget to remove it

@Klingo
ow i see....
I will Fix that

@Mortar-
ehm...
so i must create 3 Varible ?
Example :
-FE_Integer1
-FE_Integer2
-FE_Integer3
like that ^ ???

 

[Klingo]

You never destroy that

• Set FE_StrikePick[FE_Integer[3]] = (Random unit from FE_CasterRandomPick[FE_Integer[3]])

 

[Cocobo]

You never destroy that

• Set FE_StrikePick[FE_Integer[3]] = (Random unit from FE_CasterRandomPick[FE_Integer[3]])

that is unit variable not unit group....

 

[Klingo]

that is unit variable not unit group....

My bad , I Thought it was Random N units from unitgroup

 

[Cocobo]

no problem