Fire Beam V2.13

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

19:07, 12th Jul 2010
TriggerHappy:

The coding is horrendous. If you're going to use that much custom script then switch to JASS. Your method of indexing is scary as well. And please, don't use waits.

 

[Axarion]

Uses waits, pauses the caster, uses DoNothing -> bad

 

[Septimus]

leak location as well :=/

 

[Klingo]

Not Mui, it does leak, Use waits and you use the useless function "do nothing"

 

[Vuormalainen]

What actions to use instead of wait?

 

[Klingo]

What actions to use instead of wait?

use timer or periodic trigger depending on what you want to do

 

[therash]

Awesome concept, but you should make the explosion lock to the point you select.

 

[Zanekok]

and dont use waits under 0.27 if you want use waits because 0.27 is smallest you can have on wait or they changed it?(you have there 0.01 and 0.00)

 

[ChaosKnight]

(Owner of FB_CasterUnit[FB_TriggerExecCount])

• set somevariable = Owner of FB_CasterUnit[FB_TriggerExecCount])

You got some of this. Does those leak?

 

[SkimmelDK]

and dont use waits under 0.27 if you want use waits because 0.27 is smallest you can have on wait or they changed it?(you have there 0.01 and 0.00)

I think they cahnged it then

 

[SkimmelDK]

Not Mui, it does leak, Use waits and you use the useless function "do nothing"

It is MUI, i tested it. And will you please tell me where the leaks are. I found some myself buy I'll like to get rid of all

 

[Zanekok]

I think they cahnged it then

You can write anything there but it changes to 0.27 if its lesser

 

[Klingo]

It is MUI, i tested it. And will you please tell me where the leaks are. I found some myself buy I'll like to get rid of all

Sorry but this isn't MUI, but do you know what MUI is? altough when I added a second hero and i made him cast he got stuck.


Edit: There's a leak

• Unit - Create 1 Start Effect1 for (Owner of FB_CasterUnit[FB_TriggerExecCount]) at (Position of FB_CasterUnit[FB_TriggerExecCount]) facing Default building facing degrees

that location need to be set into a variable then destroyed and there's alot more like this...

Edit2: I found something about leaks , maybe you should watch it.
http://world-editor-tutorials.thehelper.net/cat_usersubmit.php?view=27242

 

[SkimmelDK]

Sorry but this isn't MUI, but do you know what MUI is? altough when I added a second hero and i made him cast he got stuck.


Edit: There's a leak

• Unit - Create 1 Start Effect1 for (Owner of FB_CasterUnit[FB_TriggerExecCount]) at (Position of FB_CasterUnit[FB_TriggerExecCount]) facing Default building facing degrees

that location need to be set into a variable then destroyed and there's alot more like this...

Edit2: I found something about leaks , maybe you should watch it.
http://world-editor-tutorials.thehelper.net/cat_usersubmit.php?view=27242

I just fixed the stuck-thing, so now its MUI. MUI(Multi-Unit Instanceability) is when multiple units casts the spell at the same time. Thanks for the leak, I'll fix them.

 

[Dr Super Good]

The relience on TriggerSleepAction (both kinds of wait) means it will execute slower in multiplyer games than when testing in singleplayer. This is due to the wait being syncronized and thus adding lag onto it for each wait used.

 

[SkimmelDK]

The relience on TriggerSleepAction (both kinds of wait) means it will execute slower in multiplyer games than when testing in singleplayer. This is due to the wait being syncronized and thus adding lag onto it for each wait used.

Okay... Then I'll use timers in my next spell, but keeps the wait comamnds in this, cause its working... XD

 

[WherewolfTherewolf]

Well as you can see, there are a lot of errors present in your spell.

Some things you'll want to check out:
How to remove Leaks
How to make this spell MUI possible solution 1 - Hashtables
How to make this spell MUI possible solution 2 - Dynamic value storage

I'd suggest working with hash tables as they tend to be easy to work with, though many people suggest Dynamic value storage.

This spell is not currently acceptable.


Also using waits in loops is generally not a good idea as it can interfere with it's functions if that same loop integer is to used again while one instance is running (arrays can get around this, to a point).

Also look into using timers instead of waits - they tend to be more reliable.

 

[SkimmelDK]

Well as you can see, there are a lot of errors present in your spell.

Some things you'll want to check out:
How to remove Leaks
How to make this spell MUI possible solution 1 - Hashtables
How to make this spell MUI possible solution 2 - Dynamic value storage

I'd suggest working with hash tables as they tend to be easy to work with, though many people suggest Dynamic value storage.

This spell is not currently acceptable.


Also using waits in loops is generally not a good idea as it can interfere with it's functions if that same loop integer is to used again while one instance is running (arrays can get around this, to a point).

Also look into using timers instead of waits - they tend to be more reliable.

Thank you so much. I been looking for a dynamic value storage tutorial for some while, and that is also the reason why i used the kind of system i did in this spell. And the other tutorials also helped me, so thank you agin!

 

[darknezz003]

The Spell is too slow +wait...Everyone can kill the hero before it explodes or cast @_@

 

[x3GlikE]

The Spell is too slow +wait...Everyone can kill the hero before it explodes or cast @_@

yeah bad

It wont be good in survival / quick maps

I dont think it will even work as a boss spell??

 

[Ryumania]

For My map the spell is good enouth!!!
It also is better then Nothing that he tries it!!!!

 

[Almia]

what did i just see????
[trigger=]Wait 0.0 seconds[/trigger]