Fiery Damnation v1.31 Gui and Jass

[Kingz]

Note:

FAIL

• Unit - Create 1 FD_Dummy2 for (Owner of (Triggering unit)) at FD_tmppt1 facing Default building facing (270.0) degrees

One dummy created, it is automaticaly asigne as Last Created Unit
Then:

• If (FD_int Equal to (==) 1) then do (Unit - Add a 5.00 second Generic expiration timer to (Last created unit)) else do (If (FD_int Equal to (==) 2) then do (Unit - Add a 10.00 second Generic expiration timer to (Last created unit)) else do (If (FD_int Equal to (==) 3) then do (Unit - Add a 15.00 second Generic expiration timer to (Last created unit)) else do (Do nothing)))

First timer attached and a do nothing function.

• Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • FD_int Equal to (==) 1
  • Then - Actions
    • Unit - Add a 5.00 second Generic expiration timer to (Last created unit)
  • Else - Actions
    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • FD_int Equal to (==) 2
      • Then - Actions
        • Unit - Add a 10.00 second Generic expiration timer to (Last created unit)
      • Else - Actions
        • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • FD_int Equal to (==) 3
          • Then - Actions
            • Unit - Add a 15.00 second Generic expiration timer to (Last created unit)
          • Else - Actions

Third timer attached:

• Unit - Add a 10.00 second Generic expiration timer to (Last created unit)

So you first give it a one timer, then another and on the end yet another timer for one unit

Too much unnecesary actions...
EDIT:
I will continue this discusion tommorow as my computer needs to reboot in order to start fraps and i have to get up early

 

[Deuterium]

And why give it the same timers twice? I mean yes that's smart to do:
"Oh you dummy are going to be destroyed in 5 second, oh no, I meant in 5, oh no, what about 10?"

@ Kingz: adjust your "Hidden" tags...

 

[Squiggy]

I really seem to have forgotten to delete the if/then/else.. well it's fixed by now

Could we do that for all of my spells?
Almost thirty comments in half an evening, tis awesome advertising

 

[Deuterium]

Yeah me too, I need to head to bed...

 

[Squiggy]

I was being sarcastic.
You might know that I'm not a fan of making big posts, same goes for this one but I simply can't stand why you people have such a big deal out of that.

I admit the so-called fail in one of my lines due to the fact that I was not sober when I made the spell (that's my business, I have the right to make spells whenever I like).
But I don't get along with your comment to tell me to grow up.
You hardly know me and you judge over me, well I guess that's really mature..

 

[busterkomo]

If you guys think your rating holds any more weight than mine, then shouldn't you know better than to care about a moderator's review?

 

[jesus.is.a.lie]

This is the most retarded shit ever. Kingz fails, this spell is reasonably decent for THW standards, and Ash is right as always.

 

[Deuterium]

Well,I think I edited the post as you were writing yours...
I noticed it was a bit flaming and disrespectful of me, so yeah... apologies on that


EDIT:
@ hvo:
Are you being sarcastic with what you just said? Please tell me you are, otherwise that wouldn't be that smart of you to say

 

[Ash]

Well, I don't think a moderator should be allowed to rate, personally. It's your job to review and make sure it's of an acceptable standard, not to set precedence.

But that's a topic for site discussion.

 

[Kingz]

Glad to see this sorted up.
And btw Squiggy i never called you childish

 

[Deuterium]

Well yess thanks to Eccho!! You get our point Sguiggy now? Neither me or Kingz were trying to offend you...
Both of us usually really care for maximum efficiency when making our own spells, so we do know whether a spell can be still improved or not.


@ Ash:
Well nope, having a moderator rating allows the downloader to really know how good the spell is... I mean not all users know how to rate, but mods are supposed to know that.

 

[Rmx]

I will download the spell and search for every inch of leaks Wuahahaha ... you will regret the day you uploaded this spell

 

[Deuterium]

And the review comes when Rmx?

 

[Squiggy]

I really doubt that the spell leaks..

 

[Rmx]

Well i will just check it ... didn't tell u if it leaks yet lol

 

[nerovesper]

Too hot it burns. xD

 

[frostwhisper]

Bloody hell, this wins.

 

[Squiggy]

Here goes, I added the recoded version for the lulz.
I might reconsider a re-review of the spell

 

[Kingz]

Again, make the dummy ID's constant.
You seem not to know why you need to do that though.
So ASK Hindyhat OR someone else.
Cause currently you skipped a basic step when it comes to coding in jass.

 

[Squiggy]

Again, I know how to do it and why I should do it

 

[Deuterium]

Again, I know how to do it and why I should do it

Then why don't you?

 

[Squiggy]

I've updated some stuff now..
(read the changelog)

 

[-JonNny]

Took a look at it

Quite simple but still not bad, i like it
Thought i got some sugestions , ill comment on the vJass version

- set expTime = SquareRoot(dx * dx + dy * dy)/425
Your setting the "time" according to the units movementspeed due its moving to the target locaions
but i would guess its better to place it in the global block for modifications of the movementspeed
and btw, the units max ms is set in the gameplay constants to 400 and not 425

- You could may add a modification for the number of Missiles, shouldnt be that hard due your already using a loop

- the range the dummies move foreward is set up to 700 in the sript
if the spell got a higher castrange the dummies would stop due you are not checking the distance
add a constant for that

- The spell buggs if its casted on the hero directly (portrait or hero icon) and all missiles will move and stay forever, fix that - cannot image noone noticed that before !

- Some more comments could be good, i can image that not everyone knows whats meant with the "LIFEFACTOR" constant
Also some comments seem to be mixed up
call DestroyEffect(AddSpecialEffect(EFFPATH2,x, y)) //It's ordered to cast 'fan of knives'

does not look like fan of knives for me

All in all not bad but nothing special... [3.75/5]

 

[Azsure]

I found a bug:
The worst is that I don't remember anymore what have I did to make this happens. Oo

 

[aider]

This spell works perfectly when Im playing from the download map. But when I copy everything over, the special effects never goes away (resulting in major lagg after about 5 casts) and no damage at all. The spell in the test map goes to the target location, but copied over it alwyas goes to same range. I have triple-checked the triggers

 

[Oljin]

unfortunately this spell created so many lags in my map that i had to remove it. the more it was casted the slower the game was, until it was that slow that we had to abort it. i tried to find out why it does it, but i couldnt find any leaks...