Earth's Rampage v1.1a

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Purgeandfire; 29th Aug 2014

Latest review (short):
http://www.hiveworkshop.com/forums/2579640-post60.html

BPower 16.03.2014

http://www.hiveworkshop.com/forums/spells-569/earths-rampage-v1-0e-235480/index3.html#post2500190

Old

BPower 4.03.2014
You're nested loop is leaking groups and locations like a broken battery.

Basically you lose controll of your hero, making him rampaging into the enemies, while the creep agro ignores you because you are invulnerable. I can see one ending up in a very shitty position with chances 100 to 1. A good name could be lottery rampage.
However wc3 modding is very various and maybe someone wants exactly this concept.

Earth's Rampage v1.0c | Reviewed by Maker | 10th Jun 2013

NEEDS FIX

Load the ability level in the looping trigger from the variable you stored in the cast trigger You have four actions to remove the caster from selection, you only need one You leak the offset point when creating the dummy ER_StartPoint and ER_Dummy do not need to be arrays Units with locust won't be picked by Pick units in range. There is no need to remove the unit from the group since it is never there The dummy shouldn't give vision

[tr]

Even older review Earth's Rampage v1.0b | Reviewed by Maker | 6th Jun 2013 NEEDS FIX Leaks, the offset point when creating the dummy and ER_StartPoint that you set in ER Cast and overwrite in the looping trigger. Do a double check on any other possible leaks [tr]

 

[MasterTrainer]

~Reserved

 

[Chaosy]

effect seems nice and the triggering seems ok. I can't grade your triggers due fugly indexing which makes it unreadable for me.
I think it will be approvalbe after maker comes with 10 changes or so

 

[DESTROYER123]

Effect looks nice and according to Chaosy triggers are good.
So,
5/5

 

[MasterTrainer]

effect seems nice and the triggering seems ok. I can't grade your triggers due fugly indexing which makes it unreadable for me.
I think it will be approvalbe after maker comes with 10 changes or so

Sorry; I'm not really good when it comes to the proper indexing conventions. I'm also hoping of Maker's super-long review; it's one of the fun perks of spell making.

 

[Chaosy]

@master, it's not your indexing that is wrong. It's the index in general that blows my mind.
that's why I use hashtables in every spell I make it's so much easier to read.

 

[deathismyfriend]

@master, it's not your indexing that is wrong. It's the index in general that blows my mind.
that's why I use hashtables in every spell I make it's so much easier to read.

ooo wow umm i have a tutorial on it that should help lol. i believe thats were mastertrainer learned how to index. its in my gui tutorial. Things a GUIer Should Know. chapter is how to index. Its rather easy to understand.

Here is the principle of it.
to add things like a new instance of a spell u use the maxIndex number which u increase each time the spell is cast.

in the loop trigger u use a temp integer to loop from 1 to maxIndex.
then to de-index u move everything from maxIndex to the tempInteger ( current indexing number)
then u clean the last index up and null anything that needs to be nulled.
and finally reduce the maxIndex and the tempInteger (currentIndex)
then ur all done.

 

[Chaosy]

The problem for me as said is not to understand or use it. My eyes hurt by reading the index. My bad who wrote "blows my mind" since that's not the case .

However I am grateful for informing me

 

[deathismyfriend]

The problem for me as said is not to understand or use it. My eyes hurt by reading the index. My bad who wrote "blows my mind" since that's not the case .

However I am grateful for informing me

ooo lol. oops. u can always make a tempInt called c.
then for the maxindex u could make a variable d = maxIndex and use that instead. i do that in my spells when i make them in jass / vJass.

@TO
the config should be changed to what how i told u earlier lol

 

[MasterTrainer]

@deathismyfriend, @Chaosy, I learned indexing in 1 day, both from deathismyfriend's tutorial and Tank-Commander's MUI tutorial.

 

[Almia]

ER_Counter[ER_CurrentIndex] Equal to 33

Sounds configurable to me.

Leaks two locations( Dummy Point in the Else block and the Create Unit that has Offset)

 

[MasterTrainer]

Has offset... do you mean this:

Hidden

• Unit - Create 1 ER_Dummy for ER_TempPlayer at (ER_StartPoint[ER_CurrentIndex] offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1])))) towards (((360.00 / (Real(ER_SpireNum[ER_Level]))) x (Real(ER_TempInt2[2]))) + (ER_SpireCurve[ER_Level] x (Real(ER_TempInt2[1])))) facing Default building facing degrees

 

[Almia]

Its obvious bro

 

[MasterTrainer]

Sorry; I have a tendency to sometimes not notice something so obvious. I'll get right to it!

Thanks again Almia, (+2) Rep!

 

[Chaosy]

@death
that is actually kinda smart... If I name them 1, 2 and 3 I could use it

 

[Almia]

@MasterTrainer.

Hide that Trigger line about the offset. My page is stretching for about 2 feet (

 

[MasterTrainer]

It is done.

 

[deathismyfriend]

@death
that is actually kinda smart... If I name them 1, 2 and 3 I could use it

I'm not sure what u are referring to ? Lol sry I'm on my phone so it's hard to read everything that has been said lol.

 

[Maker]

No default spell deselects the caster, I wonder why you do that? In my opinion it shouldn't deselect.

 

[Vinz]

I concur, this ability is not like Omnislash at all.

 

[MasterTrainer]

I understand your point now Maker; I only did it so the Caster won't be able to move.

@EliTe I never intended the spell to be like Omnislash.

 

[Maker]

This makes the caster not able to move, but it can still turn.

Custom script: call SetUnitPropWindow(unit, 0)

Store the value with GetUnitPropWindow(unit) before setting it to 0, and then load it to reset it.

 

[Almia]

This makes the caster not able to move, but it can still turn.

Custom script: call SetUnitPropWindow(unit, 0)

Store the value with GetUnitPropWindow(unit) before setting it to 0, and then load it to reset it.

And also make sure to index the value of GetUnitPropWindow. Something like:

Custom script: set udg_propWindow[udg_newIndex] = GetUnitPropWindow(udg_TempU) Custom script: call SetUnitPropWindow(udg_TempU, 0)

Then after the spell ends:

Custom script: call SetUnitPropWindow(udg_TempU, udg_propWindow[udg_tempIndex])

 

[Vinz]

Omnislash-like skills deselect the hero. If you want no movement, you can set unit movement speed or those solutions above.

 

[MasterTrainer]

Oh EliTe help me out here: can you explain more on what Almia said?

 

[Vinz]

Stores propwindow into an indexed variable, sets the unit's propwindow to 0, then returns it after the spell.

EDIT: Or simply, add the propwindow into your indexing.

 

[Doomlord]

Oh EliTe help me out here: can you explain more on what Almia said?

Almia is saying that you need to attach the caster's prop window to the index being processed. Each unit has its own prop window value so you cannot use the GetUnitDefaultPropWindow () func here and you have to save it the same way you save values. When the spell ends, the unit's prop window will be set back to this value. He has explained the issue very clear there.

@Elite: Sorry, I posted on impulse.

 

[MasterTrainer]

What type of var is propwindow?

EDIT: I did not see Doom's post..

 

[Vinz]

Prop Window is Movement Speed in GUI right? Most likely either Integer or Real.

 

[Doomlord]

Real IIRC. I don't know what it is exactly either but it isn't movement speed. However, I do know that it is the only way to "trap" a unit like in the Ensnare spell.

 

[MasterTrainer]

Hmm.. I already have CurrentIndex and MaxIndex as integers for the indexes; can anyone point me to how I should get the TempIndex and NewIndex Almia was talking about?

(If this question appears to have a really obvious answer, please be informed that I am working on a lot right now)

 

[Doomlord]

Save it like you save other values. It is just a value after all

On a side note, NewIndex is MaxIndex, TempIndex is CurrentIndex.

 

[Vinz]

Indeed, it's within the real comparison. The object editor just confused me; it does not contain a decimal.

 

[Almia]

@MasterTrainer
You should learn how to read demos
That's why you got problems in your old spell weeks ago XD

and also,Prop Window is real and its not a Move Speed.

Thanks for Doomlord helping MasterTrainer to understand the demo code.

 

[MasterTrainer]

Sorry; it's just that this is the first time I'm about to use PropWindow and I'm still learning to master indexing. (And Hashtables)

Thanks Almia

 

[MasterTrainer]

LOL sorry it took me so long to update this spell... at that time I was really trying to figure out how to edit it without ruining the whole spell (i.e. removing arrays from variables that are a major part of a lot of functions/actions), it only came to me now while I was browsing the Forums.

 

[IcemanBo]

Unit - Make ER_Caster[ER_MaxIndex] Invulnerable Set ER_Caster[ER_MaxIndex] = (Triggering unit)

-->

Set ER_Caster[ER_MaxIndex] = (Triggering unit) Unit - Make ER_Caster[ER_MaxIndex] Invulnerable

I don't see you make unit unit vulnerable again.

-------- Recycling -------- Custom script: call RemoveLocation(udg_ER_SomePoint) Custom script: call DestroyGroup(udg_ER_DummyGroup) <--- Custom script: call RemoveLocation(udg_ER_TempPoint) <--- Custom script: call RemoveLocation(udg_ER_DummyPoint) <---

Why these actions? Only the line with "SomePoint" makes sense. Or not?

 

[MasterTrainer]

Unit - Make ER_Caster[ER_MaxIndex] Invulnerable Set ER_Caster[ER_MaxIndex] = (Triggering unit)

-->

Set ER_Caster[ER_MaxIndex] = (Triggering unit) Unit - Make ER_Caster[ER_MaxIndex] Invulnerable

I don't see you make unit unit vulnerable again.

-------- Recycling -------- Custom script: call RemoveLocation(udg_ER_SomePoint) Custom script: call DestroyGroup(udg_ER_DummyGroup) <--- Custom script: call RemoveLocation(udg_ER_TempPoint) <--- Custom script: call RemoveLocation(udg_ER_DummyPoint) <---

Why these actions? Only the line with "SomePoint" makes sense. Or not?

Interesting... but anyway:
I made my unit vulnerable since being invulnerable + unselectable seems unfair to some extent.


Custom script: call DestroyGroup(udg_ER_DummyGroup) <---
Custom script: call RemoveLocation(udg_ER_TempPoint) <---
Custom script: call RemoveLocation(udg_ER_DummyPoint) <---

These actions are, um, as you might say my backup plan, or ultimate cleaning of leaks solution. A desperate attempt to remove any remaining leaks.

Are they redundant since I've cleared those variables in the iterations before these actions?

 

[IcemanBo]

But then you dont need the invul action?

And, yes. You should not just destroy groups, remove locations at some place just as a backup clean. (like it's here I would not)

Just get sure to immediatly clean your leak if you can, that should be the only cool way I think.

 

[MasterTrainer]

Oh wait it seems I haven't updated the Cast trigger yet in the first post--- must fix that immediately.

Thanks for the help though )

 

[BPower]

This line does not support MUI. Fix that.

• Set ER_ControlPlayer = (Owner of ER_Caster[ER_MaxIndex])

In "Recycling" you attempt to destroy a group which does not exist.
Also you attempt to remove a location which does not exist.

• Custom script: call DestroyGroup(udg_ER_DummyGroup)

In your last loop is something very wrong.
You apply timed life multiple times to the same unit. Furthermore you add that unit to the dummy unit to the unit group.

 

[deathismyfriend]

You also forgot to mention that ER_Level is not MUI.

This also leaks

• (ER_SomePoint offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1]))))

 

[Kazeon]

effect seems nice and the triggering seems ok. I can't grade your triggers due fugly indexing which makes it unreadable for me.
I think it will be approvalbe after maker comes with 10 changes or so

the indexing is pretty okay but I do find some..

• you need to give it index or it will causes bug
  
  • Set ER_ControlPlayer = (Owner of ER_Caster[ER_MaxIndex])
  • Set ER_Level = (Level of Earth's Rampage for ER_Caster[ER_MaxIndex])
• oh, nested loop with unit enumeration inside it (I'm talking about the loop trigger)? it's a hard process for a simple looking spell, isn't it? can you find another lighter way?
  
  
• store (Facing of ER_Caster[ER_CurrentIndex]) into a variable before looping
  
  • Set ER_TempPoint = (ER_SomePoint offset by ER_TempReal towards (Facing of ER_Caster[ER_CurrentIndex]) degrees
• damage and attack type is better optional
  
  • Unit - Cause ER_Caster[ER_CurrentIndex] to damage (Picked unit), dealing ER_SpireDamage[ER_Level] damage of attack type Normal and damage type Normal
• just like BPow said, you do it wrong
  
  • Unit Group - Pick every unit in ER_DummyGroup and do (Actions)
  • Loop - Actions
  • Unit - Cause ER_SomeUnit to damage (Picked unit), dealing ER_StompDamage[ER_Level] damage of attack type Chaos and damage type Divine
  • Unit - Add a 0.30 second Generic expiration timer to ER_SomeUnit
• do you need to do it when ER_CurrentIndex is equal to ER_MaxIndex?
  
  • Set ER_Caster[ER_CurrentIndex] = ER_Caster[ER_MaxIndex]
  • Set ER_Counter2[ER_CurrentIndex] = ER_Counter2[ER_MaxIndex]
  • Set ER_Counter[ER_CurrentIndex] = ER_Counter[ER_MaxIndex]
• and this part, you do it wrong too It will not makes the caster invul for the first cast
  
  • Unit - Make ER_Caster[ER_MaxIndex] Invulnerable
  • Set ER_Caster[ER_MaxIndex] = (Triggering unit)

This also leaks

• (ER_SomePoint offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1]))))

are you sure?
he is right, you are leaking location here

• Unit - Create 1 ER_Dummy for ER_ControlPlayer at (ER_SomePoint offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1]))))

 

[MasterTrainer]

...
...
In your last loop is something very wrong.
You apply timed life multiple times to the same unit. Furthermore you add that unit to the dummy unit to the unit group.

This one is the only one left to fix... oh my god. Plus some of the things ^^ Dalvengyr said.

 

[Wrda]

Still, i don't get why you make the caster get de-selected...
On the other hand, this is a good spell.
Keep up the good work

 

[MasterTrainer]

Update: the spell now doesn't de-select the caster, so he's free to move around while the earth rampages in front of him.

 

[Kazeon]

• Unit - Create 1 ER_Dummy for ER_ControlPlayer[ER_CurrentIndex] at (ER_SomePoint offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1])))) towards (((360.00 / (Real(ER_SpireNum[ER_Level]))) x (Real(ER_TempInt2[2]))) + (ER_SpireCurve[ER_Level] x (Real(ER_TempInt2[1])))) degrees) facing Default building facing degrees

leak

 

[MasterTrainer]

But if i remove the location SomePoint in the iteration the spell misbehaves.

 

[deathismyfriend]

But if i remove the location SomePoint in the iteration the spell misbehaves.

This is the part that leaks.

• (ER_SomePoint offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1]))))

Whenever you use offset it creates a new point / location at the offset.