Esdo's "Tactical Dragonfire" spell v1.1a

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

09:21, 14th Jun 2014
BPower:
https://www.hiveworkshop.com/threads/esdos-tactical-dragonfire-spell-v1-1a.249417/post-2541250

 

[deathismyfriend]

Again this is your third spell and my third time saying this. You need to supply a config trigger for every spell you submit here.

Also never use waits in spells or anything submitted here.

 

[esdo]

Again this is your third spell and my third time saying this. You need to supply a config trigger for every spell you submit here.

Also never use waits in spells or anything submitted here.

I got the config files up on the two other spells. I just didn't post it on the spell details because it didn't seem necessary. Also i said that they where "Fully configurable ( SpellNameConfig trigger ). But whatever I will post those configs.

As for this spell... i don't see much to config other than max range and etc, because the DMG and DMG per lvl should be edited on the Unit Editor. I included instructions for that in a trigger comment in my map. I am going to make a config for that too.

The wait is necessary bacause it simply won't work without it. I don't know why. WIthout the wait the "Force player to press key" action wont work, even tho it works with all other spells i tested it with. Problem is that if i wont use berserk as a base spell, I cannot set up the cooldown.

 

[deathismyfriend]

Don't use waits. Use a timer.

 

[esdo]

Don't use waits. Use a timer.

Ok - gonna do that and add gonfig to this one.

But why are waits so bad? I get that latency can interfere in waits but this is a 0.01 timer. How could latency fuck up with that?

 

[deathismyfriend]

Waits are not timers. They are handled differently that is why waits are bad. Look at my tutorial Things You Should Know When Using Triggers / GUI. There is a chapter in there on waits. Then go to the bottom for a link to wait time delays.

 

[Tank-Commander]

I have to ask, why exactly are there so many triggers for just one spell? considering some of these have the same event (periodic) all periodic events can be reduced to one trigger, also the amount of object based damage is kind of bad - you want most if not all damage handling to be done through triggers as good practice (doing so could reduce this spell to 2 triggers, if the same is done with all periodic events) discluding the configuration

 

[Kazeon]

Spoiler Reviewed by: Dalvengyr

[TD]

[TD] Esdo's "Tactical Dragonfire" spell v1.0e [/TD]

Close

Comment

Review

Suggestion

Overall

Status

Spoiler

• This ability has an interesting concept and offer something new in this spell section (afaik) although it's somehow not practiceable at any map.

Spoiler

• Great idea but still need a lot of works
• please, don't use waits. Remove them all.
  
  • Wait 0.01 seconds
• Store the Tactical Dragon, Tactical Dragon 1, Tactical Dragon 2 into a variable
• Store dummy unit (dragon striker) into a variable
• You should remove those debug messages if you want to submit here
  
  • Game - Display to (All players) the text: Point A
  • Game - Display to (All players) the text: DRAGON!
• Use a proper projectile arc calculation and set the rate to 0 (instant)
  
  • Animation - Change TacticalDragonfire_Dragon[TacticalDragonfire_LoopInteger] flying height to 1000.00 at (1000.00 / 0.20)
  here is an easy calculation for proper missile arc
  
  Spoiler

  [COLOR="DarkSlateBlue"]((4.00 x fly_height_max) / distance_max) x (distance_max - distance_current) x (distance_current / distance_max)[/COLOR]

• there are still a lot

Spoiler

• the flame strike could be customized so user can configure damage amount, damage delay, duration, aoe, etc. via trigger

Trigger/Code
Concept
Effect
Object Editor

[TD] Category [/TD][TD] Rating [/TD]

Unacceptable

[/TD]

[tr]

 

[Adiktuz]

It's better to make damage values available as triggered ones rather than OE based... OE based damages is simply not that flexible

 

[esdo]

So, spell updated. Removed waits and added a config trigger. I don't really want to make triggered damage because the flamestrike spell fits my spell's needs so perfectly!

If it's really needed to get approval, well then, i guess ill do it later...

 

[BPower]

The configuration trigger is very poor made. Effects, ability, duration, level dependent values, magic numbers .... should also be part of the config.

Why do you use so many triggers for the same event? All periodic events could be merged into one.

Game messages are ok for debugging (in spells), but in your final release they should be removed. "DRAGON" that sounds just stupid to me. Another case of course would be if the message is directly concatenated with the spell. Yet in that case a texttag would be more fitting.

Nowhere is specified that the spell requires the hotkey "Q" in the object editor.

The tooltips are poor, you can use the blizzard default as template or be creative.