Earth's Rampage v1.1a

[GywGod133]

Do this in your other UNIT GROUP

You must save the Picked unit in a variable

so just like this

• Unit Group - Pick every unit in ER_DummyGroup and do (Actions)
  • Loop - Actions
    • Set Temp_Unit = Picked unit
    • Unit - Cause ER_Caster[ER_CurrentIndex] to damage Temp_Unit, dealing ER_SpireDamage[ER_Level] damage of attack type Normal and damage type Normal

EDIT:

You forgot this on your loop

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
  • ER_MaxIndex Equal to 0
• Then - Actions
  • Trigger - Turn off this trigger
• Else - Actions

 

[MasterTrainer]

@deathismyfriend how do I remove the leak then? I need suggestions...
@AKA.GywGod133 do i do anything else to the tempunit afterwards? Also why bother to store it in a var?

 

[deathismyfriend]

@deathismyfriend how do I remove the leak then? I need suggestions...

Same as any other location / point.

Do this.

• Set tempPointOffset = (ER_SomePoint offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1]))))
• Custom script: // Then use the point in your action.
• Custom script: //Then remove.
• Custom script: call RemoveLocation( udg_tempPointOffset)

 

[Vinz]

Only store picked unit if you reference it more than twice.

 

[MasterTrainer]

Same as any other location / point.

Do this.

• Set tempPointOffset = (ER_SomePoint offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1]))))
• Custom script: // Then use the point in your action.
• Custom script: //Then remove.
• Custom script: call RemoveLocation( udg_tempPointOffset)

Thanks man, will do.

Do this in your other UNIT GROUP

You must save the Picked unit in a variable

so just like this

• Unit Group - Pick every unit in ER_DummyGroup and do (Actions)
  • Loop - Actions
    • Set Temp_Unit = Picked unit
    • Unit - Cause ER_Caster[ER_CurrentIndex] to damage Temp_Unit, dealing ER_SpireDamage[ER_Level] damage of attack type Normal and damage type Normal

EDIT:

You forgot this on your loop

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
  • ER_MaxIndex Equal to 0
• Then - Actions
  • Trigger - Turn off this trigger
• Else - Actions

I can put the Temp_Unit, but the turning off trigger is already part of the code. Now either you meant this loop:

loop one

For each (Integer ER_TempInt2[1]) from 1 to ER_SpireElementNum[ER_Level], do (Actions) Loop - Actions For each (Integer ER_TempInt2[2]) from 1 to ER_SpireNum[ER_Level], do (Actions) Loop - Actions Unit - Create 1 ER_Dummy for ER_ControlPlayer[ER_CurrentIndex] at (ER_SomePoint offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1])))) towards (((360.00 / (Real(ER_SpireNum[ER_Level]))) x (Real(ER_TempInt2[2]))) + (ER_SpireCurve[ER_Level] x (Real(ER_TempInt2[1])))) degrees) facing Default building facing degrees Set ER_SomeUnit = (Last created unit) Set ER_DummyPoint = (Position of ER_SomeUnit) Set ER_DummyGroup = (Units within ER_SpiralRangeDamage[ER_Level] of ER_DummyPoint matching (((Matching unit) belongs to an enemy of ER_ControlPlayer[ER_CurrentIndex]) Equal to True)) Unit Group - Pick every unit in ER_DummyGroup and do (Actions) Loop - Actions Unit - Cause ER_Caster[ER_CurrentIndex] to damage (Picked unit), dealing ER_SpireDamage[ER_Level] damage of attack type Normal and damage type Normal Custom script: call RemoveLocation(udg_ER_DummyPoint) Custom script: call DestroyGroup(udg_ER_DummyGroup)

or this one:

loop two

For each (Integer ER_CurrentIndex) from 1 to ER_MaxIndex, do (Actions) Loop - Actions Set ER_Counter[ER_CurrentIndex] = (ER_Counter[ER_CurrentIndex] + 1

Which is it?

 

[GywGod133]

@mastertrainer

but the turning off trigger is already part of the code

opps sorry for that, >.<

 

[MasterTrainer]

I've fixed the leak, but now all that's left is properly caching the offset point.

 

[mogulkhan1Axe]

This looks nice 4/5

 

[Kazeon]

Execution looks horrible. As far as I see, the caster takes damage too. And the stomp is not stopped after the caster has died. Channeling would be better though.

• Set ER_SomeUnit = (Last created unit)

If that unit is used to avoid location beyond map bounds, then you should manually check the map bound instead, not by creating a unit:

• ((Playable map area) contains (Center of (Playable map area))) Equal to (==) True

I think that condition is good enough for GUI.
So you can remove that dummy unit from your spell.

Also improve the tooltip a bit. Currently, I don't have idea what does the spell do?

Also triggers in your description is different from your trigger in map. Please fix, so people wont make a wrong review.

EDIT:
After further understanding, I know what are you doing with those dummy unit.
Actually, dummy unit is totally unneeded for your spell sir, you could use:

• Special Effect - Create a special effect at (Center of (Playable map area)) using Abilities\Spells\Human\ThunderClap\ThunderClapCaster.mdl

for the special effect

And

• Set ER_DummyPoint = (Position of ER_SomeUnit)

could be replaced with

• Set ER_TempPoint = (ER_SomePoint offset by ER_TempReal towards ER_Facing[ER_CurrentIndex] degrees)

since they are totally a same. ANd again, you don't need that dummy unit.

 

[MasterTrainer]

Execution looks horrible. As far as I see, the caster takes damage too. And the stomp is not stopped after the caster has died. Channeling would be better though.

• Set ER_SomeUnit = (Last created unit)

If that unit is used to avoid location beyond map bounds, then you should manually check the map bound instead, not by creating a unit:

• ((Playable map area) contains (Center of (Playable map area))) Equal to (==) True

I think that condition is good enough for GUI.
So you can remove that dummy unit from your spell.

Also improve the tooltip a bit. Currently, I don't have idea what does the spell do?

Also triggers in your description is different from your trigger in map. Please fix, so people wont make a wrong review.

EDIT:
After further understanding, I know what are you doing with those dummy unit.
Actually, dummy unit is totally unneeded for your spell sir, you could use:

• Special Effect - Create a special effect at (Center of (Playable map area)) using Abilities\Spells\Human\ThunderClap\ThunderClapCaster.mdl

for the special effect

And

• Set ER_DummyPoint = (Position of ER_SomeUnit)

could be replaced with

• Set ER_TempPoint = (ER_SomePoint offset by ER_TempReal towards ER_Facing[ER_CurrentIndex] degrees)

since they are totally a same. ANd again, you don't need that dummy unit.

Thanks for the corrections
Damn there are a lot of things I need to learn about spells. Guess I'm too excited.

 

[PurgeandFire]

Review

This spell is almost on its way to approval! Still need to fix the leak in this line: Trigger Unit - Create 1 ER_Dummy for ER_ControlPlayer[ER_CurrentIndex] at (ER_SomePoint offset by (ER_SpiralDistance[ER_Level] + (ER_SpireDistance[ER_Level] x (Real(ER_TempInt2[1])))) towards (((360.00 / (Real(ER_SpireNum[ER_Level]))) x (Real(ER_TempInt2[2]))) + (ER_SpireCurve[ER_Level] x (Real(ER_TempInt2[1])))) degrees) facing Default building facing degrees If you fix it, make sure you update the triggers in the main post. Dalvengyr mentioned some good points.

Otherwise, it looks pretty good.