Dropping Bombing [GUI] v0.2

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Dropping Bombing [GUI] v0.2 | Reviewed by Maker | 28th Feb 2013

Needs Fix

Required changes You can get stuck due to pathing being ignored The unit goes through buildings and pathing blockers Suggested changes The spell obviously isn't v0.2 so why use that kind of version number Adding Magic Immune classification does not work, add an ability instead You should add Locust to the tree dummy, not invulnerability You set loc1 and loc2 in bot THEN and ELSE in the looping trigger, take them out of the if/then/else The spell creates upto 122 special effects per cast, which is too many

[td]
[/td]

Old reviews Dropping Bombing [GUI] v0.1 | Reviewed by Maker | 24th Feb 2013 Needs Fix Required changes Do not upload v0.1 work, only "finished" work Don't use Pause unit. It pauses buffs Add importing instructions into the map Leak Set DB_Location = ((Position of DB_Caster[DB_TempInt]) offset by DB_Speed... 288 special effects per cast is too much You can get stuck everywhere due to pathing being ignored The unit goes through trees, buildings, pathing blockers... Suggested changes Filter out dead units from being damaged The target point of ability being cast could determine how far the unit goes [td]

Old reviews

[/TD]

 

[Wrda]

The configurations should be in a init trigger, it would be more readable, unlike the cast trigger. This is all what i caught in a fast look of the triggers.

 

[shadowvzs]

like spell look cool, damage work well, only problem like with most of the similiar system is the pathing, i can go trought the cliffs/ trees and stuck at end

 

[Marcos DAB]

like spell look cool, damage work well, only problem like with most of the similiar system is the pathing, i can go trought the cliffs/ trees and stuck at end

I could refine the code to finish running when collides with something insurmountable.

But there is a way that you can change if you want, changing just one line.
Not the best way, but it serves.

• (Terrain pathing at DB_Location of type Flyability is off) Not equal to True

To

• (Terrain pathing at DB_Location of type Walkability is off) Not equal to True

 

[shadowvzs]

I could refine the code to finish running when collides with something insurmountable.

But there is a way that you can change if you want, changing just one line.
Not the best way, but it serves.

• (Terrain pathing at DB_Location of type Flyability is off) Not equal to True

To

• (Terrain pathing at DB_Location of type Walkability is off) Not equal to True

that dont do nothing with obstacles like trees/ pathblockers etc......

best way is useing a GetTerrainWalkable library but since it isnt vjass u can use something gui version similiar like this

header

function HideBothersomeItem takes nothing returns nothing
  if IsItemVisible(GetEnumItem()) then
      set udg_TW_HI[udg_TW_Max]=GetEnumItem()
      call SetItemVisible(udg_TW_HI[udg_TW_Max],false)
      set udg_TW_Max=udg_TW_Max+1
  endif
endfunction
 
function IsTerrainWalkable takes real x, real y returns boolean
        call MoveRectTo(udg_TW_R,x,y)
        call EnumItemsInRect(udg_TW_R,null,function HideBothersomeItem)
        call SetItemPosition(udg_TW_IC,x,y)//this unhides the item...
        set udg_TW_X=GetItemX(udg_TW_IC)-x
        set udg_TW_Y=GetItemY(udg_TW_IC)-y
        call SetItemVisible(udg_TW_IC,false)//...so we must hide it again
      loop
         exitwhen udg_TW_Max<=0
         set udg_TW_Max=udg_TW_Max-1
         call SetItemVisible(udg_TW_HI[udg_TW_Max],true)
         set udg_TW_HI[udg_TW_Max]=null
      endloop
    if IsTerrainPathable(x, y, PATHING_TYPE_WALKABILITY) then
       return false
    else
       return udg_TW_X*udg_TW_X+udg_TW_Y*udg_TW_Y<udg_TW_MaxR  
    endif
endfunction

settings

• Map initilize
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- X and Y coordinates --------
    • Set TW_X = 0.00
    • Set TW_Y = 0.00
    • -------- Max Range --------
    • Set TW_MaxR = 1.00
    • -------- Hidden item for check --------
    • Custom script: set udg_TW_IC=CreateItem('ciri',0,0)
    • Item - Hide TW_IC
    • -------- Array index for hidden item array --------
    • Set TW_Max = 0
    • -------- Region for system --------
    • Custom script: set udg_TW_R = Rect(0.0,0.0,128.0,128.0)

demo

• Example
  • Events
    • Time - Every 0.30 seconds of game time
  • Conditions
  • Actions
    • -------- Point variable is used for this demo, not part of the system --------
    • Set Point = (Position of Gryphon Rider 0001 <gen>)
    • Custom script: if IsTerrainWalkable (GetLocationX(udg_Point), GetLocationY(udg_Point)) then
    • Game - Display to (All players) the text: Point is walkable
    • Custom script: else
    • Game - Display to (All players) the text: Point isnt walkable...
    • Custom script: endif
    • Custom script: call RemoveLocation(udg_Point)

 

[Chaosy]

Looks neat but I highly dislike your indexer I can't read that so no triggering tips from me.

but then again it looks nice