Dota 2 Meat Hook Ability v1.1.2

[Moderator]

13:40, 01st Feb 2015
Changed were made, and it works fine. Approved.

Old

23:53, 27th Jan 2015
IcemanBo: Read my posts in thread. You don't change it in your updates.

IcemanBo: http://www.hiveworkshop.com/forums/...ability-v2-0-a-258574/index3.html#post2643828

IcemanBo: http://www.hiveworkshop.com/forums/...ability-v1-9-a-258574/index3.html#post2642134
IcemanBo:
You leak onCast. (MH_Point[MH_Index1] is never removed)
The points don't need to be array variables. StartPoint included.. No need to index it.

IcemanBo: http://www.hiveworkshop.com/forums/...ability-v1-6-a-258574/index3.html#post2638544

IcemanBo: http://www.hiveworkshop.com/forums/spells-569/dota-2-meat-hook-ability-v1-6-a-258574/index3.html#post2638479

IcemanBo: http://www.hiveworkshop.com/forums/...ability-v1-5-a-258574/index3.html#post2638113

03:10, 7th Jan 2015
IcemanBo:
http://www.hiveworkshop.com/forums/...ability-v1-4-a-258574/index3.html#post2636900

 

[GywGod133]

Please post the trigger to easy review

Code:
[trigger]CODE[/trigger]

--->

• CODE

EDIT:

Setup

• setup
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set HookAbility = Meat Hook
    • Set HookTravelDistance = 800.00
    • Set HookDamage = 75.00

Start

• hook1
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to HookAbility
  • Actions
    • Set HookCallCount = (HookCallCount + 1)
    • Set Hooker[HookCallCount] = (Triggering unit)
    • Set TempPoint = (Position of (Triggering unit))
    • Set HookStartPoint[HookCallCount] = (Position of (Triggering unit))
    • Set HookDistance[HookCallCount] = HookTravelDistance
    • Set HookAngle[HookCallCount] = (Angle from (Position of (Triggering unit)) to (Target point of ability being cast))
    • Unit Group - Pick every unit in (Units in (Playable map area) matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is A structure) Not equal to True) and ((Matching unit) Not equal to (Triggering unit))))) and do (Actions)
      • Loop - Actions
        • Unit Group - Add (Picked unit) to AvailableTargets
    • Unit - Create 1 Chicken for (Triggering player) at TempPoint facing HookAngle[HookCallCount] degrees
    • Player - Disable Meat Hook for (Owner of Hooker[HookCallCount])
    • Set HookHead[HookCallCount] = (Last created unit)
    • Set ActiveHook[HookCallCount] = True
    • Custom script: call RemoveLocation(udg_TempPoint)

Loop

• hook2
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to HookCallCount, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ActiveHook[(Integer A)] Equal to True
          • Then - Actions
            • Set HookerPos[(Integer A)] = (Position of Hooker[(Integer A)])
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • And - All (Conditions) are true
                  • Conditions
                    • (Distance between HookStartPoint[(Integer A)] and (Position of HookHead[(Integer A)])) Less than HookDistance[(Integer A)]
                    • HookFlag[(Integer A)] Equal to False
              • Then - Actions
                • Unit Group - Pick every unit in (Units within 75.00 of (Position of HookHead[(Integer A)]) matching ((((Matching unit) is A structure) Not equal to True) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Not equal to (Owner of HookHead[(Integer A)]))))) and do (Actions)
                  • Loop - Actions
                    • Set HookOn[(Integer A)] = True
                    • Set HookedUnit[(Integer A)] = (Picked unit)
                    • Set HookFlag[(Integer A)] = True
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • ((Picked unit) belongs to an enemy of (Owner of HookHead[(Integer A)])) Equal to True
                      • Then - Actions
                        • Unit - Cause Hooker[(Integer A)] to damage (Picked unit), dealing HookDamage damage of attack type Spells and damage type Divine
                      • Else - Actions
                • Set DestPoint[(Integer A)] = ((Position of HookHead[(Integer A)]) offset by 45.00 towards HookAngle[(Integer A)] degrees)
                • Unit - Move HookHead[(Integer A)] instantly to DestPoint[(Integer A)]
                • Lightning - Destroy (Last created lightning effect)
                • Lightning - Create a Magic Leash lightning effect from source HookerPos[(Integer A)] to target (Position of HookHead[(Integer A)])
                • Custom script: call RemoveLocation(udg_DestPoint[GetForLoopIndexA()])
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • And - All (Conditions) are true
                      • Conditions
                        • (HookHead[(Integer A)] is in (Units within 90.00 of HookerPos[(Integer A)])) Equal to True
                        • HookFlag[(Integer A)] Equal to True
                  • Then - Actions
                    • Lightning - Destroy (Last created lightning effect)
                    • Unit - Remove HookHead[(Integer A)] from the game
                    • Player - Enable Meat Hook for (Owner of Hooker[(Integer A)])
                    • Set ActiveHook[(Integer A)] = False
                    • Set HookFlag[(Integer A)] = False
                    • Set HookOn[(Integer A)] = False
                  • Else - Actions
                    • Set HookFlag[(Integer A)] = True
                    • Set DestPoint[(Integer A)] = ((Position of HookHead[(Integer A)]) offset by 45.00 towards ((Angle from HookerPos[(Integer A)] to (Position of HookHead[(Integer A)])) + 180.00) degrees)
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • HookOn[(Integer A)] Equal to True
                      • Then - Actions
                        • Unit - Move HookedUnit[(Integer A)] instantly to DestPoint[(Integer A)]
                      • Else - Actions
                    • Unit - Move HookHead[(Integer A)] instantly to DestPoint[(Integer A)]
                    • Unit - Make HookHead[(Integer A)] face (Angle from HookerPos[(Integer A)] to (Position of HookHead[(Integer A)])) over 0.00 seconds
                    • Lightning - Destroy (Last created lightning effect)
                    • Lightning - Create a Magic Leash lightning effect from source HookerPos[(Integer A)] to target (Position of HookHead[(Integer A)])
                    • Custom script: call RemoveLocation(udg_DestPoint[GetForLoopIndexA()])
            • Custom script: call RemoveLocation(udg_HookerPos[GetForLoopIndexA()])
          • Else - Actions

============

ĺong code

• Unit Group - Pick every unit in (Units in (Playable map area) matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is A structure) Not equal to True) and ((Matching unit) Not equal to (Triggering unit))))) and do (Actions)
  • Loop - Actions
    • Unit Group - Add (Picked unit) to AvailableTargets

You have Unit Group Leak

In Unit Group you must use ITE(IF THEN ELSE) instead using Unit Group for checking the condition.
Like this...

• Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
  • Loop - Actions
    • Set SaveYourPickedUnit = (Picked unit)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Put here your condition
      • Then - Actions
        • Unit Group - Add SaveYourPickedUnit to AvailableTargets
      • Else - Actions

You need to store the picked unit in variable

• Set HookAngle[HookCallCount] = (Angle from (Position of (Triggering unit)) to (Target point of ability being cast))

You have point location leak here

• For each (Integer A) from 1 to HookCallCount, do (Actions)
  • Loop - Actions

Dont use Integer A / B
use Integer Variable instead

• Unit Group - Pick every unit in (Units within 75.00 of (Position of HookHead[(Integer A)]) matching ((((Matching unit) is A structure) Not equal to True) and ((((Matching unit) is alive) Equal to True) and ((Owner of (Matching unit)) Not equal to (Owner of HookHead[(Integer A)]))))) and do (Actions)
  • Loop - Actions
    • Set HookOn[(Integer A)] = True
    • Set HookedUnit[(Integer A)] = (Picked unit)
    • Set HookFlag[(Integer A)] = True
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) belongs to an enemy of (Owner of HookHead[(Integer A)])) Equal to True
      • Then - Actions
        • Unit - Cause Hooker[(Integer A)] to damage (Picked unit), dealing HookDamage damage of attack type Spells and damage type Divine
      • Else - Actions

Unit Group leak
need ITE also


You must add Turn Off / Turn On function
in your Loop Trigger

 

[dark09cry]

Thanks for the feedback.

Thanks for noticing those leaks. I will fix them ASAP.

 

[Deleted member 219079]

Dont use Integer A / B

I'm curious, what's wrong with

    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 10
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop

With own variable it'd transform to:

    set udg_i = 1
    loop
        exitwhen udg_i > 10
        set udg_i = udg_i + 1
    endloop

If it's about assigning bj_forLoopAIndexEnd, this isn't a JASS forum. Integer assigment doesn't have visual impact afaik.

---

• For each (Integer TempHookIndex) from 1 to HookCallCount, do (Actions)
  • Loop - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
  • ActiveHook[TempHookIndex] Equal to True

This is a creative way of looping, but I recommend checking:
http://www.hiveworkshop.com/forums/...orials-279/visualize-dynamic-indexing-241896/
http://www.hiveworkshop.com/forums/spells-569/gui-dynamic-indexing-template-144325/

---

• (HookHead[TempHookIndex] is in (Units within 90.00 of HookerPos[TempHookIndex])) Equal to True

) is an unit group, I recommend creating variable group g, and doing it like this:

• Set g = Units within 90.00 of HookerPos[TempHookIndex]
• ... (use the group) ...
• Custom Script - call DestroyGroup(udg_g)

Otherwise you'll keep your memory employed for nothing.
Alt. way is to use:

• Custom script: set bj_wantDestroyGroup = true

Before using temporary groups.



This is a good start and the spell is practical and balanced, but I hope you'll check the dynamic indexing links I gave you
Train hard and you might become the next god of WC3 modding ;P

 

[GywGod133]

@Jondrean

I'm curious, what's wrong with

    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 10
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop

With own variable it'd transform to:

    set udg_i = 1
    loop
        exitwhen udg_i > 10
        set udg_i = udg_i + 1
    endloop

If it's about assigning bj_forLoopAIndexEnd, this isn't a JASS forum. Integer assigment doesn't have visual impact afaik.

cuz of bj
You need to avoid the bj

You can use Integer A / B
but its slower

 

[Meatmuffin]

I'm somewhat confused, maybe because I don't have enough practice

• Lightning - Destroy (Last created lightning effect)
  • Lightning - Create a Magic Leash lightning effect from source HookerPos[TempHookIndex] to target (Position of HookHead[TempHookIndex])

Why do you destroy the lightning before you create it?

 

[GywGod133]

@lithuffin

• Lightning - Destroy (Last created lightning effect)

Useless....

 

[Meatmuffin]

Define useless, because I'm still confused.

 

[Deleted member 219079]

cuz of bj
You need to avoid the bj

I dunno who the hell have taught you so...

Not all BJs are bad. In this case bj_forLoopAIndexEnd and bj_forLoopAIndex are only global variables. Even though when using own integer, end index will get inlined, there is no visual impact compared to the bj one.

Something like:

function CameraSetSmoothingFactorBJ takes real factor returns nothing
    call CameraSetSmoothingFactor(factor)
endfunction

Is a shadow caller, which will cost you a function call.
But something like:

function RMaxBJ takes real a, real b returns real
    if (a < b) then
        return b
    else
        return a
    endif
endfunction

Is very useful, and there is no need for recreating such a function.

 

[Daffa]

I don't care much with A/B.
Its far easier to check and organize with Variable Integer.

 

[dark09cry]

Thanks for the tips...

I'm planning to index each caster and edd them in a unit group. Will that cause any leaks?

 

[Deleted member 219079]

I'm planning to index each caster and edd them in a unit group. Will that cause any leaks?

So you will use Unit Indexer?

Then I'm pretty sure that's called Paladon's indexing. It's just fine and pretty efficient too

I'd say go for it, it sounds good.

About leaks, it's up to you to succesfully get rid of any leaks. Post the code here to get feedback.

 

[dark09cry]

No, I'm not using any plugins. It's just the idea of it that's I'm going to implement. I'll update the description.

 

[deathismyfriend]

I dunno who the hell have taught you so...

Not all BJs are bad. In this case bj_forLoopAIndexEnd and bj_forLoopAIndex are only global variables. Even though when using own integer, end index will get inlined, there is no visual impact compared to the bj one.

I told GywGod133 about the integer A/B.

They never get inlined. Take a look at this for example.

• For each (Integer A) from 1 to 10, do (Actions)
  • Loop - Actions
    • Game - Display to (All players) the text: (String((Integer A)))

Gets changed to this.

function Trig_Untitled_Trigger_001_Actions takes nothing returns nothing
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 10
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call DisplayTextToForce( GetPlayersAll(), I2S(GetForLoopIndexA()) )
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
endfunction

You can see that Integer A/B use a function call whenever the looping integer is used. This causes slower performance and is just lazy coding when all it takes is one variable to create.

No, I'm not using any plugins. It's just the idea of it that's I'm going to implement. I'll update the description.

A Unit Indexer is not a plug in. It is a system on the hive. It is very useful in some cases. I don't see a reason that you need it in here though.

These still leak a location.

• Distance between HookStartPoint[TempHookIndex] and (Position of HookHead[TempHookIndex])) Less than HookDistance[TempHookIndex]
• Unit - Make HookHead[TempHookIndex] face (Angle from HookerPos[TempHookIndex] to (Position of HookHead[TempHookIndex])) over 0.00 seconds

These should be stored as it is used more than once.

• Owner of Hooker[TempHookIndex])
• ((HookDistance[TempHookIndex] / HookTravelDuration) / 10.00)

Remove this

• And - All (Conditions) are true

After De-Indexing you should null all variables except integers / reals / strings. (I might be forgetting one.)

 

[Deleted member 219079]

They never get inlined.

I didn't say they do? Re-read my post.

You can see that Integer A/B use a function call whenever the looping integer is used.

+rep FINALLY! A sensible answer for why A/B is bad;

cuz of bj
You need to avoid the bj

This tells me nothing.

After De-Indexing you should null all variables except integers / reals / strings. (I might be forgetting one.)

You don't need to null variables which extend handle, null everything which extends widget or agent: http://warcraft.ingame.de/maps/mappedia/Common.j

 

[deathismyfriend]

You don't need to null variables which extend handle, null everything which extends widget or agent: http://warcraft.ingame.de/maps/mappedia/Common.j

That is not true. You need to null everything except strings / integers / reals. And as said I may be missing one. Handles do leak when not nulled. There handles are never removed so they take up space when not being used.

 

[Deleted member 219079]

Please prove me wrong. Sources are appreciated.

 

[deathismyfriend]

Please prove me wrong. Sources are appreciated.

Run some tests yourself and see. Also I am saying what most mods here say about nulling. If you want sources speak to Maker he is the one that did most of the tests for leaks himself.

 

[Deleted member 219079]

That is no source. But please if you have a way to prove me wrong then do so, currently I have following statement in my tutorial:

Certain non-nullied locals can cause performance impact. Abstract is something conceptual, for example an unit; we define unit by certain properties and unit is always a subject to change in-game.

Something not abstract is integer, we are certain 3 is 3.
To null local use set myLocal = null
For further learning about which variable types should be nullied, open up this page. Null everything which extends widget or agent; these have abstract properties so you need to null them.

And you're the first one to say that stands wrong. Just any post regarding such benchmarks is appreciated

Run some tests yourself and see.

Gimme a code to test and I shall test it.

Also I am saying what most mods here say about nulling.

I've never seen a mod say so.

 

[deathismyfriend]

That is no source. But please if you have a way to prove me wrong then do so, currently I have following statement in my tutorial:



And you're the first one to say that stands wrong. Just any post regarding such benchmarks is appreciated


Gimme a code to test and I shall test it.


I've never seen a mod say so.

I don't code in WC3 much anymore. If you want benchmarks then make it yourself it is not hard.
Repeatedly create a new lightning then destroy it. Then show handle id to see. It is maybe 3 or 4 GUI actions so not hard to show that it is bad to not null.
The handle id does not get released unless they are nulled.

 

[Deleted member 219079]

Repeatedly create a new lightning then destroy it.

No difference between this

scope a initializer init {
    include "cj_types.j"
    integer i = 0
    player p = Player(0)
    void f () {
        i = i + 1
        lightning l = AddLightning("CLPB", false, 0, 0, 100, 100)
        DestroyLightning(l)
        DisplayTextToPlayer(p, 0, 0, I2S(i)+" "+I2S(GetHandleId(l)))
        l = null
    }
    void init () {
        PanCameraTo(0,0)
        FogEnable(false)
        FogMaskEnable(false)
        TimerStart(CreateTimer(), 0.001, true, function f)
    }
}

and this

scope a initializer init {
    include "cj_types.j"
    integer i = 0
    player p = Player(0)
    void f () {
        i = i + 1
        lightning l = AddLightning("CLPB", false, 0, 0, 100, 100)
        DestroyLightning(l)
        DisplayTextToPlayer(p, 0, 0, I2S(i)+" "+I2S(GetHandleId(l)))
    }
    void init () {
        PanCameraTo(0,0)
        FogEnable(false)
        FogMaskEnable(false)
        TimerStart(CreateTimer(), 0.001, true, function f)
    }
}

Both became unresponsive after a while.

Then show handle id to see.

It gave me 1 the whole time.

The handle id does not get released unless they are nulled.

My sensei Malhorne didn't say my statement is wrong (I'm talking about the tutorial), though I'm not sure how accurately he looked at it. I could beg for his wisdom ask him again if you insist.

It might be that I've made the benchmark wrong, tell me if I have.

 

[deathismyfriend]

You are never creating a local timer variable in that.

 

[Deleted member 219079]

Since you're the teacher of my sensei I have to believe you

 

[deathismyfriend]

Since you're the teacher of my sensei I have to believe you

I was able to test lightning it looks like Malhorne must have tested some more things than I did. You do not not to null lightning variables but I'm not sure about the others.

I'll have to ask him what others he tested.

 

[Deleted member 219079]

Feel free to report here, I'll make necessary changes to my tutorial then, it has been in the submissions since may... :'(

 

[Melvic]

what are you guys showing?

 

[deathismyfriend]

You store triggering unit. You should use the variable in these.

• Set Hooker[HookCallCount] = (Triggering unit)
• Set TempPoint = (Position of (Triggering unit))
• Set HookLevel[HookCallCount] = (Level of HookAbility for Hooker[HookCallCount])
• Set HookStartPoint[HookCallCount] = (Position of (Triggering unit))

 

[lgxstfu]

Sir can you help me with these bugs?
.
.

i implemented your spell on Multiple Units,
when my Character and the AI Enemy uses the Hook at the same time,
these Happens:
when my Hookhead Reach's the Return Detector of AI Enemy
my Character Blink's Instantly to Enemy's Position.

HELP SIR PLSS

 

[axator]

In "hook1" trigger:

• Set Hooker[HookCallCount] = (Triggering unit)
• Set TempPoint = (Position of (Triggering unit))
• Set HookStartPoint[HookCallCount] = (Position of (Triggering unit))
• Set HookerPos[HookCallCount] = (Position of Hooker[HookCallCount])

What's the point of saving the same point into 3 different variables?
After saving Triggering Unit into Hooker variable you should use him while setting other variables: Position of (Triggering unit) ---> Position of Hooker[HookCallCount]

 

[Vinz]

@OP, why do you pick units in Playable Map Area? I suggest using Detector immediately.

 

[IcemanBo]

You don't need all these "And All Conditions" blocks in your loop. They are linked with a logical and by default.

I was able to test lightning it looks like Malhorne must have tested some more things than I did. You do not not to null lightning variables but I'm not sure about the others.

It's is because you don't have to null all handles. But agents. player is an exxception, because it is an constant agent, that doesn't have to be nulled.
Here is the list of all handles (agents included): http://jass.sourceforge.net/doc/api/BUILT_IN-types-handle.shtml

 

[IcemanBo]

• Provide an in-game screenshot.
• Make a short, but informative spell description.
• Your SetUp trigger must run automatically after map initialization. User should not have to run it himself.
• Make the configuration to support levels.
• I would suggest you to get rid of the import data. Spells should be as stand alone as possible and easy to import. How ever you simply could suggest the icon and model in your thread and share a link to them.
• Give all your triggers and variables decent names. For example: prefix_Name. ("DMH_MaxIndex" as example)
• For now I only had a very quick look over the code, but you don't need these "And - All Condtions" blocks. You can see condtions in GUI as automatically linked with a logical and.
• The check to turn off the loop should be moved into the deindex part.

Needs Fix

 

[dark09cry]

Regarding the display of the thread, how can you make it fit with the browser width. Mine seem over the right.

 

[Almia]

Seriously?

We have tons of this since the day Pudge was born!

Well anyways if you want to submit this, well I don't have the power to stop your freedom

 

[IcemanBo]

@Almia, I checked some of older approved resources, and found out they don't fit the modern standards.

So it might be ok to have one well coded GUI version.

Now to the hook:

- Add import instructions.
- Give your dummy a decent name. "Chicken" might be confusing.
- Change the ability to "Hero Ability", so heroes can learn them. Don't forget to add a learn tooltip for it, once it's a hero ability.
- MH_Flag boolen is not needed. You can solve this only by operating with the counter.
- Effec should be set in config.
- Attack- Damage type should be set in config.
- If no target was found in time, no need to do certain operations. So directly make the check on top if it needs to be deindexed or not.

Needs Fix

 

[dark09cry]

Add import instructions.

Ok, Is my How To Use section in thread don't supply enough information on how to import?

If no target was found in time, no need to do certain operations. So directly make the check on top if it needs to be deindexed or not.

I'm a bit confused about this one? Don't understand what it meant. Can you rephrase that?

Thanks.!

 

[IcemanBo]

(Unit-type of TempUnit) != (Unit-type of MH_Hook[MH_Index2])

->

(Unit-type of TempUnit) != HookDummy)

Only move HookedUnit if it exists. As you do with creating special effect.

Instead of a DistCounter you just could check for hook's distance.

In loop when hook cathes a unit after this check:

(TempUnit is Immun gegen Magie) == True

... you do similar operations twice. It can restructured and merged a bit.

UnitGroup Detector2 is not needed at all. Just checking for distance would suffice.

Some short and useful documentation in main code is always appreciated.

Yes, you are right import instructions exist in thread. I think it's acceptable, too.
It was a personal preference, because I think it's more useful to add them direcly in your spell folder. But it's up to you.

It's a nice looking hook. I like it!

Still some changes needed, Needs Fix.

 

[dark09cry]

Only move HookedUnit if it exists. As you do with creating special effect.

The hooked unit only moves if MH_HookOn is True which is set along in checking for a hooked unit. What is the error in that?

Instead of a DistCounter you just could check for hook's distance.

I did in previous versions but a bug seems to pop and MUI capabilities are stripped off that's why I switched to a counter. Works well now.

UnitGroup Detector2 is not needed at all. Just checking for distance would suffice.

Right, I forgot some editing along and didn't realize that. Good thing you noticed. Updating...

In loop when hook cathes a unit after this check:

• (TempUnit is Immun gegen Magie) == True

... you do similar operations twice. It can restructured and merged a bit.

Yeah, you're right quick fix and its good to go.

It's a nice looking hook. I like it!

Cool right, and it glows too. Haha...

Thanks.!

 

[IcemanBo]

^No error is in it. It's okay.

For deindexing:

(Distance between MH_HookerPos[MH_Index2] and MH_HookPos[MH_Index2]) <= 98.00

I do not like this check. Your creation offset is 80.00. So distance check must be a lower value. Not 98. Else it may be that the hook will be deindexed immediatly. (happened in my test)
So better make it a lower constant value. Best -> make it a (not for user) variable in config trigger, to ensure the distance value for deindex is always lower than the distance creation value.

Change it and it can be approved. Also please give your file a proper name with version number. For example: "Meat Hook v1.6"

Needs Fix

 

[IcemanBo]

Your played sound is set once in setup trigger. It is always constant. No neeed to use an array variable and index it for each instance.

DestPoint doesn't need to be an array. And why do you want do deindex it dynamicly? I don't see the sense, because you create and remove in each loop run.

^Same for Angle.

Basicly... If you evaluate new values each iteration, there is no need at all to index/deindex the variable.
Only use array variable, and index it if really needed.

The hook should end, if caster is dead or removed.

Needs Fix

 

[IcemanBo]

If caster is not alive the hook goes on, and then will disappear when going back.

It probably would be even better, if it would instantly disappear, so also before it reached the max distance.

Also if caster is dead, operations/checks for movement of dummy or damaging the hooked unit is not really needed. Only deindexing neeeded to be done. (if there is a hooked unit, you would try to damage it, even caster is dead or removed)

The Angle does not to be an array. You evaluate it each iteration depanding on given points. So also no need to index/deindex it.

 

[dark09cry]

Major Update Reasons

How come the angle doesn't need to be an array? I don't understand why. I use it once on hook launch, then use it again on return but that is well the same variable. Should I just use a TempReal variable over the Angle one? You couldn't really tell if damaging a hooked unit while caster died is really a problem now. The damage check for the hooked unit is a bug solution that removes the bug which damages a nearby enemy unit within the hook's search radius while it is not the hooked unit. About the overdoing of variables in the loop code, I reverted it because there's a bug that the hook returns on a magic immune enemy unit rather than pass through it if the config is set to false. Should I remove attachments? It's optional though, it still works without it and its editable in the config. (Updated)

 

[IcemanBo]

In your loop, in your first condition block:

(MH_DistCounter[MH_Index2] < MH_Distance[MH_Index2]) [/stable] add a check if caster is alive. Hook should be stopped then: (MH_DistCounter[MH_Index2] < MH_Distance[MH_Index2]) (MH_Hooker[MH_Index2] is dead) == False [/stable] Rest might be negligible. Remove attachments? No I think you do good with it.

 

[dark09cry]

(Updated)

Ok now I did what you said but isn't it repeated already? I put the deindexing outside the if else statement for the hook and that might be what you are mentioning. Though I will wait for your comment.

 

[IcemanBo]

Yeah, the deindexing now works correctly. Good. But actually no need to run the HookBackwards if unit is dead, too. You currently do:

Current structure:

If Caster == Alive and HookingFowards then

DoHookForwards()​

else

DoHookBackwards()​

endif

If Caster == Dead or HookFinished then

Deindex()​

endif

The "DoHookBackwards()" will have no real affect. You will do checks/operations for nothing here. (though it will only run once, if caster is dead)
So you could do...

Alternative structure:

If Caster == Alive then

if HookForwards then​

DoHookForwards()​

else​

DoHookBackwards()​

endif​

else

Deindex()​

endif

However, it works.

Approved

Note that you potentially call the function "OwnerOfHooker" more often. You could reduce the amount of these function calls to one, if you index the player onCast.

 

[dark09cry]

Nice, thanks for the approval. However Your suggestion might take a while because my PC broke and I had to reset everything.

 

[Lign]

Lots of coders making this ability in Jass. So this's 5/5 to me 'cause.....GUI =)

btw, I will use this in my map! Thank you!

 

[Flux]

The problem using Lightning Effect as the chain is that once a player saw the tip of the hook, he can also know where the hook caster is positioned because the whole lightning effect will be visible. Nevertheless, its a good spell so +rep.

 

[Trakya]

How to make the hook only to grab enemies not allies?