Detect Unit/Item Type from code in string

[ALiEN95]

Edit:

ITEM LIST :
I005,I002,I004,I003,I001
how can my trigger detect item-type from this list?

UNIT LIST:
Hblm,hpea
how can my trigger detect unit-type from this list?

 

[Pharaoh_]

But that method you did works fine, why would you want strings for that?

 

[ALiEN95]

But that method you did works fine, why would you want strings for that?

no,it cant work its "fake"

im just showing how the all list would be reading that its possible

 

[Pharaoh_]

• Trigger
• Events
  • Player - Player 1 (Red) types a message containing -item as a Substring
• Conditions
• Actions
  • Set String = ((Entered chat string), 7, 10)
  • Set Unit = Your unit
  • Custom script: call CreateItem (S2I(udg_String), GetUnitX(udg_Unit), GetUnitY(udg_Unit))
  • Custom script: call UnitAddItem (udg_Unit, GetLastCreatedItem())

 

[ALiEN95]

• Trigger
• Events
  • Player - Player 1 (Red) types a message containing -item as a Substring
• Conditions
• Actions
  • Set String = ((Entered chat string), 7, 10)
  • Set Unit = Your unit
  • Custom script: call CreateItem (S2I(udg_String), GetUnitX(udg_Unit), GetUnitY(udg_Unit))
  • Custom script: call UnitAddItem (udg_Unit, GetLastCreatedItem())

tried everything but it didn't work

can you do this please?

this is the list of items

I005,I002,I004,I003,I001

set item type variable = first code

this is the list of units

hwt3,Hblm,hpea

set unit type variable = first code

 

[Pharaoh_]

I remember a script on WC3C that was doing this, but unfortunately, I can't find it. This trigger should work, but when I display the String variable, it returns 0. Either I can't notice what I'm doing wrong or the conversion is false.

• Item
  • Events
    • Player - Player 1 (Red) types a chat message containing - as A substring
  • Conditions
  • Actions
    • Set String = (Integer((Substring((Entered chat string), 2, 5))))
    • For each (Integer A) from 1 to 5, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Integer((Substring((Entered chat string), 5, 5)))) Equal to (Integer A)
          • Then - Actions
            • Custom script: call UnitAddItemById(udg_Unit, udg_String)
          • Else - Actions

P.S. "String" is an Integer variable.

 

[ALiEN95]

I remember a script on WC3C that was doing this, but unfortunately, I can't find it. This trigger should work, but when I display the String variable, it returns 0. Either I can't notice what I'm doing wrong or the conversion is false.
P.S. "String" is an Integer variable.

Custom script: call UnitAddItemById(udg_Unit, udg_String)
i think custom script works on order id code that has 14 digits
I005 is not integer and its returns 0
none of this things work



if anybody can do this it would be enough

set String = I005
set Item_Type = String

 

[ikillforeyou]

try " ' + Integer(Item code) + ' "

 

[ALiEN95]

try " ' + Integer(Item code) + ' "

im not sure if you make any sense xD,it cant work ....

 

[PurgeandFire]

Do you mean something like this? It should work:

• Actions
  • Custom script: set udg_int1 = 'I005'
  • Set string1 = (String(int1))
  • Set int2 = (Integer(string1))

Unless you mean something else.

 

[ikillforeyou]

Hmm, no, there is no way

if you wanted, you'd have to set the ability values to an array, like this

local integer array abilis
set abilis[0] = 'A001'
set abilis[1] = 'A002'
set abilis[2] = 'A003'

etc, etc
Catch my drift?

 

[Berb]

Well if I remember correctly the old code that you're referring to is from pre-patch 1.24b --I believe it used a function like this for converting from a string to an integer:

function s2i takes string s returns integer
    return s
    return 0
endfunction

Since then we have lost this kind of functionality, though nobody here has mentioned anything about StringHash, which is also used to convert a string into an integer. There is also AbilityId which I haven't been able to get working properly.

 

[PurgeandFire]

Well if I remember correctly the old code that you're referring to is from pre-patch 1.24b --I believe it used a function like this for converting from a string to an integer:

function s2i takes string s returns integer
    return s
    return 0
endfunction

Since then we have lost this kind of functionality, though nobody here has mentioned anything about StringHash, which is also used to convert a string into an integer. There is also AbilityId which I haven't been able to get working properly.

Out of curiosity, what is wrong with S2I()?

native S2I  takes string s returns integer

 

[ALiEN95]

i only found this.... but it sucks because it can work ONLY on CUSTOM units

• Unit - Create 1 (Unit-type((custom_ + CODE))) for Player 1 (Red) at (Center of (Playable map area)) facing Default building facing degrees

 

[Berb]

Nothing is wrong with S2I, it does exactly what it is supposed to do. The problem is that if you have a string "A000" and you pass it to the S2I function, it will return 0 because "A" is not a number. The same happens for "'A000'" (notice the extra ' mark).

If you use S2I( I2S( 'A000' ) ) then it will return a string that represents the integer that is represented by 'A000'.

I believe with the old return-bug you could make it return a type-casted value, which I believe is what we are looking for here.

 

[ALiEN95]

Nothing is wrong with S2I, it does exactly what it is supposed to do. The problem is that if you have a string "A000" and you pass it to the S2I function, it will return 0 because "A" is not a number. The same happens for "'A000'" (notice the extra ' mark).

If you use S2I( I2S( 'A000' ) ) then it will return a string that represents the integer that is represented by 'A000'.

I believe with the old return-bug you could make it return a type-casted value, which I believe is what we are looking for here.

tried but i cant make it work

help

 

[Berb]

What can't you make work?

There is nothing in my post that is a solution to your problem, so I'm gassed at your efforts to "make it work".

 

[Dr Super Good]

You will have to store the item type list as an integer array. Thus you can use indexes to recall items from it. For multiple lists, you just need a system to allocate space from an array into separate lists.

This will be far better than any for of string index system.

 

[Anachron]

Requires ASCII.

    function String2Rawcode takes string s returns integer
        local integer i = StringLength(s)
        local integer j = 1
        local integer k = 0
        loop
            exitwhen i == 0
            set i = i-1
            set k = k+Char2Ascii(SubString(s, i, i+1))*j
            set j = j*256
        endloop
        return k
    endfunction
    function blah takes nothing returns nothing
        local string test = "'hpea'"
        local integer id = String2Rawcode(test)
        call BJDebugMsg(I2S(id))
    endfunction

 

[PurgeandFire]

Inputting the integer represented by the rawcode works just fine.

As long as you don't need to actually display the values (which in that case you'd need the ASCII lib) then it will be fine.

Example:

    if S2I(I2S('hfoo')) == 'hfoo' then
        call BJDebugMsg("hello")
    endif

Will display hello.

So I don't understand why there is a need for longer methods when this method is fully functional. (Though, I don't doubt the uses of those systems =) )

 

[Dr Super Good]

Because 'hfoo' is not a string but an integer.

S2I(I2S('hfoo')) == 'hfoo' simplifies to true as
S2I(I2S('hfoo')) becomes 'hfoo' (pointless converting to string and back to integer).
'hfoo' == 'hfoo' becomes 0 == 0 as both values are constants and the same.
0 == 0 becomes true as it is always true.

Again, 'hfoo' is an integer and not a string.

 

[Berb]

Try:

set intVar = S2I("'A000'")

You won't be so lucky, PurgeandFire111.

 

[Anachron]

Just use the stuff I've written.
There is no way to get an intval of Hex-Values, wc3 lacks hex support.

 

[Dr Super Good]

The problem is not hex, WC3 can easilly support hex via simple type cast functions.

The problem is '0000' is a 32 it integer consisting of 4 bytes (chars). These chars are full 256 bit ascII numbers.

Thus you can and I have even made a unit with type 'H00@' and it is perfectly valid via JNGP.

In the end it is most efficent to store them in a list via arrays. Direct index axcess is hundreds of times faster than type casting can ever be for such a situation with the tools available. Ideally what you would do in C is map the 4 char long string directly to an integer via binary.

 

[Anachron]

Sorry, I was actually meaning ASCII.

 

[ALiEN95]

thank you all for helping but i think i will just use array variables..