Damage Engine 5.A.0.0

[ShaDowPoWeR]

what's the best way to detect a skill like cold arrows/black or any variation for ranged attacks that consumes mana?
the biggest trouble I'm having is that if I check if the target unit has a buff then it works perfectly but if I give a bash ability that gives x% to hit (necessary against some units with a lot of evasion) the buff isn't placed.

 

[Spacebuns]

Is it technically possible to change the source of the damage (i.e. before the damage is dealt, another unit takes credit for the damage instead of DamageEventSource)?

 

[Bribe]

what's the best way to detect a skill like cold arrows/black or any variation for ranged attacks that consumes mana?
the biggest trouble I'm having is that if I check if the target unit has a buff then it works perfectly but if I give a bash ability that gives x% to hit (necessary against some units with a lot of evasion) the buff isn't placed.

The Bash ability can be detected by using the DamageEvent == 2.00 event combined with checking if the DamageEventLevel is greater than 0 and then checking if the target has the bash buff.

 

[Bribe]

Is it technically possible to change the source of the damage (i.e. before the damage is dealt, another unit takes credit for the damage instead of DamageEventSource)?

Best way is to set the damage to zero then re-apply the damage as DAMAGE_TYPE_UNIVERSAL from the new source.

 

[Spacebuns]

I think there is a problem in the latest 1.29.2 PTR where playing a map with Damage Engine will cause a unit to have 2 Defend abilities. I have encountered it, but haven't been able to replicate it yet.

 

[Bribe]

That's likely due to you using two unit indexers on the map or not assigning the ability ID correctly.

 

[Kakerate]

Could you add a boolean for IsDamagePhysical/IsDamagePure? Some types of damage go through both armor and magic resist, so it would be nice to group between the two.

 

[Bribe]

Could you add a boolean for IsDamagePhysical/IsDamagePure? Some types of damage go through both armor and magic resist, so it would be nice to group between the two.

IsDamageSpell being false is the same as your first one being true, but the second one has no way of being detected. WC3 engine won't tell you what the pre-armor amount was.

 

[Kakerate]

Aw, that's a shame. Hopefully we can get some DamageEvent API soon then.

 

[Bribe]

Aw, that's a shame. Hopefully we can get some DamageEvent API soon then.

I asked Kam about it, but i won't hold my breath. right now the team is trying to scramble to fix current bugs not add even more new features which may or may not work.

 

[Kakerate]

Yeah, definitely not holding my breath on it. I'm sure by the time the API is around ill have already hacked together a workaround. IsDamageSpell detects all spell type damage, Even if it was damage also reduced by Armor. I'll have to set flags before dealing triggered damage, but still trying to figure out how exactly would be most efficient to support damage types Physical, Spell, Special (reduced by both Armor & MR%), and Pure.

I think I'll try only setting IsPhysical flag for special damage and seeing if the system plays nice with it.

 

[Elektrohund]

A must have for Hero-centric maps

 

[Kakerate]

It is worth noting that Bribe's statement of "not(IsSpell)==Physical" is false, because you can deal damage with sources not reduced by armor or magic resist, as well as damage reduced by both.

 

[Bribe]

It is worth noting that Bribe's statement of "not(IsSpell)==Physical" is false, because you can deal damage with sources not reduced by armor or magic resist, as well as damage reduced by both.

Good. Make something better.

 

[Kakerate]

I obviously take you on your word that there is no way to plainly detect all types of damage on 1.29, so there'd be no point for me to make a new system
I hope you can empathize with the slight annoyance of setting a flag before every UnitDamageTarget, but mainly because some 1.29 APIs I originally saw floating around showed we might get attack damagepoint/ damagetype detection.

Even then this doesnt catch normal ability damage, though if we get something as simple as GetAbilityDamageSource(), it could be worked around.

 

[Bribe]

I obviously take you on your word that there is no way to plainly detect all types of damage on 1.29, so there'd be no point for me to make a new system
I hope you can empathize with the slight annoyance of setting a flag before every UnitDamageTarget, but mainly because some 1.29 APIs I originally saw floating around showed we might get attack damagepoint/ damagetype detection.

Even then this doesnt catch normal ability damage, though if we get something as simple as GetAbilityDamageSource(), it could be worked around.

It reads like you're mistaking Magic Damage for Spell Damage. Magic damage is classified as physical while Spell damage it's classified as spell.

There weren't too many natives added that change how this system works in 1.29. Mainly just SetEventDamage.

 

[apsyll]

If your brain is as GUI as mine this is a must have.^^

 

[Bribe]

For those who are on the 1.29 patch, this version of Damage Engine (attached) is now using the SetEventDamage native.

Benefits: no longer needs Cheat Death Ability, no longer needs custom fixes for Life Drain and Finger of Death, no longer creates a trigger for each damage instance.

Also, the Damage Return Value on Locust Swarm can be switched back to its default 0.75 instead of -0.75 which was previously needed.

Disadvantages: not compatible with code pre-1.29, may have bugs which I haven't spotted (though unlikely).

For now, I will leave the actual resource unchanged, but if enough people request it I will make this 1.29 version the default Damage Engine version.

//===========================================================================
// Damage Engine lets you detect, amplify, block or nullify damage. It even
// lets you detect if the damage was physical or from a spell. Just reference
// DamageEventAmount/Source/Target or the boolean IsDamageSpell, to get the
// necessary damage event data.
//
// - Detect damage: use the event "DamageEvent Equal to 1.00"
// - To change damage before it's dealt: use the event "DamageModifierEvent Equal to 1.00"
// - Detect damage after it was applied, use the event "AfterDamageEvent Equal to 1.00"
// - Detect spell damage: use the condition "IsDamageSpell Equal to True"
// - Detect zero-damage: use the event "DamageEvent Equal to 2.00" (an AfterDamageEvent will not fire for this)
//
// You can specify the DamageEventType before dealing triggered damage, then run the trigger "ClearDamageEvent (Checking Conditions)" after dealing triggered damage from within a damage event:
// - Set NextDamageType = DamageTypeWhatever
// - Unit - Cause...
// - Trigger - Run ClearDamageEvent (Checking Conditions)
//
// You can modify the DamageEventAmount and the DamageEventType from a "DamageModifierEvent Equal to 1.00" trigger.
// - If the amount is modified to negative, it will count as a heal.
// - If the amount is set to 0, no damage will be dealt.
//
// If you need to reference the original in-game damage, use the variable "DamageEventPrevAmt".
//
//===========================================================================
// Programming note about "integer i" and "udg_DmgEvRecursionN": integer i
// ranges from -1 upwards. "udg_DmgEvRecursionN" ranges from 0 upwards.
// "integer i" is always 1 less than "udg_DmgEvRecursionN"
//
function DmgEvResetVars takes nothing returns nothing
    local integer i = udg_DmgEvRecursionN - 2
    set udg_DmgEvRecursionN = i + 1
    if i >= 0 then
        set udg_DamageEventPrevAmt  = udg_LastDmgPrevAmount[i]
        set udg_DamageEventAmount   = udg_LastDmgValue[i]
        set udg_DamageEventSource   = udg_LastDmgSource[i]
        set udg_DamageEventTarget   = udg_LastDmgTarget[i]
        set udg_IsDamageSpell       = udg_LastDmgWasSpell[i]
        set udg_DamageEventType     = udg_LastDmgPrevType[i]
    endif
endfunction
function ClearDamageEvent takes boolean clear returns nothing
    if clear then
        set udg_NextDamageOverride = false
        set udg_NextDamageType = 0
    endif
    if udg_DmgEvQueued then
        //The 0-second timer has expired, or there had been multiple sequential damage events running in parallel.     
        set udg_DmgEvQueued = false
        set udg_AfterDamageEvent = 0.00
        set udg_AfterDamageEvent = 1.00 //No longer fires with Unit State Event detection - this is
        set udg_AfterDamageEvent = 0.00 //lighter on the system but will fire slightly later than before.
                                        //It now only serves for counter-damage after the initial damage.
        call ClearDamageEvent(true) //Check for any potential failed recursive damage from the previous event.
        call DmgEvResetVars()
    endif
endfunction
function DmgEvOnAOEEnd takes nothing returns nothing
    if udg_DamageEventAOE > 1 then
        set udg_AOEDamageEvent = 0.00
        set udg_AOEDamageEvent = 1.00
        set udg_AOEDamageEvent = 0.00
        set udg_DamageEventAOE = 1
    endif
    set udg_DamageEventLevel = 1
    set udg_EnhancedDamageTarget = null
    call GroupClear(udg_DamageEventAOEGroup)
endfunction
 
function DmgEvOnExpire takes nothing returns nothing
    set udg_DmgEvStarted = false //The timer has expired. Flag off to allow it to be restarted when needed.
    call ClearDamageEvent(true) //Check for any lingering damage
    //Reset things so they don't perpetuate for AoE/Level target detection
    call DmgEvOnAOEEnd()
    set udg_DamageEventTarget = null
    set udg_DamageEventSource = null
endfunction
function PreClearDamageEvent takes nothing returns boolean
    call ClearDamageEvent(true)
    return false
endfunction
function OnUnitDamage takes nothing returns boolean
    local boolean override = udg_DamageEventOverride
    local integer i
    local integer e = udg_DamageEventLevel
    local integer a = udg_DamageEventAOE
    local string s
    local unit u
    local unit f
    call ClearDamageEvent(false) //in case the 0.00 second timer hasn't yet expired
    set i = udg_DmgEvRecursionN - 1 //Had to be moved here due to false recursion tracking
    if i < 0 then
        //Added 25 July 2017 to detect AOE damage or multiple single-target damage
        set u                       = udg_DamageEventTarget
        set f                       = udg_DamageEventSource
    elseif i < 16 then
        set udg_LastDmgPrevAmount[i]= udg_DamageEventPrevAmt
        set udg_LastDmgValue[i]     = udg_DamageEventAmount
        set udg_LastDmgSource[i]    = udg_DamageEventSource
        set udg_LastDmgTarget[i]    = udg_DamageEventTarget
        set udg_LastDmgWasSpell[i]  = udg_IsDamageSpell
        set udg_LastDmgPrevType[i]  = udg_DamageEventType
    else
        set s = "WARNING: Recursion error when dealing damage! Make sure when you deal damage from within a DamageEvent trigger, do it like this:"
        set s = s + "Trigger - Turn off (This Trigger)"
        set s = s + "Unit - Cause..."
        set s = s + "Trigger - Run ClearDamageEvent (Checking Conditions)"
        set s = s + "Trigger - Turn on (This Trigger)"
    
        //Delete the next couple of lines to disable the in-game recursion crash warnings
        call ClearTextMessages()
        call DisplayTimedTextToPlayer(GetLocalPlayer(), 0.00, 0.00, 999.00, s)
        return false
    endif
    set udg_DmgEvRecursionN     = i + 2
    set udg_DamageEventAmount   = GetEventDamage()
    set udg_DamageEventTarget   = GetTriggerUnit()
    set udg_DamageEventSource   = GetEventDamageSource()
 
    set udg_DamageEventType     = udg_NextDamageType
    set udg_NextDamageType      = 0
    set udg_DamageEventOverride = udg_NextDamageOverride
    set udg_NextDamageOverride  = false
 
    if i < 0 then
        //Added 25 July 2017 to detect AOE damage or multiple single-target damage
        if udg_DamageEventType == 0 then
            if f == udg_DamageEventSource then
                //Source has damaged more than once
                if IsUnitInGroup(udg_DamageEventTarget, udg_DamageEventAOEGroup) then
                    //Added 5 August 2017 to improve tracking of enhanced damage against, say, Pulverize
                    set udg_DamageEventLevel = udg_DamageEventLevel + 1
                    set udg_EnhancedDamageTarget = udg_DamageEventTarget
                else
                    //Multiple targets hit by this source - flag as AOE
                    set udg_DamageEventAOE = udg_DamageEventAOE + 1
                endif
            else
                //New damage source - unflag everything
                set u = udg_DamageEventSource
                set udg_DamageEventSource = f
                call DmgEvOnAOEEnd()
                set udg_DamageEventSource = u
            endif
            call GroupAddUnit(udg_DamageEventAOEGroup, udg_DamageEventTarget)
        endif
        if not udg_DmgEvStarted then
            set udg_DmgEvStarted = true
            call TimerStart(udg_DmgEvTimer, 0.00, false, function DmgEvOnExpire)
        endif
    endif
 
    if udg_DamageEventAmount == 0.00 then
        if not udg_HideDamageFrom[GetUnitUserData(udg_DamageEventSource)] then
            set udg_DamageEventPrevAmt = 0.00
            set udg_DamageEvent = 0.00
            set udg_DamageEvent = 2.00
            set udg_DamageEvent = 0.00
        endif
        call DmgEvResetVars()
    else
        set u = udg_DamageEventTarget
        set udg_IsDamageSpell = udg_DamageEventAmount < 0.00
        if udg_IsDamageSpell then
            set udg_DamageEventAmount = -udg_DamageEventAmount
            if IsUnitType(u, UNIT_TYPE_ETHEREAL) and not IsUnitType(u, UNIT_TYPE_HERO) then
                set udg_DamageEventAmount = udg_DamageEventAmount*udg_DAMAGE_FACTOR_ETHEREAL //1.67
            endif
            if GetUnitAbilityLevel(u, 'Aegr') > 0 then
                set udg_DamageEventAmount = udg_DamageEventAmount*udg_DAMAGE_FACTOR_ELUNES //0.80
            endif
            if udg_DmgEvBracers != 0 and IsUnitType(u, UNIT_TYPE_HERO) then
                //Inline of UnitHasItemOfTypeBJ without the potential handle ID leak.
                set i = bj_MAX_INVENTORY
                loop
                    set i = i - 1
                    if GetItemTypeId(UnitItemInSlot(u, i)) == udg_DmgEvBracers then
                        set udg_DamageEventAmount = udg_DamageEventAmount*udg_DAMAGE_FACTOR_BRACERS //0.67
                        exitwhen true
                    endif
                    exitwhen i == 0
                endloop
            endif
        endif
        set udg_DamageEventPrevAmt = udg_DamageEventAmount
        set udg_DamageModifierEvent = 0.00
        if not udg_DamageEventOverride then
            set udg_DamageModifierEvent = 1.00 //Primary modification - multiplication, blocking, reversing, etc.
            set udg_DamageModifierEvent = 2.00 //Secondary Modification - addition/subtraction
            set udg_DamageModifierEvent = 3.00 //Similar to 2.00 but with knowing all previous addition/subtraction have run.
        endif
        if udg_DamageEventAmount > 0.00 then
            set udg_DamageModifierEvent = 4.00 //Apply finite damage modification such as Mana Shield or Anti-Magic Shell.
        endif
        set udg_DamageEventOverride = override
        set udg_DamageModifierEvent = 0.00
        if not udg_HideDamageFrom[GetUnitUserData(udg_DamageEventSource)] then
            set udg_DamageEvent = 0.00
            set udg_DamageEvent = 1.00
            set udg_DamageEvent = 0.00
        endif
        call ClearDamageEvent(true) //in case the unit state event failed from a recursive damage event
    
        //All events have run and the damage amount is finalized.
        call SetEventDamage(udg_DamageEventAmount)
        set udg_DmgEvQueued = true
        if udg_DamageEventType < 0 and GetWidgetLife(u) - udg_DamageEventAmount <= 0.405 then
            call SetUnitExploded(u, true) //In 1.29 Finger of Death works as intended.
        endif
    endif
    set u = null
    set f = null
    return false
endfunction
function CreateDmgEvTrg takes nothing returns nothing
    set udg_DamageEventTrigger = CreateTrigger()
    call TriggerAddCondition(udg_DamageEventTrigger, Filter(function OnUnitDamage))
endfunction
function SetupDmgEv takes nothing returns boolean
    local integer i = udg_UDex
    local unit u = udg_UDexUnits[i]
    if GetUnitAbilityLevel(u, 'Aloc') == 0 and TriggerEvaluate(gg_trg_Damage_Engine_Config) then
        set udg_UnitDamageRegistered[i] = true
        call TriggerRegisterUnitEvent(udg_DamageEventTrigger, u, EVENT_UNIT_DAMAGED)
        call UnitAddAbility(u, udg_SpellDamageAbility)
        call UnitMakeAbilityPermanent(u, true, udg_SpellDamageAbility)
    endif
    set u = null
    return false
endfunction
function RemoveDmgEv takes nothing returns boolean
    local integer i = udg_UDex
    set udg_HideDamageFrom[i] = false
    if udg_UnitDamageRegistered[i] then
        set udg_UnitDamageRegistered[i] = false
        set udg_DamageEventsWasted = udg_DamageEventsWasted + 1
        if udg_DamageEventsWasted == 32 then //After 32 registered units have been removed...
            set udg_DamageEventsWasted = 0
            
            //Rebuild the mass EVENT_UNIT_DAMAGED trigger:
            call DestroyTrigger(udg_DamageEventTrigger)
            call CreateDmgEvTrg()
            set i = udg_UDexNext[0]
            loop
                exitwhen i == 0
                if udg_UnitDamageRegistered[i] then
                    call TriggerRegisterUnitEvent(udg_DamageEventTrigger, udg_UDexUnits[i], EVENT_UNIT_DAMAGED)
                endif
                set i = udg_UDexNext[i]
            endloop
        endif
    endif
    return false
endfunction
 
//===========================================================================
function InitTrig_Damage_Engine takes nothing returns nothing
    local unit u = CreateUnit(Player(bj_PLAYER_NEUTRAL_EXTRA), 'uloc', 0, 0, 0)
    local integer i = bj_MAX_PLAYERS //Fixed in 3.8
 
    //Create trigger to add units to the system.
    local trigger t = CreateTrigger()
    call TriggerRegisterVariableEvent(t, "udg_UnitIndexEvent", EQUAL, 1.00)
    call TriggerAddCondition(t, Filter(function SetupDmgEv))
 
    //Create trigger to remove units from the system.
    set t = CreateTrigger()
    call TriggerRegisterVariableEvent(t, "udg_UnitIndexEvent", EQUAL, 2.00)
    call TriggerAddCondition(t, Filter(function RemoveDmgEv))
    set t = null
 
    //Execute the configuration function to first set all GUI variables:
    call ExecuteFunc("Trig_Damage_Engine_Config_Actions")
 
    //Create trigger for storing all EVENT_UNIT_DAMAGED events.
    call CreateDmgEvTrg()
 
    //Create GUI-friendly trigger for cleaning up after UnitDamageTarget.
    set udg_ClearDamageEvent = CreateTrigger()
    call TriggerAddCondition(udg_ClearDamageEvent, Filter(function PreClearDamageEvent))
 
    //Disable SpellDamageAbility for every player.
    loop
        set i = i - 1
        call SetPlayerAbilityAvailable(Player(i), udg_SpellDamageAbility, false)
        exitwhen i == 0
    endloop
 
    //Preload ability
    call UnitAddAbility(u, udg_SpellDamageAbility)
    call RemoveUnit(u)
    set u = null
endfunction

 

[nedio95]

For those who are on the 1.29 patch, this version of Damage Engine (attached) is now using the SetEventDamage native.

Benefits: no longer needs Cheat Death Ability, no longer needs custom fixes for Life Drain and Finger of Death, no longer creates a trigger for each damage instance.

Disadvantages: not compatible with code pre-1.29, may have bugs which I haven't spotted (though unlikely).

For now, I will leave the actual resource unchanged, but if enough people request it I will make this 1.29 version the default Damage Engine version.

//===========================================================================
// Damage Engine lets you detect, amplify, block or nullify damage. It even
// lets you detect if the damage was physical or from a spell. Just reference
// DamageEventAmount/Source/Target or the boolean IsDamageSpell, to get the
// necessary damage event data.
//
// - Detect damage: use the event "DamageEvent Equal to 1.00"
// - To change damage before it's dealt: use the event "DamageModifierEvent Equal to 1.00"
// - Detect damage after it was applied, use the event "AfterDamageEvent Equal to 1.00"
// - Detect spell damage: use the condition "IsDamageSpell Equal to True"
// - Detect zero-damage: use the event "DamageEvent Equal to 2.00" (an AfterDamageEvent will not fire for this)
//
// You can specify the DamageEventType before dealing triggered damage, then run the trigger "ClearDamageEvent (Checking Conditions)" after dealing triggered damage from within a damage event:
// - Set NextDamageType = DamageTypeWhatever
// - Unit - Cause...
// - Trigger - Run ClearDamageEvent (Checking Conditions)
//
// You can modify the DamageEventAmount and the DamageEventType from a "DamageModifierEvent Equal to 1.00" trigger.
// - If the amount is modified to negative, it will count as a heal.
// - If the amount is set to 0, no damage will be dealt.
//
// If you need to reference the original in-game damage, use the variable "DamageEventPrevAmt".
//
//===========================================================================
// Programming note about "integer i" and "udg_DmgEvRecursionN": integer i
// ranges from -1 upwards. "udg_DmgEvRecursionN" ranges from 0 upwards.
// "integer i" is always 1 less than "udg_DmgEvRecursionN"
//
function DmgEvResetVars takes nothing returns nothing
    local integer i = udg_DmgEvRecursionN - 2
    set udg_DmgEvRecursionN = i + 1
    if i >= 0 then
        set udg_DamageEventPrevAmt  = udg_LastDmgPrevAmount[i]
        set udg_DamageEventAmount   = udg_LastDmgValue[i]
        set udg_DamageEventSource   = udg_LastDmgSource[i]
        set udg_DamageEventTarget   = udg_LastDmgTarget[i]
        set udg_IsDamageSpell       = udg_LastDmgWasSpell[i]
        set udg_DamageEventType     = udg_LastDmgPrevType[i]
    endif
endfunction
function ClearDamageEvent takes boolean clear returns nothing
    if clear then
        set udg_NextDamageOverride = false
        set udg_NextDamageType = 0
    endif
    if udg_DmgEvQueued then
        //The 0-second timer has expired, or there had been multiple sequential damage events running in parallel.  
        set udg_DmgEvQueued = false
        set udg_AfterDamageEvent = 0.00
        set udg_AfterDamageEvent = 1.00 //No longer fires with Unit State Event detection - this is
        set udg_AfterDamageEvent = 0.00 //lighter on the system but will fire slightly later than before.
                                        //It now only serves for counter-damage after the initial damage.
        call ClearDamageEvent(true) //Check for any potential failed recursive damage from the previous event.
        call DmgEvResetVars()
    endif
endfunction
function DmgEvOnAOEEnd takes nothing returns nothing
    if udg_DamageEventAOE > 1 then
        set udg_AOEDamageEvent = 0.00
        set udg_AOEDamageEvent = 1.00
        set udg_AOEDamageEvent = 0.00
        set udg_DamageEventAOE = 1
    endif
    set udg_DamageEventLevel = 1
    set udg_EnhancedDamageTarget = null
    call GroupClear(udg_DamageEventAOEGroup)
endfunction
 
function DmgEvOnExpire takes nothing returns nothing
    set udg_DmgEvStarted = false //The timer has expired. Flag off to allow it to be restarted when needed.
    call ClearDamageEvent(true) //Check for any lingering damage
    //Reset things so they don't perpetuate for AoE/Level target detection
    call DmgEvOnAOEEnd()
    set udg_DamageEventTarget = null
    set udg_DamageEventSource = null
endfunction
function PreClearDamageEvent takes nothing returns boolean
    call ClearDamageEvent(true)
    return false
endfunction
function OnUnitDamage takes nothing returns boolean
    local boolean override = udg_DamageEventOverride
    local integer i
    local integer e = udg_DamageEventLevel
    local integer a = udg_DamageEventAOE
    local string s
    local unit u
    local unit f
    call ClearDamageEvent(false) //in case the 0.00 second timer hasn't yet expired
    set i = udg_DmgEvRecursionN - 1 //Had to be moved here due to false recursion tracking
    if i < 0 then
        //Added 25 July 2017 to detect AOE damage or multiple single-target damage
        set u                       = udg_DamageEventTarget
        set f                       = udg_DamageEventSource
    elseif i < 16 then
        set udg_LastDmgPrevAmount[i]= udg_DamageEventPrevAmt
        set udg_LastDmgValue[i]     = udg_DamageEventAmount
        set udg_LastDmgSource[i]    = udg_DamageEventSource
        set udg_LastDmgTarget[i]    = udg_DamageEventTarget
        set udg_LastDmgWasSpell[i]  = udg_IsDamageSpell
        set udg_LastDmgPrevType[i]  = udg_DamageEventType
    else
        set s = "WARNING: Recursion error when dealing damage! Make sure when you deal damage from within a DamageEvent trigger, do it like this:"
        set s = s + "Trigger - Turn off (This Trigger)"
        set s = s + "Unit - Cause..."
        set s = s + "Trigger - Run ClearDamageEvent (Checking Conditions)"
        set s = s + "Trigger - Turn on (This Trigger)"
 
        //Delete the next couple of lines to disable the in-game recursion crash warnings
        call ClearTextMessages()
        call DisplayTimedTextToPlayer(GetLocalPlayer(), 0.00, 0.00, 999.00, s)
        return false
    endif
    set udg_DmgEvRecursionN     = i + 2
    set udg_DamageEventAmount   = GetEventDamage()
    set udg_DamageEventTarget   = GetTriggerUnit()
    set udg_DamageEventSource   = GetEventDamageSource()
 
    set udg_DamageEventType     = udg_NextDamageType
    set udg_NextDamageType      = 0
    set udg_DamageEventOverride = udg_NextDamageOverride
    set udg_NextDamageOverride  = false
 
    if i < 0 then
        //Added 25 July 2017 to detect AOE damage or multiple single-target damage
        if udg_DamageEventType == 0 then
            if f == udg_DamageEventSource then
                //Source has damaged more than once
                if IsUnitInGroup(udg_DamageEventTarget, udg_DamageEventAOEGroup) then
                    //Added 5 August 2017 to improve tracking of enhanced damage against, say, Pulverize
                    set udg_DamageEventLevel = udg_DamageEventLevel + 1
                    set udg_EnhancedDamageTarget = udg_DamageEventTarget
                else
                    //Multiple targets hit by this source - flag as AOE
                    set udg_DamageEventAOE = udg_DamageEventAOE + 1
                endif
            else
                //New damage source - unflag everything
                set u = udg_DamageEventSource
                set udg_DamageEventSource = f
                call DmgEvOnAOEEnd()
                set udg_DamageEventSource = u
            endif
            call GroupAddUnit(udg_DamageEventAOEGroup, udg_DamageEventTarget)
        endif
        if not udg_DmgEvStarted then
            set udg_DmgEvStarted = true
            call TimerStart(udg_DmgEvTimer, 0.00, false, function DmgEvOnExpire)
        endif
    endif
 
    if udg_DamageEventAmount == 0.00 then
        if not udg_HideDamageFrom[GetUnitUserData(udg_DamageEventSource)] then
            set udg_DamageEventPrevAmt = 0.00
            set udg_DamageEvent = 0.00
            set udg_DamageEvent = 2.00
            set udg_DamageEvent = 0.00
        endif
        call DmgEvResetVars()
    else
        set u = udg_DamageEventTarget
        set udg_IsDamageSpell = udg_DamageEventAmount < 0.00
        if udg_IsDamageSpell then
            set udg_DamageEventAmount = -udg_DamageEventAmount
            if IsUnitType(u, UNIT_TYPE_ETHEREAL) and not IsUnitType(u, UNIT_TYPE_HERO) then
                set udg_DamageEventAmount = udg_DamageEventAmount*udg_DAMAGE_FACTOR_ETHEREAL //1.67
            endif
            if GetUnitAbilityLevel(u, 'Aegr') > 0 then
                set udg_DamageEventAmount = udg_DamageEventAmount*udg_DAMAGE_FACTOR_ELUNES //0.80
            endif
            if udg_DmgEvBracers != 0 and IsUnitType(u, UNIT_TYPE_HERO) then
                //Inline of UnitHasItemOfTypeBJ without the potential handle ID leak.
                set i = bj_MAX_INVENTORY
                loop
                    set i = i - 1
                    if GetItemTypeId(UnitItemInSlot(u, i)) == udg_DmgEvBracers then
                        set udg_DamageEventAmount = udg_DamageEventAmount*udg_DAMAGE_FACTOR_BRACERS //0.67
                        exitwhen true
                    endif
                    exitwhen i == 0
                endloop
            endif
        endif
        set udg_DamageEventPrevAmt = udg_DamageEventAmount
        set udg_DamageModifierEvent = 0.00
        if not udg_DamageEventOverride then
            set udg_DamageModifierEvent = 1.00 //Primary modification - multiplication, blocking, reversing, etc.
            set udg_DamageModifierEvent = 2.00 //Secondary Modification - addition/subtraction
            set udg_DamageModifierEvent = 3.00 //Similar to 2.00 but with knowing all previous addition/subtraction have run.
        endif
        if udg_DamageEventAmount > 0.00 then
            set udg_DamageModifierEvent = 4.00 //Apply finite damage modification such as Mana Shield or Anti-Magic Shell.
        endif
        set udg_DamageEventOverride = override
        set udg_DamageModifierEvent = 0.00
        if not udg_HideDamageFrom[GetUnitUserData(udg_DamageEventSource)] then
            set udg_DamageEvent = 0.00
            set udg_DamageEvent = 1.00
            set udg_DamageEvent = 0.00
        endif
        call ClearDamageEvent(true) //in case the unit state event failed from a recursive damage event
 
        //All events have run and the damage amount is finalized.
        call SetEventDamage(udg_DamageEventAmount)
        set udg_DmgEvQueued = true
        if udg_DamageEventType < 0 and GetWidgetLife(u) - udg_DamageEventAmount <= 0.405 then
            call SetUnitExploded(u, true) //In 1.29 Finger of Death works as intended.
        endif
    endif
    set u = null
    set f = null
    return false
endfunction
function CreateDmgEvTrg takes nothing returns nothing
    set udg_DamageEventTrigger = CreateTrigger()
    call TriggerAddCondition(udg_DamageEventTrigger, Filter(function OnUnitDamage))
endfunction
function SetupDmgEv takes nothing returns boolean
    local integer i = udg_UDex
    local unit u = udg_UDexUnits[i]
    if GetUnitAbilityLevel(u, 'Aloc') == 0 and TriggerEvaluate(gg_trg_Damage_Engine_Config) then
        set udg_UnitDamageRegistered[i] = true
        call TriggerRegisterUnitEvent(udg_DamageEventTrigger, u, EVENT_UNIT_DAMAGED)
        call UnitAddAbility(u, udg_SpellDamageAbility)
        call UnitMakeAbilityPermanent(u, true, udg_SpellDamageAbility)
    endif
    set u = null
    return false
endfunction
function RemoveDmgEv takes nothing returns boolean
    local integer i = udg_UDex
    set udg_HideDamageFrom[i] = false
    if udg_UnitDamageRegistered[i] then
        set udg_UnitDamageRegistered[i] = false
        set udg_DamageEventsWasted = udg_DamageEventsWasted + 1
        if udg_DamageEventsWasted == 32 then //After 32 registered units have been removed...
            set udg_DamageEventsWasted = 0
         
            //Rebuild the mass EVENT_UNIT_DAMAGED trigger:
            call DestroyTrigger(udg_DamageEventTrigger)
            call CreateDmgEvTrg()
            set i = udg_UDexNext[0]
            loop
                exitwhen i == 0
                if udg_UnitDamageRegistered[i] then
                    call TriggerRegisterUnitEvent(udg_DamageEventTrigger, udg_UDexUnits[i], EVENT_UNIT_DAMAGED)
                endif
                set i = udg_UDexNext[i]
            endloop
        endif
    endif
    return false
endfunction
 
//===========================================================================
function InitTrig_Damage_Engine takes nothing returns nothing
    local unit u = CreateUnit(Player(bj_PLAYER_NEUTRAL_EXTRA), 'uloc', 0, 0, 0)
    local integer i = bj_MAX_PLAYERS //Fixed in 3.8
 
    //Create trigger to add units to the system.
    local trigger t = CreateTrigger()
    call TriggerRegisterVariableEvent(t, "udg_UnitIndexEvent", EQUAL, 1.00)
    call TriggerAddCondition(t, Filter(function SetupDmgEv))
 
    //Create trigger to remove units from the system.
    set t = CreateTrigger()
    call TriggerRegisterVariableEvent(t, "udg_UnitIndexEvent", EQUAL, 2.00)
    call TriggerAddCondition(t, Filter(function RemoveDmgEv))
    set t = null
 
    //Execute the configuration function to first set all GUI variables:
    call ExecuteFunc("Trig_Damage_Engine_Config_Actions")
 
    //Create trigger for storing all EVENT_UNIT_DAMAGED events.
    call CreateDmgEvTrg()
 
    //Create GUI-friendly trigger for cleaning up after UnitDamageTarget.
    set udg_ClearDamageEvent = CreateTrigger()
    call TriggerAddCondition(udg_ClearDamageEvent, Filter(function PreClearDamageEvent))
 
    //Disable SpellDamageAbility for every player.
    loop
        set i = i - 1
        call SetPlayerAbilityAvailable(Player(i), udg_SpellDamageAbility, false)
        exitwhen i == 0
    endloop
 
    //Preload ability
    call UnitAddAbility(u, udg_SpellDamageAbility)
    call RemoveUnit(u)
    set u = null
endfunction

Maybe you could post it as a pack, containing both ?

Gotta poke @Ralle to suggest making spell having multiple file uploads for different versions. Maybe even keeping a record of past versions?

regards
-Ned

 

[Bribe]

Maybe you could post it as a pack, containing both ?

Gotta poke @Ralle to suggest making spell having multiple file uploads for different versions. Maybe even keeping a record of past versions?

regards
-Ned

Not a bad idea. I had forgotten to mention though that Locust Swarm also should be switched back to 0.75.

 

[A]mun]

Hopping back into the editor, testing version 4.0.

edit: getting a little error on save:

 

[Tasyen]

Blizzard added "Blz" as Prefix to all new natives beeing publish with 1.29, on the PTR they did not have that prefix. Bribe seems to have used the naming from the PTR, SetEventDamage -> BlzSetEventDamage.

 

[A]mun]

^Yep, that's the easy fix right there! Cheers mate!

 

[Bribe]

Yikes, glad I didn't update the primary resource then.

I'm wondering why they would do that.

 

[_Guhun_]

Yikes, glad I didn't update the primary resource then.

I'm wondering why they would do that.

Probably because someone reported that some old map broke since it used functions with the same name as the native. My own map would have a SetUnitName if I had made it before the Producer Update was announced.

Adding the Blz prefix makes it much less likely that an old map would have a function with the same name. I believe they will probably follow the same pattern for all new natives in the future.

 

[Bribe]

Probably because someone reported that some old map broke since it used functions with the same name as the native. My own map would have a SetUnitName if I had made it before the Producer Update was announced.

Adding the Blz prefix makes it much less likely that an old map would have a function with the same name. I believe they will probably follow the same pattern for all new natives in the future.

Ok that's actually a very good reason

 

[DarkDez17]

Greetings, I wanted to ask if it's possible to create Spell Damage Reduction effect which scales with ability level by using this engine. (Sorry if this question is stupid, just had no idea how to do it)

 

[Spellbound]

"If IsSpellDamage is equal to true, the damage was caused by a spell."
Use that as your condition and you can just modify DamageEventAmount to your desired value and the damage will change.

Keep in mind that to modify damage it can only be done if DamageModifierEvent Equal to 1.00, not if DamageEvent Equal to 1.00.

Check the How to Use segment for more info.

 

[DarkDez17]

"If IsSpellDamage is equal to true, the damage was caused by a spell."
Use that as your condition and you can just modify DamageEventAmount to your desired value and the damage will change.

Keep in mind that to modify damage it can only be done if DamageModifierEvent Equal to 1.00, not if DamageEvent Equal to 1.00.

Check the How to Use segment for more info.

thank you for answering my question

 

[Goblintrain]

Ok... i imported the damage engine... now how the hell do i use it?

 

[Spacebuns]

You need to read the instructions and if necessary, get more knowledge of using triggers.

 

[Spacebuns]

I have an idea: You should create a boolean IsDamageKilling to check if the DamageEventAmount is sufficient to kill the DamageEventTarget.

 

[Bribe]

You'll just want to check that info yourself. You can use a Damage modifier event 4 to verify damage VS life as by then all the other damage processing should be done.

 

[Goblintrain]

Hey, if this is the wrong place to ask this question, i will move it elsewhere, but this seemed to me like a good place to start. Damage Engine has been daunting, but i had some success with it yesterday that is proving how valuable a resource it can be. Yesterday i successfully replicated Item Life Steal for ranged attacks, & separated spell damage from attack damage. Simple things, sure, but still things i was never able to do efficiently.

The next thing i would like to accomplish is to designate a unit (with a particular buff) to be completely immune to "damage" and yet provoke attack & spell targeting. In other words -be invulnerable but still targetable -unlike with the traditional invulnerability/spell immunity features in the game. If i can not make the target completely magic immune, that is Ok. Damage immunity while still remaining a target is the crucial part of my goal.

Is Damage Engine the right tool for that?

 

[A]mun]

^ Yes.

Carefully read the instructions and you got your answer, also consult the test map.

 

[Bribe]

Yes, there's a unit in the test map (the Zombie) who cannot be damaged. Anything targeting it has its DamageEventAmount set to 0. You can do the same with your buff. From a DamageModifierEvent set the damage amount to 0 if the damage target has your buff.

 

[ShaDowPoWeR]

how do I check if it's the first hit of an aoe physical attack? I don't want an aoe attack to trigger some stuff more than once per hit.
I have some effects when you have x item or ability using DamageEvent when damaging with a melee/ranged physical attack, it works well. The only problem is that with cleave or other splash skills (melee and ranged) you could potentially trigger the effect multiple times per hit (ok for some things and not ok for others).

 

[Spellbound]

Afaik there is no way to pick the first enemy hit from an AoE attack. Splash damage doesn't play well will a DDS, so the workaround is to trigger all your cleaves and other splash attacks.

 

[Bribe]

This system does allow you to get the first enemy hit by AoE. It does not, however, allow you to determine if that unit was the only one hit by an AoE spell or attack.

 

[Spellbound]

Wait so if I make a Mortar Team attack ground and they hit 4 units, one of those 4 units will be the 'first'? How do you differentiate it from the rest?

 

[Bribe]

I have an event which fires after AoE damage completes. The first unit in the group is the first one hit.

Edit: the event is AOEDamageEvent == 1.00

 

[ShaDowPoWeR]

thanks I got it to work using DamageEventAOE==1 as a condition to get what I wanted.

 

[Bribe]

While that will get you

thanks I got it to work using DamageEventAOE==1 as a condition to get what I wanted.

Well that number will be 1 no matter if it was the first unit but by AOE or single target. But if the other conditions you have already rule out other scenarios then it would work.

Would you mind sharing the trigger you used?

 

[ShaDowPoWeR]

I've been testing it and this works for melee units with/without cleave and ranged units with/without missile splash
s = source
t = target
udg_attackt = attacked unit from is attacked event

if (udg_IsDamageSpell==false)and((udg_DamageEventAOE==1)and(IsUnitType(s,UNIT_TYPE_RANGED_ATTACKER)==true))or((IsUnitType(s,UNIT_TYPE_MELEE_ATTACKER)==true)and(udg_attackt[GetUnitUserData(s)]==t))then

 

[Bribe]

Just FYI if you want to differentiate a unit who uses cleave with that you'd have to check if their ability level of Cleave is > 0.

Again there's no way (yet?) for the system to know if a single unit was hit by AoE. The system can only tell if more than one unit was hit.

 

[-Manuel-]

I found a bug...

UnitAlive(udg_DamageEventTarget)
IsUnitType(udg_DamageEventTarget,UNIT_TYPE_DEAD) or GetUnitTypeId(udg_DamageEventTarget) == 0

don't works on AfterDamageEvent. The only way to detect if a unit is alive that works on this event is.

GetWidgetLife(udg_DamageEventTarget) < 0.405

I think that is a bug related to Damage Engine, because UnitAlive works normally in others triggers.

I attached a test map, type -c to test UnitAlive.

 

[Bribe]

If you're using the pre-1.29 thing you are seeing the AfterDamageEvent from a unit state event. Flags such as whether the unit is alive or dead wouldn't be set yet. You should just check the unit's life.

With the 1.29-only version, you wouldn't run into this issue. I use either a timer or a subsequent damage instance to launch that event; by either point everything will have been processed.

 

[-Manuel-]

If you're using the pre-1.29 thing you are seeing the AfterDamageEvent from a unit state event. Flags such as whether the unit is alive or dead wouldn't be set yet. You should just check the unit's life.

With the 1.29-only version, you wouldn't run into this issue. I use either a timer or a subsequent damage instance to launch that event; by either point everything will have been processed.

Yeah i use the pre-1.29 version. I will use the widget life method for now.
Thanks.

 

[Austrulex]

Hi, I was wondering if there is a version of this great resource without the the physical/spell damage differentiation? I need a DDS that has GUI compatibility and can modify damage done but I can't use the system as it is now because of the life drain/DoT issue which from what I understand is because of the use of Spell dmg reduction ability, and I don't need to differentiate between and spell damage.

 

[Bribe]

Then just don't assign the spell detect ability to anything. It will allow the system to do what you want.