Damage Engine 5.A.0.0

[Bribe]

Since my last flowchart was so well-received, here's the general flow of Damage Engine 3.8 (in retrospect):

 1 A unit enters the game and is processed by GUI Unit Indexer or GUI Unit Event.	 → → 	 2 Add an event for the unit to the monolithic DamageEventTrigger and add the Detect Spell Damage Ability to it.	 → → 	 3 WarCraft 3 detects incoming damage, distributes it into Spirit Link/Mana Shield, then applies armor type & amount	 → ↓ 
 ↓ ← 	 6 If any recursive damage is detected from any of those events, it is executed immediately. Any recursive events from those recursive events are also executed immediately.	 ← ←	 5 Damage Engine deploys the DamageModifierEvents 1.00 through 3.00	 ← ←	 4 The EVENT_UNIT_DAMAGED event runs. If the damage is negative, flag IsDamageSpell as True and invert the damage back to a positive.
 7 If DamageEventAmount is greater than 0.00, run the DamageModifierEvent 4.00. Same old recursive events apply as with 1.00-3.00.	 → → 	 8 Now that DamageEventAmount is finalized, run DamageEvent 1.00. Same old recursive events apply as with DamageModifier events.	 → → 	 9 The user can access DamageEventPrevAmount if they want to know the damage amount before user modifications (before in-game modifications was impossible to know).	 → ↓ 
 ↓ ← 	 12 Set a flag to indicate the removal of the Cheat Death Ability and start a timer as a failsafe.	 ← ←	 11 If the target’s maximum HP is too low to handle the incoming damage, give it the Cheat Death Ability +500,000	 ← ←	 10 Compensate for (DamageEventAmount - Life of DamageEventTarget) by increasing or decreasing the target unit’s HP.
 13 The timer expires/a new damage event is run/the UNIT_STATE_EVENT detects the HP change/the user calls ClearDamageEvent (whichever happens first)	 → → 	 14 If the unit was wielding the Cheat Death Ability, remove it.	 → → 	 15 If the damage was above 0.00, run AfterDamageEvent 1.00. Same old recursive events apply as with all previous events.	 → ↓ 
 √ 	 18 Once enough units have left, rebuilt the massive DamageEventTrigger and re-add events only for active units.	 ← ←	 17 When a unit is removed from the game, increment a tracking integer to know how many units have been removed.	 ← ←	 16 Once the timer expires (if it hadn’t already) or if a new DamageEventSource was applied, run AOEDamageEvent 1.00.

 

[Palette]

I'm just gonna leave this here to show what a journey it has been to get Damage Engine set up with all the new mechanics:

 1 Unit attacks or casts a spell	 → → 	 2 The projectile or weapon hits the target unit	 → → 	 3 EVENT_UNIT_DAMAGING is fired before any modifications to the damage are made.	 → ↓ 
 ↓ ← 	 6 User changes to DamageEventAmount and/or to DamageEventDamageT/AttackT/WeaponT are saved into the WC3 engine.	 ← ←	 5 If any recursive damage is detected from any of those events, it is postponed and the current damage will continue first.	 ← ←	 4 Damage Engine deploys the DamageModifierEvents 1.00 through 3.00
 7 WarCraft 3 processes the user damage.	 → → 	 8 WarCraft 3 then distributes the processed damage into Spirit Link/Mana Shield, then applies armor type & amount	 → → 	 9 WarCraft 3 runs any interrupting events, such as spirit link or defensive damage like Thorns Aura	 → ↓ 
 ↓ ← 	 12 Damage Engine will either keep using the original variables with their values, or will recover the original damage values in the event of recursive Spirit Link/defensive retaliating damage.	 ← ←	 11 Once any potential recursive WarCraft 3 damage is processed, the EVENT_UNIT_DAMAGED event runs. This is the original event we always had access to.	 ← ←	 10 If such events such as Spirit Link were detected, they fire their own EVENT_UNIT_DAMAGING & EVENT_UNIT_DAMAGED, and DamageEngine processes it along the way for the user.
 13 If the damage is above zero, DamageModifierEvent 4.00 will run. If any recursive damage is detected, it is postponed.	 → → 	 14 The user can make modification to the damage here with the after-damage amount.	 → → 	 15 The user can access DamageEventPrevAmount if they want to know the damage amount before user changes/WarCraft 3 changes.	 → ↓ 
 ↓ ← 	 18 The user can specify whether or not to change LethalDamageHP in order to stop the unit from dying.	 ← ←	 17 If the damage is still above zero, check if the damage is lethal. If so, run LethalDamageEvent 1.00. If any recursive damage is detected, it is postponed.	 ← ←	 16 If the user wants the value that DamageEngine used to have with DamageEventPrevAmt (after WarCraft 3 processing but before user changes) they multiply DamageEventPrevAmt x DamageScalingWC3.
 19 Once all modification is done, run DamageEvent 1.00. If any recursive damage is detected, it is postponed.	 → → 	 20 Run all potential recursive Unit - Damage Target function calls in chronological order (first in, first out).	 → → 	 21 After a 0.00 second timer expires, run the AOEDamageEvent (if multiple units were hit by the same source in the same instant).	 √ 

lovin this thanks

 

[Bribe]

Coming next in 5.2: Defense and armor type detection and (maybe) modification.

I have a working model, but I'm unsure if this system is best suited for modifying those things. If I do, it's going to only affect the current damage instance and then set each to their previous values (ie. changing DamageEventAttackT doesn't change the unit's attack type but DOES change it for the current damage.

The update will also very likely return AfterDamageEvent to the system. I need to be able to allow the user to delay damage until after the first damage has been applied to the unit.

Lastly, after carefully reviewing the previous posts in this thread, the one suggestion that I went over that hasn't been addressed in 5.1, is Evasion. Triggered evasion is never really going to work right, because on-hit effects will still proc. Also, you can turn off the on-hit sound of melee attacks by changing DamageEventWeaponT to WEAPON_TYPE_NONE, however you cannot change the audio nor visual of the projectile impacting on the target unit. Lastly, you can't even detect if a WarCraft 3 attack was actually evaded (without using some heavily complex attack indexing system with instant projectiles).

Maybe with a future WarCraft 3 update we'll have access to explore the mechanics of Evasion and how it interacts with the DDS, but in the mean time I can only provide more access for GUI users with regards to detection and modification of in-instance armor & defense types, as well as a very likely resurrection of the AfterDamageEvent.

 

[Bribe]

Damage Engine 5.2.0.0 is here - this is the last foreseeable innovative update to Damage Engine. This release is stable (as is 5.1.3.1), but non-essential. Changes are:

• You can now read/modify DamageEventArmorT/DefenseT. Please have a look at the Damage Engine Config trigger to understand what these two values can be. Armor types are things like Flesh/Stone, whereas Defense Types are things like Hero, Unarmored, Fortified.
• Re-introduced AfterDamageEvent, which kicks in after the target unit's HP has been reduced.
• Recursive damage is now dealt after the after damage event, instead of after the damage event, which has only one minor hero XP implication in the event of retaliating damage from one to the other where both damage instances are lethal.

 

[Bribe]

I've added FAQs to address what I recall are the things that have been asked the most. I've also included steps on how to upgrade from one version of Damage Engine to the next, as there has typically been a pattern of how I decide which integer gets incremented with each update.

I've also spun off the Damage Engine 3.8 into a Pastebin, so now all the information here is relevant just to Damage Engine 5 and higher.

 

[El Saif]

Bribe, i'm wondering how to this : while UnitA damages a unit, he pierces some of the target's armor. So it would dealt more damage.

 

[Bribe]

Bribe, i'm wondering how to this : while UnitA damages a unit, he pierces some of the target's armor. So it would dealt more damage.

Depends on the complexity.

You definitely want to use DamageModifierEvent 1.00, and then do one (or some) of the following:

Set DamageEventAmount = (DamageEventAmount x 2.00) (this doubles the damage)
or
Set DamageEventAttackT = ATTACK_TYPE_CHAOS (this causes the damage to be 100% regardless of defense type)
or
Set DamageEventDamageT = DAMAGE_TYPE_UNIVERSAL (this causes the target unit's armor value to be ignored)
or
Set DamageEventDefenseT = DEFENSE_TYPE_UNARMORED (this causes piercing and siege attacks to inflict bonus damage)

 

[El Saif]

Hmm.. but how if want it like, the UnitA will pierce 7 armor. The target has 10 armor, so if target takes damage, the damage amount is same as if the target has 3 armor.

 

[Bribe]

Hmm.. but how if want it like, the UnitA will pierce 7 armor. The target has 10 armor, so if target takes damage, the damage amount is same as if the target has 3 armor.

WarCraft 3 armor calculation, if the Gameplay Constants weren't changed, works like this (source: Warcraft III - Basics -> Armor and Weapon Types):

For positive Armor, damage reduction =((armor)*0.06)/(1+0.06*(armor))
For negative Armor, it is damage increase = 2-0.94^(-armor) since you take more damage for negative armor scores.

In order to make the target ignore a fixed amount of armor, I'd have to make an update to damage engine to change the target's actual armor value for just that moment. I can work on that, but it will take some time to get it sorted (making sure bonus armor is kept separate from base armor).

Gimme a few days to make sure it's bug-free before I do another update to the engine.

 

[El Saif]

Well, i actually make it. But it seems error will happens when you dealing converted physical damage from spells. That one isn't from this testmap, i actually tried once a week ago. It got so bad that the armor decreasing like crazy.
We can just reduce the target's armor within DamageEventModifier equal to 1.00 and then increasing it back at DamageEvent equal to 1.00. The testmap will show that the original paladin won't pierce any armor since the Uther will pierce 100 armors.

 

[Bribe]

That doesn't have any issues with decreasing the armor. The Uther has wayyy too fast attack speed set in Object Editor. When you set his attack speed to normal, it works as expected.

 

[El Saif]

That doesn't have any issues with decreasing the armor. The Uther has wayyy too fast attack speed set in Object Editor. When you set his attack speed to normal, it works as expected.

Oh sorry i just updated the testmap right after i uploaded it so it's normal now, the attack speed and the peasant hp.

Edit : And what i mean about the error i got is as far as i can remember is when i changed phoenix fire damage to hero/normal and also changing the weapon type. It causes error that the armor didn't increase back.

Edit 2 : Nah, i just tested it again and nothing bad happens right now. I don't know why.

 

[Darkfang]

Bribe is there any system to detect stats from items?

 

[Bribe]

Bribe is there any system to detect stats from items?

What kinds of stats?

 

[Devalut]

Is that "FAIL" I see in the screenshot?
What causes this to occur?

 

[Bribe]

Is that "FAIL" I see in the screenshot?
What causes this to occur?

The peasant has always dealt zero damage in the demo map, but now that we have access to weapontype and armortype, we can control what on-hit sound is played. For the peasant, I set them both to NONE, so his attack "misses".

You can check the FAQs I wrote for a smidge more detail.

 

[blink]

@Bribe Is there an event that fires after the damage has been applied? I created a custom ui healthbar that updates when a "DamageEvent becomes Equal to 1.00" however that seemed to set the healthbar to the health of the unit before it was damaged.

@Devalut, based on that prof pic alone I can see that you're a man of culture as well

 

[Bribe]

@Bribe Is there an event that fires after the damage has been applied? I created a custom ui healthbar that updates when a "DamageEvent becomes Equal to 1.00" however that seemed to set the healthbar to the health of the unit before it was damaged.

AfterDamageEvent 1.00 is what you want. I reintroduced it in 5.2.

 

[blink]

awesome. I should update then

Edit: AfterDamageEvent seems to have a delay. @Bribe. DamageEvent seemed to work fine tho so all's working I guess. Thanks!

 

[Bribe]

awesome. I should update then

Edit: AfterDamageEvent seems to have a delay. @Bribe. DamageEvent seemed to work fine tho so all's working I guess. Thanks!

I fixed the delay in today's update. I've also added DamageEventArmorPierced thank to El Saif.

 

[pick-a-chew]

I am not sure if this feedback is particularly helpful, but prior to 1.31 my map ran pretty smooth with Damage Engine, even in situations where hundreds of damage events would occur per second and wouldn't cause any performance issues. Since the 5.0.0.0 version (and beyond) of Damage Engine its performance has been significantly worse, the map plays fine but during intense battles (where there are hundreds of instances of damage per second going on) there's a bit of choking. Nothing particularly worrisome but players on lower end machines complain about debilitating lag.

It's particularly bad during AoE effects when multiple instances of damage occur at the same time (e.g. Thunder Clap).

There's a bit of optimization I can do on my end to alleviate the issue but I felt like it was worth letting you know that the latest iteration of D.E performs less well (maybe you already know ).

 

[Bribe]

I am not sure if this feedback is particularly helpful, but prior to 1.31 my map ran pretty smooth with Damage Engine, even in situations where hundreds of damage events would occur per second and wouldn't cause any performance issues. Since the 5.0.0.0 version (and beyond) of Damage Engine its performance has been significantly worse, the map plays fine but during intense battles (where there are hundreds of instances of damage per second going on) there's a bit of choking. Nothing particularly worrisome but players on lower end machines complain about debilitating lag.

It's particularly bad during AoE effects when multiple instances of damage occur at the same time (e.g. Thunder Clap).

There's a bit of optimization I can do on my end to alleviate the issue but I felt like it was worth letting you know that the latest iteration of D.E performs less well (maybe you already know ).

This is a very important question and one which I will answer in detail, giving you some choice which may help to circumvent this issue.

First, some details:

1. WarCraft 3 is now significantly more CPU intensive. The FPS is about half of what it used to be. Most probably wouldn't notice, but the lower-end machines certainly would.
   
   
   
2. Damage Engine is now based on two events, rather than one, per damage instance - so this has somewhat of a performance impact (however minor).
   
   
   
3. It's impossible to know how much less efficient Damage Engine 5 is from what it would've been in previous iterations of WarCraft 3, because the new natives restrict it. However, I could run some speed benchmarks comparing the performance of Damage Engine 3.8 to 5.3 and see what kind of delta we're dealing with.

Next, onto some solutions:

1. Avoid duplicate events (where possible). This means, instead of having multiple triggers each with DamageModifierEvent becomes Equal to 1.00, just have one trigger with an if/else chain that regulates the conditions of all the other triggers in the map that had been using that event, and if the conditions are successful then run the respective trigger.
   
   
   
2. Make sure Damage Engine is on the latest version. I make performance improvements in the code with every update. Not saying it's the solution to the problem, but minor optimizations do go a long way.

Some final notes: Yesterday, I was thinking about writing a Lua Damage Engine, which would co-exist with GUI Damage Engine. I know currently maps cannot both have vJass and Lua, so this would serve as - yet another - bridge for those who need compatibility with however their map is implemented. However, there is also @TriggerHappy's JNGP Lua Edition - Combining JASS/vJass/Lua, which could, potentially, bridge that gap without me needing to code a second version.

 

[Elektrohund]

I used to have a DamageModifierEvent trigger for every player (4) on my map. It caused the map to crash during heavy AoE, so now I only use one!

 

[Ulfsire]

Just implemented this...my first DDS...what have I been doing all these years? This is FANTASTIC. Thank you SO MUCH for making something user-friendly. I'm now able to employ so many ideas in my maps. Wish I could give this more than 5 stars.

 

[Bribe]

Major update! Infinite recursion loops are now 100% a thing of the past! No more annoying steps to mitigate it yourself, since the system now tracks the triggers it fires and will prevent your trigger from re-firing during the recursive sequence.

This is achieved by hooking the TriggerRegisterVariableEvent call, adding your trigger to a list, and running that list instead of actually using the variable event. So now the entire process is risk-free.

Yes, so you can stop doing weird things like setting the DamageEventTrigger to your own trigger before dealing damage. Damage Engine 5.4 has got you covered. No more recursion!

 

[El Saif]

Major update! Infinite recursion loops are now 100% a thing of the past! No more annoying steps to mitigate it yourself, since the system now tracks the triggers it fires and will prevent your trigger from re-firing during the recursive sequence.

This is achieved by hooking the TriggerRegisterVariableEvent call, adding your trigger to a list, and running that list instead of actually using the variable event. So now the entire process is risk-free.

Yes, so you can stop doing weird things like setting the DamageEventTrigger to your own trigger before dealing damage. Damage Engine 5.4 has got you covered. No more recursion!

I was just thinking about this and now you really made it, great job.

Edit : Hmm

 

[Ricola3D]

Dummy question : the latest version only works with WE 1.31.x right ? So I cannot both use it and protect my map at the same time right (with Widgetizer, Vexorian's optimizer, ...) ?

 

[AutisticTenacity]

@Bribe Is there a way to turn on damage recursion? As the damage events no longer run, shield events cannot damage shields in this situation.

Here's a test map, reproduction steps are as follows

1. Shield yourself, and the enemy peasant
   
2. Let the enemy peasant break your shield
3. Watch the shield explosion directly damage the enemy peasant's health, bypassing the shield

Also, I believe Sunken City makes use of damage recursion as well, with some procs being able to trigger procs in a chain, if very lucky or given a large enough mob density with AoE procs. Though in their case, removing recursion would just be an excuse to rebalance things without needing to consider recursive damage returns on stacking procs effects trying to hit some recursion critical mass.

 

[Bribe]

@Bribe Is there a way to turn on damage recursion? As the damage events no longer run, shield events cannot damage shields in this situation.

Here's a test map, reproduction steps are as follows

1. Shield yourself, and the enemy peasant
   
2. Let the enemy peasant break your shield
3. Watch the shield explosion directly damage the enemy peasant's health, bypassing the shield

Also, I believe Sunken City makes use of damage recursion as well, with some procs being able to trigger procs in a chain, if very lucky or given a large enough mob density with AoE procs. Though in their case, removing recursion would just be an excuse to rebalance things without needing to consider recursive damage returns on stacking procs effects trying to hit some recursion critical mass.

A few things:

1. I tested the map and I'm not sure what the expected behavior is there.
2. I'm not sure which triggers pertain to the affected shields.
   
3. The anti-recursion disables the core event trigger, and I see that you have a central event trigger from where all the little ones spawn. To "get around" the recursion protection I have, one must have more events (not necessarily more triggers, because I'm not turning off triggers - I'm turning off events). So this means:
   • Things that should always run regardless of how deep the recursion is (such as damage enhancement or reduction) should have their own event(s) and not deal damage from them.
   • Things which SHOULD deal damage recursively should have two events (get ready, shit's about to get real):
     • • ForcedRecursion
         • Events
           • Game - DamageModifierEvent becomes Equal to 4.00
           • Game - DamageModifierEvent becomes Equal to 4.00
         • Conditions
         • Actions
           • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
             • If - Conditions
               • IsDamageCode Equal to False
             • Then - Actions
               • -------- Normal event, do whatever you want as the source wasn't triggered --------
               • Unit - Cause Source to damage Target...
             • Else - Actions
               • -------- Recursive event - do some recursive calculations with your shields in order to come up with--------
               • -------- final numbers of damage/shield reduction for the DamageEventSource and DamageEventTarget --------
               • Unit - Cause Source to damage Target for <calculated total>...
               • Unit - Cause Target to damage Source for <calculated total>...
   • • Actually, the above can't really be done either, since it would fire twice for the initial event. The system doesn't currently have a way to support forced recursion. It'd be harder for the user to figure it out than for me to just update the system for daredevils. Stay tuned.

Dummy question : the latest version only works with WE 1.31.x right ? So I cannot both use it and protect my map at the same time right (with Widgetizer, Vexorian's optimizer, ...) ?

Only 3.8 (found in the pastebin) works pre-1.31.

 

[Bribe]

Ok, for those who insist on it, this code allows recursion. I'm hesitant to release this as an actual patch.

Basically, this is an advanced concept and against the design of the engine, so you'll need to use Custom script and set DamageEngine_allowRecursion = true.

It will allow that triggered damage to go recursive to the number of MAX_RECURSION.

//===========================================================================
// Damage Engine lets you detect, amplify, block or nullify damage. It even
// lets you detect if the damage was physical or from a spell. Just reference
// DamageEventAmount/Source/Target or the boolean IsDamageSpell, to get the
// necessary damage event data.
//
// - Detect damage (after it's been dealt to the unit): use the event "DamageEvent Equal to 1.00"
// - To change damage before it's dealt: use the event "DamageModifierEvent Equal to 1.00"
// - Detect spell damage: use the condition "IsDamageSpell Equal to True"
// - Detect zero-damage: use the event "DamageEvent Equal to 2.00"
//
// You can specify the DamageEventType before dealing triggered damage:
// - Set NextDamageType = DamageTypeWhatever
// - Unit - Cause...
//
// You can modify the DamageEventAmount and the DamageEventType from a "DamageModifierEvent Equal to 1.00" trigger.
// - If the amount is modified to negative, it will count as a heal.
// - If the amount is set to 0, no damage will be dealt.
//
// If you need to reference the original in-game damage, use the variable "DamageEventPrevAmt".
//
//===========================================================================
library DamageEngine initializer Init
globals
    private constant integer MAX_RECURSION = 16
    public boolean allowRecursion = false
    private integer array daredevil
    private boolean recursive = false
    private integer recursion = -1
    
    private boolean started = false
    private boolean finished = false
    private boolean purge = false
    private timer ticker = CreateTimer()
    private trigger trig = CreateTrigger()
    private real previousAmount = 0.00      //Added to track the original modified damage pre-spirit Link
    private real previousValue = 0.00       //Added to track the original pure damage amount of Spirit Link
    private integer previousType = 0        //Track the type
    private boolean previousCode = false    //Was it caused by a trigger/script?
    private boolean preDamage = false
    private boolean holdClear = false
  
    //Added in 5.2 to detect and modify armor and defense types from within the damage instance.
    private real previousPierce     = 0.00
    private integer armorType       = 0
    private integer previousArmor   = 0
    private integer prevPreArmor    = 0
    private integer defenseType     = 0
    private integer previousDefense = 0
    private integer prevPreDefense  = 0
  
    private unit array lastSource
    private unit array lastTarget
    private real array lastAmount
    private attacktype array lastAttackT
    private damagetype array lastDamageT
    private weapontype array lastWeaponT
    private integer array lastTrig
    private integer array lastType
  
    //Added in 5.4 to silently eliminate recursion.
    private integer userTrigs = 9
    private integer eventTrig = 0
    private integer array nextTrig
    private trigger array userTrig
    private boolean array trigFrozen
endglobals
//GUI Vars:
/*
    boolean udg_DamageEventOverride
    boolean udg_NextDamageType
    boolean udg_DamageEventType
    boolean udg_IsDamageCode            //New in 5.1 as per request from chopinski
    boolean udg_IsDamageSpell
    boolean udg_IsDamageMelee           //New in 5.0
    boolean udg_IsDamageRanged          //New in 5.0
    unit udg_DamageEventSource
    unit udg_DamageEventTarget
    real    udg_AOEDamageEvent
    integer udg_DamageEventAOE
    group   udg_DamageEventAOEGroup
    unit    udg_AOEDamageSource         //New in 5.0
    integer udg_DamageEventLevel
    unit    udg_EnhancedDamageTarget
    real udg_DamageModifierEvent
    real udg_LethalDamageEvent          //New in 5.0
    real udg_DamageEvent
    real udg_AfterDamageEvent
    real udg_DamageEventAmount
    real udg_DamageEventPrevAmt
    real DamageEventArmorPierced
    real udg_DamageScalingWC3
    real udg_DamageScalingUser
    real udg_LethalDamageHP             //New in 5.0
    integer udg_DamageEventAttackT      //New in 5.0
    integer udg_DamageEventDamageT      //New in 5.0
    integer udg_DamageEventWeaponT      //New in 5.0
    integer udg_DamageEventArmorT
    integer udg_DamageEventDefenseT
*/
  
private function RunTrigs takes integer i, integer cat returns nothing
    set recursive = true
    loop
        set i = nextTrig[i]
        exitwhen i == 0
        exitwhen cat == 1 and (udg_DamageEventOverride or udg_DamageEventType*udg_DamageEventType == 4)
        exitwhen cat == 2 and udg_DamageEventAmount <= 0.00
        if not trigFrozen[i] and IsTriggerEnabled(userTrig[i]) then
            set eventTrig = i
            if TriggerEvaluate(userTrig[i]) then
                call TriggerExecute(userTrig[i])
            endif
            //call BJDebugMsg("Ran " + I2S(i))
        endif
    endloop
    set recursive = false
endfunction
  
private function OnAOEEnd takes nothing returns nothing
    if udg_DamageEventAOE > 1 then
        call RunTrigs(8, 0)
        set udg_DamageEventAOE      = 1
    endif
    set udg_DamageEventLevel        = 1
    set udg_EnhancedDamageTarget    = null
    set udg_AOEDamageSource         = null
    call GroupClear(udg_DamageEventAOEGroup)
endfunction
  
private function Finish takes nothing returns nothing
    local integer i = -1
    if finished then
        set finished = false
        if udg_DamageEventPrevAmt != 0.00 and udg_DamageEventDamageT != udg_DAMAGE_TYPE_UNKNOWN then
            call RunTrigs(7, 0)
        endif
        if recursion > -1 and not holdClear and not purge then
            set purge = true
            //call BJDebugMsg("Clearing Recursion: " + I2S(recursion))
            loop
                exitwhen i >= recursion
                set i = i + 1 //Need to loop bottom to top to make sure damage order is preserved.
              
                set udg_NextDamageType = lastType[i]
                //call BJDebugMsg("Stacking on " + R2S(lastAmount[i]))
                call UnitDamageTarget(lastSource[i], lastTarget[i], lastAmount[i], true, false, lastAttackT[i], lastDamageT[i], lastWeaponT[i])
                call Finish()
            endloop
            loop
                exitwhen i <= -1
                set trigFrozen[lastTrig[i]] = false //Only re-enable recursive triggers AFTER all damage is dealt.
                set daredevil[lastTrig[i]] = 0 //Reset this stuff if the user tried some nonsense
                set i = i - 1
            endloop
            //call BJDebugMsg("Cleared Recursion: " + I2S(recursion))
            set recursion = -1 //Can only be set after all the damage has successfully ended.
            set purge = false
        endif
    endif
endfunction
  
private function OnExpire takes nothing returns nothing
    set started = false //The timer has expired. Flag off to allow it to be restarted when needed.
    call Finish() //Wrap up any outstanding damage instance
    call OnAOEEnd() //Reset things so they don't perpetuate for AoE/Level target detection
endfunction
private function CalibrateMR takes nothing returns nothing
    set udg_IsDamageMelee           = false
    set udg_IsDamageRanged          = false
    set udg_IsDamageSpell           = udg_DamageEventAttackT == 0 //In Patch 1.31, one can just check the attack type to find out if it's a spell.
    if udg_DamageEventDamageT == udg_DAMAGE_TYPE_NORMAL and not udg_IsDamageSpell then //This damage type is the only one that can get reduced by armor.
        set udg_IsDamageMelee       = IsUnitType(udg_DamageEventSource, UNIT_TYPE_MELEE_ATTACKER)
        set udg_IsDamageRanged      = IsUnitType(udg_DamageEventSource, UNIT_TYPE_RANGED_ATTACKER)
        if udg_IsDamageMelee and udg_IsDamageRanged then
            set udg_IsDamageMelee   = udg_DamageEventWeaponT > 0// Melee units play a sound when damaging
            set udg_IsDamageRanged  = not udg_IsDamageMelee     // In the case where a unit is both ranged and melee, the ranged attack plays no sound.
        endif                                                   // The Huntress has a melee sound for her ranged projectile, however it is only an issue
    endif                                                       //if she also had a melee attack, because by default she is only UNIT_TYPE_RANGED_ATTACKER.
endfunction
private function OnPreDamage takes nothing returns boolean
    local unit src      = GetEventDamageSource()
    local unit tgt      = GetTriggerUnit()
    local real amt      = GetEventDamage()
    local attacktype at = BlzGetEventAttackType()
    local damagetype dt = BlzGetEventDamageType()
    local weapontype wt = BlzGetEventWeaponType()
  
    if recursive then
        if amt != 0.00 then
            set recursion = recursion + 1
          
            //Store recursive damage into a queue from index "recursion" (0-15)
            //This damage will be fired after the current damage instance has wrapped up its events.
            //This damage can only be caused by triggers.
            set lastAmount[recursion]   = amt
            set lastSource[recursion]   = src
            set lastTarget[recursion]   = tgt
            set lastAttackT[recursion]  = at
            set lastDamageT[recursion]  = dt
            set lastWeaponT[recursion]  = wt
            set lastTrig[recursion]     = eventTrig
            if udg_NextDamageType == 0 then
                set lastType[recursion] = udg_DamageTypeCode
            else
                set lastType[recursion] = udg_NextDamageType
            endif
            if allowRecursion and not trigFrozen[eventTrig] then
                set daredevil[eventTrig] = daredevil[eventTrig] + 1
                if daredevil[eventTrig] >= MAX_RECURSION then
                    set trigFrozen[eventTrig] = true
                endif
            else
                set trigFrozen[eventTrig] = true
            endif
        endif
        set udg_NextDamageType = 0
        call BlzSetEventDamage(0.00) //queue the damage instance instead of letting it run recursively
    else
        if not purge then
            call Finish()
            //Added 25 July 2017 to detect AOE damage or multiple single-target damage
            if started then
                if src != udg_AOEDamageSource then //Source has damaged more than once
                  
                    call OnAOEEnd() //New damage source - unflag everything
                    set udg_AOEDamageSource = src
                elseif tgt == udg_EnhancedDamageTarget then
                    set udg_DamageEventLevel= udg_DamageEventLevel + 1  //The number of times the same unit was hit.
                elseif not IsUnitInGroup(tgt, udg_DamageEventAOEGroup) then
                    set udg_DamageEventAOE  = udg_DamageEventAOE + 1    //Multiple targets hit by this source - flag as AOE
                endif
                if preDamage then
                    set preDamage           = false
                    set previousAmount      = udg_DamageEventAmount
                    set previousValue       = udg_DamageEventPrevAmt    //Store the actual pre-armor value.
                    set previousType        = udg_DamageEventType       //also store the damage type.
                    set previousCode        = udg_IsDamageCode          //store this as well.
                    set previousArmor       = udg_DamageEventArmorT
                    set prevPreArmor        = armorType
                    set previousDefense     = udg_DamageEventDefenseT
                    set prevPreDefense      = defenseType
                    set previousPierce      = udg_DamageEventArmorPierced
                    set holdClear           = true
                endif
            else
                call TimerStart(ticker, 0.00, false, function OnExpire)
                set started                 = true
                set udg_AOEDamageSource     = src
                set udg_EnhancedDamageTarget= tgt
            endif
            call GroupAddUnit(udg_DamageEventAOEGroup, tgt)
        endif
        set udg_DamageEventType             = udg_NextDamageType
        if udg_NextDamageType != 0 then
            set udg_DamageEventType         = udg_NextDamageType
            set udg_NextDamageType          = 0
            set udg_IsDamageCode            = true //New in 5.1 - requested by chopinski to allow user to detect Code damage
        endif
        set udg_DamageEventOverride         = dt == null or amt == 0.00 //Got rid of NextDamageOverride in 5.1 for simplicity
        set udg_DamageEventPrevAmt          = amt
        set udg_DamageEventSource           = src
        set udg_DamageEventTarget           = tgt
        set udg_DamageEventAmount           = amt
        set udg_DamageEventAttackT          = GetHandleId(at)
        set udg_DamageEventDamageT          = GetHandleId(dt)
        set udg_DamageEventWeaponT          = GetHandleId(wt)
      
        call CalibrateMR() //Set Melee and Ranged settings.
      
        set udg_DamageEventArmorT           = BlzGetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_ARMOR_TYPE) //Introduced in Damage Engine 5.2.0.0
        set udg_DamageEventDefenseT         = BlzGetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_DEFENSE_TYPE)
        set armorType                       = udg_DamageEventArmorT
        set defenseType                     = udg_DamageEventDefenseT
        set udg_DamageEventArmorPierced     = 0.00
      
        //Ignores event on various debuffs like Faerie Fire - alternatively,
        //the user can exploit UNKNOWN damage type to avoid damage detection.
        if not udg_DamageEventOverride then
            call RunTrigs(1, 1)
          
            //All events have run and the pre-damage amount is finalized.
            call BlzSetEventAttackType(ConvertAttackType(udg_DamageEventAttackT))
            call BlzSetEventDamageType(ConvertDamageType(udg_DamageEventDamageT))
            call BlzSetEventWeaponType(ConvertWeaponType(udg_DamageEventWeaponT))
            if udg_DamageEventArmorPierced != 0.00 then
                call BlzSetUnitArmor(udg_DamageEventTarget, BlzGetUnitArmor(udg_DamageEventTarget) - udg_DamageEventArmorPierced)
            endif
            if armorType != udg_DamageEventArmorT then
                call BlzSetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_ARMOR_TYPE, udg_DamageEventArmorT) //Introduced in Damage Engine 5.2.0.0
            endif
            if defenseType != udg_DamageEventDefenseT then
                call BlzSetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_DEFENSE_TYPE, udg_DamageEventDefenseT) //Introduced in Damage Engine 5.2.0.0
            endif
            call BlzSetEventDamage(udg_DamageEventAmount)
        endif
        set preDamage = true
        //call BJDebugMsg("Ready to deal " + R2S(udg_DamageEventAmount))
    endif
    set src = null
    set tgt = null
    set allowRecursion = false
    return false
endfunction
//The traditional on-damage response, where armor reduction has already been factored in.
private function OnDamage takes nothing returns boolean
    local real r = GetEventDamage()
    if recursive then
        return false
    endif
    //call BJDebugMsg("Second event running")
    if preDamage then
        set preDamage = false   //This should be the case in almost all circumstances
    else
        call Finish() //Wrap up the outstanding damage instance
        set holdClear                   = false
        //Unfortunately, Spirit Link and Thorns Aura/Spiked Carapace fire the DAMAGED event out of sequence with the DAMAGING event,
        //so I have to re-generate a buncha stuff here.
        set udg_DamageEventAmount       = previousAmount
        set udg_DamageEventPrevAmt      = previousValue
        set udg_DamageEventType         = previousType
        set udg_IsDamageCode            = previousCode
        set udg_DamageEventSource       = GetEventDamageSource()
        set udg_DamageEventTarget       = GetTriggerUnit()
        set udg_DamageEventAttackT      = GetHandleId(BlzGetEventAttackType())
        set udg_DamageEventDamageT      = GetHandleId(BlzGetEventDamageType())
        set udg_DamageEventWeaponT      = GetHandleId(BlzGetEventWeaponType())
        set udg_DamageEventArmorT       = previousArmor
        set udg_DamageEventDefenseT     = previousDefense
        set udg_DamageEventArmorPierced = previousPierce
        set armorType                   = prevPreArmor
        set defenseType                 = prevPreDefense
        call CalibrateMR() //Apply melee/ranged settings once again.
    endif
    if udg_DamageEventArmorPierced != 0.00 then
        call BlzSetUnitArmor(udg_DamageEventTarget, BlzGetUnitArmor(udg_DamageEventTarget) + udg_DamageEventArmorPierced)
    endif
    if armorType != udg_DamageEventArmorT then
        call BlzSetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_ARMOR_TYPE, armorType) //revert changes made to the damage instance
    endif
    if defenseType != udg_DamageEventDefenseT then
        call BlzSetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_DEFENSE_TYPE, defenseType)
    endif
    set recursive = true
    if udg_DamageEventPrevAmt == 0.00 then
        call RunTrigs(6, 0)
    else
        if udg_DamageEventAmount != 0.00 and r != 0.00 then
            set udg_DamageScalingWC3 = r / udg_DamageEventAmount
        elseif udg_DamageEventAmount > 0.00 then
            set udg_DamageScalingWC3 = 0.00
        else
            set udg_DamageScalingWC3 = 1.00
        endif
        set r = udg_DamageEventAmount
        set udg_DamageScalingUser = r/udg_DamageEventPrevAmt
        set udg_DamageEventAmount = r*udg_DamageScalingWC3
      
        if udg_DamageEventAmount > 0.00 then
            //This event is used for custom shields which have a limited hit point value
            //The shield here kicks in after armor, so it acts like extra hit points.
            call RunTrigs(4, 2)
            set udg_LethalDamageHP = GetWidgetLife(udg_DamageEventTarget) - udg_DamageEventAmount
            if udg_LethalDamageHP <= 0.405 then
                call RunTrigs(8, 0) //Added 10 May 2019 to detect and potentially prevent lethal damage. Instead of
                //modifying the damage, you need to modify LethalDamageHP instead (the final HP of the unit).
              
                set udg_DamageEventAmount = GetWidgetLife(udg_DamageEventTarget) - udg_LethalDamageHP
                if udg_DamageEventType < 0 and udg_LethalDamageHP <= 0.405 then
                    call SetUnitExploded(udg_DamageEventTarget, true)   //Explosive damage types should blow up the target.
                endif
            endif
            set udg_DamageScalingUser = udg_DamageEventAmount/(udg_DamageEventPrevAmt*udg_DamageScalingWC3)
        endif
        call BlzSetEventDamage(udg_DamageEventAmount)   //Apply the final damage amount.
        //if recursion > -1 then
            //call BJDebugMsg("Dealing " + R2S(udg_DamageEventAmount))
        //endif
        if udg_DamageEventDamageT != udg_DAMAGE_TYPE_UNKNOWN then
            call RunTrigs(5, 0)
        endif
    endif
    set recursive = false
    set finished = true
    if udg_DamageEventAmount == 0.00 then
        call Finish()
    endif
    return false
endfunction
//===========================================================================
private function Init takes nothing returns nothing
    call TriggerRegisterAnyUnitEventBJ(trig, EVENT_PLAYER_UNIT_DAMAGED) //Thanks to this I no longer have to create an event for every unit in the map.
    call TriggerAddCondition(trig, Filter(function OnDamage))
    set trig = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(trig, EVENT_PLAYER_UNIT_DAMAGING) //The new 1.31 event which fires before damage.
    call TriggerAddCondition(trig, Filter(function OnPreDamage))
endfunction
public function DebugStr takes nothing returns nothing
    set udg_AttackTypeDebugStr[0] = "SPELLS"    //ATTACK_TYPE_NORMAL in JASS
    set udg_AttackTypeDebugStr[1] = "NORMAL"    //ATTACK_TYPE_MELEE in JASS
    set udg_AttackTypeDebugStr[2] = "PIERCE"
    set udg_AttackTypeDebugStr[3] = "SIEGE"
    set udg_AttackTypeDebugStr[4] = "MAGIC"
    set udg_AttackTypeDebugStr[5] = "CHAOS"
    set udg_AttackTypeDebugStr[6] = "HERO"
  
    set udg_DamageTypeDebugStr[0]  = "UNKNOWN"
    set udg_DamageTypeDebugStr[4]  = "NORMAL"
    set udg_DamageTypeDebugStr[5]  = "ENHANCED"
    set udg_DamageTypeDebugStr[8]  = "FIRE"
    set udg_DamageTypeDebugStr[9]  = "COLD"
    set udg_DamageTypeDebugStr[10] = "LIGHTNING"
    set udg_DamageTypeDebugStr[11] = "POISON"
    set udg_DamageTypeDebugStr[12] = "DISEASE"
    set udg_DamageTypeDebugStr[13] = "DIVINE"
    set udg_DamageTypeDebugStr[14] = "MAGIC"
    set udg_DamageTypeDebugStr[15] = "SONIC"
    set udg_DamageTypeDebugStr[16] = "ACID"
    set udg_DamageTypeDebugStr[17] = "FORCE"
    set udg_DamageTypeDebugStr[18] = "DEATH"
    set udg_DamageTypeDebugStr[19] = "MIND"
    set udg_DamageTypeDebugStr[20] = "PLANT"
    set udg_DamageTypeDebugStr[21] = "DEFENSIVE"
    set udg_DamageTypeDebugStr[22] = "DEMOLITION"
    set udg_DamageTypeDebugStr[23] = "SLOW_POISON"
    set udg_DamageTypeDebugStr[24] = "SPIRIT_LINK"
    set udg_DamageTypeDebugStr[25] = "SHADOW_STRIKE"
    set udg_DamageTypeDebugStr[26] = "UNIVERSAL"
  
    set udg_WeaponTypeDebugStr[0]  = "NONE"     //WEAPON_TYPE_WHOKNOWS in JASS
    set udg_WeaponTypeDebugStr[1]  = "METAL_LIGHT_CHOP"
    set udg_WeaponTypeDebugStr[2]  = "METAL_MEDIUM_CHOP"
    set udg_WeaponTypeDebugStr[3]  = "METAL_HEAVY_CHOP"
    set udg_WeaponTypeDebugStr[4]  = "METAL_LIGHT_SLICE"
    set udg_WeaponTypeDebugStr[5]  = "METAL_MEDIUM_SLICE"
    set udg_WeaponTypeDebugStr[6]  = "METAL_HEAVY_SLICE"
    set udg_WeaponTypeDebugStr[7]  = "METAL_MEDIUM_BASH"
    set udg_WeaponTypeDebugStr[8]  = "METAL_HEAVY_BASH"
    set udg_WeaponTypeDebugStr[9]  = "METAL_MEDIUM_STAB"
    set udg_WeaponTypeDebugStr[10] = "METAL_HEAVY_STAB"
    set udg_WeaponTypeDebugStr[11] = "WOOD_LIGHT_SLICE"
    set udg_WeaponTypeDebugStr[12] = "WOOD_MEDIUM_SLICE"
    set udg_WeaponTypeDebugStr[13] = "WOOD_HEAVY_SLICE"
    set udg_WeaponTypeDebugStr[14] = "WOOD_LIGHT_BASH"
    set udg_WeaponTypeDebugStr[15] = "WOOD_MEDIUM_BASH"
    set udg_WeaponTypeDebugStr[16] = "WOOD_HEAVY_BASH"
    set udg_WeaponTypeDebugStr[17] = "WOOD_LIGHT_STAB"
    set udg_WeaponTypeDebugStr[18] = "WOOD_MEDIUM_STAB"
    set udg_WeaponTypeDebugStr[19] = "CLAW_LIGHT_SLICE"
    set udg_WeaponTypeDebugStr[20] = "CLAW_MEDIUM_SLICE"
    set udg_WeaponTypeDebugStr[21] = "CLAW_HEAVY_SLICE"
    set udg_WeaponTypeDebugStr[22] = "AXE_MEDIUM_CHOP"
    set udg_WeaponTypeDebugStr[23] = "ROCK_HEAVY_BASH"
  
    set udg_DefenseTypeDebugStr[0] = "LIGHT"
    set udg_DefenseTypeDebugStr[1] = "MEDIUM"
    set udg_DefenseTypeDebugStr[2] = "HEAVY"
    set udg_DefenseTypeDebugStr[3] = "FORTIFIED"
    set udg_DefenseTypeDebugStr[4] = "NORMAL"
    set udg_DefenseTypeDebugStr[5] = "HERO"
    set udg_DefenseTypeDebugStr[6] = "DIVINE"
    set udg_DefenseTypeDebugStr[7] = "UNARMORED"
    set udg_ArmorTypeDebugStr[0] = "NONE"
    set udg_ArmorTypeDebugStr[1] = "FLESH"
    set udg_ArmorTypeDebugStr[2] = "METAL"
    set udg_ArmorTypeDebugStr[3] = "WOOD"
    set udg_ArmorTypeDebugStr[4] = "ETHEREAL"
    set udg_ArmorTypeDebugStr[5] = "STONE"
endfunction
//This function exists mainly to make it easier to switch from another DDS, like PDD.
function UnitDamageTargetEx takes unit src, unit tgt, real amt, boolean a, boolean r, attacktype at, damagetype dt, weapontype wt returns boolean
    if udg_NextDamageType == 0 then
       set udg_NextDamageType = udg_DamageTypeCode
    endif
    call UnitDamageTarget(src, tgt, amt, a, r, at, dt, wt)
    return recursive
endfunction
public function SetupEvent takes trigger whichTrig, string var, integer index returns nothing
    local integer max = 1
    local integer off = 0
    local integer exit = 0
    local integer i
    if var == "udg_DamageModifierEvent" then
        if index < 3 then
            set exit = index + 1
        endif
        if nextTrig[1] == 0 then
            set nextTrig[1] = 2
            set nextTrig[2] = 3
            set trigFrozen[2] = true
            set trigFrozen[3] = true
        endif
        set max = 4
    elseif var == "udg_DamageEvent" then
        set max = 2
        set off = 4
    elseif var == "udg_AfterDamageEvent" then
        set off = 6
    elseif var == "udg_LethalDamageEvent" then
        set off = 7
    elseif var == "udg_AOEDamageEvent" then
        set off = 8
    else
        return
    endif
    set i = IMaxBJ(IMinBJ(index, max), 1) + off
    //call BJDebugMsg("Root index: " + I2S(i))
    loop
        set index = i
        set i = nextTrig[i]
        exitwhen i == exit
    endloop
    set userTrigs = userTrigs + 1
    set nextTrig[index] = userTrigs
    set nextTrig[userTrigs] = exit
    set userTrig[userTrigs] = whichTrig
    //call BJDebugMsg("Registered " + I2S(userTrigs) + " to " + I2S(index))
endfunction
  
private function PreSetup takes trigger whichTrig, string var, limitop op, real value returns nothing
    call SetupEvent(whichTrig, var, R2I(value))
endfunction
  
hook TriggerRegisterVariableEvent PreSetup
  
endlibrary

 

[AutisticTenacity]

The expected behaviour would be that when a flame shield breaks, it would damage units around it. If the units that are affected by the explosion have a shield, those shields should be able to block the damage.

Since the shield breaking happened in the damage event, the damage it dealt when broken would be considered recursive. When recursive damage gets ignored by the damage detection system, the shields can't block damage properly. Presumably this would also mean any form of recursive damage would end up unblocked.

Being able to enable/disable damage recursion pretty much solves that problem.

There are still some very strange things I'll need to ponder over though, such as how to have recursion be true only so that the damage event can catch shield events dealing damage - but otherwise revert back to what the user has opted to use. It's very tricky.

Spoiler: Rant about how troublesome things are

For example, what if someone wished to reflect 100% of damage taken to back their attacker, but not have the damage be recursive (otherwise two units reflecting each other will result both players taking about 8x the damage of the initial hit, since the damage engine tracks recursion level and it'll quit, after the 16th time or so).

They could simply disable recursion, and leave it at that.

But then, the shield system would then not block the reflected damage. Let's say, for gameplay reasons, that it should block this damage.

This means recursion needs to be set to true for it to work. But the trouble is in how recursion can be enabled, and have a unit deal damage so that the engine can pick it up so shields can apply, but otherwise still be set to disabled to everything else that runs on the damage detection engine.

Going back to the example, let's say one of the units has a shield that should explode when broken. If this shield breaks and explodes, the damage from the explosion would need to have recursion set to be true. If the shield explodes and damages a unit with recursion to true, it would also cause the reflection damage to be dealt, but wait, instead of the reflection damage being ignored as it should be, recursion is currently set to true, when it shouldn't have been. This would result in the 8x recursive damage reflection we originally didn't want.

Of course, the easiest solution is to not actually deal recursive/reactive damage instantly. But that would be a problem because it would be up to the user to accomplish.

I'd imagine most GUI users aren't too keen on using timers or projectile systems as opposed to instantly dealing the damage. Using waits/sleep is also out of the question, for obvious system breaking reasons.

 

[Bribe]

The expected behaviour would be that when a flame shield breaks, it would damage units around it. If the units that are affected by the explosion have a shield, those shields should be able to block the damage.

Since the shield breaking happened in the damage event, the damage it dealt when broken would be considered recursive. When recursive damage gets ignored by the damage detection system, the shields can't block damage properly. Presumably this would also mean any form of recursive damage would end up unblocked.

Being able to enable/disable damage recursion pretty much solves that problem.

There are still some very strange things I'll need to ponder over though, such as how to have recursion be true only so that the damage event can catch shield events dealing damage - but otherwise revert back to what the user has opted to use. It's very tricky.

Spoiler: Rant about how troublesome things are

For example, what if someone wished to reflect 100% of damage taken to back their attacker, but not have the damage be recursive (otherwise two units reflecting each other will result both players taking about 8x the damage of the initial hit, since the damage engine tracks recursion level and it'll quit, after the 16th time or so).

They could simply disable recursion, and leave it at that.

But then, the shield system would then not block the reflected damage. Let's say, for gameplay reasons, that it should block this damage.

This means recursion needs to be set to true for it to work. But the trouble is in how recursion can be enabled, and have a unit deal damage so that the engine can pick it up so shields can apply, but otherwise still be set to disabled to everything else that runs on the damage detection engine.

Going back to the example, let's say one of the units has a shield that should explode when broken. If this shield breaks and explodes, the damage from the explosion would need to have recursion set to be true. If the shield explodes and damages a unit with recursion to true, it would also cause the reflection damage to be dealt, but wait, instead of the reflection damage being ignored as it should be, recursion is currently set to true, when it shouldn't have been. This would result in the 8x recursive damage reflection we originally didn't want.

Of course, the easiest solution is to not actually deal recursive/reactive damage instantly. But that would be a problem because it would be up to the user to accomplish.

I'd imagine most GUI users aren't too keen on using timers or projectile systems as opposed to instantly dealing the damage. Using waits/sleep is also out of the question, for obvious system breaking reasons.

Even with the unupdated version, if you deal recursive damage from one event, it will ignore the recursive damage only from the trigger whose event was caught dealing the damage. So if you avoid dealing damage from DamageModifier 4, you'll ALWAYS be able to let them block damage.

What you could do is pair the shield event with another event further along in the sequence (ie. DamageEvent 1) and deal the damage from there. So you have two triggers instead of one - one whose damage can only fire once and another whose shields can fire for as many events there are.

 

[Bribe]

New Damage Engine explanation video out - finally going into detail about recursion in this one since I've released the "Inception" update that is bound to throw some into an infinite loop themselves.

 

[ZeroGravity]

so now what should my damage trigger looks like now? Probably not this.

 

[Bribe]

so now what should my damage trigger looks like now? Probably not this.

View attachment 327098

You can delete the DamageEventTrigger line as it's no longer necessary. The rest is fine.

 

[ZeroGravity]

kk thanks, I'll try out the new ver.

 

[Bribe]

Ok with the 5.4.2 release, please read the patch notes. This was the most agonizing bug fix implementation I've needed to do since Spirit Link, as it turns out that the DAMAGED event doesn't always run even when the DAMAGING event does.

@SpasMaster make sure you add the 2 new GUI variables.

 

[Bribe]

For anyone who needs a Lua version of this script to run in your map, I've added a Lua version inclusive with Lua Unit Indexer, Lua Is Unit Moving and Lua ArcingTextTag.

There may be a glitch somewhere in one of the converted Lua resources, as I encountered a crash once but couldn't reproduce it. Please keep me posted if you run into any issues (especially ones which can be replicated).

Big shout out to @MindWorX and Zed on Discord for illustrating how to "replace" natives in Lua. This Lua version has a lot of potential as I could potentially extract the Trig_YourTrigger_Conditions and Trig_YourTrigger_Actions variable names and call them directly rather than evaluating & executing them. This could improve performance dramatically.

 

[Devalut]

When watching your deep dive I was making dinner, I had to double take and reassure myself I wasn't watching a review for Inception.
Very cool changes, also adorable squeaker.

 

[Bribe]

For those who have been wanting the most performance as possible from their Damage Events, today I've introduced an updated Lua script which is compatible with a groundbreaking resource [Lua] Ridiculously Fast Triggers. The Lua demo map features this script and I have benchmarked it as running SEVENTEEN TIMES FASTER than traditional trigger evaluate & trigger execute.

I HIGHLY recommend switching your map over to Lua. I am in the process of adding a Lua-compatible script to all of my most frequently-used resources.

 

[Coldgamer]

Bribe, thanks for this absolute fantastic system! There are so many helpful things in there, i really love your system.

Currently I'm trying to understand everything but there is something I'm wondering. There is the text floating system, which displays the text in blue for spells, what works in most cases but if a unit for example have a specific armour-type (in my case heavy, he receive 50% more dmg from spells), the font colour is changing to red.

Looks like the condition for DamageEventAmount is triggering:

DamageEventAmount Less than (DamageEventPrevAmt x 0.60)

Any idea why this is happening and what can I do?

Thanks in advance!

 

[Bribe]

Bribe, thanks for this absolute fantastic system! There are so many helpful things in there, i really love your system.

Currently I'm trying to understand everything but there is something I'm wondering. There is the text floating system, which displays the text in blue for spells, what works in most cases but if a unit for example have a specific armour-type (in my case heavy, he receive 50% more dmg from spells), the font colour is changing to red.

Looks like the condition for DamageEventAmount is triggering:

DamageEventAmount Less than (DamageEventPrevAmt x 0.60)

Any idea why this is happening and what can I do?

Thanks in advance!

In the conditions where you see "DamageEventAmount Greater than or equal to (DamageEventPrevAmt x 1.50)", change them to be "DamageScalingUser Greater than or equal to 1.50".

You can also change the other one "DamageEventAmount Less than (DamageEventPrevAmt x 0.60)" to "DamageScalingUser Less than 0.60" if that one is also giving you trouble.

I have had those variables in the demo map for a long time, but they really should proc off of user damage modification rather than WC3-processed damage. I'll update the demo maps sometime soon.

 

[acagnip]

Is it possible to detect attacks from frost arrows, searing arrows etc. ? In older version i used EnhancedDamageTarget to detect them but now it seems it isn't possible.

 

[Bribe]

Just check if DamageEventLevel is greater than 1. If so, some kind of on-hit effect took place prior to the damage against that target.

However, Searing Arrows was never detectable.

Is it possible to detect attacks from frost arrows, searing arrows etc. ? In older version i used EnhancedDamageTarget to detect them but now it seems it isn't possible.

 

[Coldgamer]

In the conditions where you see "DamageEventAmount Greater than or equal to (DamageEventPrevAmt x 1.50)", change them to be "DamageScalingUser Greater than or equal to 1.50".

You can also change the other one "DamageEventAmount Less than (DamageEventPrevAmt x 0.60)" to "DamageScalingUser Less than 0.60" if that one is also giving you trouble.

I have had those variables in the demo map for a long time, but they really should proc off of user damage modification rather than WC3-processed damage. I'll update the demo maps sometime soon.

Works absolutly perfect, I am so grateful to you!

 

[pick-a-chew]

I updated this resource in my biggest project and ran into a problem where the damage engine stops working early on in the game (no damage happens), I'm not entirely sure what the problem could be since the coding was fine before i updated DE, though I did notice that a lot of the older triggers in the map still use "NextDamageType = 0" from when you would run "set NextDamageType... cause unit to damage... Run ClearDamageEvent" in the pre-patch version. There is no defined 0 damage type in the config trigger, and I was wondering if this could this be the problem?

I think before i updated the version was 5.3.1.0 if that's helpful.

Any other ideas for the sudden issue?

 

[Bribe]

I updated this resource in my biggest project and ran into a problem where the damage engine stops working early on in the game (no damage happens), I'm not entirely sure what the problem could be since the coding was fine before i updated DE, though I did notice that a lot of the older triggers in the map still use "NextDamageType = 0" from when you would run "set NextDamageType... cause unit to damage... Run ClearDamageEvent" in the pre-patch version. There is no defined 0 damage type in the config trigger, and I was wondering if this could this be the problem?

I think before i updated the version was 5.3.1.0 if that's helpful.

Any other ideas for the sudden issue?

Are you using Lua or vJass? Also could you please give me a rough idea of how long it takes or what kind of events led up to it (ie. a big fight or a certain kind of spell)?

 

[pick-a-chew]

I am still using the vJass version.

The problem occurs in the early game during pretty standard PvE battles between a group of player heroes and a group of mobs ranging from 3 - 120 units, though when the damage engine breaks it usually happens early on the encounter when there aren't many creeps present. In the early game, most heroes don't have access to most of their skills, which has made the problem a bit easier to search for, though I haven't found it yet.

My replay analysis of one instance of the bug just showed a simple coded starfall-like ability was the last successful damage instance, followed by a melee attack by a hero that had its damage completely negated. This was a bit unexpected as these damage instances would only pass through the core damage engine trigger in the map. The problem doesn't seem to have a 100% incidence rate and my players are suggesting that particular coded abilities from certain heroes might be the root of the problem. I am continuing to comb through my spell triggers and optimize them in line with 5.4.2.0's guidelines (i have found a couple that were using older rules).

I figure at this point there may be a logic problem between a coded ability and the damage engine itself.

Either way when the bug occurs, the damage engine dies completely. Even if you cease all damage for a while, wait for all spells to finish etc., damage is incapable of happening ever again. Could that help pinpoint a particular kind of coding error within the map's script?

 

[Bribe]

Could it be it's recursion related? Are you using that new DamageEngine_inception variable? I think I was able to break something by pushing it, but I can't exactly tell because the map lag was pushed to absolutely insane levels to make it seem to break.

I have attached the map with that stress test.

Regardless, the reporting on Damage Engine was active the whole time.

My recommendation is to go back to your triggers and make sure your are not turning off your on damage detection triggers. That's probably what is happening.

 

[HenrkIII]

Either way when the bug occurs, the damage engine dies completely. Even if you cease all damage for a while, wait for all spells to finish etc., damage is incapable of happening ever again. Could that help pinpoint a particular kind of coding error within the map's script?

Well I see that i'm not the only one experiencing the same thing. I'm also having this issue for some reason.

Could it be it's recursion related? Are you using that new DamageEngine_inception variable? I think I was able to break something by pushing it, but I can't exactly tell because the map lag was pushed to absolutely insane levels to make it seem to break.

I have attached the map with that stress test.

Regardless, the reporting on Damage Engine was active the whole time.

My recommendation is to go back to your triggers and make sure your are not turning off your on damage detection triggers. That's probably what is happening.

I dunno if pick a chew was turning off his damage detection trigger but I'm not so probably this is a Damage Engine v5.4.2.0 specific bug? I'm trying to check the reason as to why this happens but with no luck.