Cleaving Attacks v1.2.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

2 Sep 2011
Bribe: It's not MUI.

 

[baassee]

215kb for one simple spell? No way.

-Remove all imports.

-Remove the Display Damage trigger

-Remove this line

• (Unit-type of GDD_DamageSource) Equal to Blademaster

as other units might want this spell.

-Leaks

• Set Cleave_Point = (Position of GDD_DamagedUnit) - Use Custom Script: call RemoveLocation(udg_Cleave_Point) to remove the location.
• Set Cleave_UG = (Units within 150.00 of Cleave_Point matching (((((Matching unit) is Sleeping) Not equal to True) and ((Matching unit) Not equal to GDD_DamagedUnit)) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of GDD_Da

-Don't need the unitgroup variable just put this line before the group picking

• Custom Script:set bj_wantDestroyGroup = true

-This should be set before the whole if.

• Set lvlofcleave = (Level of Cleaving attacks for GDD_DamageSource)

Posting the code for you as you didnt do that

Trigger

• Cleaving attacks
  • Events
    • Game - GDD_Event becomes Equal to 0.00
  • Conditions
    • (Unit-type of GDD_DamageSource) Equal to Blademaster
    • (Level of Cleaving attacks for GDD_DamageSource) Greater than or equal to 1
  • Actions
    • Trigger - Turn off (This trigger)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random integer number between 1 and 100) Less than or equal to (((Level of Cleaving attacks for GDD_DamageSource) x 10) + 10)
      • Then - Actions
        • Set Cleave_Point = (Position of GDD_DamagedUnit)
        • Set Cleave_UG = (Units within 150.00 of Cleave_Point matching (((((Matching unit) is Sleeping) Not equal to True) and ((Matching unit) Not equal to GDD_DamagedUnit)) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of GDD_Da
        • Set lvlofcleave = (Level of Cleaving attacks for GDD_DamageSource)
        • Set cleavedmg = (GDD_Damage x ((0.20 x (Real(lvlofcleave))) + 0.20))
        • Unit Group - Pick every unit in Cleave_UG and do (Actions)
          • Loop - Actions
            • Special Effect - Create a special effect attached to the chest of (Picked unit) using Objects\Spawnmodels\Human\HumanBlood\HumanBloodLarge0.mdl
            • Special Effect - Destroy (Last created special effect)
            • Unit - Cause GDD_DamageSource to damage (Picked unit), dealing cleavedmg damage of attack type Hero and damage type Normal
      • Else - Actions
    • Trigger - Turn on (This trigger)

EDIT:

Fixed the whole trigger for you

Code

• Cleaving attacks
  • Events
    • Game - GDD_Event becomes Equal to 0.00
  • Conditions
    • (Level of Cleaving attacks for GDD_DamageSource) Greater than or equal to 1
  • Actions
    • Trigger - Turn off (This trigger)
    • Set lvlofcleave = (Level of Cleaving attacks for GDD_DamageSource)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random integer number between 1 and 100) Less than or equal to ((lvlofcleave x 10) + 10)
      • Then - Actions
        • Set Cleave_Point = (Position of GDD_DamagedUnit)
        • Set cleavedmg = (GDD_Damage x ((0.20 x (Real(lvlofcleave))) + 0.20))
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 150.00 of Cleave_Point matching ((((Matching unit) is Sleeping) Equal to False) and (((Matching unit) Not equal to GDD_DamagedUnit) and (((Matching unit) belongs to an enemy of (Owner of GDD_DamageSource)) Equal to True)))) and do (Actions)
          • Loop - Actions
            • Special Effect - Create a special effect attached to the chest of (Picked unit) using Objects\Spawnmodels\Human\HumanBlood\HumanBloodLarge0.mdl
            • Special Effect - Destroy (Last created special effect)
            • Unit - Cause GDD_DamageSource to damage (Picked unit), dealing cleavedmg damage of attack type Hero and damage type Normal
        • Custom script: call RemoveLocation(udg_Cleave_Point)
      • Else - Actions
    • Trigger - Turn on (This trigger)

-Also you really should rename the lvlofcleave variable to something more proper.


-And I do think this will be a bit too easy to be approved...

 

[woodknight]

v1.1 -
Removed Imports - No idea how they got there. They are for my map.

The Display Damage triger was for testing purposes, but OK - removed.

Blademaster check removed

Changed location of lvlofcleave triger and changed name

Custom scripts added.

Will you tell me what exactly the custom scripts do so I can use the in the future? Thx for the corrections.

edit: How do I make the collapsible thing in the descripsion?

 

[baassee]

Will you tell me what exactly the custom scripts do so I can use the in the future? Thx for the corrections.

edit: How do I make the collapsible thing in the descripsion?

It's just plain JASS. It's the GUI way to implement JASS lines but in the end, it's all JASS.

In this case we use it for removing memory leaks which takes up unnecessary RAM when it will not be refered to anymore. So it's just a bunch of things that the map will not use but will still take space.

There are a few threads about this, I wont link them as I find myself too lazy. And the Things that leaks thread is way too big and long to be read. In my opinion.

You mean [HIDDEN="HiddenTags"][/HIDDEN]?

 

[maddeem]

Please make this do a % of your triggering unit's damage. i really need to look at the code before i post...
Ok so this is what you need. Have the % editable per level in some sort of int trigger. Judging from base's code, it appears flawless.
Yup all good. Really is simple though...

 

[Spellbound]

Wouldn't this cleave activate even on damage spells cast by the Blademaster? A Bladestorm would deal terrible, terrible damage...

The only way I can think or restricting this to actual attacks is through a Orb effect given to the Blademaster upon entering playable map area :/

 

[woodknight]

You appear to be right I will do something about it as soon as I figure out how exactly.

 

[defskull]

Too simple to be approved.
A spell should be more powerful than the original ones (Cleaving Attack) but this one is weaker than the original... what the...

You should change the damage output cleaving damage (more than 100%), than, this will make this spell powerful than the original ones.

Facts:
If you change the damage output to more than 100%, primary unit takes less damage than the cleaved damage.

Like if you set it to 300%, primary unit will always takes 100% damage while the cleaved units will take instead 300%. It's like a damage modifier/multiplier for the cleaved units. It's more like Critical Strike too.

 

[xorkatoss]

this seems to be working fine and i don't see any reason to give a bad rating so 5/5

 

[Bribe]

Well aside from being dealt by a blademaster the other problems here
are:

• Spell/triggered damage will also trigger the cleaving attack
• There is no bug-free way to determine if the damage is an attack or
a spell
• The only way to make it work properly is to have all non-physical
damage in the map triggered and to set a boolean when it's triggered
to let the game engine know.

A spell should be more powerful than the original ones (Cleaving Attack) but this one is weaker than the original... what the...

There is no rule that says the spell has to be more powerful from the
original ones. In fact, I have wanted a percent-chance cleaving attack
in the past when I used to develop my WarChasers II map.

 

[defskull]

Well, do you want a Chain Lightning dealing 10 damage and bounce up 2 to units max?
>.<"

Stop this off-topic.

What I'm saying is, the custom spell should be more original, that's all.

 

[Bribe]

The originality here is fine. It's that it has too many bugs.

The "too simple" rule for spells is not something to be thrown around,
as sometimes simple is better. The "too simple" rule is usually for
something that could be created with Object Editor or something that
could be triggered without any thought.

 

[baassee]

• Spell/triggered damage will also trigger the cleaving attack

Atleast it cannot trigger itself

 

[Bribe]

...which would be epic by the way.

 

[baassee]

...which would be epic by the way.

Your irony confuses me.

 

[Bribe]

The resulting infinite AoE damage + infinite loop is enough to make any good
Wc3 programmer smile.

 

[woodknight]

I think I figured it out.

If the spell will be a hero spell and only one hero has it the solution is simple enough I think. One thing is the condition

• (Unit-type of GDD_DamageSource) Equal to Your_Hero

should be there to check if its him doing the damage, so you don't have to raise a flag value in every spell you make for other heroes.
Another condition should be:

• Spell_Fired Equal to False

Spell_Fired will be a variable we triger only in his other abilities like so:

• Spell_Fired Equal to True

before the damage is done and

• Spell_Fired Equal to False

after that.

If we want a MUI spell then we will have to have the Spell_Fired trigering in every spell on the map.

I wanted this spell for a hero only and now it works fine for me. For multiple units I think it would be more convenient to use the basic Cleavin Attack ability.

 

[Bribe]

Well now that means this is not MUI every map would have to be
taylored to handle your exact spell damage. I have been meaning
to add a boolean like this in the next update to Damage Event, I
guess now is a good time for it. That way Damage Event can deal
with the triggered damage and spells like this won't have to.

 

[woodknight]

Do you mean in the Damage Detection System? That is way beyond my legue right now. I will add my suggestions from my previous post so people can decide what to do. I guess this spell won't be approved, but my intension was having it reviewed by people far more experienced than me so I can see my rookie mistakes. Thanks for that.

 

[baassee]

Next time, just post it into the trigger and scripts section if you want more critisisms.