Check for leaks...

[Palermo1]

Tell me if you guys see any leaks or anything. When the map gets down to higher levels, it starts lagging real bad untill most of the units are dead.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Level Equal to 1
  • Then - Actions
    • Game - Display to (All players) the text: (|cffffcc00Round: |r + (String(Level)))
    • Sound - Play BattleNetTick <gen>
    • For each (Integer A) from 0 to 12, do (Actions)
      • Loop - Actions
        • Unit - Create Num_Players_Units units_level[0] for Player 12 (Brown) at Spawn_Points[(Integer A)] facing Default building facing degrees
  • Else - Actions
    • Do nothing

 

[HELL_YA]

Im no expert on Leaks but I do know a few things
1.You need to delete the sound after it fades
2.REMOVE DO nothing it just makes things worse(it makes the trigger work harder for nothing)
3. There are a few other things but here is a tool that can help u http://www.hiveworkshop.com/forums/tools-560/leak-check-1-3-a-62951/ if u need help on the tool just ask me and il help

 

[Palermo1]

It seems that when I do destroy last created sound it doesn't play the sound at all.

 

[TriggerHappy]

It seems that when I do destroy last created sound it doesn't play the sound at all.

It's because your not supposed to destroy it.

From what you posted there are no leaks, though it would be better for you to post the entire trigger.

Also the Do Nothing is useless.

 

[Palermo1]

• Begins Levels
  • Events
    • Player - Player 12 (Brown)'s Food used becomes Less than or equal to 0.00
  • Conditions
  • Actions
    • Game - Display to (All players) the text: You have |cffffcc00...
    • Wait 20.00 seconds
    • Set Level = (Level + 1)
    • Leaderboard - Change the value for Neutral Passive in (Last created leaderboard) to Level
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Level Greater than 10
      • Then - Actions
        • Set Income = (Num_Players_Units + (Level / 2))
      • Else - Actions
        • Set Income = (Num_Players_Units + Level)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Level Equal to 1
      • Then - Actions
        • Game - Display to (All players) the text: (|cffffcc00Round: |r + (String(Level)))
        • Sound - Play BattleNetTick <gen>
        • For each (Integer A) from 0 to 12, do (Actions)
          • Loop - Actions
            • Unit - Create Num_Players_Units units_level[0] for Player 12 (Brown) at Spawn_Points[(Integer A)] facing Default building facing degrees
      • Else - Actions
    • Game - Display to (All players) for 15.00 seconds the text: (|cffffcc00Supplies have sold: |r+ + ((String(Income)) + Gold.))
    • Sound - Play AutoCastButtonClick1 <gen>
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Add Income to (Picked player) Current gold

I removed all the other loops so the trigger won't be so long on here. The levels go from 1 to 30.

 

[FriXionX]

I cant see any leaks.

I think

• Player Group - Pick every player in (All Players)

leaks, but im not sure, you'll have to get a second opinion on that..

 

[Kercyn]

No. All Players is the only player/unit group that doesn't leak ^^

 

[FriXionX]

ah ha.

 

[eleljrk]

Fix the Integer A to a Variable (name it loop_integer - No array), and then it is ok.

 

[HELL_YA]

Sry about the sound thingy lol
Here are a few thigns to help u later on in memory leaks
Tutorial: http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/basic-memory-leaks-5889/
Tool: http://www.hiveworkshop.com/forums/tools-560/leak-check-1-3-a-62951/
Spell: http://www.hiveworkshop.com/forums/...troyer-142630/?prev=search=memory&d=list&r=20

 

[Palermo1]

Well could this be causing lag?

• Magic Bolt
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Unit-type of (Attacking unit)) Equal to Magic Vault
  • Actions
    • Unit - Order (Attacking unit) to Human Mountain King - Storm Bolt (Attacked unit)

But then it only lags in later levels beginning around 14 and gradually getting worst.

Only other thing i can think of is that my level trigger is to long and it has to cycle through to many if/then/else statements before it finds the correct condition? I can't figure out why it lags so bad. It's like a huge lag where the screen pauses pretty much so It's not too much units in game.

I fixed every single leak in the map btw.

 

[Kercyn]

Doesn't make sense. Even if it was a TD map or a map where multiple units are attacked simultaneously, it shouldn't lag. Can you post the map please so that we can have a look?

 

[TriggerHappy]

Unless the players food becomes 0 multiple times in 20 seconds, it shouldn't lag.

 

[Palermo1]

Doesn't make sense. Even if it was a TD map or a map where multiple units are attacked simultaneously, it shouldn't lag. Can you post the map please so that we can have a look?

Just note this was supposed to be a fast, quick, fun project and it basically was untill now lol. I wish this damn problem didn't happen : ).

When we got to around level 18 I think with 8 people, the game paused up for a long time and it would jump here and there untill we lost and defeat came up.

 

[Kercyn]

I've edited some of your triggers so that they are more efficient (Do Nothing is absolutely useless. Triggers that have been edited have an "e" in the beginning and I've written what I've done in the comments). I've also noticed that you use other towers' abilities in the same fashion that you use Storm Bolt. Do they cause lag or it's just this particular type of tower? Begin Levels leaks locations in the loops. Overall, your triggers look good though

(Doesn't lag for me ^^)

 

[Palermo1]

Thank you very much. I'll let you know if it still lags. The ability towers don't really lag. It's just later points in the game it like freezes and makes it unbareable to play.

Edit: I like what you did with my don't attack triggers. I also protect my map with ExtProtect. But that should cause lag should it.

 

[Palermo1]

Man, it still lags big time. Seems like it doesn't matter if it happens early or late. Right when the units come out attacking it lags really bad sometimes like I said, pauses the screen up. I think it may be those triggers that I posted above that when a unit is attack, attacking units is equal to (whatever), cast whatever spell. I have about 5 triggers that do that. Take note that the attackers/defender towers/defender heros are all attacking which is a lot of units being ran through 5 triggers. Could these triggers possible making it lag so much?

 

[manstie]

• Begins Levels
  • Events
    • Player - Player 12 (Brown)'s Food used becomes Less than or equal to 0.00
  • Conditions
  • Actions
    • Game - Display to (All players) the text: You have |cffffcc00...
    • Wait 20.00 seconds
    • Set Level = (Level + 1)
    • Leaderboard - Change the value for Neutral Passive in (Last created leaderboard) to Level
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Level Greater than 10
      • Then - Actions
        • Set Income = (Num_Players_Units + (Level / 2))
      • Else - Actions
        • Set Income = (Num_Players_Units + Level)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Level Equal to 1
      • Then - Actions
        • Game - Display to (All players) the text: (|cffffcc00Round: |r + (String(Level)))
        • Sound - Play BattleNetTick <gen>
        • For each (Integer A) from 0 to 12, do (Actions)
          • Loop - Actions
            • Unit - Create Num_Players_Units units_level[0] for Player 12 (Brown) at Spawn_Points[(Integer A)] facing Default building facing degrees
      • Else - Actions
    • Game - Display to (All players) for 15.00 seconds the text: (|cffffcc00Supplies have sold: |r+ + ((String(Income)) + Gold.))
    • Sound - Play AutoCastButtonClick1 <gen>
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Add Income to (Picked player) Current gold

I removed all the other loops so the trigger won't be so long on here. The levels go from 1 to 30.

You guys, seriously can't see that position leak?

• Leak
  • Events
  • Conditions
  • Actions
    • For each (Integer A) from 0 to 12, do (Actions)
      • Loop - Actions
        • Set RemovePoint = Spawn_Points[(Integer A)]
        • Unit - Create Num_Players_Units units_level[0] for Player 12 (Brown) at RemovePoint facing Default building facing degrees
        • Custom script: call RemoveLocation(udg_RemovePoint)

 

[Palermo1]

You guys, seriously can't see that position leak?

• Leak
  • Events
  • Conditions
  • Actions
    • For each (Integer A) from 0 to 12, do (Actions)
      • Loop - Actions
        • Set RemovePoint = Spawn_Points[(Integer A)]
        • Unit - Create Num_Players_Units units_level[0] for Player 12 (Brown) at RemovePoint facing Default building facing degrees
        • Custom script: call RemoveLocation(udg_RemovePoint)

I was told that it does not leak. I guess I'll try it, but what do others think?

 

[Maker]

If you have pre-set locations (points) in an array, and create units there, it does not leak. It only leaks if you set the locatins[index] to another location.

 

[Kercyn]

Oh, and Palermo1? Since towers don't have attack, why don't you just change their attack art and adjust their damage? For example, instead of throwing a magical hammer, change the attack animation to look like a hammer, adjust the damage and give it a 100% chance to bash for 0.2.

 

[Palermo1]

Well, that would be a bunch of trouble for nothing in my opinion. It's not the tower causing lag. I have around 5 towers that casts abilities they don't cause lag. It lags usually starting in levels aroound 15+ but I did have it lag at level 9. I was saying that stormbolt trigger combined with the other ability triggers could be causing it to lag, just a thought because that is a lot of towers/units attacking each other and causing those triggers to fire. I truely have no clue as to why it does this. I was beginning to think it was caused when someone left the game and I messed something up in the leaver trigger but it did not seem to be the case.

 

[Palermo1]

Figured it out...

A tower was causing it. One that casts a modified shadow strike. Some reason the shadow strike was causing lag. Going to make it cast another ability.

Thanks for all the help people.