Arcane Blast v0.7 [GUI]

Moderator · Nov 4, 2009

11:14, 15th Jun 2010
Hanky:
The spell is just to simple. Everyone could do that in 2 minutes or less.

pippo · Nov 4, 2009

The idea is great but there are many bad things.

Arcane Blast
- Events
  - Unit - A unit start the launch of an ability
- Conditions
  - (Ability being cast) Uguale a Arcane Blast
- Actions
  - Set Caster = (Casting unit)
  - Wait 0.50 seconds

Following there are many leaks:
-First of all the group leaks: you have to set a variable for the group and then pick the units in the variable (and clear).
-Leaks the points, too: you have to set many variables as points and then clear all.
I will show you how to fix that all
Also there is a thing that make it not much "MUI" or "MPI" that is the wait...I will show you how to fix leaks first

Unit Group - Pick every unit in (Units within 450.00 of (Position of Caster)) and do (Actions)
- Loop - Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - ((Picked unit) has buff Arcane Blast ) Uguale a TRUE
      - ((Picked unit) is Un eroe) Uguale a FALSE
      - ((Picked unit) is Una struttura) Uguale a FALSE
    - Allora - Azioni
      - Unit - Create 1 (Unit-type of (Picked unit)) for (Owner of Caster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees
      - Unit - There are many actions below but they doesn't leak...

Just do it:

Arcane Blast
- Events
  - Unit - A unit ends the launch of an ability
- Conditions
  - (Ability being cast) Uguale a Arcane Blast
- Actions
  - Set Caster = (Casting unit)
  - Set Point = (Position of Caster)
  - Set Group = (Units within 450.00 of Point)
  - Unit Group - Pick every unit in Group and do (Actions)
    - Loop - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ((Picked unit) has buff Arcane Blast ) Uguale a TRUE
        
        ((Picked unit) is Un eroe) Uguale a FALSE
        
        ((Picked unit) is Una struttura) Uguale a FALSE
        
        Then - Actions
        
        Set Point2 = (Position of (Picked Unit))
        
        Unit - Create 1 (Unit-type of (Picked unit)) for (Owner of Caster) at Point2 facing (Facing of (Picked unit)) degrees
        
        Custom script: call RemoveLocation(udg_Point2)
  - Custom script: call RemoveLocation(udg_Point)
  - Custom script: call DestroyGroup(udg_Group)

To remove the wait you only have to change the EVENT to "A unit ENDS the launch of an ability", and it'll be fine!

I already fixed it to make the review, but I wan't that you fix this, too. I like it, and without leaks and with MUI and MPI it will be fine (it IS fine!). Have fun!

Mainy · Nov 4, 2009

I will update

MortAr · Nov 4, 2009

Set Caster = (Casting unit)

Use triggering unit

Wait 0.50 seconds

Remove this

Unit Group - Pick every unit in (Units within 450.00 of (Position of Caster)) and do (Actions)
- Loop - Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - ((Picked unit) has buff Arcane Blast ) Equal to True
      - ((Picked unit) is A Hero) Equal to False
      - ((Picked unit) is A structure) Equal to False
    - Then - Actions
      - Unit - Create 1 (Unit-type of (Picked unit)) for (Owner of Caster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees
      - Set EtherealCopy[1] = (Last created unit)
      - Unit - Add a 3.00 second Generic expiration timer to EtherealCopy[1]
      - Animation - Change EtherealCopy[1]'s vertex coloring to (0.00%, 100.00%, 100.00%) with 20.00% transparency
      - Unit - Add Arcane Blast (Ethereal Copy) to EtherealCopy[1]
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Level of Arcane Blast for Caster) Equal to 2
        
        Then - Actions
        
        Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to 2
        
        Else - Actions
        
        Do nothing
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Level of Arcane Blast for Caster) Equal to 3
        
        Then - Actions
        
        Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to 3
        
        Else - Actions
        
        Do nothing
    - Else - Actions
      - Do nothing

This leaks a location, group

Unit - Create 1 (Unit-type of (Picked unit)) for (Owner of Caster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees

This leaks 2 locations

Do nothing

Never add this line anywhere, it only slows down the trigger

This

If (All Conditions are True) then do (Then Actions) else do (Else Actions)
- If - Conditions
  - (Level of Arcane Blast for Caster) Equal to 2
- Then - Actions
  - Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to 2
- Else - Actions
  - Do nothing

And this

If (All Conditions are True) then do (Then Actions) else do (Else Actions)
- If - Conditions
  - (Level of Arcane Blast for Caster) Equal to 3
- Then - Actions
  - Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to 3
- Else - Actions
  - Do nothing

Can be changed with

Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to (Level of Arcane Blast for Caster)

Thus preventing multi usage of IF/THEN/ELSE

At the end, your trigger must look like this:

Arcane Blast
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Arcane Blast
- Actions
  - Set Caster = (Triggering unit)
  - Set Eth_Location = (Position of Caster)
  - Set Ethernal_Group = (Units within 450.00 of Eth_Location matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of Caster)) Equal to True))))
  - Unit Group - Pick every unit in Ethernal_Group and do (Actions)
    - Loop - Actions
      - Set Unit_Loc = (Position of (Picked unit))
      - Unit - Create 1 (Unit-type of (Picked unit)) for (Owner of Caster) at Unit_Loc facing Default building facing degrees
      - Set EtherealCopy[1] = (Last created unit)
      - Unit - Add a 3.00 second Generic expiration timer to EtherealCopy[1]
      - Animation - Change EtherealCopy[1]'s vertex coloring to (0.00%, 100.00%, 100.00%) with 20.00% transparency
      - Unit - Add Arcane Blast (Ethereal Copy) to EtherealCopy[1]
      - Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to (Level of Arcane Blast for Caster)
      - Custom script: call RemoveLocation (udg_Unit_Loc)
  - Custom script: set udg_Caster = null
  - Custom script: call RemoveLocation (udg_Eth_Location)
  - Custom script: call DestroyGroup (udg_Ethernal_Group)

Other things, fix discription, fix your typos, and add documentation with "Trigger Comments" showing what the trigger actually does.

Also I forgot to mention, you don't need an array veriable for the "EtherealCopy" unit, and also add this after the "Custom script: call RemoveLocation (udg_Unit_Loc)"

Custom script: set udg_EtherealCopy = null

pippo · Nov 4, 2009

MortAr- said:
Set Caster = (Casting unit)

Use triggering unit

Wait 0.50 seconds

Remove this

Unit Group - Pick every unit in (Units within 450.00 of (Position of Caster)) and do (Actions)

Loop - Actions

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

((Picked unit) has buff Arcane Blast ) Equal to True

((Picked unit) is A Hero) Equal to False

((Picked unit) is A structure) Equal to False

Then - Actions

Unit - Create 1 (Unit-type of (Picked unit)) for (Owner of Caster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees

Set EtherealCopy[1] = (Last created unit)

Unit - Add a 3.00 second Generic expiration timer to EtherealCopy[1]

Animation - Change EtherealCopy[1]'s vertex coloring to (0.00%, 100.00%, 100.00%) with 20.00% transparency

Unit - Add Arcane Blast (Ethereal Copy) to EtherealCopy[1]

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(Level of Arcane Blast for Caster) Equal to 2

Then - Actions

Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to 2

Else - Actions

Do nothing

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(Level of Arcane Blast for Caster) Equal to 3

Then - Actions

Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to 3

Else - Actions

Do nothing

Else - Actions

Do nothing

This leaks a location, group

Unit - Create 1 (Unit-type of (Picked unit)) for (Owner of Caster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees

This leaks 2 locations

Do nothing

Never add this line anywhere, it only slows down the trigger

This

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(Level of Arcane Blast for Caster) Equal to 2

Then - Actions

Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to 2

Else - Actions

Do nothing

And this

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(Level of Arcane Blast for Caster) Equal to 3

Then - Actions

Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to 3

Else - Actions

Do nothing

Can be changed with

Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to (Level of Arcane Blast for Caster)

Thus preventing multi usage of IF/THEN/ELSE

At the end, your trigger must look like this:

Arcane Blast

Events

Unit - A unit Starts the effect of an ability

Conditions

(Ability being cast) Equal to Arcane Blast

Actions

Set Caster = (Triggering unit)

Set Eth_Location = (Position of Caster)

Set Ethernal_Group = (Units within 450.00 of Eth_Location matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of Caster)) Equal to True))))

Unit Group - Pick every unit in Ethernal_Group and do (Actions)

Loop - Actions

Set Unit_Loc = (Position of (Picked unit))

Unit - Create 1 (Unit-type of (Picked unit)) for (Owner of Caster) at Unit_Loc facing Default building facing degrees

Set EtherealCopy[1] = (Last created unit)

Unit - Add a 3.00 second Generic expiration timer to EtherealCopy[1]

Animation - Change EtherealCopy[1]'s vertex coloring to (0.00%, 100.00%, 100.00%) with 20.00% transparency

Unit - Add Arcane Blast (Ethereal Copy) to EtherealCopy[1]

Unit - Set level of Arcane Blast (Ethereal Copy) for EtherealCopy[1] to (Level of Arcane Blast for Caster)

Custom script: call RemoveLocation (udg_Unit_Loc)

Custom script: set udg_Caster = null

Custom script: call RemoveLocation (udg_Eth_Location)

Custom script: call DestroyGroup (udg_Ethernal_Group)

Other things, fix discription, fix your typos, and add documentation with "Trigger Comments" showing what the trigger actually does.

Also I forgot to mention, you don't need an array veriable for the "EtherealCopy" unit, and also add this after the "Custom script: call RemoveLocation (udg_Unit_Loc)"

Custom script: set udg_EtherealCopy = null

Yeah, you're right, I forgot to say the things I didn't said (of course it is lol^^)...

anyway all is fixed, and it's FINE!

uh, and why didn't you use "Unit - a unit ends the launch of an ability"? Anyway it's fine.

Ah, a thing, the setting of the variable to null, can be made either in custom script mode or in variable mode...

Mainy · Nov 4, 2009

Fixed v0.4 oO

Squiggy · Nov 4, 2009

Set ABCaster = (Triggering unit)

Use (Triggering Unit)

Replace the arrayed variable for the dummy with a normal one.

MortAr · Nov 4, 2009

"ABDummy[1]" that is not nulled, you need to clear it inside the loop using

Custom script: set udg_ABDummy[1] = null

And again, you don't need an array veriable since the dummy is used only into 1 trigger.

baassee · Nov 4, 2009

mortar I thought that you didnt need to null unit variables as they overwrite themselves without leaking?

YourNameHere · Nov 4, 2009

baassee said:
mortar I thought that you didnt need to null unit variables as they overwrite themselves without leaking?

You don't have to null globals at all, only local variables.

MortAr · Nov 4, 2009

baassee said:
mortar I thought that you didnt need to null unit variables as they overwrite themselves without leaking?

In the end of the loop you'll still have 1 unit left.
Yes actually, you don't need to null them, but its not a mistake. Just to keep memory free.

Mainy · Nov 4, 2009

Final v0.6

BloodSoul · Nov 5, 2009

Change this event:

Arcane Blast
- Events
  - Unit - A unit Begins casting an ability

To this:

Arcane Blast
- Events
  - Unit - A unit Starts the effect of an ability

-
Using "A unit Begins casting..." there is a bug.
When you "click" at spell, the triggers 'run', and if I cast the spell, press the button S (stop).
I can cancel the use of spell but the triggers run.
If you don't understand what I said, see this replay:
http://rapidshare.com/files/302729370/Bug.w3g.html
Or
http://www.megaupload.com/?d=SB0VN2YX
--
Map: http://www.easy-share.com/1908349455/WorldEditTestMap.w3x
--

S: The map file must be called: WorldEditTestMap
At folder: Warcraft III\Maps\Test

Mainy · Nov 5, 2009

Lol? it's allright

YourNameHere · Nov 5, 2009

MortAr- said:
In the end of the loop you'll still have 1 unit left.
Yes actually, you don't need to null them, but its not a mistake. Just to keep memory free.

Memory? No, we only null variables because Warcraft's handle counter doesn't decrease automaticly.

baassee · Nov 5, 2009

YourNameHere said:
Memory? No, we only null variables because Warcraft's handle counter doesn't decrease automaticly.

thanks for making that clear to mortar

hell gate · Nov 5, 2009

if you use

JASS:

set udg_ABCaster = null

you also should use

JASS:

set udg_ABCastPoint = null
set udg_ABGroup = null

X-OMG-X · Nov 5, 2009

Using imported models is never a good thing in spells.

MortAr · Nov 5, 2009

X-OMG-X said:
Using imported models is never a good thing in spells.

Why?

Mainy · Nov 5, 2009

X-OMG-X said:
Using imported models is never a good thing in spells.

The special effects can be removed, will not alter the functioning of the ability... -.-"

Anachron · Nov 6, 2009

Lol. This is kinda of useless because it only has 10 lines of code and is quite impressive for meh. But its up to the mods to approve it or not.

X-OMG-X · Nov 6, 2009

Mainy said:
The special effects can be removed, will not alter the functioning of the ability... -.-"

True, but its still not recommend. If the author know there is a similar effect in wc3 thw advice to use that effect instead of the imported one. A good example could be if you made a fire explosion and you used an imported one instead of the flamestrike effects.

Arcane Blast v0.7 [GUI]

Aggronor - Vinebeard [GUI] (Map)

Moderator

Moderator

Similar threads